From 009f441d00e10fc861701605479441be93153090 Mon Sep 17 00:00:00 2001
From: mwganson <mwganson@gmail.com>
Date: Wed, 16 Oct 2024 05:21:47 +0000
Subject: [PATCH] [Points WB] fix issue where points are inaccurately imported
 when the points are far from the origin.  This PR checks if the bounding box
 contains the origin and offers to move it to the origin if not, addresses
 issue #5808

---
 src/Mod/Points/Gui/Command.cpp | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/src/Mod/Points/Gui/Command.cpp b/src/Mod/Points/Gui/Command.cpp
index 016f1d8e35..ab18b36fa8 100644
--- a/src/Mod/Points/Gui/Command.cpp
+++ b/src/Mod/Points/Gui/Command.cpp
@@ -24,6 +24,7 @@
 #ifndef _PreComp_
 #include <Inventor/events/SoMouseButtonEvent.h>
 #include <QInputDialog>
+#include <QMessageBox>
 #include <algorithm>
 #endif
 
@@ -98,7 +99,39 @@ void CmdPointsImport::activated(int iMsg)
         commitCommand();
 
         updateActive();
+
+        /** check if boundbox contains the origin, offer to move it to the origin if not
+         *  addresses issue #5808 where an imported points cloud that was far from the
+         *  origin had inaccuracies in the relative positioning of the points due to
+         *  imprecise floating point variables used in COIN
+         **/
+        Points::Feature *pcFtr = dynamic_cast<Points::Feature *>(doc->getDocument()->getActiveObject());
+        if (pcFtr) {
+            auto points = pcFtr->Points.getValue();
+            auto bbox = points.getBoundBox();
+            auto center = bbox.GetCenter();
+
+            if (!bbox.IsInBox(Base::Vector3d(0,0,0))) {
+                QMessageBox msgBox;
+                msgBox.setIcon(QMessageBox::Question);
+                msgBox.setWindowTitle(QObject::tr( "Points not at Origin"));
+                msgBox.setText(QObject::tr("The Bounding Box of the imported points does not contain the origin.  "
+                                             "Do you want to translate it to the origin?"));
+                msgBox.setStandardButtons(QMessageBox::Yes | QMessageBox::No);
+                msgBox.setDefaultButton(QMessageBox::Yes);
+                auto ret = msgBox.exec();
+
+                if (ret == QMessageBox::Yes) {
+                    Points::PointKernel translatedPoints;
+                    for (const auto& point : points) {
+                        translatedPoints.push_back(point - center);
+                    }
+                    pcFtr->Points.setValue(translatedPoints);
+                }
+            }
+        }
     }
+
 }
 
 bool CmdPointsImport::isActive()