Toponaming: Clean code, apply remark recommendations and Tweak tests

2024-07-18 17:10:24 -04:00
parent f6494bdf05
commit 0178e848e4
7 changed files with 149 additions and 124 deletions
--- a/src/Base/Bitmask.h
+++ b/src/Base/Bitmask.h
@@ -113,7 +113,8 @@ class Flags {
    Enum i;

 public:
-    constexpr inline Flags(Enum f = Enum()) : i(f) {}
+    // Linter seems wrong on next line, don't want explicit here forcing downstream changes
+    constexpr inline Flags(Enum f = Enum()) : i(f) {}   // NOLINT (runtime/explicit)
    constexpr bool testFlag(Enum f) const {
        using u = typename std::underlying_type<Enum>::type;
        return (i & f) == f && (static_cast<u>(f) != 0 || i == f);