From 04a9c1e7b057296af5c4ae33fdb055d9a9ec129b Mon Sep 17 00:00:00 2001 From: Chris Hennes Date: Tue, 16 Dec 2025 15:17:07 -0600 Subject: [PATCH] Assembly: Compiler warning cleanup --- src/Mod/Assembly/App/AssemblyLink.cpp | 4 ++-- src/Mod/Assembly/Gui/TaskAssemblyMessages.cpp | 2 +- src/Mod/Assembly/Gui/TaskAssemblyMessages.h | 2 +- src/Mod/Assembly/Gui/ViewProviderAssembly.h | 1 - 4 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/Mod/Assembly/App/AssemblyLink.cpp b/src/Mod/Assembly/App/AssemblyLink.cpp index f61537f515..48d3857d21 100644 --- a/src/Mod/Assembly/App/AssemblyLink.cpp +++ b/src/Mod/Assembly/App/AssemblyLink.cpp @@ -323,7 +323,7 @@ void AssemblyLink::synchronizeComponents() = srcLink->ElementList.getValues(); const std::vector newElements = link2->ElementList.getValues(); - for (int i = 0; i < srcElements.size(); ++i) { + for (size_t i = 0; i < srcElements.size(); ++i) { objLinkMap[srcElements[i]] = newElements[i]; } break; @@ -373,7 +373,7 @@ void AssemblyLink::synchronizeComponents() newLink->ElementCount.setValue(srcLink->ElementCount.getValue()); const std::vector srcElements = srcLink->ElementList.getValues(); const std::vector newElements = newLink->ElementList.getValues(); - for (int i = 0; i < srcElements.size(); ++i) { + for (size_t i = 0; i < srcElements.size(); ++i) { auto* newObj = newElements[i]; auto* srcObj = srcElements[i]; if (newObj && srcObj) { diff --git a/src/Mod/Assembly/Gui/TaskAssemblyMessages.cpp b/src/Mod/Assembly/Gui/TaskAssemblyMessages.cpp index 418cbb1084..7d56b9628f 100644 --- a/src/Mod/Assembly/Gui/TaskAssemblyMessages.cpp +++ b/src/Mod/Assembly/Gui/TaskAssemblyMessages.cpp @@ -69,7 +69,7 @@ void TaskAssemblyMessages::updateToolTip(const QString& link) } } -void TaskAssemblyMessages::onLabelStatusLinkClicked(const QString& str) +void TaskAssemblyMessages::onLabelStatusLinkClicked(const QString& /*str*/) { // The commands are not implemented yet since App is not reporting yet the solver's status /* if (str == QStringLiteral("#conflicting")) { diff --git a/src/Mod/Assembly/Gui/TaskAssemblyMessages.h b/src/Mod/Assembly/Gui/TaskAssemblyMessages.h index 2a2892b843..ae95138c0d 100644 --- a/src/Mod/Assembly/Gui/TaskAssemblyMessages.h +++ b/src/Mod/Assembly/Gui/TaskAssemblyMessages.h @@ -44,7 +44,7 @@ public: private: void onLabelStatusLinkClicked(const QString&) override; - void updateToolTip(const QString& link); + void updateToolTip(const QString& link) override; protected: ViewProviderAssembly* vp; diff --git a/src/Mod/Assembly/Gui/ViewProviderAssembly.h b/src/Mod/Assembly/Gui/ViewProviderAssembly.h index 76a2dabdd4..e551a8e8a0 100644 --- a/src/Mod/Assembly/Gui/ViewProviderAssembly.h +++ b/src/Mod/Assembly/Gui/ViewProviderAssembly.h @@ -284,7 +284,6 @@ private: std::set& visited ); - TaskAssemblyMessages* taskSolver; boost::signals2::connection connectSolverUpdate; boost::signals2::scoped_connection m_preTransactionConn; };