From 05bba1ab42cd61a0150eae23448d4671e9f7bc30 Mon Sep 17 00:00:00 2001 From: Chris Hennes Date: Thu, 20 Mar 2025 23:20:48 -0500 Subject: [PATCH] Spreadsheet: Ensure copy of temp string is kept Coverity issue 545269. A temporary string is constructed, and its address stored via c_str(). That pointer is then used after the string is destroyed. The fix is to store the std::string. --- src/Mod/Spreadsheet/Gui/AppSpreadsheetGui.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Mod/Spreadsheet/Gui/AppSpreadsheetGui.cpp b/src/Mod/Spreadsheet/Gui/AppSpreadsheetGui.cpp index 3da6814815..b9b964868c 100644 --- a/src/Mod/Spreadsheet/Gui/AppSpreadsheetGui.cpp +++ b/src/Mod/Spreadsheet/Gui/AppSpreadsheetGui.cpp @@ -69,8 +69,8 @@ private: { try { Base::FileInfo file(Name); - auto filename = file.fileNamePure().c_str(); - auto* pcSheet = pcDoc->addObject(filename); + auto filename = file.fileNamePure(); + auto* pcSheet = pcDoc->addObject(filename.c_str()); pcSheet->importFromFile(Name, '\t', '"', '\\'); pcSheet->execute();