From 0859cf655519d7e0b18fc41c6abefbada449c753 Mon Sep 17 00:00:00 2001 From: AgCaliva Date: Fri, 8 Sep 2023 09:12:52 -0300 Subject: [PATCH] Fix DOMDocument redefinition error --- src/Base/DocumentReader.cpp | 1 + src/Base/DocumentReader.h | 8 -------- src/Base/Parameter.h | 9 +-------- src/Base/XMLTools.cpp | 10 ++++------ src/Base/XMLTools.h | 20 +++++++------------ src/Main/MainGui.cpp | 8 ++++++-- src/Main/MainPy.cpp | 6 ++++-- src/Mod/Inspection/Gui/Command.cpp | 4 ++-- .../Inspection/Gui/ViewProviderInspection.cpp | 4 +++- src/Mod/Points/Gui/Command.cpp | 5 +++-- src/Mod/Points/Gui/ViewProvider.cpp | 3 ++- src/Mod/Sandbox/Gui/PreCompiled.h | 8 ++++---- .../Gui/ViewProviderSpreadsheet.cpp | 3 ++- src/Tools/_TEMPLATE_/Gui/PreCompiled.h | 8 +++++--- 14 files changed, 44 insertions(+), 53 deletions(-) diff --git a/src/Base/DocumentReader.cpp b/src/Base/DocumentReader.cpp index b4245d58eb..b91c0e5b1f 100644 --- a/src/Base/DocumentReader.cpp +++ b/src/Base/DocumentReader.cpp @@ -19,6 +19,7 @@ * Suite 330, Boston, MA 02111-1307, USA * * * ***************************************************************************/ +#include "PreCompiled.h" #include "DocumentReader.h" #include "InputSource.h" #include "XMLTools.h" diff --git a/src/Base/DocumentReader.h b/src/Base/DocumentReader.h index ff7d6b14ce..cf9bf4e71e 100644 --- a/src/Base/DocumentReader.h +++ b/src/Base/DocumentReader.h @@ -30,12 +30,6 @@ #include #include -//#ifndef _PreComp_ -//# include -//# include -//#endif - - #include namespace zipios { @@ -45,8 +39,6 @@ class ZipInputStream; XERCES_CPP_NAMESPACE_BEGIN class DOMNode; class DOMElement; -// class DefaultHandler; -// class SAX2XMLReader; XERCES_CPP_NAMESPACE_END namespace Base { diff --git a/src/Base/Parameter.h b/src/Base/Parameter.h index e3c2342ec5..f27c3b02cb 100644 --- a/src/Base/Parameter.h +++ b/src/Base/Parameter.h @@ -53,18 +53,11 @@ using PyObject = struct _object; #include #include #include +#include #include "Handle.h" #include "Observer.h" - - -#ifndef _PreComp_ -//# include -# include -#endif - - #ifdef _MSC_VER # pragma warning( disable : 4251 ) # pragma warning( disable : 4503 ) diff --git a/src/Base/XMLTools.cpp b/src/Base/XMLTools.cpp index fb0fda11e7..fb492c062d 100644 --- a/src/Base/XMLTools.cpp +++ b/src/Base/XMLTools.cpp @@ -26,15 +26,15 @@ #include "XMLTools.h" using namespace Base; +XERCES_CPP_NAMESPACE_USE -std::unique_ptr XMLTools::transcoder; +std::unique_ptr XMLTools::transcoder; void XMLTools::initialize() { - XERCES_CPP_NAMESPACE_USE; if (!transcoder.get()) { XMLTransService::Codes res{}; - transcoder.reset(XERCES_CPP_NAMESPACE_QUALIFIER XMLPlatformUtils::fgTransService->makeNewTranscoderFor(XERCES_CPP_NAMESPACE_QUALIFIER XMLRecognizer::UTF_8, res, 4096, XERCES_CPP_NAMESPACE_QUALIFIER XMLPlatformUtils::fgMemoryManager)); + transcoder.reset(XMLPlatformUtils::fgTransService->makeNewTranscoderFor(XMLRecognizer::UTF_8, res, 4096, XMLPlatformUtils::fgMemoryManager)); if (res != XMLTransService::Ok) throw Base::UnicodeError("Can\'t create transcoder"); } @@ -44,7 +44,6 @@ std::string XMLTools::toStdString(const XMLCh* const toTranscode) { std::string str; - XERCES_CPP_NAMESPACE_USE; initialize(); //char outBuff[128]; @@ -74,8 +73,7 @@ std::basic_string XMLTools::toXMLString(const char* const fromTranscode) std::basic_string str; if (!fromTranscode) return str; - - XERCES_CPP_NAMESPACE_USE; + initialize(); static XMLCh outBuff[128]; diff --git a/src/Base/XMLTools.h b/src/Base/XMLTools.h index d0dc66c876..e5f537b2f2 100644 --- a/src/Base/XMLTools.h +++ b/src/Base/XMLTools.h @@ -28,16 +28,10 @@ #include #include #include +#include #include - - -XERCES_CPP_NAMESPACE_BEGIN - class DOMNode; - class DOMElement; - class DOMDocument; -XERCES_CPP_NAMESPACE_END - +XERCES_CPP_NAMESPACE_USE // Helper class class BaseExport XMLTools { @@ -48,7 +42,7 @@ public: static void terminate(); private: - static std::unique_ptr transcoder; + static std::unique_ptr transcoder; }; //************************************************************************** @@ -79,12 +73,12 @@ inline std::ostream& operator<<(std::ostream& target, const StrX& toDump) inline StrX::StrX(const XMLCh* const toTranscode) { // Call the private transcoding method - fLocalForm = XERCES_CPP_NAMESPACE_QUALIFIER XMLString::transcode(toTranscode); + fLocalForm = XMLString::transcode(toTranscode); } inline StrX::~StrX() { - XERCES_CPP_NAMESPACE_QUALIFIER XMLString::release(&fLocalForm); + XMLString::release(&fLocalForm); } @@ -158,12 +152,12 @@ private : inline XStr::XStr(const char* const toTranscode) { - fUnicodeForm = XERCES_CPP_NAMESPACE_QUALIFIER XMLString::transcode(toTranscode); + fUnicodeForm = XMLString::transcode(toTranscode); } inline XStr::~XStr() { - XERCES_CPP_NAMESPACE_QUALIFIER XMLString::release(&fUnicodeForm); + XMLString::release(&fUnicodeForm); } diff --git a/src/Main/MainGui.cpp b/src/Main/MainGui.cpp index b405a07832..48ae847ef4 100644 --- a/src/Main/MainGui.cpp +++ b/src/Main/MainGui.cpp @@ -23,6 +23,12 @@ #include +#if defined(_MSC_VER) +#include +#include +#endif + + #ifdef _PreComp_ # undef _PreComp_ #endif @@ -305,8 +311,6 @@ int main( int argc, char ** argv ) } #if defined(_MSC_VER) -#include -#include typedef BOOL (__stdcall *tMDWD)( IN HANDLE hProcess, diff --git a/src/Main/MainPy.cpp b/src/Main/MainPy.cpp index e202653592..83ccf0fe36 100644 --- a/src/Main/MainPy.cpp +++ b/src/Main/MainPy.cpp @@ -27,6 +27,10 @@ # undef _PreComp_ #endif +#if defined(FC_OS_WIN32) +# include +#endif + #if defined(FC_OS_LINUX) || defined(FC_OS_BSD) # include #endif @@ -52,9 +56,7 @@ #include #include - #if defined(FC_OS_WIN32) -# include /** DllMain is called when DLL is loaded */ diff --git a/src/Mod/Inspection/Gui/Command.cpp b/src/Mod/Inspection/Gui/Command.cpp index 659d8a63cf..e7d0f0c255 100644 --- a/src/Mod/Inspection/Gui/Command.cpp +++ b/src/Mod/Inspection/Gui/Command.cpp @@ -24,6 +24,8 @@ #ifndef _PreComp_ # include #endif +#include +#include #include #include @@ -31,8 +33,6 @@ #include #include #include -#include -#include #include #include "VisualInspection.h" diff --git a/src/Mod/Inspection/Gui/ViewProviderInspection.cpp b/src/Mod/Inspection/Gui/ViewProviderInspection.cpp index e62b62bc6d..ebe105c7df 100644 --- a/src/Mod/Inspection/Gui/ViewProviderInspection.cpp +++ b/src/Mod/Inspection/Gui/ViewProviderInspection.cpp @@ -46,13 +46,15 @@ # include #endif +#include + #include #include #include #include #include #include -#include + #include #include #include diff --git a/src/Mod/Points/Gui/Command.cpp b/src/Mod/Points/Gui/Command.cpp index 98b3bb5800..4525f2ddfd 100644 --- a/src/Mod/Points/Gui/Command.cpp +++ b/src/Mod/Points/Gui/Command.cpp @@ -26,6 +26,8 @@ # include # include #endif +#include +#include #include #include @@ -39,8 +41,7 @@ #include #include #include -#include -#include + #include #include diff --git a/src/Mod/Points/Gui/ViewProvider.cpp b/src/Mod/Points/Gui/ViewProvider.cpp index e9fa723855..eec2a03c5f 100644 --- a/src/Mod/Points/Gui/ViewProvider.cpp +++ b/src/Mod/Points/Gui/ViewProvider.cpp @@ -36,13 +36,14 @@ # include # include #endif +#include #include #include #include #include #include -#include + #include #include diff --git a/src/Mod/Sandbox/Gui/PreCompiled.h b/src/Mod/Sandbox/Gui/PreCompiled.h index f8a4715690..7f913bc123 100644 --- a/src/Mod/Sandbox/Gui/PreCompiled.h +++ b/src/Mod/Sandbox/Gui/PreCompiled.h @@ -26,6 +26,10 @@ #include +#ifdef FC_OS_WIN32 +# include +#endif + // Importing of App classes #ifdef FC_OS_WIN32 # define SandboxAppExport __declspec(dllimport) @@ -62,10 +66,6 @@ // Xerces #include -#ifdef FC_OS_WIN32 -# include -#endif - // Qt Toolkit #include #include diff --git a/src/Mod/Spreadsheet/Gui/ViewProviderSpreadsheet.cpp b/src/Mod/Spreadsheet/Gui/ViewProviderSpreadsheet.cpp index 4d9d70378f..b8dfebee15 100644 --- a/src/Mod/Spreadsheet/Gui/ViewProviderSpreadsheet.cpp +++ b/src/Mod/Spreadsheet/Gui/ViewProviderSpreadsheet.cpp @@ -29,11 +29,12 @@ # include #endif +#include + #include #include #include #include -#include #include #include "ViewProviderSpreadsheet.h" diff --git a/src/Tools/_TEMPLATE_/Gui/PreCompiled.h b/src/Tools/_TEMPLATE_/Gui/PreCompiled.h index af3161df95..44a5c54fc8 100644 --- a/src/Tools/_TEMPLATE_/Gui/PreCompiled.h +++ b/src/Tools/_TEMPLATE_/Gui/PreCompiled.h @@ -26,6 +26,10 @@ #include +#ifdef FC_OS_WIN32 +#include +#endif + // Importing of App classes #ifdef FC_OS_WIN32 #define _TEMPLATE_AppExport __declspec(dllimport) @@ -56,9 +60,7 @@ // Xerces #include -#ifdef FC_OS_WIN32 -#include -#endif + // Qt Toolkit #ifndef __QtAll__