Addon Manager: Refactor Metadata

Create a Python-native metadata class. Includes unit tests, and some PyLint cleanup.

src/Mod/AddonManager/AddonManagerTest/app/test_addon.py

@@ -23,7 +23,9 @@
 
 import unittest
 import os
-import FreeCAD
+import sys
+
+sys.path.append("../../")
 
 from Addon import Addon, INTERNAL_WORKBENCHES
 from addonmanager_macro import Macro
@@ -35,7 +37,7 @@ class TestAddon(unittest.TestCase):
 
     def setUp(self):
         self.test_dir = os.path.join(
-            FreeCAD.getHomePath(), "Mod", "AddonManager", "AddonManagerTest", "data"
+            os.path.dirname(__file__), "..", "data"
         )
 
     def test_display_name(self):
@@ -55,51 +57,6 @@ class TestAddon(unittest.TestCase):
         self.assertEqual(addon.name, "FreeCAD")
         self.assertEqual(addon.display_name, "Test Workbench")
 
-    def test_metadata_loading(self):
-        addon = Addon(
-            "FreeCAD",
-            "https://github.com/FreeCAD/FreeCAD",
-            Addon.Status.NOT_INSTALLED,
-            "master",
-        )
-        addon.load_metadata_file(os.path.join(self.test_dir, "good_package.xml"))
-
-        # Generic tests:
-        self.assertIsNotNone(addon.metadata)
-        self.assertEqual(addon.metadata.Version, "1.0.1")
-        self.assertEqual(
-            addon.metadata.Description, "A package.xml file for unit testing."
-        )
-
-        maintainer_list = addon.metadata.Maintainer
-        self.assertEqual(len(maintainer_list), 1, "Wrong number of maintainers found")
-        self.assertEqual(maintainer_list[0]["name"], "FreeCAD Developer")
-        self.assertEqual(maintainer_list[0]["email"], "developer@freecad.org")
-
-        license_list = addon.metadata.License
-        self.assertEqual(len(license_list), 1, "Wrong number of licenses found")
-        self.assertEqual(license_list[0]["name"], "LGPLv2.1")
-        self.assertEqual(license_list[0]["file"], "LICENSE")
-
-        url_list = addon.metadata.Urls
-        self.assertEqual(len(url_list), 2, "Wrong number of urls found")
-        self.assertEqual(url_list[0]["type"], "repository")
-        self.assertEqual(
-            url_list[0]["location"], "https://github.com/chennes/FreeCAD-Package"
-        )
-        self.assertEqual(url_list[0]["branch"], "main")
-        self.assertEqual(url_list[1]["type"], "readme")
-        self.assertEqual(
-            url_list[1]["location"],
-            "https://github.com/chennes/FreeCAD-Package/blob/main/README.md",
-        )
-
-        contents = addon.metadata.Content
-        self.assertEqual(len(contents), 1, "Wrong number of content catetories found")
-        self.assertEqual(
-            len(contents["workbench"]), 1, "Wrong number of workbenches found"
-        )
-
     def test_git_url_cleanup(self):
         base_url = "https://github.com/FreeCAD/FreeCAD"
         test_urls = [f"  {base_url}  ", f"{base_url}.git", f"  {base_url}.git  "]
@@ -124,7 +81,7 @@ class TestAddon(unittest.TestCase):
         expected_tags.add("TagA")
         expected_tags.add("TagB")
         expected_tags.add("TagC")
-        self.assertEqual(tags, expected_tags)
+        self.assertEqual(expected_tags, tags)
 
     def test_contains_functions(self):