kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Gui: clean-up Selection API

Browse Source 
Replace the int of the 'resolve' argument of several functions with a proper enum class.
* This avoids the inconsistencies in client code where often true/false is passed when an int is expected
* This avoids the use of magic numbers like 0, 1, 2 or the undocumented 3
This commit is contained in:
wmayer
2022-04-09 17:03:43 +02:00
parent 2d266a75cd
commit 0b2c73cf32
24 changed files with 365 additions and 274 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/Gui/TaskElementColors.cpp
View File

@@ -271,12 +271,12 @@ public:
}
void onSelectionChanged() {
if(busy)
if(busy)
return;
busy = true;
std::map<std::string,int> sels;
for(auto &sel : Selection().getSelectionEx(
editDoc.c_str(),App::DocumentObject::getClassTypeId(),0))
editDoc.c_str(),App::DocumentObject::getClassTypeId(), ResolveMode::NoResolve))
{
if(sel.getFeatName()!=editObj) continue;
for(auto &sub : sel.getSubNames()) {
@@ -324,7 +324,7 @@ ElementColors::ElementColors(ViewProviderDocumentObject* vp, bool noHide)
if(d->ui->onTop->isChecked())
d->vpParent->OnTopWhenSelected.setValue(3);
Selection().addSelectionGate(d,0);
Selection().addSelectionGate(d, ResolveMode::NoResolve);
d->connectDelDoc = Application::Instance->signalDeleteDocument.connect(boost::bind
(&ElementColors::slotDeleteDocument, this, bp::_1));
@@ -379,7 +379,7 @@ void ElementColors::on_boxSelect_clicked()
}
void ElementColors::on_hideSelection_clicked() {
auto sels = Selection().getSelectionEx(d->editDoc.c_str(),App::DocumentObject::getClassTypeId(),0);
auto sels = Selection().getSelectionEx(d->editDoc.c_str(), App::DocumentObject::getClassTypeId(), ResolveMode::NoResolve);
for(auto &sel : sels) {
if(d->editObj!=sel.getFeatName())
continue;
@@ -400,7 +400,7 @@ void ElementColors::on_hideSelection_clicked() {
void ElementColors::on_addSelection_clicked()
{
auto sels = Selection().getSelectionEx(d->editDoc.c_str(),App::DocumentObject::getClassTypeId(),0);
auto sels = Selection().getSelectionEx(d->editDoc.c_str(), App::DocumentObject::getClassTypeId(), ResolveMode::NoResolve);
d->items.clear();
if(sels.empty())
d->addItem(-1,"Face",true);