From 0bd0ec5ed24320d0db16a39be596b5c3fd2a7560 Mon Sep 17 00:00:00 2001
From: 0penBrain <48731257+0penBrain@users.noreply.github.com>
Date: Fri, 29 Oct 2021 17:23:48 +0200
Subject: [PATCH] [PartDesign] Remove useless function overriding

 Double-click is already handled by PartDesign::ViewProvider::doubleClicked()
 Overridings in Loft & Pipe brings no specific behavior
 By removing overridings, behavioral consistency is improved both in ...
 ... undo commands & body activation management when PartDesign items ...
 ... are double-clicked
---
 src/Mod/PartDesign/Gui/ViewProviderLoft.cpp | 5 -----
 src/Mod/PartDesign/Gui/ViewProviderLoft.h   | 1 -
 src/Mod/PartDesign/Gui/ViewProviderPipe.cpp | 5 -----
 src/Mod/PartDesign/Gui/ViewProviderPipe.h   | 1 -
 4 files changed, 12 deletions(-)

diff --git a/src/Mod/PartDesign/Gui/ViewProviderLoft.cpp b/src/Mod/PartDesign/Gui/ViewProviderLoft.cpp
index 8cbb387b47..6f260f3b78 100644
--- a/src/Mod/PartDesign/Gui/ViewProviderLoft.cpp
+++ b/src/Mod/PartDesign/Gui/ViewProviderLoft.cpp
@@ -81,11 +81,6 @@ void ViewProviderLoft::setupContextMenu(QMenu* menu, QObject* receiver, const ch
     PartDesignGui::ViewProvider::setupContextMenu(menu, receiver, member);
 }
 
-bool ViewProviderLoft::doubleClicked(void)
-{
-    return PartDesignGui::setEdit(pcObject);
-}
-
 bool ViewProviderLoft::setEdit(int ModNum)
 {
     if (ModNum == ViewProvider::Default)
diff --git a/src/Mod/PartDesign/Gui/ViewProviderLoft.h b/src/Mod/PartDesign/Gui/ViewProviderLoft.h
index dcec346ee3..01f24e76c5 100644
--- a/src/Mod/PartDesign/Gui/ViewProviderLoft.h
+++ b/src/Mod/PartDesign/Gui/ViewProviderLoft.h
@@ -41,7 +41,6 @@ public:
     /// grouping handling 
     std::vector<App::DocumentObject*> claimChildren(void)const;
     void setupContextMenu(QMenu*, QObject*, const char*);
-    bool doubleClicked();
 
     virtual bool onDelete(const std::vector<std::string> &);
     void highlightReferences(const bool on, bool auxiliary);
diff --git a/src/Mod/PartDesign/Gui/ViewProviderPipe.cpp b/src/Mod/PartDesign/Gui/ViewProviderPipe.cpp
index 490bddf704..5c875153be 100644
--- a/src/Mod/PartDesign/Gui/ViewProviderPipe.cpp
+++ b/src/Mod/PartDesign/Gui/ViewProviderPipe.cpp
@@ -89,11 +89,6 @@ void ViewProviderPipe::setupContextMenu(QMenu* menu, QObject* receiver, const ch
     PartDesignGui::ViewProvider::setupContextMenu(menu, receiver, member);
 }
 
-bool ViewProviderPipe::doubleClicked(void)
-{
-    return PartDesignGui::setEdit(pcObject);
-}
-
 bool ViewProviderPipe::setEdit(int ModNum) {
     if (ModNum == ViewProvider::Default )
         setPreviewDisplayMode(true);
diff --git a/src/Mod/PartDesign/Gui/ViewProviderPipe.h b/src/Mod/PartDesign/Gui/ViewProviderPipe.h
index 7fbf6647ed..e3efe3a695 100644
--- a/src/Mod/PartDesign/Gui/ViewProviderPipe.h
+++ b/src/Mod/PartDesign/Gui/ViewProviderPipe.h
@@ -49,7 +49,6 @@ public:
     /// grouping handling 
     std::vector<App::DocumentObject*> claimChildren(void)const;
     void setupContextMenu(QMenu*, QObject*, const char*);
-    bool doubleClicked();
 
     virtual bool onDelete(const std::vector<std::string> &);
     void highlightReferences(Reference mode, bool on);