Fix warnings introduced in new PartDesign

Mostly unused wariables and compare of signed & unsigned
2015-11-10 16:58:27 +03:00
parent 81015b3f44
commit 0cfc0cd424
25 changed files with 60 additions and 87 deletions
--- a/src/Mod/PartDesign/Gui/ViewProviderPipe.cpp
+++ b/src/Mod/PartDesign/Gui/ViewProviderPipe.cpp
@@ -174,8 +174,9 @@ void ViewProviderPipe::highlightReferences(const bool on, bool auxillery)
            colors.resize(eMap.Extent(), svp->LineColor.getValue());

            for (std::string e : edges) {
-                int idx = atoi(e.substr(4).c_str()) - 1;
-                if (idx < colors.size())
+                int idx = std::stoi(e.substr(4)) - 1;
+                assert ( idx > 0 );
+                if ( idx < (ssize_t) colors.size() )
                    colors[idx] = App::Color(1.0,0.0,1.0); // magenta
            }
            svp->LineColorArray.setValues(colors);