From 0d4952579805b6fd26e8efdfa853cf88c436a6d8 Mon Sep 17 00:00:00 2001
From: Benjamin Nauck <benjamin@nauck.se>
Date: Tue, 9 Mar 2021 00:43:42 +0100
Subject: [PATCH] Gui: Auto update NaviCube when changing preferences

---
 src/Gui/NaviCube.cpp | 61 +++++++++++++++++++++++++-------------------
 1 file changed, 35 insertions(+), 26 deletions(-)

diff --git a/src/Gui/NaviCube.cpp b/src/Gui/NaviCube.cpp
index 72f57992ab..fca7e374b4 100644
--- a/src/Gui/NaviCube.cpp
+++ b/src/Gui/NaviCube.cpp
@@ -172,13 +172,16 @@ public:
 	}
 };
 
-class NaviCubeImplementation {
+class NaviCubeImplementation : public ParameterGrp::ObserverType {
 public:
 	NaviCubeImplementation(Gui::View3DInventorViewer*);
 	virtual ~ NaviCubeImplementation();
 	void drawNaviCube();
 	void createContextMenu(const std::vector<std::string>& cmd);
 
+	/// Observer message from the ParameterGrp
+	virtual void OnChange(ParameterGrp::SubjectType &rCaller,ParameterGrp::MessageType Reason);
+
 	bool processSoEvent(const SoEvent* ev);
 private:
 	bool mousePressed(short x, short y);
@@ -306,40 +309,27 @@ void NaviCube::setCorner(Corner c) {
 
 NaviCubeImplementation::NaviCubeImplementation(
 	Gui::View3DInventorViewer* viewer) {
-	ParameterGrp::handle hGrp = App::GetApplication().GetParameterGroupByPath("User parameter:BaseApp/Preferences/NaviCube");
+
 	m_View3DInventorViewer = viewer;
 
-	m_TextColor = QColor(0,0,0,255);
-	if (hGrp->GetUnsigned("TextColor")) {
-		m_TextColor.setRgba(hGrp->GetUnsigned("TextColor"));
-	}
+	auto hGrp = App::GetApplication().GetParameterGroupByPath("User parameter:BaseApp/Preferences/NaviCube");
+	hGrp->Attach(this);
 
-	m_FrontFaceColor = QColor(255,255,255,128);
-	if (hGrp->GetUnsigned("FrontColor")) {
-		m_FrontFaceColor.setRgba(hGrp->GetUnsigned("FrontColor"));
-	}
-
-	m_BackFaceColor = QColor(226,233,239,128);
-	if (hGrp->GetUnsigned("BackColor")) {
-		m_BackFaceColor.setRgba(hGrp->GetUnsigned("BackColor"));
-	}
-
-	m_HiliteColor = QColor(170,226,255);
-	if (hGrp->GetUnsigned("HiliteColor")) {
-		m_HiliteColor.setRgba(hGrp->GetUnsigned("HiliteColor"));
-	}
-
-	m_ButtonColor = QColor(226,233,239,128);
-	if (hGrp->GetUnsigned("ButtonColor")) {
-		m_ButtonColor.setRgba(hGrp->GetUnsigned("ButtonColor"));
-	}
+	OnChange(*hGrp, "TextColor");
+	OnChange(*hGrp, "FrontColor");
+	OnChange(*hGrp, "BackColor");
+	OnChange(*hGrp, "HiliteColor");
+	OnChange(*hGrp, "ButtonColor");
+	OnChange(*hGrp, "CubeSize");
 
 	m_PickingFramebuffer = NULL;
-	m_CubeWidgetSize = (hGrp->GetInt("CubeSize", 132));
 	m_Menu = createNaviCubeMenu();
 }
 
 NaviCubeImplementation::~NaviCubeImplementation() {
+	auto hGrp = App::GetApplication().GetParameterGroupByPath("User parameter:BaseApp/Preferences/NaviCube");
+	hGrp->Detach(this);
+
 	delete m_Menu;
 	if (m_PickingFramebuffer)
 		delete m_PickingFramebuffer;
@@ -351,6 +341,25 @@ NaviCubeImplementation::~NaviCubeImplementation() {
 #endif
 }
 
+void NaviCubeImplementation::OnChange(ParameterGrp::SubjectType &rCaller, ParameterGrp::MessageType reason)
+{
+	const auto & rGrp = static_cast<ParameterGrp &>(rCaller);
+
+	if (strcmp(reason,"TextColor") == 0) {
+		m_TextColor.setRgba(rGrp.GetUnsigned(reason, QColor(0,0,0,255).rgba()));
+	} else if (strcmp(reason,"FrontColor") == 0) {
+		m_FrontFaceColor.setRgba(rGrp.GetUnsigned(reason, QColor(255,255,255,128).rgba()));
+	} else if (strcmp(reason,"BackColor") == 0) {
+		m_BackFaceColor.setRgba(rGrp.GetUnsigned(reason, QColor(226,233,239,128).rgba()));
+	} else if (strcmp(reason,"HiliteColor") == 0) {
+		m_HiliteColor.setRgba(rGrp.GetUnsigned(reason, QColor(170,226,255).rgba()));
+	} else if (strcmp(reason,"ButtonColor") == 0) {
+		m_ButtonColor.setRgba(rGrp.GetUnsigned(reason, QColor(226,233,239,128).rgba()));
+	} else if (strcmp(reason,"CubeSize") == 0) {
+		m_CubeWidgetSize = (rGrp.GetInt(reason, 132));
+	}
+}
+
 char* NaviCubeImplementation::enum2str(int e) {
 	switch (e) {
 	default : return "???";