From 0e22ada9dd7db17c4cca572af0e2124c3682e660 Mon Sep 17 00:00:00 2001 From: adrianinsaval <36372335+adrianinsaval@users.noreply.github.com> Date: Tue, 19 Jul 2022 21:13:01 -0400 Subject: [PATCH] [PD Pad/Pocket] Fix bug with midplane usage in TwoLengths mode (#7216) * [PD Pad/Pocket] Fix bug with midplane usage in TwoLengths mode --- src/Mod/PartDesign/App/FeatureExtrude.cpp | 3 --- src/Mod/PartDesign/Gui/TaskPadParameters.cpp | 3 --- src/Mod/PartDesign/Gui/TaskPocketParameters.cpp | 3 --- 3 files changed, 9 deletions(-) diff --git a/src/Mod/PartDesign/App/FeatureExtrude.cpp b/src/Mod/PartDesign/App/FeatureExtrude.cpp index c0b82875f4..cf4843009a 100644 --- a/src/Mod/PartDesign/App/FeatureExtrude.cpp +++ b/src/Mod/PartDesign/App/FeatureExtrude.cpp @@ -144,12 +144,9 @@ void FeatureExtrude::generatePrism(TopoDS_Shape& prism, if (method == "TwoLengths") { - // midplane makes no sense here Ltotal += L2; if (reversed) Loffset = -L; - else if (midplane) - Loffset = -0.5 * (L2 + L); else Loffset = -L2; } diff --git a/src/Mod/PartDesign/Gui/TaskPadParameters.cpp b/src/Mod/PartDesign/Gui/TaskPadParameters.cpp index 7592f6398c..608775a76c 100644 --- a/src/Mod/PartDesign/Gui/TaskPadParameters.cpp +++ b/src/Mod/PartDesign/Gui/TaskPadParameters.cpp @@ -111,9 +111,6 @@ void TaskPadParameters::onModeChanged(int index) break; case Modes::TwoDimensions: pcPad->Type.setValue("TwoLengths"); - // symmetric is then not possible - if (ui->checkBoxMidplane->isChecked()) - ui->checkBoxMidplane->setChecked(false); break; } diff --git a/src/Mod/PartDesign/Gui/TaskPocketParameters.cpp b/src/Mod/PartDesign/Gui/TaskPocketParameters.cpp index c787e385be..3412e449fa 100644 --- a/src/Mod/PartDesign/Gui/TaskPocketParameters.cpp +++ b/src/Mod/PartDesign/Gui/TaskPocketParameters.cpp @@ -122,9 +122,6 @@ void TaskPocketParameters::onModeChanged(int index) case Modes::TwoDimensions: oldLength = pcPocket->Length.getValue(); pcPocket->Type.setValue("TwoLengths"); - // symmetric is then not possible - if (ui->checkBoxMidplane->isChecked()) - ui->checkBoxMidplane->setChecked(false); break; }