kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Part/Toponaming: Tests for flushElementMap and resetElementMap (#12471)

Browse Source 
* Part/Toponaming: tests for flushElementMap and resetElementMap
 * Added test for resetElementMap()
 * Added test for flushElementMap()
 * restored ComplexGeoData::resetElementMap to RT fork
 * modified TopoShape::resetElementMap to match the restored signature of ComplexGeoData::resetElementMap
 * added checks in TopoShape::makeShapeWithElementMap to avoid segfaults
 * added check in TopoShape::setElementComboName to avoid segfaults
 * restored testFindSubShapesForSourceWithTypeAndIndex
 * modified test saveDocFileWithNoElementMap to match the restored signature of ComplexGeoData::resetElementMap
* Part/Toponaming: tests for flushElementMap and resetElementMap
 * Removed comments in ComplexGeoData::resetElementMap()
 * Changed TopoShape::resetElementMap():: from virtual to override
 * Removed comment in TopoShape::resetElementMap()
 * Added comments about differences between main and RT fork
 * Removed comment in test saveDocFileWithNoElementMap
 * Updated expected test result in makeElementCompoundTwoShapesGeneratesMap
 * Updated expected test result in resetElementMapTest
 * Fixed typo in test flushElementMapTest
* Part/Toponaming: tests for flushElementMap and resetElementMap
 * updated expected tests results after previous methods modifications

---------

Signed-off-by: CalligaroV <vincenzo.calligaro@gmail.com>
This commit is contained in:
Vincenzo Calligaro
2024-02-29 20:27:27 +01:00
committed by GitHub
parent cbc39e989f
commit 0e7aa5f7bc
8 changed files with 281 additions and 87 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tests/src/Mod/Part/App/TopoShapeMakeShape.cpp
View File

@@ -71,7 +71,8 @@ TEST_F(TopoShapeMakeShapeTests, shapeVertex)
// Act
TopoShape& result = topoShape.makeElementShape(vertexMaker, topoShape);
// Assert
EXPECT_EQ(result.getElementMap().size(), 0);
EXPECT_EQ(result.getElementMap().size(), 1); // Changed with PR#12471. Probably will change
// again after importing other TopoNaming logics
EXPECT_EQ(result.countSubElements("Vertex"), 1);
EXPECT_EQ(result.countSubShapes("Vertex"), 1);
}