kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Base: Drop QString-std::string conversion functions from Tools

Browse Source 
Convenience helpers function Tools::toStdString and Tools::fromStdString
were implemented for Qt4 or older to perform utf8 aware conversion as
QString::toStdString/QString::fromStdString were using toAscii/fromAscii
internally (see https://dreamswork.github.io/qt4/classQString.html).

Since Qt5 QString uses toUtf8/fromUTf8, which makes the helper functions
obsolete (see https://doc.qt.io/qt-5/qstring.html#fromStdString).
This commit is contained in:
Ladislav Michl
2024-12-02 12:34:11 +01:00
committed by Chris Hennes
parent f9d1391588
commit 0ee3c9f8e6
54 changed files with 190 additions and 255 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/Mod/TechDraw/Gui/TaskCenterLine.cpp
View File

@@ -23,7 +23,6 @@
#include "PreCompiled.h"
#include <Base/Console.h>
#include <Base/Tools.h>
#include <Base/UnitsApi.h>
#include <Gui/Application.h>
#include <Gui/BitmapFactory.h>
@@ -170,9 +169,9 @@ void TaskCenterLine::setUiPrimary()
if (m_partFeat) {
std::string baseName = m_partFeat->getNameInDocument();
ui->leBaseView->setText(Base::Tools::fromStdString(baseName));
ui->leBaseView->setText(QString::fromStdString(baseName));
for (auto& s: m_subNames) {
QString listItem = Base::Tools::fromStdString(s);
QString listItem = QString::fromStdString(s);
ui->lstSubList->addItem(listItem);
}
}
@@ -212,8 +211,8 @@ void TaskCenterLine::setUiEdit()
setWindowTitle(QObject::tr("Edit Center Line"));
if (m_partFeat) {
std::string baseName = m_partFeat->getNameInDocument();
ui->leBaseView->setText(Base::Tools::fromStdString(baseName));
QString listItem = Base::Tools::fromStdString(m_edgeName);
ui->leBaseView->setText(QString::fromStdString(baseName));
QString listItem = QString::fromStdString(m_edgeName);
ui->lstSubList->addItem(listItem);
}
ui->cpLineColor->setColor(m_cl->m_format.getColor().asValue<QColor>());