kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Base: Drop QString-std::string conversion functions from Tools

Browse Source 
Convenience helpers function Tools::toStdString and Tools::fromStdString
were implemented for Qt4 or older to perform utf8 aware conversion as
QString::toStdString/QString::fromStdString were using toAscii/fromAscii
internally (see https://dreamswork.github.io/qt4/classQString.html).

Since Qt5 QString uses toUtf8/fromUTf8, which makes the helper functions
obsolete (see https://doc.qt.io/qt-5/qstring.html#fromStdString).
This commit is contained in:
Ladislav Michl
2024-12-02 12:34:11 +01:00
committed by Chris Hennes
parent f9d1391588
commit 0ee3c9f8e6
54 changed files with 190 additions and 255 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/Mod/TechDraw/Gui/TaskDimRepair.cpp
View File

@@ -30,7 +30,6 @@
#endif// #ifndef _PreComp_
#include <App/Document.h>
#include <Base/Tools.h>
#include <Gui/BitmapFactory.h>
#include <Gui/Command.h>
#include <Gui/MainWindow.h>
@@ -68,12 +67,12 @@ void TaskDimRepair::setUiPrimary()
ui->leName->setReadOnly(true);
ui->leLabel->setReadOnly(true);
ui->leName->setText(Base::Tools::fromStdString(m_dim->getNameInDocument()));
ui->leLabel->setText(Base::Tools::fromStdString(m_dim->Label.getValue()));
ui->leName->setText(QString::fromStdString(m_dim->getNameInDocument()));
ui->leLabel->setText(QString::fromStdString(m_dim->Label.getValue()));
std::string objName = m_dim->getViewPart()->getNameInDocument();
std::string objLabel = m_dim->getViewPart()->Label.getValue();
ui->leObject2d->setText(Base::Tools::fromStdString(objName + " / " + objLabel));
ui->leObject2d->setText(QString::fromStdString(objName + " / " + objLabel));
const std::vector<std::string>& subElements2d = m_dim->References2D.getSubValues();
std::vector<std::string> noLabels(subElements2d.size());
fillList(ui->lwGeometry2d, subElements2d, noLabels);
@@ -164,7 +163,7 @@ void TaskDimRepair::updateUi()
{
std::string objName = m_dim->getViewPart()->getNameInDocument();
std::string objLabel = m_dim->getViewPart()->Label.getValue();
ui->leObject2d->setText(Base::Tools::fromStdString(objName + " / " + objLabel));
ui->leObject2d->setText(QString::fromStdString(objName + " / " + objLabel));
std::vector<std::string> subElements2d;
for (auto& ref : m_toApply2d) {
@@ -182,15 +181,15 @@ void TaskDimRepair::loadTableWidget(QTableWidget* tw, ReferenceVector refs)
tw->setRowCount(refs.size() + 1);
size_t iRow = 0;
for (auto& ref : refs) {
QString qName = Base::Tools::fromStdString(ref.getObject()->getNameInDocument());
QString qName = QString::fromStdString(ref.getObject()->getNameInDocument());
QTableWidgetItem* itemName = new QTableWidgetItem(qName);
itemName->setTextAlignment(Qt::AlignRight | Qt::AlignVCenter);
tw->setItem(iRow, 0, itemName);
QString qLabel = Base::Tools::fromStdString(std::string(ref.getObject()->Label.getValue()));
QString qLabel = QString::fromStdString(std::string(ref.getObject()->Label.getValue()));
QTableWidgetItem* itemLabel = new QTableWidgetItem(qLabel);
itemLabel->setTextAlignment(Qt::AlignRight | Qt::AlignVCenter);
tw->setItem(iRow, 1, itemLabel);
QString qSubName = Base::Tools::fromStdString(ref.getSubName());
QString qSubName = QString::fromStdString(ref.getSubName());
QTableWidgetItem* itemSubName = new QTableWidgetItem(qSubName);
itemSubName->setTextAlignment(Qt::AlignRight | Qt::AlignVCenter);
tw->setItem(iRow, 2, itemSubName);
@@ -209,8 +208,8 @@ void TaskDimRepair::fillList(QListWidget* lwItems, std::vector<std::string> labe
int i = 0;
lwItems->clear();
for (; i < labelCount; i++) {
qLabel = Base::Tools::fromStdString(labels[i]);
qName = Base::Tools::fromStdString(names[i]);
qLabel = QString::fromStdString(labels[i]);
qName = QString::fromStdString(names[i]);
qText = QString::fromUtf8("%1 %2").arg(qName, qLabel);
item = new QListWidgetItem(qText, lwItems);
item->setTextAlignment(Qt::AlignRight | Qt::AlignVCenter);
@@ -234,7 +233,7 @@ bool TaskDimRepair::accept()
{
Gui::Command::doCommand(Gui::Command::Gui, "Gui.ActiveDocument.resetEdit()");
Gui::Command::openCommand(Base::Tools::toStdString(tr("Repair Dimension")).c_str());
Gui::Command::openCommand(tr("Repair Dimension").toStdString().c_str());
replaceReferences();
Gui::Command::commitCommand();