kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Gui: fix possible problems with new style connect

Browse Source 
* In UIntSpinBox rename the signal to not overwrite the signal of the base class
* In UIntSpinBox use the (ambiguous) signal 'valueChanged' of the base class QSpinBox
* To avoid that connect() fails use the function pointer of the Qt class where the signal is defined
This commit is contained in:
wmayer
2023-01-12 17:02:59 +01:00
parent 19d624396f
commit 103de43a4e
14 changed files with 43 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/Gui/SpinBox.cpp
View File

@@ -324,7 +324,7 @@ UIntSpinBox::UIntSpinBox (QWidget* parent)
{
d = new UIntSpinBoxPrivate;
d->mValidator = new UnsignedValidator(this->minimum(), this->maximum(), this);
connect(this, &Gui::UIntSpinBox::valueChanged, this, &UIntSpinBox::valueChange);
connect(this, qOverload<int>(&QSpinBox::valueChanged), this, &UIntSpinBox::valueChange);
setRange(0, 99);
setValue(0);
updateValidator();
@@ -361,7 +361,7 @@ void UIntSpinBox::setValue(uint value)
void UIntSpinBox::valueChange(int value)
{
Q_EMIT valueChanged(d->mapToUInt(value));
Q_EMIT unsignedChanged(d->mapToUInt(value));
}
uint UIntSpinBox::minimum() const
@@ -422,8 +422,8 @@ bool UIntSpinBox::apply(const std::string & propName)
Gui::Command::doCommand(Gui::Command::Doc, "%s = %u", propName.c_str(), value());
return true;
}
else
return false;
return false;
}
void UIntSpinBox::setNumberExpression(App::NumberExpression* expr)