kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

PartDesign: decouple refine and other geometric computation (#17008)

Browse Source
This commit is contained in:
Florian Foinant-Willig
2024-12-02 17:57:30 +01:00
committed by GitHub
parent 32e339447a
commit 115667f73a
14 changed files with 141 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/Mod/PartDesign/App/FeatureRevolution.cpp
View File

@@ -80,6 +80,12 @@ short Revolution::mustExecute() const
App::DocumentObjectExecReturn* Revolution::execute()
{
if (onlyHasToRefine()){
TopoShape result = refineShapeIfActive(rawShape);
Shape.setValue(result);
return App::DocumentObject::StdReturn;
}
// Validate parameters
// All angles are in radians unless explicitly stated
double angleDeg = Angle.getValue();
@@ -213,12 +219,16 @@ App::DocumentObjectExecReturn* Revolution::execute()
}
if (!result.isNull()) {
// store shape before refinement
this->rawShape = result;
result = refineShapeIfActive(result);
// set the additive shape property for later usage in e.g. pattern
this->AddSubShape.setValue(result);
if (!base.isNull()) {
result = result.makeElementFuse(base);
// store shape before refinement
this->rawShape = result;
result = refineShapeIfActive(result);
}
this->Shape.setValue(getSolid(result));