kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

[TD]remove obsolete log messages

Browse Source
This commit is contained in:
wandererfan
2023-01-08 20:08:55 -05:00
committed by WandererFan
parent b57e5646f6
commit 12db3618df
35 changed files with 406 additions and 535 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Mod/TechDraw/App/AppTechDrawPy.cpp
View File

@@ -242,7 +242,6 @@ private:
}
if (edgeList.empty()) {
Base::Console().Log("LOG - edgeWalker: input is empty\n");
return Py::None();
}
@@ -369,7 +368,6 @@ private:
}
if (edgeList.empty()) {
Base::Console().Log("LOG - ATDP::findShapeOutline: input is empty\n");
return Py::None();
}

9
src/Mod/TechDraw/App/DrawGeomHatch.cpp
View File

@@ -243,7 +243,6 @@ std::vector<LineSet> DrawGeomHatch::getTrimmedLines(int i) //get the trimmed
DrawViewPart* source = getSourceView();
if (!source ||
!source->hasGeometry()) {
Base::Console().Log("DGH::getTrimmedLines - no source geometry\n");
return result;
}
return getTrimmedLines(source, m_lineSets, i, ScalePattern.getValue(),
@@ -310,7 +309,6 @@ std::vector<LineSet> DrawGeomHatch::getTrimmedLines(DrawViewPart* source,
std::vector<LineSet> result;
if (lineSets.empty()) {
Base::Console().Log("DGH::getTrimmedLines - no LineSets!\n");
return result;
}
@@ -350,7 +348,6 @@ std::vector<LineSet> DrawGeomHatch::getTrimmedLines(DrawViewPart* source,
BRepAlgoAPI_Common mkCommon(face, grid);
if ((!mkCommon.IsDone()) ||
(mkCommon.Shape().IsNull()) ) {
Base::Console().Log("INFO - DGH::getTrimmedLines - Common creation failed\n");
return result;
}
TopoDS_Shape common = mkCommon.Shape();
@@ -368,7 +365,6 @@ std::vector<LineSet> DrawGeomHatch::getTrimmedLines(DrawViewPart* source,
for ( int i = 1 ; i <= mapOfEdges.Extent() ; i++ ) { //remember, TopExp makes no promises about the order it finds edges
const TopoDS_Edge& edge = TopoDS::Edge(mapOfEdges(i));
if (edge.IsNull()) {
Base::Console().Log("INFO - DGH::getTrimmedLines - edge: %d is NULL\n", i);
continue;
}
resultEdges.push_back(edge);
@@ -379,7 +375,6 @@ std::vector<LineSet> DrawGeomHatch::getTrimmedLines(DrawViewPart* source,
for (auto& e: resultEdges) {
TechDraw::BaseGeomPtr base = BaseGeom::baseFactory(e);
if (!base) {
Base::Console().Log("FAIL - DGH::getTrimmedLines - baseFactory failed for edge: %d\n", i);
throw Base::ValueError("DGH::getTrimmedLines - baseFactory failed");
}
resultGeoms.push_back(base);
@@ -519,7 +514,6 @@ std::vector<LineSet> DrawGeomHatch::getFaceOverlay(int fdx)
DrawViewPart* source = getSourceView();
if (!source ||
!source->hasGeometry()) {
Base::Console().Log("DGH::getFaceOverlay - no source geometry\n");
return result;
}
@@ -541,7 +535,6 @@ std::vector<LineSet> DrawGeomHatch::getFaceOverlay(int fdx)
for (auto& e: candidates) {
TechDraw::BaseGeomPtr base = BaseGeom::baseFactory(e);
if (!base) {
Base::Console().Log("FAIL - DGH::getFaceOverlay - baseFactory failed for edge: %d\n", i);
throw Base::ValueError("DGH::getFaceOverlay - baseFactory failed");
}
resultGeoms.push_back(base);
@@ -575,7 +568,6 @@ TopoDS_Face DrawGeomHatch::extractFace(DrawViewPart* source, int iface )
mkFace.Add(*itWire);
}
if (!mkFace.IsDone()) {
Base::Console().Log("INFO - DGH::extractFace - face creation failed\n");
return result;
}
TopoDS_Face face = mkFace.Face();
@@ -589,7 +581,6 @@ TopoDS_Face DrawGeomHatch::extractFace(DrawViewPart* source, int iface )
temp = mkTrf.Shape();
}
catch (...) {
Base::Console().Log("DGH::extractFace - mirror failed.\n");
return result;
}
result = TopoDS::Face(temp);

6
src/Mod/TechDraw/App/DrawLeaderLine.cpp
View File

@@ -179,9 +179,6 @@ double DrawLeaderLine::getBaseScale() const
DrawView* parent = getBaseView();
if (parent) {
result = parent->getScale();
} else {
//TARFU
Base::Console().Log("DrawLeaderLine - %s - scale not found. Using 1.0. \n", getNameInDocument());
}
return result;
}
@@ -194,9 +191,6 @@ double DrawLeaderLine::getScale() const
DrawView* parent = getBaseView();
if (parent) {
result = parent->getScale();
} else {
//TARFU
Base::Console().Log("DrawLeaderLine - %s - scale not found. Using 1.0. \n", getNameInDocument());
}
}
return result;

9
src/Mod/TechDraw/App/DrawPage.cpp
View File

@@ -420,10 +420,6 @@ void DrawPage::unsetupObject()
docName.c_str(),
viewName.c_str());
}
else {
Base::Console().Log("DP::unsetupObject - v(%s) is not in document. skipping\n",
pageName.c_str());
}
}
std::vector<App::DocumentObject*> emptyViews;//probably superfluous
Views.setValues(emptyViews);
@@ -466,11 +462,6 @@ void DrawPage::handleChangedPropertyType(Base::XMLReader& reader, const char* Ty
Scale.setValue(1.0);
}
}
else {
// has Scale prop that isn't Float!
Base::Console().Log("DrawPage::Restore - old Document Scale is Not Float!\n");
// no idea
}
}
}

775
src/Mod/TechDraw/App/DrawProjGroup.cpp
View File

File diff suppressed because it is too large Load Diff

1
src/Mod/TechDraw/App/DrawProjGroupItem.cpp
View File

@@ -325,7 +325,6 @@ double DrawProjGroupItem::getScale(void) const
if (pgroup) {
result = pgroup->getScale();
if (!(result > 0.0)) {
Base::Console().Log("DPGI - %s - bad scale found (%.3f) using 1.0\n", getNameInDocument(), Scale.getValue());
result = 1.0; //kludgy protective fix. autoscale sometimes serves up 0.0!
}
}

4
src/Mod/TechDraw/App/DrawSVGTemplate.cpp
View File

@@ -222,14 +222,14 @@ std::map<std::string, std::string> DrawSVGTemplate::getEditableTextsFromTemplate
tfi.setFile(App::Application::getResourceDir() + "Mod/Drawing/Templates/" + tfi.fileName());
// try the redirect
if (!tfi.isReadable()) {
Base::Console().Log("DrawSVGTemplate::getEditableTextsFromTemplate() not able to open %s!\n", Template.getValue());
Base::Console().Error("DrawSVGTemplate::getEditableTextsFromTemplate() not able to open %s!\n", Template.getValue());
return editables;
}
}
QFile templateFile(QString::fromUtf8(tfi.filePath().c_str()));
if (!templateFile.open(QIODevice::ReadOnly)) {
Base::Console().Log("DrawSVGTemplate::getEditableTextsFromTemplate() can't read template %s!\n", Template.getValue());
Base::Console().Error("DrawSVGTemplate::getEditableTextsFromTemplate() can't read template %s!\n", Template.getValue());
return editables;
}

5
src/Mod/TechDraw/App/DrawUtil.cpp
View File

@@ -87,7 +87,6 @@ using namespace TechDraw;
std::stringstream ErrorMsg;
if (geomName.empty()) {
Base::Console().Log("DU::getIndexFromName(%s) - empty geometry name\n", geomName.c_str());
throw Base::ValueError("getIndexFromName - empty geometry name");
}
@@ -998,11 +997,9 @@ bool DrawUtil::isCrazy(TopoDS_Edge e)
double edgeLength = GCPnts_AbscissaPoint::Length(adapt, Precision::Confusion());
if (edgeLength < 0.00001) {//edge is scaled. this is 0.00001 mm on paper
Base::Console().Log("DU::isCrazy - edge crazy short: %.7f\n", edgeLength);
return true;
}
if (edgeLength > 9999.9) {//edge is scaled. this is 10 m on paper. can't be right?
Base::Console().Log("DU::isCrazy - edge crazy long: %.3f\n", edgeLength);
return true;
}
@@ -1023,11 +1020,9 @@ bool DrawUtil::isCrazy(TopoDS_Edge e)
double major = ellp.MajorRadius();
double minor = ellp.MinorRadius();
if (minor < 0.001) {//too narrow
Base::Console().Log("DU::isCrazy - ellipse is crazy narrow: %.7f\n", minor);
return true;
}
else if (major > 9999.9) {//too big
Base::Console().Log("DU::isCrazy - ellipse is crazy wide: %.3f\n", major);
return true;
}
}

7
src/Mod/TechDraw/App/DrawView.cpp
View File

@@ -457,7 +457,6 @@ double DrawView::getScale() const
}
if (!(result > 0.0)) {
result = 1.0;
Base::Console().Log("DrawView - %s - bad scale found (%.3f) using 1.0\n", getNameInDocument(), Scale.getValue());
}
return result;
}
@@ -489,11 +488,7 @@ void DrawView::handleChangedPropertyType(Base::XMLReader &reader, const char * T
} else {
Scale.setValue(1.0);
}
} else {
// has Scale prop that isn't Float!
Base::Console().Log("DrawPage::Restore - old Document Scale is Not Float!\n");
// no idea
}
}
}
else if (prop->isDerivedFrom(App::PropertyLinkList::getClassTypeId())
&& strcmp(prop->getName(), "Source") == 0) {

1
src/Mod/TechDraw/App/DrawViewMulti.cpp
View File

@@ -127,7 +127,6 @@ App::DocumentObjectExecReturn *DrawViewMulti::execute()
#endif //#if MOD_TECHDRAW_HANDLE_FACES
}
catch (Standard_Failure& e1) {
Base::Console().Log("LOG - DVM::execute - projection failed for %s - %s **\n", getNameInDocument(), e1.GetMessageString());
return new App::DocumentObjectExecReturn(e1.GetMessageString());
}

21
src/Mod/TechDraw/App/DrawViewPart.cpp
View File

@@ -577,10 +577,6 @@ void DrawViewPart::extractFaces()
if (!DrawUtil::isZeroEdge(e)) {
nonZero.push_back(e);
}
else {
Base::Console().Log("INFO - DVP::extractFaces for %s found ZeroEdge!\n",
getNameInDocument());
}
}
//HLR algo does not provide all edge intersections for edge endpoints.
@@ -595,13 +591,9 @@ void DrawViewPart::extractFaces()
BRepBndLib::AddOptimal(*itOuter, sOuter);
sOuter.SetGap(0.1);
if (sOuter.IsVoid()) {
Base::Console().Log("DVP::Extract Faces - outer Bnd_Box is void for %s\n",
getNameInDocument());
continue;
}
if (DrawUtil::isZeroEdge(*itOuter)) {
Base::Console().Log("DVP::extractFaces - outerEdge: %d is ZeroEdge\n",
iOuter);//this is not finding ZeroEdges
continue; //skip zero length edges. shouldn't happen ;)
}
int iInner = 0;
@@ -618,9 +610,6 @@ void DrawViewPart::extractFaces()
BRepBndLib::AddOptimal(*itInner, sInner);
sInner.SetGap(0.1);
if (sInner.IsVoid()) {
Base::Console().Log(
"INFO - DVP::Extract Faces - inner Bnd_Box is void for %s\n",
getNameInDocument());
continue;
}
if (sOuter.IsOut(sInner)) {//bboxes of edges don't intersect, don't bother
@@ -654,7 +643,6 @@ void DrawViewPart::extractFaces()
std::vector<TopoDS_Edge> newEdges = DrawProjectSplit::splitEdges(nonZero, sorted);
if (newEdges.empty()) {
Base::Console().Log("DVP::extractFaces - no newEdges\n");
return;
}
@@ -844,8 +832,6 @@ TechDraw::BaseGeomPtr DrawViewPart::getGeomByIndex(int idx) const
{
const std::vector<TechDraw::BaseGeomPtr>& geoms = getEdgeGeometry();
if (geoms.empty()) {
Base::Console().Log("DVP::getGeomByIndex(%d) - no Edge Geometry. Probably restoring?\n",
idx);
return nullptr;
}
if ((unsigned)idx >= geoms.size()) {
@@ -861,8 +847,6 @@ TechDraw::VertexPtr DrawViewPart::getProjVertexByIndex(int idx) const
{
const std::vector<TechDraw::VertexPtr>& geoms = getVertexGeometry();
if (geoms.empty()) {
Base::Console().Log(
"DVP::getProjVertexByIndex(%d) - no Vertex Geometry. Probably restoring?\n", idx);
return nullptr;
}
if ((unsigned)idx >= geoms.size()) {
@@ -877,7 +861,6 @@ TechDraw::VertexPtr DrawViewPart::getProjVertexByCosTag(std::string cosTag)
TechDraw::VertexPtr result = nullptr;
std::vector<TechDraw::VertexPtr> gVerts = getVertexGeometry();
if (gVerts.empty()) {
Base::Console().Log("INFO - getProjVertexByCosTag(%s) - no Vertex Geometry.\n");
return result;
}
@@ -902,7 +885,7 @@ std::vector<TechDraw::BaseGeomPtr> DrawViewPart::getFaceEdgesByIndex(int idx) co
for (auto& g : w->geoms) {
if (g->cosmetic) {
//if g is cosmetic, we should skip it
Base::Console().Log("DVP::getFaceEdgesByIndex - found cosmetic edge\n");
continue;
}
else {
result.push_back(g);
@@ -1299,8 +1282,6 @@ bool DrawViewPart::checkXDirection() const
Base::Vector3d dir = Direction.getValue();
Base::Vector3d origin(0.0, 0.0, 0.0);
Base::Vector3d xDir = getLegacyX(origin, dir);
Base::Console().Log("DVP - %s - XDirection property not set. Trying %s\n",
getNameInDocument(), DrawUtil::formatVector(xDir).c_str());
return false;
}
return true;

4
src/Mod/TechDraw/App/DrawViewSection.cpp
View File

@@ -910,8 +910,6 @@ gp_Ax2 DrawViewSection::getCSFromBase(const std::string sectionName) const
dvsXDir = gp_Dir(sectionXDir.x, sectionXDir.y, sectionXDir.z);
}
else {
Base::Console().Log("Error - DVS::getCSFromBase - bad sectionName: %s\n",
sectionName.c_str());
dvsDir = dvpRight;
dvsXDir = dvpDir;
}
@@ -940,7 +938,7 @@ gp_Ax2 DrawViewSection::getSectionCS() const
sectionCS = gp_Ax2(gOrigin, gNormal, gXDir);
}
catch (...) {
Base::Console().Log("DVS::getSectionCS - %s - failed to create section CS\n",
Base::Console().Error("DVS::getSectionCS - %s - failed to create section CS\n",
getNameInDocument());
}
return sectionCS;

16
src/Mod/TechDraw/App/Geometry.cpp
View File

@@ -102,9 +102,7 @@ Wire::Wire(const TopoDS_Wire &w)
BaseGeomPtr bg = BaseGeom::baseFactory(edge);
if (bg) {
geoms.push_back(bg);
} else {
Base::Console().Log("G::Wire - baseFactory returned null geom ptr\n");
}
}
}
}
@@ -1209,15 +1207,12 @@ BSpline::BSpline(const TopoDS_Edge &e)
}
else if (approx.HasResult()) { //result, but not within tolerance
spline = approx.Curve();
Base::Console().Log("Geometry::BSpline - result not within tolerance\n");
}
else {
f = c.FirstParameter();
l = c.LastParameter();
s = c.Value(f);
ePt = c.Value(l);
Base::Console().Log("Error - Geometry::BSpline - no result- from:(%.3f, %.3f) to:(%.3f, %.3f) poles: %d\n",
s.X(), s.Y(),ePt.X(),ePt.Y(),spline->NbPoles());
TColgp_Array1OfPnt controlPoints(0, 1);
controlPoints.SetValue(0, s);
controlPoints.SetValue(1, ePt);
@@ -1230,9 +1225,6 @@ BSpline::BSpline(const TopoDS_Edge &e)
for (Standard_Integer i = 1; i <= crt.NbArcs(); ++i) {
BezierSegment tempSegment;
Handle(Geom_BezierCurve) bezier = crt.Arc(i);
if (bezier->Degree() > 3) {
Base::Console().Log("Geometry::BSpline - converted curve degree > 3\n");
}
tempSegment.poles = bezier->NbPoles();
tempSegment.degree = bezier->Degree();
for (int pole = 1; pole <= tempSegment.poles; ++pole) {
@@ -1326,9 +1318,6 @@ BezierSegment::BezierSegment(const TopoDS_Edge &e)
Handle(Geom_BezierCurve) bez = c.Bezier();
poles = bez->NbPoles();
degree = bez->Degree();
if (poles > 4) {
Base::Console().Log("Warning - BezierSegment has degree > 3: %d\n", degree);
}
for (int i = 1; i <= poles; ++i) {
gp_Pnt controlPoint = bez->Pole(i);
pnts.emplace_back(controlPoint.X(), controlPoint.Y(), controlPoint.Z());
@@ -1528,9 +1517,6 @@ BaseGeomPtrVector GeometryUtils::chainGeoms(BaseGeomPtrVector geoms)
} else {
atPoint = nextEdge->getEndPoint();
}
} else {
Base::Console().Log("Error - Geometry::chainGeoms - couldn't find next edge\n");
//TARFU
}
}
}

17
src/Mod/TechDraw/App/GeometryObject.cpp
View File

@@ -536,7 +536,6 @@ void GeometryObject::addGeomFromCompound(TopoDS_Shape edgeCompound, edgeClass ca
{
// Base::Console().Message("GO::addGeomFromCompound(%d, %d)\n", category, hlrVisible);
if (edgeCompound.IsNull()) {
Base::Console().Log("TechDraw::GeometryObject::addGeomFromCompound edgeCompound is NULL\n");
return;// There is no OpenCascade Geometry to be calculated
}
@@ -546,22 +545,17 @@ void GeometryObject::addGeomFromCompound(TopoDS_Shape edgeCompound, edgeClass ca
for (; edges.More(); edges.Next(), i++) {
const TopoDS_Edge& edge = TopoDS::Edge(edges.Current());
if (edge.IsNull()) {
Base::Console().Log("GO::addGeomFromCompound - edge: %d is NULL\n", i);
continue;
}
if (DU::isZeroEdge(edge)) {
Base::Console().Log("GO::addGeomFromCompound - edge: %d is zeroEdge\n", i);
continue;
}
if (DU::isCrazy(edge)) {
Base::Console().Log("GO::addGeomFromCompound - edge: %d is crazy\n", i);
continue;
}
base = BaseGeom::baseFactory(edge);
if (!base) {
Base::Console().Log(
"Error - GO::addGeomFromCompound - baseFactory failed for edge: %d\n", i);
continue;
// throw Base::ValueError("GeometryObject::addGeomFromCompound - baseFactory failed");
}
@@ -830,10 +824,7 @@ Base::BoundBox3d GeometryObject::calcBoundingBox() const
}
double xMin = 0, xMax = 0, yMin = 0, yMax = 0, zMin = 0, zMax = 0;
if (testBox.IsVoid()) {
Base::Console().Log("INFO - GO::calcBoundingBox - testBox is void\n");
}
else {
if (!testBox.IsVoid()) {
testBox.Get(xMin, yMin, zMin, xMax, yMax, zMax);
}
Base::BoundBox3d bbox(xMin, yMin, zMin, xMax, yMax, zMax);
@@ -1084,7 +1075,6 @@ TopoDS_Shape TechDraw::mirrorShape(const TopoDS_Shape& input, const gp_Pnt& inpu
transShape = mkTrf.Shape();
}
catch (...) {
Base::Console().Log("GeometryObject::mirrorShape - mirror/scale failed.\n");
return transShape;
}
return transShape;
@@ -1109,7 +1099,6 @@ TopoDS_Shape TechDraw::rotateShape(const TopoDS_Shape& input, const gp_Ax2& view
transShape = mkTrf.Shape();
}
catch (...) {
Base::Console().Log("GeometryObject::rotateShape - rotate failed.\n");
return transShape;
}
return transShape;
@@ -1127,7 +1116,6 @@ TopoDS_Shape TechDraw::scaleShape(const TopoDS_Shape& input, double scale)
transShape = mkTrf.Shape();
}
catch (...) {
Base::Console().Log("GeometryObject::scaleShape - scale failed.\n");
return transShape;
}
return transShape;
@@ -1145,7 +1133,6 @@ TopoDS_Shape TechDraw::moveShape(const TopoDS_Shape& input, const Base::Vector3d
transShape = mkTrf.Shape();
}
catch (...) {
Base::Console().Log("GeometryObject::moveShape - move failed.\n");
return transShape;
}
return transShape;
@@ -1166,7 +1153,6 @@ TopoDS_Shape TechDraw::moveShapeRestricted(const TopoDS_Shape& input, const Base
transShape = mkTrf.Shape();
}
catch (...) {
Base::Console().Log("GeometryObject::moveShapeRestricted - move failed.\n");
return transShape;
}
return transShape;
@@ -1187,7 +1173,6 @@ TopoDS_Shape TechDraw::moveShapeRestricted(const TopoDS_Shape& input, const Base
transShape = mkTrf.Shape();
}
catch (...) {
Base::Console().Log("GeometryObject::moveShapeRestricted - move failed.\n");
return transShape;
}
return transShape;

5
src/Mod/TechDraw/App/HatchLine.cpp
View File

@@ -213,8 +213,6 @@ Base::Vector3d LineSet::getPatternStartPoint(TechDraw::BaseGeomPtr g, double &of
offset = ceil(patsStartOrg) - patsStartOrg; //fraction of a patternLength patstartorg to repeat point
offset = offset * patternLength;
}
} else {
Base::Console().Log("ERROR - HL::getPatternStart - something has gone wrong!\n");
}
}
return result;
@@ -316,8 +314,7 @@ std::vector<PATLineSpec> PATLineSpec::getSpecsForPattern(std::string& parmFile,
if (status) {
lineSpecs = loadPatternDef(inFile);
} else {
//this message can come up when changing PAT file or pattern name
Base::Console().Log( "Could not find pattern: %s\n", parmName.c_str() );
//this can come up when changing PAT file or pattern name
return result;
}

4
src/Mod/TechDraw/App/ShapeExtractor.cpp
View File

@@ -269,16 +269,12 @@ std::vector<TopoDS_Shape> ShapeExtractor::getShapesFromObject(const App::Documen
result.insert(result.end(), shapes.begin(), shapes.end());
}
}
} else {
Base::Console().Log("SE::getShapesFromObject - Group is not a PropertyLinkList!\n");
}
} else if (sProp) { //has a Shape property
Part::PropertyPartShape* shape = dynamic_cast<Part::PropertyPartShape*>(sProp);
if (shape) {
TopoDS_Shape occShape = shape->getValue();
result.push_back(occShape);
} else {
Base::Console().Log("SE::getShapesFromObject - Shape is not a PropertyPartShape!\n");
}
}
return result;

2
src/Mod/TechDraw/Gui/AppTechDrawGui.cpp
View File

@@ -88,7 +88,7 @@ void loadTechDrawResource()
QFontDatabase fontDB;
int rc = fontDB.addApplicationFont(fontFile);
if (rc) {
Base::Console().Log("TechDraw failed to load osifont file: %d from: %s\n", rc, qPrintable(fontFile));
Base::Console().Warning("TechDraw failed to load osifont file: %d from: %s\n", rc, qPrintable(fontFile));
}
}

8
src/Mod/TechDraw/Gui/Command.cpp
View File

@@ -138,10 +138,6 @@ void CmdTechDrawPageDefault::activated(int iMsg)
if (dvp) {
dvp->show();
}
else {
Base::Console().Log("INFO - Template: %s for Page: %s NOT Found\n", PageName.c_str(),
TemplateName.c_str());
}
}
else {
QMessageBox::critical(Gui::getMainWindow(), QLatin1String("No template"),
@@ -219,10 +215,6 @@ void CmdTechDrawPageTemplate::activated(int iMsg)
if (dvp) {
dvp->show();
}
else {
Base::Console().Log("INFO - Template: %s for Page: %s NOT Found\n", PageName.c_str(),
TemplateName.c_str());
}
}
else {
QMessageBox::critical(Gui::getMainWindow(), QLatin1String("No template"),

1
src/Mod/TechDraw/Gui/CommandDecorate.cpp
View File

@@ -203,7 +203,6 @@ void CmdTechDrawGeometricHatch::activated(int iMsg)
Gui::ViewProvider* vp = Gui::Application::Instance->getDocument(getDocument())->getViewProvider(geomhatch);
TechDrawGui::ViewProviderGeomHatch* hvp = dynamic_cast<TechDrawGui::ViewProviderGeomHatch*>(vp);
if (!hvp) {
Base::Console().Log("ERROR - CommandDecorate - GeomHatch has no ViewProvider\n");
return;
}

4
src/Mod/TechDraw/Gui/DrawGuiUtil.cpp
View File

@@ -380,7 +380,6 @@ std::pair<Base::Vector3d, Base::Vector3d> DrawGuiUtil::get3DDirAndRot()
}
}
if (!viewer) {
Base::Console().Log("LOG - DrawGuiUtil could not find a 3D viewer\n");
return std::make_pair(viewDir, viewRight);
}
@@ -434,9 +433,6 @@ std::pair<Base::Vector3d, Base::Vector3d> DrawGuiUtil::getProjDirFromFace(App::D
projDir = projDir * (-1.0);
}
}
else {
Base::Console().Log("Selected Face has no normal at midpoint\n");
}
dirs = std::make_pair(projDir, rotVec);
return dirs;

3
src/Mod/TechDraw/Gui/MDIViewPage.cpp
View File

@@ -892,9 +892,6 @@ void MDIViewPage::onSelectionChanged(const Gui::SelectionChanges& msg)
}
blockSceneSelection(false);
}
else {
Base::Console().Log("MDIVP::onSelectionChanged - unhandled: %d\n", msg.Type);
}
}
//! maintain QGScene selected items in selection order

1
src/Mod/TechDraw/Gui/QGIPrimPath.cpp
View File

@@ -286,7 +286,6 @@ void QGIPrimPath::mousePressEvent(QGraphicsSceneMouseEvent * event)
} else {
// qparent->mousePressEvent(event); //protected!
QGraphicsPathItem::mousePressEvent(event);
Base::Console().Log("QGIPP::mousePressEvent - no QGIView parent\n");
}
} else {
// Base::Console().Message("QGIPP::mousePressEvent - passing event to ancestor\n");

1
src/Mod/TechDraw/Gui/QGIRichAnno.cpp
View File

@@ -97,7 +97,6 @@ void QGIRichAnno::updateView(bool update)
Q_UNUSED(update);
auto annoFeat( dynamic_cast<TechDraw::DrawRichAnno*>(getViewObject()) );
if (!annoFeat) {
Base::Console().Log("QGIRA::updateView - no feature!\n");
return;
}

2
src/Mod/TechDraw/Gui/QGIView.cpp
View File

@@ -303,8 +303,6 @@ double QGIView::getYInClip(double y)
QGIViewClip* QGIView::getClipGroup()
{
if (!getViewObject()->isInClip()) {
Base::Console().Log( "Logic Error - getClipGroup called for child "
"(%s) not in Clip\n", getViewName() );
return nullptr;
}

3
src/Mod/TechDraw/Gui/QGIViewBalloon.cpp
View File

@@ -874,9 +874,6 @@ void QGIViewBalloon::drawBalloon(bool dragged)
if (parentItem()) {
parentItem()->update();
}
else {
Base::Console().Log("INFO - QGIVB::draw - no parent to update\n");
}
}
void QGIViewBalloon::setPrettyPre(void)

3
src/Mod/TechDraw/Gui/QGIViewDimension.cpp
View File

@@ -790,9 +790,6 @@ void QGIViewDimension::draw()
//TODO: parent redraw still required with new frame/label??
parentItem()->update();
}
else {
Base::Console().Log("INFO - QGIVD::draw - no parent to update\n");
}
}
double QGIViewDimension::getAnglePlacementFactor(double testAngle, double endAngle,

4
src/Mod/TechDraw/Gui/QGSPage.cpp
View File

@@ -156,7 +156,6 @@ void QGSPage::updateTemplate(bool forceUpdate)
App::DocumentObject *templObj = m_vpPage->getDrawPage()->Template.getValue();
// TODO: what if template has been deleted? templObj will be NULL. segfault?
if (!templObj) {
Base::Console().Log("INFO - QGSPage::updateTemplate - Page: %s has NO template!!\n", m_vpPage->getDrawPage()->getNameInDocument());
return;
}
@@ -383,9 +382,6 @@ bool QGSPage::attachView(App::DocumentObject *obj)
} else if (typeId.isDerivedFrom(TechDraw::DrawHatch::getClassTypeId()) ) {
//Hatch is not attached like other Views (since it isn't really a View)
return true;
} else {
Base::Console().Log("Logic Error - Unknown view type in QGSPage::attachView\n");
}
return (qview != nullptr);

3
src/Mod/TechDraw/Gui/QGTracker.cpp
View File

@@ -382,7 +382,6 @@ void QGTracker::setPathFromPoints(std::vector<QPointF> pts)
{
// Base::Console().Message("QGTracker::setPathFromPoints()\n");
if (pts.empty()) {
Base::Console().Log("QGTracker::setPathFromPoints - no pts!\n");
return;
}
prepareGeometryChange();
@@ -399,7 +398,6 @@ void QGTracker::setSquareFromPoints(std::vector<QPointF> pts)
{
// Base::Console().Message("QGTracker::setSquareFromPoints()\n");
if (pts.empty()) {
Base::Console().Log("QGTracker::setSquareFromPoints - no pts!\n");
return;
}
prepareGeometryChange();
@@ -416,7 +414,6 @@ void QGTracker::setCircleFromPoints(std::vector<QPointF> pts)
{
// Base::Console().Message("QGTracker::setCircleFromPoints()\n");
if (pts.empty()) {
Base::Console().Log("QGTracker::setCircleFromPoints - no pts!\n");
return;
}
prepareGeometryChange();

1
src/Mod/TechDraw/Gui/TaskCenterLine.cpp
View File

@@ -309,7 +309,6 @@ void TaskCenterLine::createCenterLine()
}
if (!cl) {
Base::Console().Log("TCL::createCenterLine - CenterLine creation failed!\n");
Gui::Command::abortCommand();
return;
}

2
src/Mod/TechDraw/Gui/TaskComplexSection.cpp
View File

@@ -414,8 +414,6 @@ void TaskComplexSection::scaleTypeChanged(int index)
}
}
else {
Base::Console().Log(
"Error - TaskComplexSection::scaleTypeChanged - unknown scale type: %d\n", index);
return;
}
}

4
src/Mod/TechDraw/Gui/TaskLeaderLine.cpp
View File

@@ -443,9 +443,7 @@ void TaskLeaderLine::removeFeature()
if (Gui::Command::hasPendingCommand()) {
std::vector<std::string> undos = Gui::Application::Instance->activeDocument()->getUndoVector();
Gui::Application::Instance->activeDocument()->undo(1);
} else {
Base::Console().Log("TaskLeaderLine: Edit mode - NO command is active\n");
}
}
}
}

5
src/Mod/TechDraw/Gui/TaskProjGroup.cpp
View File

@@ -263,9 +263,6 @@ void TaskProjGroup::scaleTypeChanged(int index)
double scale = (double) a / (double) b;
multiView->Scale.setValue(scale);
//unblock recompute
} else {
Base::Console().Log("Error - TaskProjGroup::scaleTypeChanged - unknown scale type: %d\n", index);
return;
}
}
@@ -549,8 +546,6 @@ bool TaskProjGroup::reject()
// Gui::Application::Instance->activeDocument()->undo(1);
// multiView->rebuildViewList();
// apply();
} else {
Base::Console().Log("TaskProjGroup: Edit mode - NO command is active\n");
}
}
Gui::Command::runCommand(Gui::Command::Gui, "Gui.ActiveDocument.resetEdit()");

2
src/Mod/TechDraw/Gui/TaskRichAnno.cpp
View File

@@ -388,8 +388,6 @@ void TaskRichAnno::removeFeature()
if (Gui::Command::hasPendingCommand()) {
std::vector<std::string> undos = Gui::Application::Instance->activeDocument()->getUndoVector();
Gui::Application::Instance->activeDocument()->undo(1);
} else {
Base::Console().Log("TaskRichAnno: Edit mode - NO command is active\n");
}
}
}

2
src/Mod/TechDraw/Gui/TaskSectionView.cpp
View File

@@ -382,8 +382,6 @@ void TaskSectionView::scaleTypeChanged(int index)
}
}
else {
Base::Console().Log("Error - TaskSectionView::scaleTypeChanged - unknown scale type: %d\n",
index);
return;
}
}

4
src/Mod/TechDraw/Gui/ViewProviderPage.cpp
View File

@@ -119,9 +119,6 @@ void ViewProviderPage::attach(App::DocumentObject* pcFeat)
m_pageName = feature->getNameInDocument();
m_graphicsScene->setObjectName(QString::fromLocal8Bit(m_pageName.c_str()));
}
else {
Base::Console().Log("VPP::attach has no Feature!\n");
}
}
void ViewProviderPage::setDisplayMode(const char* ModeName)
@@ -526,7 +523,6 @@ TechDraw::DrawPage* ViewProviderPage::getDrawPage() const
{
//during redo, pcObject can become invalid, but non-zero??
if (!pcObject) {
Base::Console().Log("VPP::getDrawPage - no Page Object!\n");
return nullptr;
}
return dynamic_cast<TechDraw::DrawPage*>(pcObject);