From 15923813d4a87d2e35b786cbd07dd42664d88d83 Mon Sep 17 00:00:00 2001 From: marioalexis Date: Tue, 17 May 2022 12:55:50 -0300 Subject: [PATCH] PartDesign: Use PyObject_IsTrue in combination with conditional ternary operator --- src/Mod/PartDesign/Gui/ViewProviderPyImp.cpp | 24 ++++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/Mod/PartDesign/Gui/ViewProviderPyImp.cpp b/src/Mod/PartDesign/Gui/ViewProviderPyImp.cpp index 32f9808c90..2d672aac7f 100644 --- a/src/Mod/PartDesign/Gui/ViewProviderPyImp.cpp +++ b/src/Mod/PartDesign/Gui/ViewProviderPyImp.cpp @@ -49,26 +49,26 @@ int ViewProviderPy::setCustomAttributes(const char* , PyObject *) PyObject* ViewProviderPy::setBodyMode(PyObject* args) { - PartDesignGui::ViewProvider* base = getViewProviderPtr(); - PyObject* b_mode; - if(PyArg_ParseTuple(args, "O!", &PyBool_Type, &b_mode)){ - base->setBodyMode(PyObject_IsTrue(b_mode)); - return Py::new_reference_to(Py::None()); + if (!PyArg_ParseTuple(args, "O!", &PyBool_Type, &b_mode)) { + return nullptr; }; - return nullptr; //error + PartDesignGui::ViewProvider* base = getViewProviderPtr(); + base->setBodyMode(PyObject_IsTrue(b_mode) ? true : false); + + return Py::new_reference_to(Py::None()); } PyObject* ViewProviderPy::makeTemporaryVisible(PyObject* args) { - PartDesignGui::ViewProvider* base = getViewProviderPtr(); - PyObject* b_vis; - if(PyArg_ParseTuple(args, "O!", &PyBool_Type, &b_vis)){ - base->makeTemporaryVisible(PyObject_IsTrue(b_vis)); - return Py::new_reference_to(Py::None()); + if (!PyArg_ParseTuple(args, "O!", &PyBool_Type, &b_vis)) { + return nullptr; }; - return nullptr; //error + PartDesignGui::ViewProvider* base = getViewProviderPtr(); + base->makeTemporaryVisible(PyObject_IsTrue(b_vis) ? true : false); + + return Py::new_reference_to(Py::None()); }