Revert "App: fix property ordering problem when undo/redo (#3255)"

This reverts commit 24d30636e4fb990fdbd67538360846ff09456dfc.

src/Mod/Part/App/PartFeature.cpp

@@ -62,7 +62,6 @@
 #include <Base/Stream.h>
 #include <Base/Placement.h>
 #include <Base/Rotation.h>
-#include <Base/Tools.h>
 #include <App/Application.h>
 #include <App/FeaturePythonPyImp.h>
 #include <App/Document.h>
@@ -541,17 +540,8 @@ void Feature::onChanged(const App::Property* prop)
 {
     // if the placement has changed apply the change to the point data as well
     if (prop == &this->Placement) {
-        // The following code bypasses transaction, which may cause problem to
-        // undo/redo
-        //
-        // TopoShape& shape = const_cast<TopoShape&>(this->Shape.getShape());
-        // shape.setTransform(this->Placement.getValue().toMatrix());
-
-        TopoShape shape = this->Shape.getShape();
+        TopoShape& shape = const_cast<TopoShape&>(this->Shape.getShape());
         shape.setTransform(this->Placement.getValue().toMatrix());
-        Base::ObjectStatusLocker<App::Property::Status, App::Property> guard(
-                App::Property::NoRecompute, &this->Shape);
-        this->Shape.setValue(shape);
     }
     // if the point data has changed check and adjust the transformation as well
     else if (prop == &this->Shape) {
@@ -564,7 +554,8 @@ void Feature::onChanged(const App::Property* prop)
             // shape must not be null to override the placement
             if (!this->Shape.getValue().IsNull()) {
                 p.fromMatrix(this->Shape.getShape().getTransform());
-                this->Placement.setValueIfChanged(p);
+                if (p != this->Placement.getValue())
+                    this->Placement.setValue(p);
             }
         }
     }

src/Mod/Part/Gui/ViewProviderExt.cpp

@@ -840,12 +840,6 @@ void ViewProviderPartExt::updateData(const App::Property* prop)
 {
     const char *propName = prop->getName();
     if (propName && (strcmp(propName, "Shape") == 0 || strstr(propName, "Touched") != nullptr)) {
-        TopoDS_Shape cShape = Part::Feature::getShape(getObject());
-        if(cachedShape.IsPartner(cShape)) {
-            Gui::ViewProviderGeometryObject::updateData(prop);
-            return;
-        }
-
         // calculate the visual only if visible
         if (isUpdateForced() || Visibility.getValue())
             updateVisual();
@@ -924,7 +918,6 @@ void ViewProviderPartExt::updateVisual()
     haction.apply(this->nodeset);
 
     TopoDS_Shape cShape = Part::Feature::getShape(getObject());
-    cachedShape = cShape;
     if (cShape.IsNull()) {
         coords  ->point      .setNum(0);
         norm    ->vector     .setNum(0);

src/Mod/Part/Gui/ViewProviderExt.h

@@ -188,8 +188,6 @@ private:
     static App::PropertyQuantityConstraint::Constraints angDeflectionRange;
     static const char* LightingEnums[];
     static const char* DrawStyleEnums[];
-
-    TopoDS_Shape cachedShape;
 };
 
 }