From 17a848dfe1a221e8de11acf114adef12e6f7bc11 Mon Sep 17 00:00:00 2001 From: wmayer Date: Thu, 25 Feb 2021 11:34:29 +0100 Subject: [PATCH] TD: [skip ci] explicitly nullify geometryObject in DrawViewPart::partExec to avoid to leave it a dangling pointer in case makeGeometryForShape raises an exception --- src/Mod/TechDraw/App/DrawViewPart.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/Mod/TechDraw/App/DrawViewPart.cpp b/src/Mod/TechDraw/App/DrawViewPart.cpp index 85d534a35f..3c1aeea98c 100644 --- a/src/Mod/TechDraw/App/DrawViewPart.cpp +++ b/src/Mod/TechDraw/App/DrawViewPart.cpp @@ -343,8 +343,10 @@ void DrawViewPart::onChanged(const App::Property* prop) void DrawViewPart::partExec(TopoDS_Shape shape) { // Base::Console().Message("DVP::partExec()\n"); - if (geometryObject) + if (geometryObject) { delete geometryObject; + geometryObject = nullptr; + } geometryObject = makeGeometryForShape(shape); if (geometryObject == nullptr) { return;