From 17f5d1d44bee0877772f3ff235f664af15413f40 Mon Sep 17 00:00:00 2001 From: Ajinkya Dahale Date: Tue, 13 Feb 2024 22:25:48 +0530 Subject: [PATCH] [planegcs][test] Fix issue in arc-B-spline tangent test Correct the size of the knot vector used (described here with knots and multiplicities). --- tests/src/Mod/Sketcher/App/planegcs/Constraints.cpp | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/src/Mod/Sketcher/App/planegcs/Constraints.cpp b/tests/src/Mod/Sketcher/App/planegcs/Constraints.cpp index 670553d180..105cb20df5 100644 --- a/tests/src/Mod/Sketcher/App/planegcs/Constraints.cpp +++ b/tests/src/Mod/Sketcher/App/planegcs/Constraints.cpp @@ -85,13 +85,15 @@ TEST_F(ConstraintsTest, tangentBSplineAndArc) // NOLINT } std::vector weights(bSplineControlPoints.size(), 1.0); std::vector weightsAsPtr; - std::vector knots(bSplineControlPoints.size()); + std::vector knots(bSplineControlPoints.size() - 2); // Hardcoded for cubic std::vector knotsAsPtr; - std::vector mult(bSplineControlPoints.size(), 1); - mult.front() = 4; // Hardcoded for cubic - mult.back() = 4; // Hardcoded for cubic + std::vector mult(bSplineControlPoints.size() - 2, 1); // Hardcoded for cubic + mult.front() = 4; // Hardcoded for cubic + mult.back() = 4; // Hardcoded for cubic for (size_t i = 0; i < bSplineControlPoints.size(); ++i) { weightsAsPtr.push_back(&weights[i]); + } + for (size_t i = 0; i < knots.size(); ++i) { knots[i] = i; knotsAsPtr.push_back(&knots[i]); }