From 180edfa3cc26af68cd9d35db31372265b9adf87c Mon Sep 17 00:00:00 2001 From: berniev Date: Mon, 15 Aug 2022 19:28:04 +1000 Subject: [PATCH] Mod: Single arg ctors must be explicit --- src/Mod/Fem/App/HypothesisPy.h | 4 +- src/Mod/Fem/Gui/AbaqusHighlighter.h | 2 +- src/Mod/Fem/Gui/DlgSettingsFemCcxImp.h | 2 +- src/Mod/Fem/Gui/DlgSettingsFemElmerImp.h | 2 +- .../Fem/Gui/DlgSettingsFemExportAbaqusImp.h | 2 +- src/Mod/Fem/Gui/DlgSettingsFemGeneralImp.h | 2 +- src/Mod/Fem/Gui/DlgSettingsFemGmshImp.h | 2 +- src/Mod/Fem/Gui/DlgSettingsFemInOutVtkImp.h | 2 +- src/Mod/Fem/Gui/DlgSettingsFemMaterialImp.h | 2 +- src/Mod/Fem/Gui/DlgSettingsFemMystranImp.h | 2 +- src/Mod/Fem/Gui/DlgSettingsFemZ88Imp.h | 2 +- src/Mod/Fem/Gui/FemSelectionGate.h | 2 +- src/Mod/Fem/Gui/TaskAnalysisInfo.h | 2 +- src/Mod/Fem/Gui/TaskCreateNodeSet.h | 2 +- src/Mod/Fem/Gui/TaskDlgAnalysis.h | 2 +- src/Mod/Fem/Gui/TaskDlgCreateNodeSet.h | 2 +- src/Mod/Fem/Gui/TaskDlgMeshShapeNetgen.h | 2 +- src/Mod/Fem/Gui/TaskDriver.h | 2 +- src/Mod/Fem/Gui/TaskFemConstraint.h | 2 +- src/Mod/Fem/Gui/TaskFemConstraintBearing.h | 4 +- src/Mod/Fem/Gui/TaskFemConstraintContact.h | 4 +- .../Fem/Gui/TaskFemConstraintDisplacement.h | 4 +- src/Mod/Fem/Gui/TaskFemConstraintFixed.h | 4 +- .../Fem/Gui/TaskFemConstraintFluidBoundary.h | 4 +- src/Mod/Fem/Gui/TaskFemConstraintForce.h | 4 +- src/Mod/Fem/Gui/TaskFemConstraintGear.h | 4 +- src/Mod/Fem/Gui/TaskFemConstraintHeatflux.h | 4 +- .../Gui/TaskFemConstraintInitialTemperature.h | 4 +- src/Mod/Fem/Gui/TaskFemConstraintOnBoundary.h | 2 +- .../Fem/Gui/TaskFemConstraintPlaneRotation.h | 4 +- src/Mod/Fem/Gui/TaskFemConstraintPressure.h | 4 +- src/Mod/Fem/Gui/TaskFemConstraintPulley.h | 4 +- src/Mod/Fem/Gui/TaskFemConstraintSpring.h | 4 +- .../Fem/Gui/TaskFemConstraintTemperature.h | 4 +- src/Mod/Fem/Gui/TaskFemConstraintTransform.h | 4 +- src/Mod/Fem/Gui/TaskObjectName.h | 2 +- src/Mod/Fem/Gui/TaskPostBoxes.h | 14 ++--- src/Mod/Fem/Gui/TaskTetParameter.h | 2 +- src/Mod/Import/App/ImportOCAF2.h | 4 +- src/Mod/Import/Gui/AppImportGuiPy.cpp | 2 +- src/Mod/Inspection/App/InspectionFeature.h | 6 +-- .../Inspection/Gui/ViewProviderInspection.cpp | 2 +- src/Mod/Inspection/Gui/VisualInspection.cpp | 4 +- src/Mod/Inspection/Gui/VisualInspection.h | 2 +- src/Mod/Mesh/App/Core/Algorithm.h | 16 +++--- src/Mod/Mesh/App/Core/Approximation.h | 4 +- src/Mod/Mesh/App/Core/Builder.h | 4 +- src/Mod/Mesh/App/Core/Curvature.cpp | 2 +- src/Mod/Mesh/App/Core/Curvature.h | 2 +- src/Mod/Mesh/App/Core/Decimation.h | 2 +- src/Mod/Mesh/App/Core/Degeneration.h | 52 +++++++++---------- src/Mod/Mesh/App/Core/Elements.h | 10 ++-- src/Mod/Mesh/App/Core/Evaluation.h | 26 +++++----- src/Mod/Mesh/App/Core/Grid.h | 8 +-- src/Mod/Mesh/App/Core/Info.h | 2 +- src/Mod/Mesh/App/Core/Iterator.h | 6 +-- src/Mod/Mesh/App/Core/KDTree.h | 4 +- src/Mod/Mesh/App/Core/MeshIO.h | 4 +- src/Mod/Mesh/App/Core/Projection.h | 2 +- src/Mod/Mesh/App/Core/Segmentation.h | 4 +- src/Mod/Mesh/App/Core/Smoothing.h | 10 ++-- src/Mod/Mesh/App/Core/Tools.h | 8 +-- src/Mod/Mesh/App/Core/TopoAlgorithm.h | 4 +- src/Mod/Mesh/App/Core/Triangulation.h | 2 +- src/Mod/Mesh/App/Core/TrimByPlane.h | 2 +- src/Mod/Mesh/App/Core/Utilities.h | 4 +- src/Mod/Mesh/App/Facet.h | 2 +- src/Mod/Mesh/App/Importer.h | 2 +- src/Mod/Mesh/App/MeshPoint.h | 2 +- src/Mod/Mesh/App/MeshPyImp.cpp | 2 +- src/Mod/Mesh/Gui/DlgDecimating.h | 2 +- src/Mod/Mesh/Gui/DlgEvaluateMeshImp.h | 4 +- src/Mod/Mesh/Gui/DlgEvaluateSettings.h | 2 +- src/Mod/Mesh/Gui/DlgRegularSolidImp.h | 2 +- src/Mod/Mesh/Gui/DlgSettingsImportExportImp.h | 2 +- src/Mod/Mesh/Gui/DlgSettingsMeshView.h | 2 +- src/Mod/Mesh/Gui/DlgSmoothing.h | 4 +- src/Mod/Mesh/Gui/MeshEditor.h | 2 +- src/Mod/Mesh/Gui/RemeshGmsh.cpp | 4 +- src/Mod/Mesh/Gui/RemeshGmsh.h | 6 +-- src/Mod/Mesh/Gui/RemoveComponents.h | 4 +- src/Mod/Mesh/Gui/Segmentation.h | 4 +- src/Mod/Mesh/Gui/SegmentationBestFit.h | 4 +- src/Mod/Mesh/Gui/Selection.h | 2 +- src/Mod/Mesh/Gui/SoFCMeshObject.cpp | 8 +-- src/Mod/MeshPart/App/CurveProjector.h | 2 +- src/Mod/MeshPart/App/Mesher.h | 2 +- src/Mod/MeshPart/Gui/CrossSections.h | 4 +- src/Mod/MeshPart/Gui/CurveOnMesh.h | 2 +- src/Mod/MeshPart/Gui/TaskCurveOnMesh.h | 4 +- src/Mod/MeshPart/Gui/Tessellation.h | 4 +- src/Mod/Part/App/AttachExtension.h | 4 +- src/Mod/Part/App/Attacher.h | 2 +- src/Mod/Part/App/Geometry.h | 2 +- src/Mod/Part/App/Geometry2d.h | 2 +- src/Mod/Part/App/GeometryDefaultExtension.h | 2 +- src/Mod/Part/App/PrimitiveFeature.cpp | 2 +- src/Mod/Part/App/Tools.h | 8 +-- src/Mod/Part/App/TopoShape.cpp | 2 +- src/Mod/Part/App/TopoShape.h | 10 ++-- src/Mod/Part/App/edgecluster.h | 2 +- src/Mod/Part/Gui/CrossSections.h | 4 +- src/Mod/Part/Gui/DlgBooleanOperation.cpp | 2 +- src/Mod/Part/Gui/DlgBooleanOperation.h | 2 +- src/Mod/Part/Gui/DlgFilletEdges.cpp | 4 +- src/Mod/Part/Gui/DlgFilletEdges.h | 10 ++-- src/Mod/Part/Gui/DlgPartBoxImp.h | 2 +- src/Mod/Part/Gui/DlgPartCylinderImp.h | 2 +- src/Mod/Part/Gui/DlgPartImportIgesImp.h | 2 +- src/Mod/Part/Gui/DlgPartImportStepImp.h | 2 +- src/Mod/Part/Gui/DlgPrimitives.h | 6 +-- src/Mod/Part/Gui/DlgRevolution.h | 2 +- src/Mod/Part/Gui/DlgSettings3DViewPartImp.h | 2 +- src/Mod/Part/Gui/DlgSettingsGeneral.h | 6 +-- src/Mod/Part/Gui/DlgSettingsMeasure.h | 2 +- src/Mod/Part/Gui/DlgSettingsObjectColor.h | 2 +- src/Mod/Part/Gui/Mirroring.h | 2 +- src/Mod/Part/Gui/SectionCutting.h | 2 +- src/Mod/Part/Gui/ShapeFromMesh.h | 2 +- src/Mod/Part/Gui/TaskAttacher.h | 4 +- src/Mod/Part/Gui/TaskCheckGeometry.h | 4 +- src/Mod/Part/Gui/TaskDimension.h | 6 +-- src/Mod/Part/Gui/TaskFaceColors.cpp | 4 +- src/Mod/Part/Gui/TaskFaceColors.h | 4 +- src/Mod/Part/Gui/TaskLoft.h | 2 +- src/Mod/Part/Gui/TaskOffset.h | 4 +- src/Mod/Part/Gui/TaskShapeBuilder.h | 2 +- src/Mod/Part/Gui/TaskSweep.h | 2 +- src/Mod/Part/Gui/TaskThickness.cpp | 2 +- src/Mod/Part/Gui/TaskThickness.h | 4 +- src/Mod/PartDesign/App/FeaturePrimitive.cpp | 2 +- .../PartDesign/Gui/TaskBooleanParameters.h | 4 +- .../PartDesign/Gui/TaskChamferParameters.h | 4 +- src/Mod/PartDesign/Gui/TaskDatumParameters.h | 4 +- src/Mod/PartDesign/Gui/TaskDraftParameters.h | 4 +- .../PartDesign/Gui/TaskDressUpParameters.h | 2 +- .../PartDesign/Gui/TaskFeatureParameters.h | 2 +- src/Mod/PartDesign/Gui/TaskFilletParameters.h | 4 +- src/Mod/PartDesign/Gui/TaskHelixParameters.h | 4 +- src/Mod/PartDesign/Gui/TaskHoleParameters.h | 4 +- .../Gui/TaskLinearPatternParameters.h | 4 +- src/Mod/PartDesign/Gui/TaskLoftParameters.h | 4 +- .../PartDesign/Gui/TaskMirroredParameters.h | 4 +- .../Gui/TaskMultiTransformParameters.h | 4 +- src/Mod/PartDesign/Gui/TaskPadParameters.h | 4 +- src/Mod/PartDesign/Gui/TaskPipeParameters.h | 8 +-- src/Mod/PartDesign/Gui/TaskPocketParameters.h | 4 +- .../Gui/TaskPolarPatternParameters.h | 4 +- .../PartDesign/Gui/TaskPrimitiveParameters.h | 4 +- .../PartDesign/Gui/TaskRevolutionParameters.h | 4 +- src/Mod/PartDesign/Gui/TaskScaledParameters.h | 4 +- src/Mod/PartDesign/Gui/TaskShapeBinder.h | 4 +- .../Gui/TaskSketchBasedParameters.h | 2 +- .../PartDesign/Gui/TaskThicknessParameters.h | 4 +- .../PartDesign/Gui/TaskTransformedMessages.h | 2 +- .../Gui/TaskTransformedParameters.h | 8 +-- src/Mod/Path/App/Area.cpp | 2 +- src/Mod/Path/App/Area.h | 4 +- src/Mod/Path/Gui/DlgProcessorChooser.h | 2 +- src/Mod/Path/Gui/DlgSettingsPathColor.h | 2 +- src/Mod/Path/Gui/TaskDlgPathCompound.h | 2 +- src/Mod/Path/PathSimulator/App/VolSim.h | 4 +- src/Mod/Points/App/Points.h | 2 +- src/Mod/Points/App/PointsAlgos.h | 8 +-- src/Mod/Points/App/PointsGrid.h | 4 +- src/Mod/Points/Gui/DlgPointsReadImp.h | 2 +- src/Mod/Raytracing/Gui/DlgSettingsRayImp.h | 2 +- src/Mod/Raytracing/Gui/PovrayHighlighter.h | 2 +- .../ReverseEngineering/App/ApproxSurface.cpp | 2 +- .../ReverseEngineering/App/ApproxSurface.h | 12 ++--- src/Mod/ReverseEngineering/App/Segmentation.h | 2 +- .../Gui/FitBSplineSurface.h | 4 +- src/Mod/ReverseEngineering/Gui/Poisson.h | 4 +- src/Mod/ReverseEngineering/Gui/Segmentation.h | 4 +- .../Gui/SegmentationManual.h | 2 +- src/Mod/Robot/Gui/TaskDlgEdge2Trac.h | 2 +- src/Mod/Robot/Gui/TaskDlgTrajectoryDressUp.h | 2 +- src/Mod/Robot/Gui/TaskEdge2TracParameter.h | 2 +- src/Mod/Robot/Gui/TaskRobot6Axis.h | 2 +- src/Mod/Robot/Gui/TaskRobotControl.h | 2 +- src/Mod/Robot/Gui/TaskRobotMessages.h | 2 +- .../Gui/TaskTrajectoryDressUpParameter.h | 2 +- src/Mod/Sketcher/App/Analyse.h | 2 +- src/Mod/Sketcher/App/ExternalGeometryFacade.h | 2 +- src/Mod/Sketcher/App/GeometryFacade.h | 4 +- src/Mod/Sketcher/App/SketchAnalysis.cpp | 8 +-- src/Mod/Sketcher/App/SketchAnalysis.h | 2 +- .../Sketcher/App/SketchGeometryExtension.h | 2 +- .../Sketcher/App/SolverGeometryExtension.h | 2 +- src/Mod/Sketcher/Gui/Command.cpp | 2 +- src/Mod/Sketcher/Gui/CommandConstraints.cpp | 6 +-- src/Mod/Sketcher/Gui/CommandSketcherTools.cpp | 2 +- .../Sketcher/Gui/DrawSketchHandlerBSpline.h | 2 +- .../Gui/DrawSketchHandlerCarbonCopy.h | 2 +- .../Sketcher/Gui/DrawSketchHandlerEllipse.h | 2 +- .../Sketcher/Gui/DrawSketchHandlerExtend.h | 2 +- .../Sketcher/Gui/DrawSketchHandlerExternal.h | 2 +- .../Sketcher/Gui/DrawSketchHandlerFillet.h | 4 +- .../Sketcher/Gui/DrawSketchHandlerPolygon.h | 2 +- .../Sketcher/Gui/DrawSketchHandlerRectangle.h | 2 +- .../Sketcher/Gui/DrawSketchHandlerSplitting.h | 2 +- .../Sketcher/Gui/DrawSketchHandlerTrimming.h | 2 +- src/Mod/Sketcher/Gui/EditModeCoinManager.h | 2 +- src/Mod/Sketcher/Gui/ShortcutListener.h | 2 +- src/Mod/Sketcher/Gui/SketcherSettings.h | 6 +-- src/Mod/Sketcher/Gui/TaskDlgEditSketch.h | 2 +- .../Sketcher/Gui/TaskSketcherConstraints.cpp | 2 +- .../Sketcher/Gui/TaskSketcherConstraints.h | 2 +- .../Sketcher/Gui/TaskSketcherCreateCommands.h | 2 +- src/Mod/Sketcher/Gui/TaskSketcherElements.h | 4 +- src/Mod/Sketcher/Gui/TaskSketcherGeneral.h | 4 +- src/Mod/Sketcher/Gui/TaskSketcherMessages.h | 2 +- .../Sketcher/Gui/TaskSketcherSolverAdvanced.h | 2 +- src/Mod/Sketcher/Gui/TaskSketcherValidation.h | 4 +- src/Mod/Sketcher/Gui/ViewProviderSketch.h | 2 +- src/Mod/Spreadsheet/App/DisplayUnit.h | 2 +- src/Mod/Spreadsheet/App/PropertySheet.h | 2 +- src/Mod/Spreadsheet/Gui/DlgSettingsImp.h | 2 +- src/Mod/Spreadsheet/Gui/SheetModel.h | 2 +- src/Mod/Spreadsheet/Gui/SpreadsheetView.h | 2 +- src/Mod/Start/Gui/DlgStartPreferencesImp.h | 2 +- src/Mod/TechDraw/App/Cosmetic.h | 2 +- src/Mod/TechDraw/App/Geometry.h | 20 +++---- src/Mod/TechDraw/App/HatchLine.h | 4 +- .../Gui/DlgPrefsTechDrawAdvancedImp.h | 2 +- .../Gui/DlgPrefsTechDrawAnnotationImp.h | 2 +- .../TechDraw/Gui/DlgPrefsTechDrawColorsImp.h | 2 +- .../Gui/DlgPrefsTechDrawDimensionsImp.h | 2 +- .../TechDraw/Gui/DlgPrefsTechDrawGeneralImp.h | 2 +- src/Mod/TechDraw/Gui/DlgPrefsTechDrawHLRImp.h | 2 +- .../TechDraw/Gui/DlgPrefsTechDrawScaleImp.h | 2 +- src/Mod/TechDraw/Gui/DlgTemplateField.h | 2 +- src/Mod/TechDraw/Gui/MDIViewPage.h | 2 +- src/Mod/TechDraw/Gui/QGIDrawingTemplate.h | 2 +- src/Mod/TechDraw/Gui/QGISVGTemplate.h | 2 +- src/Mod/TechDraw/Gui/QGSPage.h | 2 +- src/Mod/TechDraw/Gui/QGVNavStyle.h | 2 +- src/Mod/TechDraw/Gui/QGVNavStyleBlender.h | 2 +- src/Mod/TechDraw/Gui/QGVNavStyleCAD.h | 2 +- src/Mod/TechDraw/Gui/QGVNavStyleGesture.h | 2 +- src/Mod/TechDraw/Gui/QGVNavStyleInventor.h | 2 +- src/Mod/TechDraw/Gui/QGVNavStyleMaya.h | 2 +- src/Mod/TechDraw/Gui/QGVNavStyleOCC.h | 2 +- src/Mod/TechDraw/Gui/QGVNavStyleOpenSCAD.h | 2 +- src/Mod/TechDraw/Gui/QGVNavStyleRevit.h | 2 +- src/Mod/TechDraw/Gui/QGVNavStyleTinkerCAD.h | 2 +- src/Mod/TechDraw/Gui/QGVNavStyleTouchpad.h | 2 +- src/Mod/TechDraw/Gui/QGVPage.cpp | 2 +- src/Mod/TechDraw/Gui/TaskActiveView.h | 2 +- src/Mod/TechDraw/Gui/TaskCustomizeFormat.h | 4 +- src/Mod/TechDraw/Gui/TaskDetail.h | 8 +-- src/Mod/TechDraw/Gui/TaskHatch.h | 4 +- src/Mod/TechDraw/Gui/TaskLeaderLine.h | 4 +- src/Mod/TechDraw/Gui/TaskRichAnno.h | 4 +- src/Mod/TechDraw/Gui/TaskSectionView.h | 8 +-- .../TechDraw/Gui/TaskSelectLineAttributes.h | 4 +- .../TechDraw/Gui/TaskSurfaceFinishSymbols.h | 4 +- src/Mod/TechDraw/Gui/TaskWeldingSymbol.h | 4 +- src/Mod/Test/Gui/UnitTestImp.h | 2 +- src/Mod/Web/App/Server.h | 4 +- src/Mod/Web/Gui/BrowserView.cpp | 4 +- src/Mod/Web/Gui/BrowserView.h | 4 +- src/Mod/Web/Gui/CookieJar.h | 2 +- 263 files changed, 473 insertions(+), 473 deletions(-) diff --git a/src/Mod/Fem/App/HypothesisPy.h b/src/Mod/Fem/App/HypothesisPy.h index 34044de5f2..ea810ce371 100755 --- a/src/Mod/Fem/App/HypothesisPy.h +++ b/src/Mod/Fem/App/HypothesisPy.h @@ -36,7 +36,7 @@ class HypothesisPy : public Py::PythonExtension { public: typedef Py::PythonExtension HypothesisPyBase; - HypothesisPy(std::shared_ptr); + explicit HypothesisPy(std::shared_ptr); ~HypothesisPy() override; std::shared_ptr getHypothesis() const { return hyp; } @@ -54,7 +54,7 @@ public: typedef SMESH_HypothesisPy SMESH_HypothesisPyBase; static void init_type(PyObject*); // announce properties and methods - SMESH_HypothesisPy(SMESH_Hypothesis*); + explicit SMESH_HypothesisPy(SMESH_Hypothesis*); ~SMESH_HypothesisPy() override; Py::Object getattr(const char *name) override; diff --git a/src/Mod/Fem/Gui/AbaqusHighlighter.h b/src/Mod/Fem/Gui/AbaqusHighlighter.h index c3122800ca..4b6d5a9e1c 100644 --- a/src/Mod/Fem/Gui/AbaqusHighlighter.h +++ b/src/Mod/Fem/Gui/AbaqusHighlighter.h @@ -35,7 +35,7 @@ namespace FemGui { class AbaqusHighlighter : public Gui::SyntaxHighlighter { public: - AbaqusHighlighter(QObject* parent); + explicit AbaqusHighlighter(QObject* parent); virtual ~AbaqusHighlighter(); protected: diff --git a/src/Mod/Fem/Gui/DlgSettingsFemCcxImp.h b/src/Mod/Fem/Gui/DlgSettingsFemCcxImp.h index 59f6c98480..8afdd7fc01 100644 --- a/src/Mod/Fem/Gui/DlgSettingsFemCcxImp.h +++ b/src/Mod/Fem/Gui/DlgSettingsFemCcxImp.h @@ -37,7 +37,7 @@ class DlgSettingsFemCcxImp : public Gui::Dialog::PreferencePage Q_OBJECT public: - DlgSettingsFemCcxImp( QWidget* parent = nullptr ); + explicit DlgSettingsFemCcxImp( QWidget* parent = nullptr ); ~DlgSettingsFemCcxImp() override; protected Q_SLOTS: diff --git a/src/Mod/Fem/Gui/DlgSettingsFemElmerImp.h b/src/Mod/Fem/Gui/DlgSettingsFemElmerImp.h index b7e8a963bc..20ffff78fb 100644 --- a/src/Mod/Fem/Gui/DlgSettingsFemElmerImp.h +++ b/src/Mod/Fem/Gui/DlgSettingsFemElmerImp.h @@ -36,7 +36,7 @@ class DlgSettingsFemElmerImp : public Gui::Dialog::PreferencePage Q_OBJECT public: - DlgSettingsFemElmerImp( QWidget* parent = nullptr ); + explicit DlgSettingsFemElmerImp( QWidget* parent = nullptr ); ~DlgSettingsFemElmerImp() override; protected Q_SLOTS: diff --git a/src/Mod/Fem/Gui/DlgSettingsFemExportAbaqusImp.h b/src/Mod/Fem/Gui/DlgSettingsFemExportAbaqusImp.h index 3935af137d..1a86e4a2e6 100644 --- a/src/Mod/Fem/Gui/DlgSettingsFemExportAbaqusImp.h +++ b/src/Mod/Fem/Gui/DlgSettingsFemExportAbaqusImp.h @@ -36,7 +36,7 @@ class DlgSettingsFemExportAbaqusImp : public Gui::Dialog::PreferencePage Q_OBJECT public: - DlgSettingsFemExportAbaqusImp( QWidget* parent = nullptr ); + explicit DlgSettingsFemExportAbaqusImp( QWidget* parent = nullptr ); ~DlgSettingsFemExportAbaqusImp() override; protected: diff --git a/src/Mod/Fem/Gui/DlgSettingsFemGeneralImp.h b/src/Mod/Fem/Gui/DlgSettingsFemGeneralImp.h index 71d3ea9eaf..ee6a01b8b7 100644 --- a/src/Mod/Fem/Gui/DlgSettingsFemGeneralImp.h +++ b/src/Mod/Fem/Gui/DlgSettingsFemGeneralImp.h @@ -36,7 +36,7 @@ class DlgSettingsFemGeneralImp : public Gui::Dialog::PreferencePage Q_OBJECT public: - DlgSettingsFemGeneralImp( QWidget* parent = nullptr ); + explicit DlgSettingsFemGeneralImp( QWidget* parent = nullptr ); ~DlgSettingsFemGeneralImp() override; protected: diff --git a/src/Mod/Fem/Gui/DlgSettingsFemGmshImp.h b/src/Mod/Fem/Gui/DlgSettingsFemGmshImp.h index 5747c1c459..5ef7e9375f 100644 --- a/src/Mod/Fem/Gui/DlgSettingsFemGmshImp.h +++ b/src/Mod/Fem/Gui/DlgSettingsFemGmshImp.h @@ -36,7 +36,7 @@ class DlgSettingsFemGmshImp : public Gui::Dialog::PreferencePage Q_OBJECT public: - DlgSettingsFemGmshImp( QWidget* parent = nullptr ); + explicit DlgSettingsFemGmshImp( QWidget* parent = nullptr ); ~DlgSettingsFemGmshImp() override; protected Q_SLOTS: diff --git a/src/Mod/Fem/Gui/DlgSettingsFemInOutVtkImp.h b/src/Mod/Fem/Gui/DlgSettingsFemInOutVtkImp.h index 12d9f38648..b9188e79f8 100644 --- a/src/Mod/Fem/Gui/DlgSettingsFemInOutVtkImp.h +++ b/src/Mod/Fem/Gui/DlgSettingsFemInOutVtkImp.h @@ -36,7 +36,7 @@ class DlgSettingsFemInOutVtkImp : public Gui::Dialog::PreferencePage Q_OBJECT public: - DlgSettingsFemInOutVtkImp( QWidget* parent = nullptr ); + explicit DlgSettingsFemInOutVtkImp( QWidget* parent = nullptr ); ~DlgSettingsFemInOutVtkImp() override; protected: diff --git a/src/Mod/Fem/Gui/DlgSettingsFemMaterialImp.h b/src/Mod/Fem/Gui/DlgSettingsFemMaterialImp.h index 8f440a7458..792b015750 100644 --- a/src/Mod/Fem/Gui/DlgSettingsFemMaterialImp.h +++ b/src/Mod/Fem/Gui/DlgSettingsFemMaterialImp.h @@ -37,7 +37,7 @@ class DlgSettingsFemMaterialImp : public Gui::Dialog::PreferencePage Q_OBJECT public: - DlgSettingsFemMaterialImp( QWidget* parent = nullptr ); + explicit DlgSettingsFemMaterialImp( QWidget* parent = nullptr ); ~DlgSettingsFemMaterialImp() override; protected: diff --git a/src/Mod/Fem/Gui/DlgSettingsFemMystranImp.h b/src/Mod/Fem/Gui/DlgSettingsFemMystranImp.h index 7ddb0580c1..e58908ed0b 100644 --- a/src/Mod/Fem/Gui/DlgSettingsFemMystranImp.h +++ b/src/Mod/Fem/Gui/DlgSettingsFemMystranImp.h @@ -37,7 +37,7 @@ class DlgSettingsFemMystranImp : public Gui::Dialog::PreferencePage Q_OBJECT public: - DlgSettingsFemMystranImp( QWidget* parent = nullptr ); + explicit DlgSettingsFemMystranImp( QWidget* parent = nullptr ); ~DlgSettingsFemMystranImp() override; protected Q_SLOTS: diff --git a/src/Mod/Fem/Gui/DlgSettingsFemZ88Imp.h b/src/Mod/Fem/Gui/DlgSettingsFemZ88Imp.h index 12e959e8d5..e90e6c045b 100644 --- a/src/Mod/Fem/Gui/DlgSettingsFemZ88Imp.h +++ b/src/Mod/Fem/Gui/DlgSettingsFemZ88Imp.h @@ -37,7 +37,7 @@ class DlgSettingsFemZ88Imp : public Gui::Dialog::PreferencePage Q_OBJECT public: - DlgSettingsFemZ88Imp( QWidget* parent = nullptr ); + explicit DlgSettingsFemZ88Imp( QWidget* parent = nullptr ); ~DlgSettingsFemZ88Imp() override; protected Q_SLOTS: diff --git a/src/Mod/Fem/Gui/FemSelectionGate.h b/src/Mod/Fem/Gui/FemSelectionGate.h index 4f74719283..1c39f47117 100644 --- a/src/Mod/Fem/Gui/FemSelectionGate.h +++ b/src/Mod/Fem/Gui/FemSelectionGate.h @@ -37,7 +37,7 @@ class FemSelectionGate : public Gui::SelectionFilterGate NodeElement }; - FemSelectionGate(ElemType type) + explicit FemSelectionGate(ElemType type) : Gui::SelectionFilterGate(nullPointer()),Type(type) { } diff --git a/src/Mod/Fem/Gui/TaskAnalysisInfo.h b/src/Mod/Fem/Gui/TaskAnalysisInfo.h index 9381008fd9..6d48f3db5a 100644 --- a/src/Mod/Fem/Gui/TaskAnalysisInfo.h +++ b/src/Mod/Fem/Gui/TaskAnalysisInfo.h @@ -56,7 +56,7 @@ class TaskAnalysisInfo : public Gui::TaskView::TaskBox Q_OBJECT public: - TaskAnalysisInfo(Fem::FemAnalysis *pcObject,QWidget *parent = nullptr); + explicit TaskAnalysisInfo(Fem::FemAnalysis *pcObject,QWidget *parent = nullptr); ~TaskAnalysisInfo() override; private Q_SLOTS: diff --git a/src/Mod/Fem/Gui/TaskCreateNodeSet.h b/src/Mod/Fem/Gui/TaskCreateNodeSet.h index a893126825..79316d668d 100644 --- a/src/Mod/Fem/Gui/TaskCreateNodeSet.h +++ b/src/Mod/Fem/Gui/TaskCreateNodeSet.h @@ -52,7 +52,7 @@ class TaskCreateNodeSet : public Gui::TaskView::TaskBox, public Gui::SelectionOb Q_OBJECT public: - TaskCreateNodeSet(Fem::FemSetNodesObject *pcObject,QWidget *parent = nullptr); + explicit TaskCreateNodeSet(Fem::FemSetNodesObject *pcObject,QWidget *parent = nullptr); ~TaskCreateNodeSet() override; std::set tempSet; diff --git a/src/Mod/Fem/Gui/TaskDlgAnalysis.h b/src/Mod/Fem/Gui/TaskDlgAnalysis.h index 4c6e58c09d..57852c1493 100644 --- a/src/Mod/Fem/Gui/TaskDlgAnalysis.h +++ b/src/Mod/Fem/Gui/TaskDlgAnalysis.h @@ -41,7 +41,7 @@ class TaskDlgAnalysis : public Gui::TaskView::TaskDialog Q_OBJECT public: - TaskDlgAnalysis(Fem::FemAnalysis *); + explicit TaskDlgAnalysis(Fem::FemAnalysis *); ~TaskDlgAnalysis() override; public: diff --git a/src/Mod/Fem/Gui/TaskDlgCreateNodeSet.h b/src/Mod/Fem/Gui/TaskDlgCreateNodeSet.h index cc2b0ebfd5..3f4d34cc76 100644 --- a/src/Mod/Fem/Gui/TaskDlgCreateNodeSet.h +++ b/src/Mod/Fem/Gui/TaskDlgCreateNodeSet.h @@ -43,7 +43,7 @@ class TaskDlgCreateNodeSet : public Gui::TaskView::TaskDialog Q_OBJECT public: - TaskDlgCreateNodeSet(Fem::FemSetNodesObject *); + explicit TaskDlgCreateNodeSet(Fem::FemSetNodesObject *); ~TaskDlgCreateNodeSet() override; public: diff --git a/src/Mod/Fem/Gui/TaskDlgMeshShapeNetgen.h b/src/Mod/Fem/Gui/TaskDlgMeshShapeNetgen.h index aef9694630..792b4ee461 100644 --- a/src/Mod/Fem/Gui/TaskDlgMeshShapeNetgen.h +++ b/src/Mod/Fem/Gui/TaskDlgMeshShapeNetgen.h @@ -42,7 +42,7 @@ class TaskDlgMeshShapeNetgen : public Gui::TaskView::TaskDialog Q_OBJECT public: - TaskDlgMeshShapeNetgen(FemGui::ViewProviderFemMeshShapeNetgen *); + explicit TaskDlgMeshShapeNetgen(FemGui::ViewProviderFemMeshShapeNetgen *); ~TaskDlgMeshShapeNetgen() override; public: diff --git a/src/Mod/Fem/Gui/TaskDriver.h b/src/Mod/Fem/Gui/TaskDriver.h index bddab2197d..d290d1f66c 100644 --- a/src/Mod/Fem/Gui/TaskDriver.h +++ b/src/Mod/Fem/Gui/TaskDriver.h @@ -54,7 +54,7 @@ class TaskDriver : public Gui::TaskView::TaskBox Q_OBJECT public: - TaskDriver(Fem::FemAnalysis *pcObject,QWidget *parent = nullptr); + explicit TaskDriver(Fem::FemAnalysis *pcObject,QWidget *parent = nullptr); ~TaskDriver() override; diff --git a/src/Mod/Fem/Gui/TaskFemConstraint.h b/src/Mod/Fem/Gui/TaskFemConstraint.h index ff1019769b..78c51a5bec 100644 --- a/src/Mod/Fem/Gui/TaskFemConstraint.h +++ b/src/Mod/Fem/Gui/TaskFemConstraint.h @@ -44,7 +44,7 @@ class TaskFemConstraint : public Gui::TaskView::TaskBox, public Gui::SelectionOb Q_OBJECT public: - TaskFemConstraint(ViewProviderFemConstraint *ConstraintView,QWidget *parent = nullptr,const char* pixmapname = ""); + explicit TaskFemConstraint(ViewProviderFemConstraint *ConstraintView,QWidget *parent = nullptr,const char* pixmapname = ""); ~TaskFemConstraint() override {} virtual const std::string getReferences() const {return std::string();} diff --git a/src/Mod/Fem/Gui/TaskFemConstraintBearing.h b/src/Mod/Fem/Gui/TaskFemConstraintBearing.h index 047cccb3c8..e8f6d6e04d 100644 --- a/src/Mod/Fem/Gui/TaskFemConstraintBearing.h +++ b/src/Mod/Fem/Gui/TaskFemConstraintBearing.h @@ -47,7 +47,7 @@ class TaskFemConstraintBearing : public TaskFemConstraint Q_OBJECT public: - TaskFemConstraintBearing(ViewProviderFemConstraint *ConstraintView, QWidget *parent = nullptr, + explicit TaskFemConstraintBearing(ViewProviderFemConstraint *ConstraintView, QWidget *parent = nullptr, const char* pixmapname = "FEM_ConstraintBearing"); ~TaskFemConstraintBearing() override; @@ -80,7 +80,7 @@ class TaskDlgFemConstraintBearing : public TaskDlgFemConstraint public: TaskDlgFemConstraintBearing() {} - TaskDlgFemConstraintBearing(ViewProviderFemConstraintBearing *ConstraintView); + explicit TaskDlgFemConstraintBearing(ViewProviderFemConstraintBearing *ConstraintView); /// is called by the framework if the dialog is accepted (Ok) bool accept() override; diff --git a/src/Mod/Fem/Gui/TaskFemConstraintContact.h b/src/Mod/Fem/Gui/TaskFemConstraintContact.h index ccdfbae266..da823f2e3f 100644 --- a/src/Mod/Fem/Gui/TaskFemConstraintContact.h +++ b/src/Mod/Fem/Gui/TaskFemConstraintContact.h @@ -40,7 +40,7 @@ class TaskFemConstraintContact : public TaskFemConstraint Q_OBJECT public: - TaskFemConstraintContact(ViewProviderFemConstraintContact *ConstraintView,QWidget *parent = nullptr); + explicit TaskFemConstraintContact(ViewProviderFemConstraintContact *ConstraintView,QWidget *parent = nullptr); ~TaskFemConstraintContact() override; const std::string getReferences() const override; double get_Slope()const; @@ -69,7 +69,7 @@ class TaskDlgFemConstraintContact : public TaskDlgFemConstraint Q_OBJECT public: - TaskDlgFemConstraintContact(ViewProviderFemConstraintContact *ConstraintView); + explicit TaskDlgFemConstraintContact(ViewProviderFemConstraintContact *ConstraintView); void open() override; bool accept() override; bool reject() override; diff --git a/src/Mod/Fem/Gui/TaskFemConstraintDisplacement.h b/src/Mod/Fem/Gui/TaskFemConstraintDisplacement.h index 7719b6bb86..6f85d27f53 100644 --- a/src/Mod/Fem/Gui/TaskFemConstraintDisplacement.h +++ b/src/Mod/Fem/Gui/TaskFemConstraintDisplacement.h @@ -49,7 +49,7 @@ class TaskFemConstraintDisplacement : public TaskFemConstraintOnBoundary Q_OBJECT public: - TaskFemConstraintDisplacement(ViewProviderFemConstraintDisplacement *ConstraintView, QWidget *parent = nullptr); + explicit TaskFemConstraintDisplacement(ViewProviderFemConstraintDisplacement *ConstraintView, QWidget *parent = nullptr); ~TaskFemConstraintDisplacement() override; const std::string getReferences() const override; double get_spinxDisplacement()const; @@ -111,7 +111,7 @@ class TaskDlgFemConstraintDisplacement : public TaskDlgFemConstraint Q_OBJECT public: - TaskDlgFemConstraintDisplacement(ViewProviderFemConstraintDisplacement *ConstraintView); + explicit TaskDlgFemConstraintDisplacement(ViewProviderFemConstraintDisplacement *ConstraintView); void open() override; bool accept() override; bool reject() override; diff --git a/src/Mod/Fem/Gui/TaskFemConstraintFixed.h b/src/Mod/Fem/Gui/TaskFemConstraintFixed.h index 4ab0783c42..2efdb08e2d 100644 --- a/src/Mod/Fem/Gui/TaskFemConstraintFixed.h +++ b/src/Mod/Fem/Gui/TaskFemConstraintFixed.h @@ -38,7 +38,7 @@ class TaskFemConstraintFixed : public TaskFemConstraintOnBoundary Q_OBJECT public: - TaskFemConstraintFixed(ViewProviderFemConstraintFixed *ConstraintView,QWidget *parent = nullptr); + explicit TaskFemConstraintFixed(ViewProviderFemConstraintFixed *ConstraintView,QWidget *parent = nullptr); ~TaskFemConstraintFixed() override; const std::string getReferences() const override; @@ -63,7 +63,7 @@ class TaskDlgFemConstraintFixed : public TaskDlgFemConstraint Q_OBJECT public: - TaskDlgFemConstraintFixed(ViewProviderFemConstraintFixed *ConstraintView); + explicit TaskDlgFemConstraintFixed(ViewProviderFemConstraintFixed *ConstraintView); void open() override; bool accept() override; bool reject() override; diff --git a/src/Mod/Fem/Gui/TaskFemConstraintFluidBoundary.h b/src/Mod/Fem/Gui/TaskFemConstraintFluidBoundary.h index 34fe7fdc87..0b87182592 100644 --- a/src/Mod/Fem/Gui/TaskFemConstraintFluidBoundary.h +++ b/src/Mod/Fem/Gui/TaskFemConstraintFluidBoundary.h @@ -49,7 +49,7 @@ class TaskFemConstraintFluidBoundary : public TaskFemConstraintOnBoundary Q_OBJECT public: - TaskFemConstraintFluidBoundary(ViewProviderFemConstraintFluidBoundary *ConstraintView,QWidget *parent = nullptr); + explicit TaskFemConstraintFluidBoundary(ViewProviderFemConstraintFluidBoundary *ConstraintView,QWidget *parent = nullptr); ~TaskFemConstraintFluidBoundary() override; const Fem::FemSolverObject* getFemSolver() const; @@ -112,7 +112,7 @@ class TaskDlgFemConstraintFluidBoundary : public TaskDlgFemConstraint Q_OBJECT public: - TaskDlgFemConstraintFluidBoundary(ViewProviderFemConstraintFluidBoundary *ConstraintView); + explicit TaskDlgFemConstraintFluidBoundary(ViewProviderFemConstraintFluidBoundary *ConstraintView); /// is called by the framework if the dialog is accepted (Ok) void open() override; diff --git a/src/Mod/Fem/Gui/TaskFemConstraintForce.h b/src/Mod/Fem/Gui/TaskFemConstraintForce.h index 2fcede17e6..9c5ca011e6 100644 --- a/src/Mod/Fem/Gui/TaskFemConstraintForce.h +++ b/src/Mod/Fem/Gui/TaskFemConstraintForce.h @@ -48,7 +48,7 @@ class TaskFemConstraintForce : public TaskFemConstraintOnBoundary Q_OBJECT public: - TaskFemConstraintForce(ViewProviderFemConstraintForce *ConstraintView,QWidget *parent = nullptr); + explicit TaskFemConstraintForce(ViewProviderFemConstraintForce *ConstraintView,QWidget *parent = nullptr); ~TaskFemConstraintForce() override; double getForce() const; const std::string getReferences() const override; @@ -83,7 +83,7 @@ class TaskDlgFemConstraintForce : public TaskDlgFemConstraint Q_OBJECT public: - TaskDlgFemConstraintForce(ViewProviderFemConstraintForce *ConstraintView); + explicit TaskDlgFemConstraintForce(ViewProviderFemConstraintForce *ConstraintView); /// is called by the framework if the dialog is accepted (Ok) void open() override; diff --git a/src/Mod/Fem/Gui/TaskFemConstraintGear.h b/src/Mod/Fem/Gui/TaskFemConstraintGear.h index 2784a73bfb..6e06d79a23 100644 --- a/src/Mod/Fem/Gui/TaskFemConstraintGear.h +++ b/src/Mod/Fem/Gui/TaskFemConstraintGear.h @@ -34,7 +34,7 @@ class TaskFemConstraintGear : public TaskFemConstraintBearing Q_OBJECT public: - TaskFemConstraintGear(ViewProviderFemConstraint *ConstraintView,QWidget *parent = nullptr, + explicit TaskFemConstraintGear(ViewProviderFemConstraint *ConstraintView,QWidget *parent = nullptr, const char* pixmapname = "FEM_ConstraintGear"); double getDiameter() const; @@ -63,7 +63,7 @@ class TaskDlgFemConstraintGear : public TaskDlgFemConstraintBearing public: TaskDlgFemConstraintGear() {} - TaskDlgFemConstraintGear(ViewProviderFemConstraintGear *ConstraintView); + explicit TaskDlgFemConstraintGear(ViewProviderFemConstraintGear *ConstraintView); /// is called by the framework if the dialog is accepted (Ok) bool accept() override; diff --git a/src/Mod/Fem/Gui/TaskFemConstraintHeatflux.h b/src/Mod/Fem/Gui/TaskFemConstraintHeatflux.h index f1d522f491..e5dada8d0d 100644 --- a/src/Mod/Fem/Gui/TaskFemConstraintHeatflux.h +++ b/src/Mod/Fem/Gui/TaskFemConstraintHeatflux.h @@ -40,7 +40,7 @@ class TaskFemConstraintHeatflux : public TaskFemConstraintOnBoundary Q_OBJECT public: - TaskFemConstraintHeatflux(ViewProviderFemConstraintHeatflux *ConstraintView,QWidget *parent = nullptr); + explicit TaskFemConstraintHeatflux(ViewProviderFemConstraintHeatflux *ConstraintView,QWidget *parent = nullptr); ~TaskFemConstraintHeatflux() override; double getAmbientTemp() const; /*double getFaceTemp(void) const;*/ @@ -74,7 +74,7 @@ class TaskDlgFemConstraintHeatflux : public TaskDlgFemConstraint Q_OBJECT public: - TaskDlgFemConstraintHeatflux(ViewProviderFemConstraintHeatflux *ConstraintView); + explicit TaskDlgFemConstraintHeatflux(ViewProviderFemConstraintHeatflux *ConstraintView); void open() override; bool accept() override; bool reject() override; diff --git a/src/Mod/Fem/Gui/TaskFemConstraintInitialTemperature.h b/src/Mod/Fem/Gui/TaskFemConstraintInitialTemperature.h index 8522dd332d..9bc50b6454 100644 --- a/src/Mod/Fem/Gui/TaskFemConstraintInitialTemperature.h +++ b/src/Mod/Fem/Gui/TaskFemConstraintInitialTemperature.h @@ -40,7 +40,7 @@ class TaskFemConstraintInitialTemperature : public TaskFemConstraint Q_OBJECT public: - TaskFemConstraintInitialTemperature(ViewProviderFemConstraintInitialTemperature *ConstraintView,QWidget *parent = nullptr); + explicit TaskFemConstraintInitialTemperature(ViewProviderFemConstraintInitialTemperature *ConstraintView,QWidget *parent = nullptr); ~TaskFemConstraintInitialTemperature() override; double get_temperature()const; @@ -59,7 +59,7 @@ class TaskDlgFemConstraintInitialTemperature : public TaskDlgFemConstraint Q_OBJECT public: - TaskDlgFemConstraintInitialTemperature(ViewProviderFemConstraintInitialTemperature *ConstraintView); + explicit TaskDlgFemConstraintInitialTemperature(ViewProviderFemConstraintInitialTemperature *ConstraintView); void open() override; bool accept() override; bool reject() override; diff --git a/src/Mod/Fem/Gui/TaskFemConstraintOnBoundary.h b/src/Mod/Fem/Gui/TaskFemConstraintOnBoundary.h index 10e59b50e8..debc0e7be9 100644 --- a/src/Mod/Fem/Gui/TaskFemConstraintOnBoundary.h +++ b/src/Mod/Fem/Gui/TaskFemConstraintOnBoundary.h @@ -48,7 +48,7 @@ class TaskFemConstraintOnBoundary : public TaskFemConstraint Q_OBJECT public: - TaskFemConstraintOnBoundary(ViewProviderFemConstraint *ConstraintView, QWidget *parent = nullptr, const char* pixmapname = ""); + explicit TaskFemConstraintOnBoundary(ViewProviderFemConstraint *ConstraintView, QWidget *parent = nullptr, const char* pixmapname = ""); ~TaskFemConstraintOnBoundary() override; protected Q_SLOTS: diff --git a/src/Mod/Fem/Gui/TaskFemConstraintPlaneRotation.h b/src/Mod/Fem/Gui/TaskFemConstraintPlaneRotation.h index 733025e056..d324507e6d 100644 --- a/src/Mod/Fem/Gui/TaskFemConstraintPlaneRotation.h +++ b/src/Mod/Fem/Gui/TaskFemConstraintPlaneRotation.h @@ -40,7 +40,7 @@ class TaskFemConstraintPlaneRotation : public TaskFemConstraint Q_OBJECT public: - TaskFemConstraintPlaneRotation(ViewProviderFemConstraintPlaneRotation *ConstraintView,QWidget *parent = nullptr); + explicit TaskFemConstraintPlaneRotation(ViewProviderFemConstraintPlaneRotation *ConstraintView,QWidget *parent = nullptr); ~TaskFemConstraintPlaneRotation() override; const std::string getReferences() const override; @@ -64,7 +64,7 @@ class TaskDlgFemConstraintPlaneRotation : public TaskDlgFemConstraint Q_OBJECT public: - TaskDlgFemConstraintPlaneRotation(ViewProviderFemConstraintPlaneRotation *ConstraintView); + explicit TaskDlgFemConstraintPlaneRotation(ViewProviderFemConstraintPlaneRotation *ConstraintView); void open() override; bool accept() override; bool reject() override; diff --git a/src/Mod/Fem/Gui/TaskFemConstraintPressure.h b/src/Mod/Fem/Gui/TaskFemConstraintPressure.h index 35bc5ebd11..b1bf50b411 100644 --- a/src/Mod/Fem/Gui/TaskFemConstraintPressure.h +++ b/src/Mod/Fem/Gui/TaskFemConstraintPressure.h @@ -40,7 +40,7 @@ class TaskFemConstraintPressure : public TaskFemConstraintOnBoundary Q_OBJECT public: - TaskFemConstraintPressure(ViewProviderFemConstraintPressure *ConstraintView,QWidget *parent = nullptr); + explicit TaskFemConstraintPressure(ViewProviderFemConstraintPressure *ConstraintView,QWidget *parent = nullptr); ~TaskFemConstraintPressure() override; const std::string getReferences() const override; double get_Pressure()const; @@ -68,7 +68,7 @@ class TaskDlgFemConstraintPressure : public TaskDlgFemConstraint Q_OBJECT public: - TaskDlgFemConstraintPressure(ViewProviderFemConstraintPressure *ConstraintView); + explicit TaskDlgFemConstraintPressure(ViewProviderFemConstraintPressure *ConstraintView); void open() override; bool accept() override; bool reject() override; diff --git a/src/Mod/Fem/Gui/TaskFemConstraintPulley.h b/src/Mod/Fem/Gui/TaskFemConstraintPulley.h index d99cb7b01e..7ca20d7e0d 100644 --- a/src/Mod/Fem/Gui/TaskFemConstraintPulley.h +++ b/src/Mod/Fem/Gui/TaskFemConstraintPulley.h @@ -34,7 +34,7 @@ class TaskFemConstraintPulley : public TaskFemConstraintGear Q_OBJECT public: - TaskFemConstraintPulley(ViewProviderFemConstraintPulley *ConstraintView,QWidget *parent = nullptr); + explicit TaskFemConstraintPulley(ViewProviderFemConstraintPulley *ConstraintView,QWidget *parent = nullptr); double getOtherDiameter() const; double getCenterDistance() const; @@ -58,7 +58,7 @@ class TaskDlgFemConstraintPulley : public TaskDlgFemConstraintGear Q_OBJECT public: - TaskDlgFemConstraintPulley(ViewProviderFemConstraintPulley *ConstraintView); + explicit TaskDlgFemConstraintPulley(ViewProviderFemConstraintPulley *ConstraintView); /// is called by the framework if the dialog is accepted (Ok) bool accept() override; diff --git a/src/Mod/Fem/Gui/TaskFemConstraintSpring.h b/src/Mod/Fem/Gui/TaskFemConstraintSpring.h index 7d2dfa2dd3..62da3938ca 100644 --- a/src/Mod/Fem/Gui/TaskFemConstraintSpring.h +++ b/src/Mod/Fem/Gui/TaskFemConstraintSpring.h @@ -38,7 +38,7 @@ class TaskFemConstraintSpring : public TaskFemConstraintOnBoundary Q_OBJECT public: - TaskFemConstraintSpring(ViewProviderFemConstraintSpring *ConstraintView,QWidget *parent = nullptr); + explicit TaskFemConstraintSpring(ViewProviderFemConstraintSpring *ConstraintView,QWidget *parent = nullptr); ~TaskFemConstraintSpring() override; const std::string getReferences() const override; double get_normalStiffness()const; @@ -65,7 +65,7 @@ class TaskDlgFemConstraintSpring : public TaskDlgFemConstraint Q_OBJECT public: - TaskDlgFemConstraintSpring(ViewProviderFemConstraintSpring *ConstraintView); + explicit TaskDlgFemConstraintSpring(ViewProviderFemConstraintSpring *ConstraintView); void open() override; bool accept() override; bool reject() override; diff --git a/src/Mod/Fem/Gui/TaskFemConstraintTemperature.h b/src/Mod/Fem/Gui/TaskFemConstraintTemperature.h index 9d1659db30..c68d0bbf5c 100644 --- a/src/Mod/Fem/Gui/TaskFemConstraintTemperature.h +++ b/src/Mod/Fem/Gui/TaskFemConstraintTemperature.h @@ -43,7 +43,7 @@ class TaskFemConstraintTemperature : public TaskFemConstraintOnBoundary Q_OBJECT public: - TaskFemConstraintTemperature(ViewProviderFemConstraintTemperature *ConstraintView,QWidget *parent = nullptr); + explicit TaskFemConstraintTemperature(ViewProviderFemConstraintTemperature *ConstraintView,QWidget *parent = nullptr); ~TaskFemConstraintTemperature() override; const std::string getReferences() const override; double get_temperature()const; @@ -74,7 +74,7 @@ class TaskDlgFemConstraintTemperature : public TaskDlgFemConstraint Q_OBJECT public: - TaskDlgFemConstraintTemperature(ViewProviderFemConstraintTemperature *ConstraintView); + explicit TaskDlgFemConstraintTemperature(ViewProviderFemConstraintTemperature *ConstraintView); void open() override; bool accept() override; bool reject() override; diff --git a/src/Mod/Fem/Gui/TaskFemConstraintTransform.h b/src/Mod/Fem/Gui/TaskFemConstraintTransform.h index d0f1d2e874..0e35bc2cc5 100644 --- a/src/Mod/Fem/Gui/TaskFemConstraintTransform.h +++ b/src/Mod/Fem/Gui/TaskFemConstraintTransform.h @@ -41,7 +41,7 @@ class TaskFemConstraintTransform : public TaskFemConstraint Q_OBJECT public: - TaskFemConstraintTransform(ViewProviderFemConstraintTransform *ConstraintView,QWidget *parent = nullptr); + explicit TaskFemConstraintTransform(ViewProviderFemConstraintTransform *ConstraintView,QWidget *parent = nullptr); ~TaskFemConstraintTransform() override; const std::string getReferences() const override; double get_X_rot()const; @@ -75,7 +75,7 @@ class TaskDlgFemConstraintTransform : public TaskDlgFemConstraint Q_OBJECT public: - TaskDlgFemConstraintTransform(ViewProviderFemConstraintTransform *ConstraintView); + explicit TaskDlgFemConstraintTransform(ViewProviderFemConstraintTransform *ConstraintView); void open() override; bool accept() override; bool reject() override; diff --git a/src/Mod/Fem/Gui/TaskObjectName.h b/src/Mod/Fem/Gui/TaskObjectName.h index d9ed16fc86..39c0369eda 100644 --- a/src/Mod/Fem/Gui/TaskObjectName.h +++ b/src/Mod/Fem/Gui/TaskObjectName.h @@ -48,7 +48,7 @@ class TaskObjectName : public Gui::TaskView::TaskBox Q_OBJECT public: - TaskObjectName(App::DocumentObject *pcObject,QWidget *parent = nullptr); + explicit TaskObjectName(App::DocumentObject *pcObject,QWidget *parent = nullptr); ~TaskObjectName() override; diff --git a/src/Mod/Fem/Gui/TaskPostBoxes.h b/src/Mod/Fem/Gui/TaskPostBoxes.h index 5f7b259082..38ace8c56c 100644 --- a/src/Mod/Fem/Gui/TaskPostBoxes.h +++ b/src/Mod/Fem/Gui/TaskPostBoxes.h @@ -179,7 +179,7 @@ class TaskDlgPost : public Gui::TaskView::TaskDialog Q_OBJECT public: - TaskDlgPost(Gui::ViewProviderDocumentObject *view); + explicit TaskDlgPost(Gui::ViewProviderDocumentObject *view); ~TaskDlgPost() override; void connectSlots(); @@ -219,7 +219,7 @@ class TaskPostDisplay : public TaskPostBox Q_OBJECT public: - TaskPostDisplay(Gui::ViewProviderDocumentObject* view, QWidget *parent = nullptr); + explicit TaskPostDisplay(Gui::ViewProviderDocumentObject* view, QWidget *parent = nullptr); ~TaskPostDisplay() override; void applyPythonCode() override; @@ -243,7 +243,7 @@ class TaskPostFunction : public TaskPostBox { Q_OBJECT public: - TaskPostFunction(Gui::ViewProviderDocumentObject* view, QWidget* parent = nullptr); + explicit TaskPostFunction(Gui::ViewProviderDocumentObject* view, QWidget* parent = nullptr); ~TaskPostFunction() override; void applyPythonCode() override; @@ -284,7 +284,7 @@ class TaskPostDataAlongLine: public TaskPostBox { Q_OBJECT public: - TaskPostDataAlongLine(Gui::ViewProviderDocumentObject* view, QWidget* parent = nullptr); + explicit TaskPostDataAlongLine(Gui::ViewProviderDocumentObject* view, QWidget* parent = nullptr); ~TaskPostDataAlongLine() override; void applyPythonCode() override; @@ -315,7 +315,7 @@ class TaskPostDataAtPoint: public TaskPostBox { Q_OBJECT public: - TaskPostDataAtPoint(Gui::ViewProviderDocumentObject* view, QWidget* parent = nullptr); + explicit TaskPostDataAtPoint(Gui::ViewProviderDocumentObject* view, QWidget* parent = nullptr); ~TaskPostDataAtPoint() override; void applyPythonCode() override; @@ -344,7 +344,7 @@ class TaskPostScalarClip : public TaskPostBox { Q_OBJECT public: - TaskPostScalarClip(Gui::ViewProviderDocumentObject* view, QWidget* parent = nullptr); + explicit TaskPostScalarClip(Gui::ViewProviderDocumentObject* view, QWidget* parent = nullptr); ~TaskPostScalarClip() override; void applyPythonCode() override; @@ -366,7 +366,7 @@ class TaskPostWarpVector : public TaskPostBox { Q_OBJECT public: - TaskPostWarpVector(Gui::ViewProviderDocumentObject* view, QWidget* parent = nullptr); + explicit TaskPostWarpVector(Gui::ViewProviderDocumentObject* view, QWidget* parent = nullptr); ~TaskPostWarpVector() override; void applyPythonCode() override; diff --git a/src/Mod/Fem/Gui/TaskTetParameter.h b/src/Mod/Fem/Gui/TaskTetParameter.h index e610802f5b..11fe5c45a0 100644 --- a/src/Mod/Fem/Gui/TaskTetParameter.h +++ b/src/Mod/Fem/Gui/TaskTetParameter.h @@ -55,7 +55,7 @@ class TaskTetParameter : public Gui::TaskView::TaskBox Q_OBJECT public: - TaskTetParameter(Fem::FemMeshShapeNetgenObject *pcObject,QWidget *parent = nullptr); + explicit TaskTetParameter(Fem::FemMeshShapeNetgenObject *pcObject,QWidget *parent = nullptr); ~TaskTetParameter() override; void setInfo(); diff --git a/src/Mod/Import/App/ImportOCAF2.h b/src/Mod/Import/App/ImportOCAF2.h index 43aa1420ad..a2bc23150b 100644 --- a/src/Mod/Import/App/ImportOCAF2.h +++ b/src/Mod/Import/App/ImportOCAF2.h @@ -128,7 +128,7 @@ private: private: class ImportLegacy : public ImportOCAF { public: - ImportLegacy(ImportOCAF2 &parent) + explicit ImportLegacy(ImportOCAF2 &parent) :ImportOCAF(parent.pDoc, parent.pDocument, parent.default_name),myParent(parent) {} @@ -172,7 +172,7 @@ class ImportExport ExportOCAF2 public: typedef std::function( App::DocumentObject*, const char*)> GetShapeColorsFunc; - ExportOCAF2(Handle(TDocStd_Document) h, GetShapeColorsFunc func=GetShapeColorsFunc()); + explicit ExportOCAF2(Handle(TDocStd_Document) h, GetShapeColorsFunc func=GetShapeColorsFunc()); void setExportHiddenObject(bool enable) {exportHidden=enable;} void setKeepPlacement(bool enable) {keepPlacement=enable;} diff --git a/src/Mod/Import/Gui/AppImportGuiPy.cpp b/src/Mod/Import/Gui/AppImportGuiPy.cpp index edd2e2b896..7f3add3a11 100644 --- a/src/Mod/Import/Gui/AppImportGuiPy.cpp +++ b/src/Mod/Import/Gui/AppImportGuiPy.cpp @@ -122,7 +122,7 @@ namespace ImportGui { class OCAFBrowser { public: - OCAFBrowser(Handle(TDocStd_Document) h) + explicit OCAFBrowser(Handle(TDocStd_Document) h) : pDoc(h) { myGroupIcon = QApplication::style()->standardIcon(QStyle::SP_DirIcon); diff --git a/src/Mod/Inspection/App/InspectionFeature.h b/src/Mod/Inspection/App/InspectionFeature.h index f69b24cac2..2efa5bdb68 100644 --- a/src/Mod/Inspection/App/InspectionFeature.h +++ b/src/Mod/Inspection/App/InspectionFeature.h @@ -59,7 +59,7 @@ public: class InspectionExport InspectActualMesh : public InspectActualGeometry { public: - InspectActualMesh(const Mesh::MeshObject& rMesh); + explicit InspectActualMesh(const Mesh::MeshObject& rMesh); ~InspectActualMesh() override; unsigned long countPoints() const override; Base::Vector3f getPoint(unsigned long) const override; @@ -73,7 +73,7 @@ private: class InspectionExport InspectActualPoints : public InspectActualGeometry { public: - InspectActualPoints(const Points::PointKernel&); + explicit InspectActualPoints(const Points::PointKernel&); unsigned long countPoints() const override; Base::Vector3f getPoint(unsigned long) const override; @@ -84,7 +84,7 @@ private: class InspectionExport InspectActualShape : public InspectActualGeometry { public: - InspectActualShape(const Part::TopoShape&); + explicit InspectActualShape(const Part::TopoShape&); unsigned long countPoints() const override; Base::Vector3f getPoint(unsigned long) const override; diff --git a/src/Mod/Inspection/Gui/ViewProviderInspection.cpp b/src/Mod/Inspection/Gui/ViewProviderInspection.cpp index 9d043dea1e..a52625bbe2 100644 --- a/src/Mod/Inspection/Gui/ViewProviderInspection.cpp +++ b/src/Mod/Inspection/Gui/ViewProviderInspection.cpp @@ -394,7 +394,7 @@ namespace InspectionGui { class ViewProviderProxyObject : public QObject { public: - ViewProviderProxyObject(QWidget* w) : QObject(nullptr), widget(w) {} + explicit ViewProviderProxyObject(QWidget* w) : QObject(nullptr), widget(w) {} ~ViewProviderProxyObject() override {} void customEvent(QEvent *) override { diff --git a/src/Mod/Inspection/Gui/VisualInspection.cpp b/src/Mod/Inspection/Gui/VisualInspection.cpp index 8bf09004af..3dfab3c51f 100644 --- a/src/Mod/Inspection/Gui/VisualInspection.cpp +++ b/src/Mod/Inspection/Gui/VisualInspection.cpp @@ -44,12 +44,12 @@ namespace InspectionGui { class SingleSelectionItem : public QTreeWidgetItem { public: - SingleSelectionItem (QTreeWidget* parent) + explicit SingleSelectionItem (QTreeWidget* parent) : QTreeWidgetItem(parent), _compItem(nullptr) { } - SingleSelectionItem (QTreeWidgetItem* parent) + explicit SingleSelectionItem (QTreeWidgetItem* parent) : QTreeWidgetItem (parent), _compItem(nullptr) { } diff --git a/src/Mod/Inspection/Gui/VisualInspection.h b/src/Mod/Inspection/Gui/VisualInspection.h index 4cdbbaaf22..ea22dd40fc 100644 --- a/src/Mod/Inspection/Gui/VisualInspection.h +++ b/src/Mod/Inspection/Gui/VisualInspection.h @@ -36,7 +36,7 @@ class VisualInspection : public QDialog Q_OBJECT public: - VisualInspection(QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); + explicit VisualInspection(QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); ~ VisualInspection() override; void accept() override; diff --git a/src/Mod/Mesh/App/Core/Algorithm.h b/src/Mod/Mesh/App/Core/Algorithm.h index 49f2f6d4c5..32634c4ddb 100644 --- a/src/Mod/Mesh/App/Core/Algorithm.h +++ b/src/Mod/Mesh/App/Core/Algorithm.h @@ -56,7 +56,7 @@ class MeshExport MeshAlgorithm { public: /// Construction - MeshAlgorithm (const MeshKernel &rclM) : _rclMesh(rclM) { } + explicit MeshAlgorithm (const MeshKernel &rclM) : _rclMesh(rclM) { } /// Destruction ~MeshAlgorithm () { } @@ -353,7 +353,7 @@ public: class MeshExport PointCollector : public MeshCollector { public: - PointCollector(std::vector& ind) : indices(ind){} + explicit PointCollector(std::vector& ind) : indices(ind){} ~PointCollector() override{} void Append(const MeshCore::MeshKernel& kernel, FacetIndex index) override { @@ -371,7 +371,7 @@ private: class MeshExport FacetCollector : public MeshCollector { public: - FacetCollector(std::vector& ind) : indices(ind){} + explicit FacetCollector(std::vector& ind) : indices(ind){} ~FacetCollector() override{} void Append(const MeshCore::MeshKernel&, FacetIndex index) override { @@ -392,7 +392,7 @@ class MeshExport MeshRefPointToFacets { public: /// Construction - MeshRefPointToFacets (const MeshKernel &rclM) : _rclMesh(rclM) + explicit MeshRefPointToFacets (const MeshKernel &rclM) : _rclMesh(rclM) { Rebuild(); } /// Destruction ~MeshRefPointToFacets () @@ -431,7 +431,7 @@ class MeshExport MeshRefFacetToFacets { public: /// Construction - MeshRefFacetToFacets (const MeshKernel &rclM) : _rclMesh(rclM) + explicit MeshRefFacetToFacets (const MeshKernel &rclM) : _rclMesh(rclM) { Rebuild(); } /// Destruction ~MeshRefFacetToFacets () @@ -460,7 +460,7 @@ class MeshExport MeshRefPointToPoints { public: /// Construction - MeshRefPointToPoints (const MeshKernel &rclM) : _rclMesh(rclM) + explicit MeshRefPointToPoints (const MeshKernel &rclM) : _rclMesh(rclM) { Rebuild(); } /// Destruction ~MeshRefPointToPoints () @@ -489,7 +489,7 @@ class MeshExport MeshRefEdgeToFacets { public: /// Construction - MeshRefEdgeToFacets (const MeshKernel &rclM) : _rclMesh(rclM) + explicit MeshRefEdgeToFacets (const MeshKernel &rclM) : _rclMesh(rclM) { Rebuild(); } /// Destruction ~MeshRefEdgeToFacets () @@ -528,7 +528,7 @@ class MeshExport MeshRefNormalToPoints { public: /// Construction - MeshRefNormalToPoints (const MeshKernel &rclM) : _rclMesh(rclM) + explicit MeshRefNormalToPoints (const MeshKernel &rclM) : _rclMesh(rclM) { Rebuild(); } /// Destruction ~MeshRefNormalToPoints () diff --git a/src/Mod/Mesh/App/Core/Approximation.h b/src/Mod/Mesh/App/Core/Approximation.h index acec6224d5..ec2f2d34df 100644 --- a/src/Mod/Mesh/App/Core/Approximation.h +++ b/src/Mod/Mesh/App/Core/Approximation.h @@ -53,7 +53,7 @@ template class PolynomialSurface : public ImplicitSurface { public: - PolynomialSurface (const Real afCoeff[6]) + explicit PolynomialSurface (const Real afCoeff[6]) { for (int i=0; i<6; i++) m_afCoeff[i] = afCoeff[i]; } virtual ~PolynomialSurface () {} @@ -498,7 +498,7 @@ public: * @param pKoef Pointer to the quadric coefficients * (double [10]) */ - FunctionContainer(const double *pKoef) + explicit FunctionContainer(const double *pKoef) { Assign( pKoef ); pImplSurf = new Wm4::QuadricSurface( dKoeff ); diff --git a/src/Mod/Mesh/App/Core/Builder.h b/src/Mod/Mesh/App/Core/Builder.h index 81415b1d56..e71f8da5f2 100644 --- a/src/Mod/Mesh/App/Core/Builder.h +++ b/src/Mod/Mesh/App/Core/Builder.h @@ -114,7 +114,7 @@ private: void RemoveUnreferencedPoints(); public: - MeshBuilder(MeshKernel &rclM); + explicit MeshBuilder(MeshKernel &rclM); ~MeshBuilder(); /** @@ -190,7 +190,7 @@ private: public: typedef int size_type; - MeshFastBuilder(MeshKernel &rclM); + explicit MeshFastBuilder(MeshKernel &rclM); ~MeshFastBuilder(); /** Initializes the class. Must be done before adding facets diff --git a/src/Mod/Mesh/App/Core/Curvature.cpp b/src/Mod/Mesh/App/Core/Curvature.cpp index af487e59da..1f9c632eb3 100644 --- a/src/Mod/Mesh/App/Core/Curvature.cpp +++ b/src/Mod/Mesh/App/Core/Curvature.cpp @@ -343,7 +343,7 @@ namespace MeshCore { class FitPointCollector : public MeshCollector { public: - FitPointCollector(std::set& ind) : indices(ind){} + explicit FitPointCollector(std::set& ind) : indices(ind){} void Append(const MeshCore::MeshKernel& kernel, FacetIndex index) override { PointIndex ulP1, ulP2, ulP3; diff --git a/src/Mod/Mesh/App/Core/Curvature.h b/src/Mod/Mesh/App/Core/Curvature.h index 2e3bc6e63b..111c855a76 100644 --- a/src/Mod/Mesh/App/Core/Curvature.h +++ b/src/Mod/Mesh/App/Core/Curvature.h @@ -55,7 +55,7 @@ private: class MeshExport MeshCurvature { public: - MeshCurvature(const MeshKernel& kernel); + explicit MeshCurvature(const MeshKernel& kernel); MeshCurvature(const MeshKernel& kernel, const std::vector& segm); float GetRadius() const { return myRadius; } void SetRadius(float r) { myRadius = r; } diff --git a/src/Mod/Mesh/App/Core/Decimation.h b/src/Mod/Mesh/App/Core/Decimation.h index 60eb24df7c..4dde8ab640 100644 --- a/src/Mod/Mesh/App/Core/Decimation.h +++ b/src/Mod/Mesh/App/Core/Decimation.h @@ -33,7 +33,7 @@ class MeshKernel; class MeshExport MeshSimplify { public: - MeshSimplify(MeshKernel&); + MeshSimplify(MeshKernel&);//explicit bombs ~MeshSimplify(); void simplify(float tolerance, float reduction); void simplify(int targetSize); diff --git a/src/Mod/Mesh/App/Core/Degeneration.h b/src/Mod/Mesh/App/Core/Degeneration.h index 5c6eb3fc24..89d29e25c2 100644 --- a/src/Mod/Mesh/App/Core/Degeneration.h +++ b/src/Mod/Mesh/App/Core/Degeneration.h @@ -50,7 +50,7 @@ public: /** * Construction. */ - MeshEvalInvalids (const MeshKernel &rclM) : MeshEvaluation( rclM ) { } + explicit MeshEvalInvalids (const MeshKernel &rclM) : MeshEvaluation( rclM ) { } /** * Destruction. */ @@ -76,7 +76,7 @@ public: /** * Construction. */ - MeshFixInvalids (MeshKernel &rclM) : MeshValidation( rclM ) { } + explicit MeshFixInvalids (MeshKernel &rclM) : MeshValidation( rclM ) { } /** * Destruction. */ @@ -101,7 +101,7 @@ public: /** * Construction. */ - MeshEvalDuplicatePoints (const MeshKernel &rclM) : MeshEvaluation( rclM ) { } + explicit MeshEvalDuplicatePoints (const MeshKernel &rclM) : MeshEvaluation( rclM ) { } /** * Destruction. */ @@ -127,7 +127,7 @@ public: /** * Construction. */ - MeshFixDuplicatePoints (MeshKernel &rclM) : MeshValidation( rclM ) { } + explicit MeshFixDuplicatePoints (MeshKernel &rclM) : MeshValidation( rclM ) { } /** * Destruction. */ @@ -149,7 +149,7 @@ public: /** * Construction. */ - MeshEvalNaNPoints (const MeshKernel &rclM) : MeshEvaluation( rclM ) { } + explicit MeshEvalNaNPoints (const MeshKernel &rclM) : MeshEvaluation( rclM ) { } /** * Destruction. */ @@ -175,7 +175,7 @@ public: /** * Construction. */ - MeshFixNaNPoints (MeshKernel &rclM) : MeshValidation( rclM ) { } + explicit MeshFixNaNPoints (MeshKernel &rclM) : MeshValidation( rclM ) { } /** * Destruction. */ @@ -199,7 +199,7 @@ public: /** * Construction. */ - MeshEvalDuplicateFacets (const MeshKernel &rclM) : MeshEvaluation( rclM ) { } + explicit MeshEvalDuplicateFacets (const MeshKernel &rclM) : MeshEvaluation( rclM ) { } /** * Destruction. */ @@ -225,7 +225,7 @@ public: /** * Construction. */ - MeshFixDuplicateFacets (MeshKernel &rclM) : MeshValidation( rclM ) { } + explicit MeshFixDuplicateFacets (MeshKernel &rclM) : MeshValidation( rclM ) { } /** * Destruction. */ @@ -246,7 +246,7 @@ public: /** * Construction. */ - MeshEvalInternalFacets (const MeshKernel &rclM) : MeshEvaluation( rclM ) { } + explicit MeshEvalInternalFacets (const MeshKernel &rclM) : MeshEvaluation( rclM ) { } /** * Destruction. */ @@ -345,7 +345,7 @@ public: * It defines the amount of perimeter of a triangle for which the shortest * edge is considered for removal. */ - MeshRemoveNeedles (MeshKernel &rclM, float fMinEdgeLen = 0.05f) + explicit MeshRemoveNeedles (MeshKernel &rclM, float fMinEdgeLen = 0.05f) : MeshValidation(rclM), fMinEdgeLength(std::min(fMinEdgeLen, 0.25f)) {} /** * Destruction. @@ -377,7 +377,7 @@ public: /** * Construction. The \arg fFactor must be in the range of 0.0 and 0.5. */ - MeshFixCaps (MeshKernel &rclM, float fMaxAng = 2.61f, float fFactor = 0.25f) // ~150 degree + explicit MeshFixCaps (MeshKernel &rclM, float fMaxAng = 2.61f, float fFactor = 0.25f) // ~150 degree : MeshValidation(rclM), fMaxAngle(fMaxAng), fSplitFactor(fFactor) { } /** * Destruction. @@ -470,7 +470,7 @@ public: /** * Construction. */ - MeshFixMergeFacets (MeshKernel &rclM) + explicit MeshFixMergeFacets (MeshKernel &rclM) : MeshValidation(rclM) { } /** * Destruction. @@ -489,7 +489,7 @@ public: class MeshExport MeshEvalDentsOnSurface : public MeshEvaluation { public: - MeshEvalDentsOnSurface (const MeshKernel &rclM) : MeshEvaluation( rclM ) { } + explicit MeshEvalDentsOnSurface (const MeshKernel &rclM) : MeshEvaluation( rclM ) { } ~MeshEvalDentsOnSurface() override {} bool Evaluate() override; @@ -502,7 +502,7 @@ private: class MeshExport MeshFixDentsOnSurface : public MeshValidation { public: - MeshFixDentsOnSurface (MeshKernel &rclM) : MeshValidation( rclM ) { } + explicit MeshFixDentsOnSurface (MeshKernel &rclM) : MeshValidation( rclM ) { } ~MeshFixDentsOnSurface() override {} bool Fixup() override; @@ -516,7 +516,7 @@ public: class MeshExport MeshEvalFoldsOnSurface : public MeshEvaluation { public: - MeshEvalFoldsOnSurface (const MeshKernel &rclM) : MeshEvaluation( rclM ) { } + explicit MeshEvalFoldsOnSurface (const MeshKernel &rclM) : MeshEvaluation( rclM ) { } ~MeshEvalFoldsOnSurface() override {} bool Evaluate() override; @@ -535,7 +535,7 @@ private: class MeshExport MeshEvalFoldsOnBoundary : public MeshEvaluation { public: - MeshEvalFoldsOnBoundary (const MeshKernel &rclM) : MeshEvaluation( rclM ) { } + explicit MeshEvalFoldsOnBoundary (const MeshKernel &rclM) : MeshEvaluation( rclM ) { } ~MeshEvalFoldsOnBoundary() override {} bool Evaluate() override; @@ -548,7 +548,7 @@ private: class MeshExport MeshFixFoldsOnBoundary : public MeshValidation { public: - MeshFixFoldsOnBoundary (MeshKernel &rclM) : MeshValidation( rclM ) { } + explicit MeshFixFoldsOnBoundary (MeshKernel &rclM) : MeshValidation( rclM ) { } ~MeshFixFoldsOnBoundary() override {} bool Fixup() override; @@ -561,7 +561,7 @@ public: class MeshExport MeshEvalFoldOversOnSurface : public MeshEvaluation { public: - MeshEvalFoldOversOnSurface (const MeshKernel &rclM) : MeshEvaluation( rclM ) { } + explicit MeshEvalFoldOversOnSurface (const MeshKernel &rclM) : MeshEvaluation( rclM ) { } ~MeshEvalFoldOversOnSurface() override {} bool Evaluate() override; @@ -606,7 +606,7 @@ public: /** * Construction. */ - MeshEvalRangeFacet (const MeshKernel &rclM) : MeshEvaluation( rclM ) { } + explicit MeshEvalRangeFacet (const MeshKernel &rclM) : MeshEvaluation( rclM ) { } /** * Destruction. */ @@ -632,7 +632,7 @@ public: /** * Construction. */ - MeshFixRangeFacet (MeshKernel &rclM) : MeshValidation( rclM ) { } + explicit MeshFixRangeFacet (MeshKernel &rclM) : MeshValidation( rclM ) { } /** * Destruction. */ @@ -654,7 +654,7 @@ public: /** * Construction. */ - MeshEvalRangePoint (const MeshKernel &rclM) : MeshEvaluation( rclM ) { } + explicit MeshEvalRangePoint (const MeshKernel &rclM) : MeshEvaluation( rclM ) { } /** * Destruction. */ @@ -680,7 +680,7 @@ public: /** * Construction. */ - MeshFixRangePoint (MeshKernel &rclM) : MeshValidation( rclM ) { } + explicit MeshFixRangePoint (MeshKernel &rclM) : MeshValidation( rclM ) { } /** * Destruction. */ @@ -703,7 +703,7 @@ public: /** * Construction. */ - MeshEvalCorruptedFacets (const MeshKernel &rclM) : MeshEvaluation( rclM ) { } + explicit MeshEvalCorruptedFacets (const MeshKernel &rclM) : MeshEvaluation( rclM ) { } /** * Destruction. */ @@ -730,7 +730,7 @@ public: /** * Construction. */ - MeshFixCorruptedFacets (MeshKernel &rclM) : MeshValidation( rclM ) { } + explicit MeshFixCorruptedFacets (MeshKernel &rclM) : MeshValidation( rclM ) { } /** * Destruction. */ @@ -752,7 +752,7 @@ public: /** * Construction. */ - MeshEvalPointOnEdge (const MeshKernel &rclM) : MeshEvaluation( rclM ) { } + explicit MeshEvalPointOnEdge (const MeshKernel &rclM) : MeshEvaluation( rclM ) { } /** * Destruction. */ @@ -786,7 +786,7 @@ public: /** * Construction. */ - MeshFixPointOnEdge (MeshKernel &rclM, bool fill = false) : MeshValidation( rclM ), fillBoundary(fill) { } + explicit MeshFixPointOnEdge (MeshKernel &rclM, bool fill = false) : MeshValidation( rclM ), fillBoundary(fill) { } /** * Destruction. */ diff --git a/src/Mod/Mesh/App/Core/Elements.h b/src/Mod/Mesh/App/Core/Elements.h index ffddf36376..0dd476e1b9 100644 --- a/src/Mod/Mesh/App/Core/Elements.h +++ b/src/Mod/Mesh/App/Core/Elements.h @@ -110,7 +110,7 @@ public: //@{ MeshPoint () : _ucFlag(0), _ulProp(0) { } inline MeshPoint (float x, float y, float z); - inline MeshPoint (const Base::Vector3f &rclPt); + inline MeshPoint (const Base::Vector3f &rclPt);//explicit bombs inline MeshPoint (const MeshPoint &rclPt); ~MeshPoint () { } //@} @@ -583,7 +583,7 @@ public: // constructor MeshPointArray () { } // constructor - MeshPointArray (PointIndex ulSize) : TMeshPointArray(ulSize) { } + explicit MeshPointArray (PointIndex ulSize) : TMeshPointArray(ulSize) { } /// copy-constructor MeshPointArray (const MeshPointArray&); // Destructor @@ -637,7 +637,7 @@ public: /// constructor MeshFacetArray () { } /// constructor - MeshFacetArray (FacetIndex ulSize) : TMeshFacetArray(ulSize) { } + explicit MeshFacetArray (FacetIndex ulSize) : TMeshFacetArray(ulSize) { } /// copy-constructor MeshFacetArray (const MeshFacetArray&); /// destructor @@ -684,7 +684,7 @@ public: class MeshExport MeshPointModifier { public: - MeshPointModifier(MeshPointArray& points) + explicit MeshPointModifier(MeshPointArray& points) : rPoints(points) { } @@ -705,7 +705,7 @@ private: class MeshExport MeshFacetModifier { public: - MeshFacetModifier(MeshFacetArray& facets) + explicit MeshFacetModifier(MeshFacetArray& facets) : rFacets(facets) { } diff --git a/src/Mod/Mesh/App/Core/Evaluation.h b/src/Mod/Mesh/App/Core/Evaluation.h index 553eb13ea7..15327e631c 100644 --- a/src/Mod/Mesh/App/Core/Evaluation.h +++ b/src/Mod/Mesh/App/Core/Evaluation.h @@ -44,7 +44,7 @@ namespace MeshCore { class MeshExport MeshEvaluation { public: - MeshEvaluation (const MeshKernel &rclB) : _rclMesh(rclB) {} + explicit MeshEvaluation (const MeshKernel &rclB) : _rclMesh(rclB) {} virtual ~MeshEvaluation () {} /** @@ -70,7 +70,7 @@ protected: class MeshExport MeshValidation { public: - MeshValidation (MeshKernel &rclB) : _rclMesh(rclB) {} + explicit MeshValidation (MeshKernel &rclB) : _rclMesh(rclB) {} virtual ~MeshValidation () {} /** @@ -127,7 +127,7 @@ private: class MeshExport MeshSameOrientationCollector : public MeshOrientationVisitor { public: - MeshSameOrientationCollector(std::vector& aulIndices); + explicit MeshSameOrientationCollector(std::vector& aulIndices); /** Returns always true and collects the indices with wrong orientation. */ bool Visit (const MeshFacet &, const MeshFacet &, FacetIndex , unsigned long) override; @@ -142,7 +142,7 @@ private: class MeshExport MeshEvalOrientation : public MeshEvaluation { public: - MeshEvalOrientation (const MeshKernel& rclM); + explicit MeshEvalOrientation (const MeshKernel& rclM); ~MeshEvalOrientation() override; bool Evaluate () override; std::vector GetIndices() const; @@ -158,7 +158,7 @@ private: class MeshExport MeshFixOrientation : public MeshValidation { public: - MeshFixOrientation (MeshKernel& rclM); + explicit MeshFixOrientation (MeshKernel& rclM); ~MeshFixOrientation() override; bool Fixup() override; }; @@ -172,7 +172,7 @@ public: class MeshExport MeshEvalSolid : public MeshEvaluation { public: - MeshEvalSolid (const MeshKernel& rclM); + explicit MeshEvalSolid (const MeshKernel& rclM); ~MeshEvalSolid() override; bool Evaluate () override; }; @@ -188,7 +188,7 @@ public: class MeshExport MeshEvalTopology : public MeshEvaluation { public: - MeshEvalTopology (const MeshKernel &rclB) : MeshEvaluation(rclB) {} + explicit MeshEvalTopology (const MeshKernel &rclB) : MeshEvaluation(rclB) {} ~MeshEvalTopology () override {} bool Evaluate () override; @@ -232,7 +232,7 @@ protected: class MeshExport MeshEvalPointManifolds : public MeshEvaluation { public: - MeshEvalPointManifolds (const MeshKernel &rclB) : MeshEvaluation(rclB) {} + explicit MeshEvalPointManifolds (const MeshKernel &rclB) : MeshEvaluation(rclB) {} ~MeshEvalPointManifolds () override {} bool Evaluate () override; @@ -258,7 +258,7 @@ protected: class MeshExport MeshEvalSingleFacet : public MeshEvalTopology { public: - MeshEvalSingleFacet (const MeshKernel &rclB) : MeshEvalTopology(rclB) {} + explicit MeshEvalSingleFacet (const MeshKernel &rclB) : MeshEvalTopology(rclB) {} ~MeshEvalSingleFacet () override {} bool Evaluate () override; }; @@ -288,7 +288,7 @@ protected: class MeshExport MeshEvalSelfIntersection : public MeshEvaluation { public: - MeshEvalSelfIntersection (const MeshKernel &rclB) : MeshEvaluation(rclB) {} + explicit MeshEvalSelfIntersection (const MeshKernel &rclB) : MeshEvaluation(rclB) {} ~MeshEvalSelfIntersection () override {} /// Evaluate the mesh and return if true if there are self intersections bool Evaluate () override; @@ -326,7 +326,7 @@ private: class MeshExport MeshEvalNeighbourhood : public MeshEvaluation { public: - MeshEvalNeighbourhood (const MeshKernel &rclB) : MeshEvaluation(rclB) {} + explicit MeshEvalNeighbourhood (const MeshKernel &rclB) : MeshEvaluation(rclB) {} ~MeshEvalNeighbourhood () override {} bool Evaluate () override; std::vector GetIndices() const; @@ -339,7 +339,7 @@ public: class MeshExport MeshFixNeighbourhood : public MeshValidation { public: - MeshFixNeighbourhood (MeshKernel &rclB) : MeshValidation(rclB) {} + explicit MeshFixNeighbourhood (MeshKernel &rclB) : MeshValidation(rclB) {} ~MeshFixNeighbourhood () override {} bool Fixup() override; }; @@ -357,7 +357,7 @@ public: class MeshExport MeshEigensystem : public MeshEvaluation { public: - MeshEigensystem (const MeshKernel &rclB); + explicit MeshEigensystem (const MeshKernel &rclB); ~MeshEigensystem () override {} /** Returns the transformation matrix. */ diff --git a/src/Mod/Mesh/App/Core/Grid.h b/src/Mod/Mesh/App/Core/Grid.h index dd738afb2f..da9e198181 100644 --- a/src/Mod/Mesh/App/Core/Grid.h +++ b/src/Mod/Mesh/App/Core/Grid.h @@ -58,7 +58,7 @@ protected: /** @name Construction */ //@{ /// Construction - MeshGrid (const MeshKernel &rclM); + explicit MeshGrid (const MeshKernel &rclM); /// Construction MeshGrid (); //@} @@ -184,7 +184,7 @@ public: /** @name Construction */ //@{ /// Construction - MeshFacetGrid (const MeshKernel &rclM); + explicit MeshFacetGrid (const MeshKernel &rclM); /// Construction MeshFacetGrid () : MeshGrid() { } /// Construction @@ -247,7 +247,7 @@ public: /// Construction MeshPointGrid (); /// Construction - MeshPointGrid (const MeshKernel &rclM); + explicit MeshPointGrid (const MeshKernel &rclM); /// Construction MeshPointGrid (const MeshKernel &rclM, int iCtGridPerAxis); /// Construction @@ -288,7 +288,7 @@ class MeshExport MeshGridIterator { public: /// Construction - MeshGridIterator (const MeshGrid &rclG); + explicit MeshGridIterator (const MeshGrid &rclG); /** Returns the bounding box of the current grid element. */ Base::BoundBox3f GetBoundBox () const { return _rclGrid.GetBoundBox(_ulX, _ulY, _ulZ); } diff --git a/src/Mod/Mesh/App/Core/Info.h b/src/Mod/Mesh/App/Core/Info.h index 166d595ed7..4da36098ee 100644 --- a/src/Mod/Mesh/App/Core/Info.h +++ b/src/Mod/Mesh/App/Core/Info.h @@ -36,7 +36,7 @@ class MeshKernel; class MeshExport MeshInfo { public: - MeshInfo (const MeshKernel &rclM); + explicit MeshInfo (const MeshKernel &rclM); virtual ~MeshInfo () {} /** * Writes general information about the mesh structure into the stream. diff --git a/src/Mod/Mesh/App/Core/Iterator.h b/src/Mod/Mesh/App/Core/Iterator.h index e687b323f4..d2d79ee31e 100644 --- a/src/Mod/Mesh/App/Core/Iterator.h +++ b/src/Mod/Mesh/App/Core/Iterator.h @@ -51,7 +51,7 @@ public: /** @name Construction */ //@{ /// construction - inline MeshFacetIterator (const MeshKernel &rclM); + inline explicit MeshFacetIterator (const MeshKernel &rclM); /// construction inline MeshFacetIterator (const MeshKernel &rclM, FacetIndex ulPos); /// construction @@ -175,7 +175,7 @@ class MeshExport MeshPointIterator public: /** @name Construction */ //@{ - inline MeshPointIterator (const MeshKernel &rclM); + inline explicit MeshPointIterator (const MeshKernel &rclM); inline MeshPointIterator (const MeshKernel &rclM, PointIndex ulPos); inline MeshPointIterator (const MeshPointIterator &rclI); //@} @@ -271,7 +271,7 @@ protected: class MeshFastFacetIterator { public: - inline MeshFastFacetIterator (const MeshKernel &rclM); + inline explicit MeshFastFacetIterator (const MeshKernel &rclM); virtual ~MeshFastFacetIterator () {} void Init () { _clIter = _rclFAry.begin(); } diff --git a/src/Mod/Mesh/App/Core/KDTree.h b/src/Mod/Mesh/App/Core/KDTree.h index 0ed64ae82e..cf78a00a6f 100644 --- a/src/Mod/Mesh/App/Core/KDTree.h +++ b/src/Mod/Mesh/App/Core/KDTree.h @@ -33,8 +33,8 @@ class MeshExport MeshKDTree { public: MeshKDTree(); - MeshKDTree(const std::vector& points); - MeshKDTree(const MeshPointArray& points); + explicit MeshKDTree(const std::vector& points); + explicit MeshKDTree(const MeshPointArray& points); ~MeshKDTree(); void AddPoint(Base::Vector3f& point); diff --git a/src/Mod/Mesh/App/Core/MeshIO.h b/src/Mod/Mesh/App/Core/MeshIO.h index acd08f446b..4dccd093ad 100644 --- a/src/Mod/Mesh/App/Core/MeshIO.h +++ b/src/Mod/Mesh/App/Core/MeshIO.h @@ -92,7 +92,7 @@ struct MeshExport Group class MeshExport MeshInput { public: - MeshInput (MeshKernel &rclM) + explicit MeshInput (MeshKernel &rclM) : _rclMesh(rclM), _material(nullptr){} MeshInput (MeshKernel &rclM, Material* m) : _rclMesh(rclM), _material(m){} @@ -151,7 +151,7 @@ protected: class MeshExport MeshOutput { public: - MeshOutput (const MeshKernel &rclM) + explicit MeshOutput (const MeshKernel &rclM) : _rclMesh(rclM), _material(nullptr), apply_transform(false){} MeshOutput (const MeshKernel &rclM, const Material* m) : _rclMesh(rclM), _material(m), apply_transform(false){} diff --git a/src/Mod/Mesh/App/Core/Projection.h b/src/Mod/Mesh/App/Core/Projection.h index 0ce76df03e..3f8b686c3f 100644 --- a/src/Mod/Mesh/App/Core/Projection.h +++ b/src/Mod/Mesh/App/Core/Projection.h @@ -46,7 +46,7 @@ class MeshGeomFacet; class MeshExport MeshProjection { public: - MeshProjection(const MeshKernel&); + explicit MeshProjection(const MeshKernel&); ~MeshProjection(); bool projectLineOnMesh(const MeshFacetGrid& grid, const Base::Vector3f& p1, FacetIndex f1, diff --git a/src/Mod/Mesh/App/Core/Segmentation.h b/src/Mod/Mesh/App/Core/Segmentation.h index 543e10c4c2..de3237502e 100644 --- a/src/Mod/Mesh/App/Core/Segmentation.h +++ b/src/Mod/Mesh/App/Core/Segmentation.h @@ -40,7 +40,7 @@ typedef std::vector MeshSegment; class MeshExport MeshSurfaceSegment { public: - MeshSurfaceSegment(unsigned long minFacets) + explicit MeshSurfaceSegment(unsigned long minFacets) : minFacets(minFacets) {} virtual ~MeshSurfaceSegment() {} virtual bool TestFacet (const MeshFacet &rclFacet) const = 0; @@ -269,7 +269,7 @@ protected: class MeshExport MeshSegmentAlgorithm { public: - MeshSegmentAlgorithm(const MeshKernel& kernel) : myKernel(kernel) {} + explicit MeshSegmentAlgorithm(const MeshKernel& kernel) : myKernel(kernel) {} void FindSegments(std::vector&); private: diff --git a/src/Mod/Mesh/App/Core/Smoothing.h b/src/Mod/Mesh/App/Core/Smoothing.h index 1a6fcae5a1..7dffab3073 100644 --- a/src/Mod/Mesh/App/Core/Smoothing.h +++ b/src/Mod/Mesh/App/Core/Smoothing.h @@ -50,7 +50,7 @@ public: C2 }; - AbstractSmoothing(MeshKernel&); + explicit AbstractSmoothing(MeshKernel&); virtual ~AbstractSmoothing(); void initialize(Component comp, Continuity cont); @@ -68,7 +68,7 @@ protected: class MeshExport PlaneFitSmoothing : public AbstractSmoothing { public: - PlaneFitSmoothing(MeshKernel&); + explicit PlaneFitSmoothing(MeshKernel&); ~PlaneFitSmoothing() override; void SetMaximum(float max) { maximum = max; @@ -83,7 +83,7 @@ private: class MeshExport LaplaceSmoothing : public AbstractSmoothing { public: - LaplaceSmoothing(MeshKernel&); + explicit LaplaceSmoothing(MeshKernel&); ~LaplaceSmoothing() override; void Smooth(unsigned int) override; void SmoothPoints(unsigned int, const std::vector&) override; @@ -103,7 +103,7 @@ protected: class MeshExport TaubinSmoothing : public LaplaceSmoothing { public: - TaubinSmoothing(MeshKernel&); + explicit TaubinSmoothing(MeshKernel&); ~TaubinSmoothing() override; void Smooth(unsigned int) override; void SmoothPoints(unsigned int, const std::vector&) override; @@ -121,7 +121,7 @@ protected: class MeshExport MedianFilterSmoothing : public AbstractSmoothing { public: - MedianFilterSmoothing(MeshKernel&); + explicit MedianFilterSmoothing(MeshKernel&); ~MedianFilterSmoothing() override; void SetWeight(int w) { weights = w; diff --git a/src/Mod/Mesh/App/Core/Tools.h b/src/Mod/Mesh/App/Core/Tools.h index 09ce35acec..241efb2351 100644 --- a/src/Mod/Mesh/App/Core/Tools.h +++ b/src/Mod/Mesh/App/Core/Tools.h @@ -43,7 +43,7 @@ namespace MeshCore { class MeshSearchNeighbours { public: - MeshSearchNeighbours ( const MeshKernel &rclM, float fSampleDistance = 1.0f); + explicit MeshSearchNeighbours ( const MeshKernel &rclM, float fSampleDistance = 1.0f); virtual ~MeshSearchNeighbours () {} /** Re-initilaizes internal structures. */ void Reinit (float fSampleDistance); @@ -69,7 +69,7 @@ protected: struct CDistRad { - CDistRad (const Base::Vector3f clCenter) : _clCenter(clCenter) {} + explicit CDistRad (const Base::Vector3f clCenter) : _clCenter(clCenter) {} bool operator()(const Base::Vector3f &rclPt1, const Base::Vector3f &rclPt2) { return Base::DistanceP2(_clCenter, rclPt1) < Base::DistanceP2(_clCenter, rclPt2); } Base::Vector3f _clCenter; }; @@ -144,7 +144,7 @@ inline bool MeshSearchNeighbours::TriangleCutsSphere (const MeshFacet &rclF) con class MeshFaceIterator { public: - MeshFaceIterator(const MeshKernel& mesh) + explicit MeshFaceIterator(const MeshKernel& mesh) : it(mesh) {} Base::Vector3f operator() (FacetIndex index) { @@ -159,7 +159,7 @@ private: class MeshVertexIterator { public: - MeshVertexIterator(const MeshKernel& mesh) + explicit MeshVertexIterator(const MeshKernel& mesh) : it(mesh) {} Base::Vector3f operator() (PointIndex index) { diff --git a/src/Mod/Mesh/App/Core/TopoAlgorithm.h b/src/Mod/Mesh/App/Core/TopoAlgorithm.h index 778db23a21..153dca1ecf 100644 --- a/src/Mod/Mesh/App/Core/TopoAlgorithm.h +++ b/src/Mod/Mesh/App/Core/TopoAlgorithm.h @@ -52,7 +52,7 @@ class MeshExport MeshTopoAlgorithm { public: // construction/destruction - MeshTopoAlgorithm (MeshKernel &rclM); + explicit MeshTopoAlgorithm (MeshKernel &rclM); virtual ~MeshTopoAlgorithm (); public: @@ -336,7 +336,7 @@ class MeshExport MeshComponents public: enum TMode {OverEdge, OverPoint}; - MeshComponents( const MeshKernel& rclMesh ); + explicit MeshComponents( const MeshKernel& rclMesh ); ~MeshComponents(); /** diff --git a/src/Mod/Mesh/App/Core/Triangulation.h b/src/Mod/Mesh/App/Core/Triangulation.h index 3ac1bb168a..0c8fc4c1fa 100644 --- a/src/Mod/Mesh/App/Core/Triangulation.h +++ b/src/Mod/Mesh/App/Core/Triangulation.h @@ -222,7 +222,7 @@ protected: class MeshExport ConstraintDelaunayTriangulator : public AbstractPolygonTriangulator { public: - ConstraintDelaunayTriangulator(float area); + explicit ConstraintDelaunayTriangulator(float area); ~ConstraintDelaunayTriangulator() override; protected: diff --git a/src/Mod/Mesh/App/Core/TrimByPlane.h b/src/Mod/Mesh/App/Core/TrimByPlane.h index c868570e8f..642336de7e 100644 --- a/src/Mod/Mesh/App/Core/TrimByPlane.h +++ b/src/Mod/Mesh/App/Core/TrimByPlane.h @@ -35,7 +35,7 @@ namespace MeshCore { class MeshExport MeshTrimByPlane { public: - MeshTrimByPlane(MeshKernel& mesh); + explicit MeshTrimByPlane(MeshKernel& mesh); ~MeshTrimByPlane(); public: diff --git a/src/Mod/Mesh/App/Core/Utilities.h b/src/Mod/Mesh/App/Core/Utilities.h index 0ed6f838d1..84804b2208 100644 --- a/src/Mod/Mesh/App/Core/Utilities.h +++ b/src/Mod/Mesh/App/Core/Utilities.h @@ -33,7 +33,7 @@ template <> struct vec_traits { typedef Wm4::Vector3d vec_type; typedef double float_type; - vec_traits(const vec_type& v) : v(v){} + explicit vec_traits(const vec_type& v) : v(v){} inline std::tuple get() const { return std::make_tuple(v.X(), v.Y(), v.Z()); } @@ -45,7 +45,7 @@ template <> struct vec_traits { typedef Wm4::Vector3f vec_type; typedef float float_type; - vec_traits(const vec_type& v) : v(v){} + explicit vec_traits(const vec_type& v) : v(v){} inline std::tuple get() const { return std::make_tuple(v.X(), v.Y(), v.Z()); } diff --git a/src/Mod/Mesh/App/Facet.h b/src/Mod/Mesh/App/Facet.h index e21dcb1d01..5873530119 100644 --- a/src/Mod/Mesh/App/Facet.h +++ b/src/Mod/Mesh/App/Facet.h @@ -43,7 +43,7 @@ class MeshObject; class MeshExport Facet : public MeshCore::MeshGeomFacet { public: - Facet(const MeshCore::MeshFacet& face = MeshCore::MeshFacet(), const MeshObject* obj = nullptr, MeshCore::FacetIndex index = MeshCore::FACET_INDEX_MAX); + explicit Facet(const MeshCore::MeshFacet& face = MeshCore::MeshFacet(), const MeshObject* obj = nullptr, MeshCore::FacetIndex index = MeshCore::FACET_INDEX_MAX); Facet(const Facet& f); ~Facet(); diff --git a/src/Mod/Mesh/App/Importer.h b/src/Mod/Mesh/App/Importer.h index e40afd79c9..6b3c5f1d6f 100644 --- a/src/Mod/Mesh/App/Importer.h +++ b/src/Mod/Mesh/App/Importer.h @@ -42,7 +42,7 @@ class Feature; class Importer { public: - Importer(App::Document*); + explicit Importer(App::Document*); ~Importer() = default; void load(const std::string& fileName); diff --git a/src/Mod/Mesh/App/MeshPoint.h b/src/Mod/Mesh/App/MeshPoint.h index e576f5cbc6..5cf418431d 100644 --- a/src/Mod/Mesh/App/MeshPoint.h +++ b/src/Mod/Mesh/App/MeshPoint.h @@ -49,7 +49,7 @@ class MeshExport MeshPoint : public Vector3d public: /// simple constructor - MeshPoint(const Vector3d& vec = Vector3d(), const MeshObject* obj = nullptr, unsigned int index = UINT_MAX) + explicit MeshPoint(const Vector3d& vec = Vector3d(), const MeshObject* obj = nullptr, unsigned int index = UINT_MAX) :Vector3d(vec),Index(index),Mesh(obj) {} diff --git a/src/Mod/Mesh/App/MeshPyImp.cpp b/src/Mod/Mesh/App/MeshPyImp.cpp index 56f52997e7..cc62c3d08b 100644 --- a/src/Mod/Mesh/App/MeshPyImp.cpp +++ b/src/Mod/Mesh/App/MeshPyImp.cpp @@ -54,7 +54,7 @@ using namespace Mesh; struct MeshPropertyLock { - MeshPropertyLock(PropertyMeshKernel* p) : prop(p) + explicit MeshPropertyLock(PropertyMeshKernel* p) : prop(p) { if (prop) prop->startEditing(); } ~MeshPropertyLock() { if (prop) prop->finishEditing(); } diff --git a/src/Mod/Mesh/Gui/DlgDecimating.h b/src/Mod/Mesh/Gui/DlgDecimating.h index e0420cb4f7..0e1133cec0 100644 --- a/src/Mod/Mesh/Gui/DlgDecimating.h +++ b/src/Mod/Mesh/Gui/DlgDecimating.h @@ -36,7 +36,7 @@ class DlgDecimating : public QWidget Q_OBJECT public: - DlgDecimating(QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); + explicit DlgDecimating(QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); ~DlgDecimating() override; void setNumberOfTriangles(int); double tolerance() const; diff --git a/src/Mod/Mesh/Gui/DlgEvaluateMeshImp.h b/src/Mod/Mesh/Gui/DlgEvaluateMeshImp.h index dfe656bc71..eac2b12a1d 100644 --- a/src/Mod/Mesh/Gui/DlgEvaluateMeshImp.h +++ b/src/Mod/Mesh/Gui/DlgEvaluateMeshImp.h @@ -70,7 +70,7 @@ class DlgEvaluateMeshImp : public QDialog, public App::DocumentObserver Q_OBJECT public: - DlgEvaluateMeshImp(QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); + explicit DlgEvaluateMeshImp(QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); ~DlgEvaluateMeshImp() override; void setMesh(Mesh::Feature*); @@ -148,7 +148,7 @@ class DockEvaluateMeshImp : public DlgEvaluateMeshImp Q_OBJECT protected: - DockEvaluateMeshImp( QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags() ); + explicit DockEvaluateMeshImp( QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags() ); ~DockEvaluateMeshImp() override; void closeEvent(QCloseEvent* e) override; diff --git a/src/Mod/Mesh/Gui/DlgEvaluateSettings.h b/src/Mod/Mesh/Gui/DlgEvaluateSettings.h index 84edaca231..18685c4a54 100644 --- a/src/Mod/Mesh/Gui/DlgEvaluateSettings.h +++ b/src/Mod/Mesh/Gui/DlgEvaluateSettings.h @@ -38,7 +38,7 @@ class DlgEvaluateSettings : public QDialog Q_OBJECT public: - DlgEvaluateSettings(QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); + explicit DlgEvaluateSettings(QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); ~DlgEvaluateSettings() override; void setNonmanifoldPointsChecked(bool); diff --git a/src/Mod/Mesh/Gui/DlgRegularSolidImp.h b/src/Mod/Mesh/Gui/DlgRegularSolidImp.h index 0b3c996f1a..2212f1c4d0 100644 --- a/src/Mod/Mesh/Gui/DlgRegularSolidImp.h +++ b/src/Mod/Mesh/Gui/DlgRegularSolidImp.h @@ -34,7 +34,7 @@ class DlgRegularSolidImp : public QDialog Q_OBJECT public: - DlgRegularSolidImp(QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); + explicit DlgRegularSolidImp(QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); ~DlgRegularSolidImp() override; public Q_SLOTS: diff --git a/src/Mod/Mesh/Gui/DlgSettingsImportExportImp.h b/src/Mod/Mesh/Gui/DlgSettingsImportExportImp.h index 455b486e1f..b835f32bd4 100644 --- a/src/Mod/Mesh/Gui/DlgSettingsImportExportImp.h +++ b/src/Mod/Mesh/Gui/DlgSettingsImportExportImp.h @@ -41,7 +41,7 @@ class DlgSettingsImportExport : public Gui::Dialog::PreferencePage Q_OBJECT public: - DlgSettingsImportExport(QWidget* parent = nullptr); + explicit DlgSettingsImportExport(QWidget* parent = nullptr); ~DlgSettingsImportExport() override; protected: diff --git a/src/Mod/Mesh/Gui/DlgSettingsMeshView.h b/src/Mod/Mesh/Gui/DlgSettingsMeshView.h index c8f5fd7cdd..68f209f178 100644 --- a/src/Mod/Mesh/Gui/DlgSettingsMeshView.h +++ b/src/Mod/Mesh/Gui/DlgSettingsMeshView.h @@ -42,7 +42,7 @@ class DlgSettingsMeshView : public Gui::Dialog::PreferencePage Q_OBJECT public: - DlgSettingsMeshView(QWidget* parent = nullptr); + explicit DlgSettingsMeshView(QWidget* parent = nullptr); ~DlgSettingsMeshView() override; protected: diff --git a/src/Mod/Mesh/Gui/DlgSmoothing.h b/src/Mod/Mesh/Gui/DlgSmoothing.h index 9cca46b606..4172794427 100644 --- a/src/Mod/Mesh/Gui/DlgSmoothing.h +++ b/src/Mod/Mesh/Gui/DlgSmoothing.h @@ -49,7 +49,7 @@ public: MedianFilter }; - DlgSmoothing(QWidget* parent = nullptr); + explicit DlgSmoothing(QWidget* parent = nullptr); ~DlgSmoothing() override; int iterations() const; double lambdaStep() const; @@ -77,7 +77,7 @@ class MeshGuiExport SmoothingDialog : public QDialog Q_OBJECT public: - SmoothingDialog(QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); + explicit SmoothingDialog(QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); ~SmoothingDialog() override; int iterations() const diff --git a/src/Mod/Mesh/Gui/MeshEditor.h b/src/Mod/Mesh/Gui/MeshEditor.h index 0b2e6b61c5..f102014b8b 100644 --- a/src/Mod/Mesh/Gui/MeshEditor.h +++ b/src/Mod/Mesh/Gui/MeshEditor.h @@ -79,7 +79,7 @@ class MeshGuiExport MeshFaceAddition : public QObject Q_OBJECT public: - MeshFaceAddition(Gui::View3DInventor* parent); + explicit MeshFaceAddition(Gui::View3DInventor* parent); ~MeshFaceAddition() override; void startEditing(ViewProviderMesh*); diff --git a/src/Mod/Mesh/Gui/RemeshGmsh.cpp b/src/Mod/Mesh/Gui/RemeshGmsh.cpp index 2ef375aba1..2d571dcf09 100644 --- a/src/Mod/Mesh/Gui/RemeshGmsh.cpp +++ b/src/Mod/Mesh/Gui/RemeshGmsh.cpp @@ -50,7 +50,7 @@ using namespace MeshGui; class GmshWidget::Private { public: - Private(QWidget* parent) + explicit Private(QWidget* parent) : gmsh(parent) { /* coverity[uninit_ctor] Members of ui are set in setupUI() */ @@ -270,7 +270,7 @@ void GmshWidget::reject() class RemeshGmsh::Private { public: - Private(Mesh::Feature* mesh) + explicit Private(Mesh::Feature* mesh) : mesh(mesh) { } diff --git a/src/Mod/Mesh/Gui/RemeshGmsh.h b/src/Mod/Mesh/Gui/RemeshGmsh.h index 98d1cf4c23..ef9f125fc1 100644 --- a/src/Mod/Mesh/Gui/RemeshGmsh.h +++ b/src/Mod/Mesh/Gui/RemeshGmsh.h @@ -52,7 +52,7 @@ class MeshGuiExport GmshWidget : public QWidget Q_OBJECT public: - GmshWidget(QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); + explicit GmshWidget(QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); ~GmshWidget() override; void accept(); void reject(); @@ -90,7 +90,7 @@ class MeshGuiExport RemeshGmsh : public GmshWidget Q_OBJECT public: - RemeshGmsh(Mesh::Feature* mesh, QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); + explicit RemeshGmsh(Mesh::Feature* mesh, QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); ~RemeshGmsh() override; protected: @@ -110,7 +110,7 @@ class TaskRemeshGmsh : public Gui::TaskView::TaskDialog Q_OBJECT public: - TaskRemeshGmsh(Mesh::Feature* mesh); + explicit TaskRemeshGmsh(Mesh::Feature* mesh); ~TaskRemeshGmsh() override; public: diff --git a/src/Mod/Mesh/Gui/RemoveComponents.h b/src/Mod/Mesh/Gui/RemoveComponents.h index ee683ef5d3..bc470af224 100644 --- a/src/Mod/Mesh/Gui/RemoveComponents.h +++ b/src/Mod/Mesh/Gui/RemoveComponents.h @@ -42,7 +42,7 @@ class MeshGuiExport RemoveComponents : public QWidget Q_OBJECT public: - RemoveComponents(QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); + explicit RemoveComponents(QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); ~RemoveComponents() override; void reject(); void deleteSelection(); @@ -78,7 +78,7 @@ class MeshGuiExport RemoveComponentsDialog : public QDialog Q_OBJECT public: - RemoveComponentsDialog(QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); + explicit RemoveComponentsDialog(QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); ~RemoveComponentsDialog() override; void reject() override; diff --git a/src/Mod/Mesh/Gui/Segmentation.h b/src/Mod/Mesh/Gui/Segmentation.h index 04e8113fad..2686f8f270 100644 --- a/src/Mod/Mesh/Gui/Segmentation.h +++ b/src/Mod/Mesh/Gui/Segmentation.h @@ -40,7 +40,7 @@ class Ui_Segmentation; class MeshGuiExport Segmentation : public QWidget { public: - Segmentation(Mesh::Feature* mesh, QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); + explicit Segmentation(Mesh::Feature* mesh, QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); ~Segmentation() override; void accept(); @@ -58,7 +58,7 @@ private: class TaskSegmentation : public Gui::TaskView::TaskDialog { public: - TaskSegmentation(Mesh::Feature* mesh); + explicit TaskSegmentation(Mesh::Feature* mesh); ~TaskSegmentation() override; public: diff --git a/src/Mod/Mesh/Gui/SegmentationBestFit.h b/src/Mod/Mesh/Gui/SegmentationBestFit.h index 604679ea6d..9a09fcbe04 100644 --- a/src/Mod/Mesh/Gui/SegmentationBestFit.h +++ b/src/Mod/Mesh/Gui/SegmentationBestFit.h @@ -82,7 +82,7 @@ class MeshGuiExport SegmentationBestFit : public QWidget Q_OBJECT public: - SegmentationBestFit(Mesh::Feature* mesh, QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); + explicit SegmentationBestFit(Mesh::Feature* mesh, QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); ~SegmentationBestFit() override; void accept(); @@ -109,7 +109,7 @@ private: class TaskSegmentationBestFit : public Gui::TaskView::TaskDialog { public: - TaskSegmentationBestFit(Mesh::Feature* mesh); + explicit TaskSegmentationBestFit(Mesh::Feature* mesh); ~TaskSegmentationBestFit() override; public: diff --git a/src/Mod/Mesh/Gui/Selection.h b/src/Mod/Mesh/Gui/Selection.h index 2fda69cd41..3ef79fb70a 100644 --- a/src/Mod/Mesh/Gui/Selection.h +++ b/src/Mod/Mesh/Gui/Selection.h @@ -40,7 +40,7 @@ class Selection : public QWidget Q_OBJECT public: - Selection(QWidget* parent = nullptr); + explicit Selection(QWidget* parent = nullptr); ~Selection() override; void setObjects(const std::vector&); std::vector getObjects() const; diff --git a/src/Mod/Mesh/Gui/SoFCMeshObject.cpp b/src/Mod/Mesh/Gui/SoFCMeshObject.cpp index ec1020fa0b..b5ca99e379 100644 --- a/src/Mod/Mesh/Gui/SoFCMeshObject.cpp +++ b/src/Mod/Mesh/Gui/SoFCMeshObject.cpp @@ -71,7 +71,7 @@ using namespace MeshGui; class SoOutputStreambuf : public std::streambuf { public: - SoOutputStreambuf(SoOutput* o) : out(o) + explicit SoOutputStreambuf(SoOutput* o) : out(o) { } protected: @@ -96,7 +96,7 @@ private: class SoOutputStream : public std::ostream { public: - SoOutputStream(SoOutput* o) : std::ostream(nullptr), buf(o) + explicit SoOutputStream(SoOutput* o) : std::ostream(nullptr), buf(o) { this->rdbuf(&buf); } @@ -107,7 +107,7 @@ private: class SoInputStreambuf : public std::streambuf { public: - SoInputStreambuf(SoInput* o) : inp(o) + explicit SoInputStreambuf(SoInput* o) : inp(o) { setg (buffer+pbSize, buffer+pbSize, @@ -160,7 +160,7 @@ private: class SoInputStream : public std::istream { public: - SoInputStream(SoInput* o) : std::istream(nullptr), buf(o) + explicit SoInputStream(SoInput* o) : std::istream(nullptr), buf(o) { this->rdbuf(&buf); } diff --git a/src/Mod/MeshPart/App/CurveProjector.h b/src/Mod/MeshPart/App/CurveProjector.h index 82ac976421..d460bd904a 100644 --- a/src/Mod/MeshPart/App/CurveProjector.h +++ b/src/Mod/MeshPart/App/CurveProjector.h @@ -177,7 +177,7 @@ public: }; /// Construction - MeshProjection(const MeshKernel& rMesh); + explicit MeshProjection(const MeshKernel& rMesh); /// Destruction ~MeshProjection(); diff --git a/src/Mod/MeshPart/App/Mesher.h b/src/Mod/MeshPart/App/Mesher.h index a889a9f265..43bc6929d7 100644 --- a/src/Mod/MeshPart/App/Mesher.h +++ b/src/Mod/MeshPart/App/Mesher.h @@ -48,7 +48,7 @@ public: Standard = 3 }; - Mesher(const TopoDS_Shape&); + explicit Mesher(const TopoDS_Shape&); ~Mesher(); void setMethod(Method m) diff --git a/src/Mod/MeshPart/Gui/CrossSections.h b/src/Mod/MeshPart/Gui/CrossSections.h index 3edf7254b0..d089e6ac57 100644 --- a/src/Mod/MeshPart/Gui/CrossSections.h +++ b/src/Mod/MeshPart/Gui/CrossSections.h @@ -44,7 +44,7 @@ class CrossSections : public QDialog enum Plane { XY, XZ, YZ }; public: - CrossSections(const Base::BoundBox3d& bb, QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); + explicit CrossSections(const Base::BoundBox3d& bb, QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); ~CrossSections() override; void accept() override; void apply(); @@ -82,7 +82,7 @@ class TaskCrossSections : public Gui::TaskView::TaskDialog Q_OBJECT public: - TaskCrossSections(const Base::BoundBox3d& bb); + explicit TaskCrossSections(const Base::BoundBox3d& bb); ~TaskCrossSections() override; public: diff --git a/src/Mod/MeshPart/Gui/CurveOnMesh.h b/src/Mod/MeshPart/Gui/CurveOnMesh.h index 84ef842105..d98bbe1faa 100644 --- a/src/Mod/MeshPart/Gui/CurveOnMesh.h +++ b/src/Mod/MeshPart/Gui/CurveOnMesh.h @@ -68,7 +68,7 @@ class CurveOnMeshHandler : public QObject Q_OBJECT public: - CurveOnMeshHandler(QObject* parent = nullptr); + explicit CurveOnMeshHandler(QObject* parent = nullptr); ~CurveOnMeshHandler() override; void enableApproximation(bool); void setParameters(int maxDegree, GeomAbs_Shape cont, double tol3d, double angle); diff --git a/src/Mod/MeshPart/Gui/TaskCurveOnMesh.h b/src/Mod/MeshPart/Gui/TaskCurveOnMesh.h index 7587e37c90..d82869f315 100644 --- a/src/Mod/MeshPart/Gui/TaskCurveOnMesh.h +++ b/src/Mod/MeshPart/Gui/TaskCurveOnMesh.h @@ -42,7 +42,7 @@ class CurveOnMeshWidget : public QWidget Q_OBJECT public: - CurveOnMeshWidget(Gui::View3DInventor* view, QWidget* parent=nullptr); + explicit CurveOnMeshWidget(Gui::View3DInventor* view, QWidget* parent=nullptr); ~CurveOnMeshWidget() override; void reject(); @@ -65,7 +65,7 @@ class TaskCurveOnMesh : public Gui::TaskView::TaskDialog Q_OBJECT public: - TaskCurveOnMesh(Gui::View3DInventor* view); + explicit TaskCurveOnMesh(Gui::View3DInventor* view); ~TaskCurveOnMesh() override; public: diff --git a/src/Mod/MeshPart/Gui/Tessellation.h b/src/Mod/MeshPart/Gui/Tessellation.h index 5da6e128a2..bee0b1f1eb 100644 --- a/src/Mod/MeshPart/Gui/Tessellation.h +++ b/src/Mod/MeshPart/Gui/Tessellation.h @@ -47,7 +47,7 @@ class Mesh2ShapeGmsh : public MeshGui::GmshWidget Q_OBJECT public: - Mesh2ShapeGmsh(QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); + explicit Mesh2ShapeGmsh(QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); ~Mesh2ShapeGmsh() override; void process(App::Document* doc, const std::list&); @@ -77,7 +77,7 @@ class Tessellation : public QWidget }; public: - Tessellation(QWidget* parent = nullptr); + explicit Tessellation(QWidget* parent = nullptr); ~Tessellation() override; bool accept(); diff --git a/src/Mod/Part/App/AttachExtension.h b/src/Mod/Part/App/AttachExtension.h index 95066f1443..c93521363d 100644 --- a/src/Mod/Part/App/AttachExtension.h +++ b/src/Mod/Part/App/AttachExtension.h @@ -46,8 +46,8 @@ class PartExport AttachEngineException : public Base::Exception public: /// Construction AttachEngineException(); - AttachEngineException(const char * sMessage); - AttachEngineException(const std::string& sMessage); + explicit AttachEngineException(const char * sMessage); + explicit AttachEngineException(const std::string& sMessage); /// Destruction ~AttachEngineException() throw() override {} }; diff --git a/src/Mod/Part/App/Attacher.h b/src/Mod/Part/App/Attacher.h index 9d9b79acca..dd62bb7ead 100644 --- a/src/Mod/Part/App/Attacher.h +++ b/src/Mod/Part/App/Attacher.h @@ -465,7 +465,7 @@ class ExceptionCancel : public Base::Exception { public: ExceptionCancel(){} - ExceptionCancel(char* msg){this->setMessage(msg);} + explicit ExceptionCancel(char* msg){this->setMessage(msg);} ~ExceptionCancel() throw() override {} }; diff --git a/src/Mod/Part/App/Geometry.h b/src/Mod/Part/App/Geometry.h index 84df0bb2e8..31c81a515f 100644 --- a/src/Mod/Part/App/Geometry.h +++ b/src/Mod/Part/App/Geometry.h @@ -1080,7 +1080,7 @@ class PartExport GeomSurfaceOfExtrusion : public GeomSurface public: GeomSurfaceOfExtrusion(); GeomSurfaceOfExtrusion(const Handle(Geom_Curve)&, const gp_Dir&); - GeomSurfaceOfExtrusion(const Handle(Geom_SurfaceOfLinearExtrusion)&); + explicit GeomSurfaceOfExtrusion(const Handle(Geom_SurfaceOfLinearExtrusion)&); ~GeomSurfaceOfExtrusion() override; Geometry *copy() const override; diff --git a/src/Mod/Part/App/Geometry2d.h b/src/Mod/Part/App/Geometry2d.h index 5d7fb30f77..d8605dfdf6 100644 --- a/src/Mod/Part/App/Geometry2d.h +++ b/src/Mod/Part/App/Geometry2d.h @@ -551,7 +551,7 @@ class PartExport Geom2dTrimmedCurve : public Geom2dCurve TYPESYSTEM_HEADER_WITH_OVERRIDE(); public: Geom2dTrimmedCurve(); - Geom2dTrimmedCurve(const Handle(Geom2d_TrimmedCurve)&); + explicit Geom2dTrimmedCurve(const Handle(Geom2d_TrimmedCurve)&); ~Geom2dTrimmedCurve() override; Geometry2d *clone() const override; diff --git a/src/Mod/Part/App/GeometryDefaultExtension.h b/src/Mod/Part/App/GeometryDefaultExtension.h index 80d7b41d5e..44c0c3d190 100644 --- a/src/Mod/Part/App/GeometryDefaultExtension.h +++ b/src/Mod/Part/App/GeometryDefaultExtension.h @@ -35,7 +35,7 @@ namespace Part { TYPESYSTEM_HEADER_WITH_OVERRIDE(); public: inline GeometryDefaultExtension(); - GeometryDefaultExtension(const T& val, std::string name = std::string()); + explicit GeometryDefaultExtension(const T& val, std::string name = std::string()); ~GeometryDefaultExtension() override = default; inline void setValue(const T& val) {value = val;}; diff --git a/src/Mod/Part/App/PrimitiveFeature.cpp b/src/Mod/Part/App/PrimitiveFeature.cpp index 571023ebe1..34b5bc7e2d 100644 --- a/src/Mod/Part/App/PrimitiveFeature.cpp +++ b/src/Mod/Part/App/PrimitiveFeature.cpp @@ -97,7 +97,7 @@ App::DocumentObjectExecReturn* Primitive::execute() { namespace Part { PYTHON_TYPE_DEF(PrimitivePy, PartFeaturePy) PYTHON_TYPE_IMP(PrimitivePy, PartFeaturePy) -} +}//explicit bombs #if defined(__clang__) # pragma clang diagnostic pop diff --git a/src/Mod/Part/App/Tools.h b/src/Mod/Part/App/Tools.h index 7ca1eee67e..8510d19885 100644 --- a/src/Mod/Part/App/Tools.h +++ b/src/Mod/Part/App/Tools.h @@ -52,7 +52,7 @@ template <> struct vec_traits { typedef gp_Pnt vec_type; typedef double float_type; - vec_traits(const vec_type& v) : v(v){} + explicit vec_traits(const vec_type& v) : v(v){} inline std::tuple get() const { return std::make_tuple(v.X(), v.Y(), v.Z()); } @@ -64,7 +64,7 @@ template <> struct vec_traits { typedef gp_Vec vec_type; typedef double float_type; - vec_traits(const vec_type& v) : v(v){} + explicit vec_traits(const vec_type& v) : v(v){} inline std::tuple get() const { return std::make_tuple(v.X(), v.Y(), v.Z()); } @@ -76,7 +76,7 @@ template <> struct vec_traits { typedef gp_Dir vec_type; typedef double float_type; - vec_traits(const vec_type& v) : v(v){} + explicit vec_traits(const vec_type& v) : v(v){} inline std::tuple get() const { return std::make_tuple(v.X(), v.Y(), v.Z()); } @@ -88,7 +88,7 @@ template <> struct vec_traits { typedef gp_XYZ vec_type; typedef double float_type; - vec_traits(const vec_type& v) : v(v){} + explicit vec_traits(const vec_type& v) : v(v){} inline std::tuple get() const { return std::make_tuple(v.X(), v.Y(), v.Z()); } diff --git a/src/Mod/Part/App/TopoShape.cpp b/src/Mod/Part/App/TopoShape.cpp index 770be905ad..9794fb3427 100644 --- a/src/Mod/Part/App/TopoShape.cpp +++ b/src/Mod/Part/App/TopoShape.cpp @@ -3378,7 +3378,7 @@ struct MeshVertex : x(X),y(Y),z(Z),i(0) { } - MeshVertex(const Base::Vector3d& p) + explicit MeshVertex(const Base::Vector3d& p) : x(p.x),y(p.y),z(p.z),i(0) { } diff --git a/src/Mod/Part/App/TopoShape.h b/src/Mod/Part/App/TopoShape.h index c9749856bb..21a377350a 100644 --- a/src/Mod/Part/App/TopoShape.h +++ b/src/Mod/Part/App/TopoShape.h @@ -54,8 +54,8 @@ class PartExport NullShapeException : public Base::ValueError public: /// Construction NullShapeException(); - NullShapeException(const char * sMessage); - NullShapeException(const std::string& sMessage); + explicit NullShapeException(const char * sMessage); + explicit NullShapeException(const std::string& sMessage); /// Destruction ~NullShapeException() throw() override {} }; @@ -67,8 +67,8 @@ class PartExport BooleanException : public Base::CADKernelError public: /// Construction BooleanException(); - BooleanException(const char * sMessage); - BooleanException(const std::string& sMessage); + explicit BooleanException(const char * sMessage); + explicit BooleanException(const std::string& sMessage); /// Destruction ~BooleanException() throw() override {} }; @@ -95,7 +95,7 @@ class PartExport TopoShape : public Data::ComplexGeoData public: TopoShape(); - TopoShape(const TopoDS_Shape&); + TopoShape(const TopoDS_Shape&);//explicit bombs TopoShape(const TopoShape&); ~TopoShape() override; diff --git a/src/Mod/Part/App/edgecluster.h b/src/Mod/Part/App/edgecluster.h index bed7dbc048..7a93164279 100644 --- a/src/Mod/Part/App/edgecluster.h +++ b/src/Mod/Part/App/edgecluster.h @@ -61,7 +61,7 @@ typedef std::vector > tEdgeClusterVector; class PartExport Edgecluster { public: - Edgecluster(const std::vector& usorted_edges); + explicit Edgecluster(const std::vector& usorted_edges); virtual ~Edgecluster(); tEdgeClusterVector GetClusters(); diff --git a/src/Mod/Part/Gui/CrossSections.h b/src/Mod/Part/Gui/CrossSections.h index 4aa5d618f5..104e591c99 100644 --- a/src/Mod/Part/Gui/CrossSections.h +++ b/src/Mod/Part/Gui/CrossSections.h @@ -46,7 +46,7 @@ class CrossSections : public QDialog enum Plane { XY, XZ, YZ }; public: - CrossSections(const Base::BoundBox3d& bb, QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); + explicit CrossSections(const Base::BoundBox3d& bb, QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); ~CrossSections() override; void accept() override; void apply(); @@ -84,7 +84,7 @@ class TaskCrossSections : public Gui::TaskView::TaskDialog Q_OBJECT public: - TaskCrossSections(const Base::BoundBox3d& bb); + explicit TaskCrossSections(const Base::BoundBox3d& bb); ~TaskCrossSections() override; public: diff --git a/src/Mod/Part/Gui/DlgBooleanOperation.cpp b/src/Mod/Part/Gui/DlgBooleanOperation.cpp index c10abe960f..9d3fa9fa74 100644 --- a/src/Mod/Part/Gui/DlgBooleanOperation.cpp +++ b/src/Mod/Part/Gui/DlgBooleanOperation.cpp @@ -52,7 +52,7 @@ namespace PartGui { class BooleanOperationItem : public QTreeWidgetItem { public: - BooleanOperationItem(int type = Type) + explicit BooleanOperationItem(int type = Type) : QTreeWidgetItem(type) { } diff --git a/src/Mod/Part/Gui/DlgBooleanOperation.h b/src/Mod/Part/Gui/DlgBooleanOperation.h index 2840fdea9b..cc3bacd37c 100644 --- a/src/Mod/Part/Gui/DlgBooleanOperation.h +++ b/src/Mod/Part/Gui/DlgBooleanOperation.h @@ -42,7 +42,7 @@ class DlgBooleanOperation : public QWidget Q_OBJECT public: - DlgBooleanOperation(QWidget* parent = nullptr); + explicit DlgBooleanOperation(QWidget* parent = nullptr); ~DlgBooleanOperation() override; void accept(); diff --git a/src/Mod/Part/Gui/DlgFilletEdges.cpp b/src/Mod/Part/Gui/DlgFilletEdges.cpp index 64c3f0bc9c..f204995f6a 100644 --- a/src/Mod/Part/Gui/DlgFilletEdges.cpp +++ b/src/Mod/Part/Gui/DlgFilletEdges.cpp @@ -170,7 +170,7 @@ namespace PartGui { bool allowEdge; App::DocumentObject*& object; public: - EdgeFaceSelection(App::DocumentObject*& obj) + explicit EdgeFaceSelection(App::DocumentObject*& obj) : Gui::SelectionFilterGate(nullPointer()), allowEdge(true), object(obj) { } @@ -214,7 +214,7 @@ namespace PartGui { { public: App::DocumentObject* obj; - SelectionObjectCompare(App::DocumentObject* obj) : obj(obj) + explicit SelectionObjectCompare(App::DocumentObject* obj) : obj(obj) { } bool operator()(const Gui::SelectionObject& sel) const diff --git a/src/Mod/Part/Gui/DlgFilletEdges.h b/src/Mod/Part/Gui/DlgFilletEdges.h index 240edd9060..d2c2d3b8f6 100644 --- a/src/Mod/Part/Gui/DlgFilletEdges.h +++ b/src/Mod/Part/Gui/DlgFilletEdges.h @@ -47,7 +47,7 @@ class FilletRadiusDelegate : public QItemDelegate Q_OBJECT public: - FilletRadiusDelegate(QObject *parent = nullptr); + explicit FilletRadiusDelegate(QObject *parent = nullptr); QWidget *createEditor(QWidget *parent, const QStyleOptionViewItem &option, const QModelIndex &index) const override; @@ -65,7 +65,7 @@ class FilletRadiusModel : public QStandardItemModel Q_OBJECT public: - FilletRadiusModel(QObject * parent = nullptr); + explicit FilletRadiusModel(QObject * parent = nullptr); Qt::ItemFlags flags (const QModelIndex & index) const override; bool setData (const QModelIndex & index, const QVariant & value, @@ -137,7 +137,7 @@ class DlgChamferEdges : public DlgFilletEdges Q_OBJECT public: - DlgChamferEdges(Part::FilletBase*, QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); + explicit DlgChamferEdges(Part::FilletBase*, QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); ~DlgChamferEdges() override; protected: @@ -149,7 +149,7 @@ class TaskFilletEdges : public Gui::TaskView::TaskDialog Q_OBJECT public: - TaskFilletEdges(Part::Fillet*); + explicit TaskFilletEdges(Part::Fillet*); ~TaskFilletEdges() override; public: @@ -173,7 +173,7 @@ class TaskChamferEdges : public Gui::TaskView::TaskDialog Q_OBJECT public: - TaskChamferEdges(Part::Chamfer*); + explicit TaskChamferEdges(Part::Chamfer*); ~TaskChamferEdges() override; public: diff --git a/src/Mod/Part/Gui/DlgPartBoxImp.h b/src/Mod/Part/Gui/DlgPartBoxImp.h index c2ebf6de86..95a8fbf3b5 100644 --- a/src/Mod/Part/Gui/DlgPartBoxImp.h +++ b/src/Mod/Part/Gui/DlgPartBoxImp.h @@ -34,7 +34,7 @@ class DlgPartBoxImp : public Gui::LocationDialogUiImp Q_OBJECT public: - DlgPartBoxImp(QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); + explicit DlgPartBoxImp(QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); ~DlgPartBoxImp() override; }; diff --git a/src/Mod/Part/Gui/DlgPartCylinderImp.h b/src/Mod/Part/Gui/DlgPartCylinderImp.h index 6d590418a9..a83671ac5c 100644 --- a/src/Mod/Part/Gui/DlgPartCylinderImp.h +++ b/src/Mod/Part/Gui/DlgPartCylinderImp.h @@ -34,7 +34,7 @@ class DlgPartCylinderImp : public Gui::LocationDialogUiImp Q_OBJECT public: - DlgPartCylinderImp(QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); + explicit DlgPartCylinderImp(QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); ~DlgPartCylinderImp() override; double getRadius() const; diff --git a/src/Mod/Part/Gui/DlgPartImportIgesImp.h b/src/Mod/Part/Gui/DlgPartImportIgesImp.h index a98a9afdde..afe22a5980 100644 --- a/src/Mod/Part/Gui/DlgPartImportIgesImp.h +++ b/src/Mod/Part/Gui/DlgPartImportIgesImp.h @@ -33,7 +33,7 @@ class DlgPartImportIgesImp : public QDialog Q_OBJECT public: - DlgPartImportIgesImp( QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags() ); + explicit DlgPartImportIgesImp( QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags() ); ~DlgPartImportIgesImp() override; public Q_SLOTS: diff --git a/src/Mod/Part/Gui/DlgPartImportStepImp.h b/src/Mod/Part/Gui/DlgPartImportStepImp.h index a1b59c5247..d27cf02ab8 100644 --- a/src/Mod/Part/Gui/DlgPartImportStepImp.h +++ b/src/Mod/Part/Gui/DlgPartImportStepImp.h @@ -34,7 +34,7 @@ class DlgPartImportStepImp : public QDialog Q_OBJECT public: - DlgPartImportStepImp( QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags() ); + explicit DlgPartImportStepImp( QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags() ); ~DlgPartImportStepImp() override; public Q_SLOTS: diff --git a/src/Mod/Part/Gui/DlgPrimitives.h b/src/Mod/Part/Gui/DlgPrimitives.h index 0d561825ff..80b62e97a9 100644 --- a/src/Mod/Part/Gui/DlgPrimitives.h +++ b/src/Mod/Part/Gui/DlgPrimitives.h @@ -67,7 +67,7 @@ class DlgPrimitives : public QWidget Q_OBJECT public: - DlgPrimitives(QWidget* parent = nullptr, Part::Primitive* feature = nullptr); + explicit DlgPrimitives(QWidget* parent = nullptr, Part::Primitive* feature = nullptr); ~DlgPrimitives() override; void createPrimitive(const QString&); void accept(const QString&); @@ -142,7 +142,7 @@ class Location : public QWidget Q_OBJECT public: - Location(QWidget* parent = nullptr, Part::Feature* feature = nullptr); + explicit Location(QWidget* parent = nullptr, Part::Feature* feature = nullptr); ~Location() override; QString toPlacement() const; @@ -182,7 +182,7 @@ class TaskPrimitivesEdit : public Gui::TaskView::TaskDialog Q_OBJECT public: - TaskPrimitivesEdit(Part::Primitive* feature); + explicit TaskPrimitivesEdit(Part::Primitive* feature); ~TaskPrimitivesEdit() override; public: diff --git a/src/Mod/Part/Gui/DlgRevolution.h b/src/Mod/Part/Gui/DlgRevolution.h index f88ba36823..6b2908cfea 100644 --- a/src/Mod/Part/Gui/DlgRevolution.h +++ b/src/Mod/Part/Gui/DlgRevolution.h @@ -36,7 +36,7 @@ class DlgRevolution : public QDialog, public Gui::SelectionObserver Q_OBJECT public: - DlgRevolution(QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); + explicit DlgRevolution(QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); ~DlgRevolution() override; void accept() override; diff --git a/src/Mod/Part/Gui/DlgSettings3DViewPartImp.h b/src/Mod/Part/Gui/DlgSettings3DViewPartImp.h index 746ca55c96..fbcff0ec65 100644 --- a/src/Mod/Part/Gui/DlgSettings3DViewPartImp.h +++ b/src/Mod/Part/Gui/DlgSettings3DViewPartImp.h @@ -39,7 +39,7 @@ class DlgSettings3DViewPart : public Gui::Dialog::PreferencePage Q_OBJECT public: - DlgSettings3DViewPart(QWidget* parent = nullptr); + explicit DlgSettings3DViewPart(QWidget* parent = nullptr); ~DlgSettings3DViewPart() override; protected: diff --git a/src/Mod/Part/Gui/DlgSettingsGeneral.h b/src/Mod/Part/Gui/DlgSettingsGeneral.h index ef741aa931..25935dc9b6 100644 --- a/src/Mod/Part/Gui/DlgSettingsGeneral.h +++ b/src/Mod/Part/Gui/DlgSettingsGeneral.h @@ -36,7 +36,7 @@ class DlgSettingsGeneral : public Gui::Dialog::PreferencePage Q_OBJECT public: - DlgSettingsGeneral(QWidget* parent = nullptr); + explicit DlgSettingsGeneral(QWidget* parent = nullptr); ~DlgSettingsGeneral() override; protected: @@ -54,7 +54,7 @@ class DlgImportExportIges : public Gui::Dialog::PreferencePage Q_OBJECT public: - DlgImportExportIges(QWidget* parent = nullptr); + explicit DlgImportExportIges(QWidget* parent = nullptr); ~DlgImportExportIges() override; protected: @@ -73,7 +73,7 @@ class DlgImportExportStep : public Gui::Dialog::PreferencePage Q_OBJECT public: - DlgImportExportStep(QWidget* parent = nullptr); + explicit DlgImportExportStep(QWidget* parent = nullptr); ~DlgImportExportStep() override; protected: diff --git a/src/Mod/Part/Gui/DlgSettingsMeasure.h b/src/Mod/Part/Gui/DlgSettingsMeasure.h index 3a764ff4a6..2f347ef2c2 100644 --- a/src/Mod/Part/Gui/DlgSettingsMeasure.h +++ b/src/Mod/Part/Gui/DlgSettingsMeasure.h @@ -39,7 +39,7 @@ class DlgSettingsMeasure : public Gui::Dialog::PreferencePage Q_OBJECT public: - DlgSettingsMeasure(QWidget* parent = nullptr); + explicit DlgSettingsMeasure(QWidget* parent = nullptr); ~DlgSettingsMeasure() override; void saveSettings() override; diff --git a/src/Mod/Part/Gui/DlgSettingsObjectColor.h b/src/Mod/Part/Gui/DlgSettingsObjectColor.h index 505f0b34e4..ad6e143f36 100644 --- a/src/Mod/Part/Gui/DlgSettingsObjectColor.h +++ b/src/Mod/Part/Gui/DlgSettingsObjectColor.h @@ -40,7 +40,7 @@ class DlgSettingsObjectColor : public Gui::Dialog::PreferencePage Q_OBJECT public: - DlgSettingsObjectColor(QWidget* parent = nullptr); + explicit DlgSettingsObjectColor(QWidget* parent = nullptr); ~DlgSettingsObjectColor() override; void saveSettings() override; diff --git a/src/Mod/Part/Gui/Mirroring.h b/src/Mod/Part/Gui/Mirroring.h index c4191b811b..1fbfc1fee9 100644 --- a/src/Mod/Part/Gui/Mirroring.h +++ b/src/Mod/Part/Gui/Mirroring.h @@ -40,7 +40,7 @@ class Mirroring : public QWidget Q_OBJECT public: - Mirroring(QWidget* parent = nullptr); + explicit Mirroring(QWidget* parent = nullptr); ~Mirroring() override; bool accept(); diff --git a/src/Mod/Part/Gui/SectionCutting.h b/src/Mod/Part/Gui/SectionCutting.h index dd5ff71dc1..d5c87aacab 100644 --- a/src/Mod/Part/Gui/SectionCutting.h +++ b/src/Mod/Part/Gui/SectionCutting.h @@ -36,7 +36,7 @@ class SectionCut : public QDialog public: static SectionCut* makeDockWidget(QWidget* parent = nullptr); - SectionCut(QWidget* parent = nullptr); + explicit SectionCut(QWidget* parent = nullptr); ~SectionCut() override; protected Q_SLOTS: diff --git a/src/Mod/Part/Gui/ShapeFromMesh.h b/src/Mod/Part/Gui/ShapeFromMesh.h index 3ac98c6e80..49f23f37ca 100644 --- a/src/Mod/Part/Gui/ShapeFromMesh.h +++ b/src/Mod/Part/Gui/ShapeFromMesh.h @@ -34,7 +34,7 @@ class ShapeFromMesh : public QDialog Q_OBJECT public: - ShapeFromMesh(QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); + explicit ShapeFromMesh(QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); ~ShapeFromMesh() override; void accept() override; diff --git a/src/Mod/Part/Gui/TaskAttacher.h b/src/Mod/Part/Gui/TaskAttacher.h index 988e952b2e..4b6acf9b19 100644 --- a/src/Mod/Part/Gui/TaskAttacher.h +++ b/src/Mod/Part/Gui/TaskAttacher.h @@ -56,7 +56,7 @@ public: typedef std::function VisibilityFunction; - TaskAttacher(Gui::ViewProviderDocumentObject *ViewProvider, QWidget *parent = nullptr, + explicit TaskAttacher(Gui::ViewProviderDocumentObject *ViewProvider, QWidget *parent = nullptr, QString picture = QString(), QString text = QString::fromLatin1("Attachment"), VisibilityFunction func = 0); ~TaskAttacher() override; @@ -151,7 +151,7 @@ class PartGuiExport TaskDlgAttacher : public Gui::TaskView::TaskDialog Q_OBJECT public: - TaskDlgAttacher(Gui::ViewProviderDocumentObject *ViewProvider, bool createBox = true); + explicit TaskDlgAttacher(Gui::ViewProviderDocumentObject *ViewProvider, bool createBox = true); ~TaskDlgAttacher() override; Gui::ViewProviderDocumentObject* getViewProvider() const diff --git a/src/Mod/Part/Gui/TaskCheckGeometry.h b/src/Mod/Part/Gui/TaskCheckGeometry.h index ccb1bf7ed0..18d8eff990 100644 --- a/src/Mod/Part/Gui/TaskCheckGeometry.h +++ b/src/Mod/Part/Gui/TaskCheckGeometry.h @@ -81,7 +81,7 @@ class ResultModel : public QAbstractItemModel { Q_OBJECT public: - ResultModel(QObject *parent = nullptr); + explicit ResultModel(QObject *parent = nullptr); ~ResultModel() override; QModelIndex index(int row, int column, const QModelIndex &parent) const override; QModelIndex parent(const QModelIndex &child) const override; @@ -102,7 +102,7 @@ class TaskCheckGeometryResults : public QWidget { Q_OBJECT public: - TaskCheckGeometryResults(QWidget *parent = nullptr); + explicit TaskCheckGeometryResults(QWidget *parent = nullptr); ~TaskCheckGeometryResults() override; QString getShapeContentString(); void goCheck(); diff --git a/src/Mod/Part/Gui/TaskDimension.h b/src/Mod/Part/Gui/TaskDimension.h index 557695a2b6..5d68fbec9e 100644 --- a/src/Mod/Part/Gui/TaskDimension.h +++ b/src/Mod/Part/Gui/TaskDimension.h @@ -193,7 +193,7 @@ class SteppedSelection : public QWidget { Q_OBJECT public: - SteppedSelection(const uint &buttonCountIn, QWidget *parent = nullptr); + explicit SteppedSelection(const uint &buttonCountIn, QWidget *parent = nullptr); ~SteppedSelection() override; QPushButton* getButton(const uint &index); void setIconDone(const uint &index); @@ -308,9 +308,9 @@ public: bool isValid() const {return status;} /*!get the calculated vector. * @return the vector. use isValid to ensure correct results.*/ - operator gp_Vec() const {return vector;} + operator gp_Vec() const {return vector;}//explicit bombs /*!build occ line used for extrema calculation*/ - operator gp_Lin() const; + operator gp_Lin() const;//explicit bombs gp_Vec getPickPoint() const {return origin;} private: diff --git a/src/Mod/Part/Gui/TaskFaceColors.cpp b/src/Mod/Part/Gui/TaskFaceColors.cpp index 56177fb3d7..2d66da422a 100644 --- a/src/Mod/Part/Gui/TaskFaceColors.cpp +++ b/src/Mod/Part/Gui/TaskFaceColors.cpp @@ -70,7 +70,7 @@ namespace PartGui { { const App::DocumentObject* object; public: - FaceSelection(const App::DocumentObject* obj) + explicit FaceSelection(const App::DocumentObject* obj) : Gui::SelectionFilterGate(), object(obj) { } @@ -102,7 +102,7 @@ public: Connection connectDelObj; Connection connectUndoDoc; - Private(ViewProviderPartExt* vp) : ui(new Ui_TaskFaceColors()), view(nullptr), vp(vp) + explicit Private(ViewProviderPartExt* vp) : ui(new Ui_TaskFaceColors()), view(nullptr), vp(vp) { obj = vp->getObject(); doc = Gui::Application::Instance->getDocument(obj->getDocument()); diff --git a/src/Mod/Part/Gui/TaskFaceColors.h b/src/Mod/Part/Gui/TaskFaceColors.h index 44842cef39..5051a01da3 100644 --- a/src/Mod/Part/Gui/TaskFaceColors.h +++ b/src/Mod/Part/Gui/TaskFaceColors.h @@ -40,7 +40,7 @@ class FaceColors : public QWidget, public Gui::SelectionObserver Q_OBJECT public: - FaceColors(ViewProviderPartExt* vp, QWidget* parent = nullptr); + explicit FaceColors(ViewProviderPartExt* vp, QWidget* parent = nullptr); ~FaceColors() override; void open(); @@ -70,7 +70,7 @@ class TaskFaceColors : public Gui::TaskView::TaskDialog Q_OBJECT public: - TaskFaceColors(ViewProviderPartExt* vp); + explicit TaskFaceColors(ViewProviderPartExt* vp); ~TaskFaceColors() override; public: diff --git a/src/Mod/Part/Gui/TaskLoft.h b/src/Mod/Part/Gui/TaskLoft.h index d7e9f03564..ea3a63ce67 100644 --- a/src/Mod/Part/Gui/TaskLoft.h +++ b/src/Mod/Part/Gui/TaskLoft.h @@ -36,7 +36,7 @@ class LoftWidget : public QWidget Q_OBJECT public: - LoftWidget(QWidget* parent = nullptr); + explicit LoftWidget(QWidget* parent = nullptr); ~LoftWidget() override; bool accept(); diff --git a/src/Mod/Part/Gui/TaskOffset.h b/src/Mod/Part/Gui/TaskOffset.h index a6cac4b12a..f53030a40d 100644 --- a/src/Mod/Part/Gui/TaskOffset.h +++ b/src/Mod/Part/Gui/TaskOffset.h @@ -35,7 +35,7 @@ class OffsetWidget : public QWidget Q_OBJECT public: - OffsetWidget(Part::Offset*, QWidget* parent = nullptr); + explicit OffsetWidget(Part::Offset*, QWidget* parent = nullptr); ~OffsetWidget() override; bool accept(); @@ -64,7 +64,7 @@ class TaskOffset : public Gui::TaskView::TaskDialog Q_OBJECT public: - TaskOffset(Part::Offset*); + explicit TaskOffset(Part::Offset*); ~TaskOffset() override; public: diff --git a/src/Mod/Part/Gui/TaskShapeBuilder.h b/src/Mod/Part/Gui/TaskShapeBuilder.h index 350d172427..0daf4267f0 100644 --- a/src/Mod/Part/Gui/TaskShapeBuilder.h +++ b/src/Mod/Part/Gui/TaskShapeBuilder.h @@ -36,7 +36,7 @@ class ShapeBuilderWidget : public QWidget, Q_OBJECT public: - ShapeBuilderWidget(QWidget* parent = nullptr); + explicit ShapeBuilderWidget(QWidget* parent = nullptr); ~ShapeBuilderWidget() override; bool accept(); diff --git a/src/Mod/Part/Gui/TaskSweep.h b/src/Mod/Part/Gui/TaskSweep.h index b36ce0e083..b4051e226e 100644 --- a/src/Mod/Part/Gui/TaskSweep.h +++ b/src/Mod/Part/Gui/TaskSweep.h @@ -40,7 +40,7 @@ class SweepWidget : public QWidget Q_OBJECT public: - SweepWidget(QWidget* parent = nullptr); + explicit SweepWidget(QWidget* parent = nullptr); ~SweepWidget() override; bool accept(); diff --git a/src/Mod/Part/Gui/TaskThickness.cpp b/src/Mod/Part/Gui/TaskThickness.cpp index c63221095b..f3eebf4bd6 100644 --- a/src/Mod/Part/Gui/TaskThickness.cpp +++ b/src/Mod/Part/Gui/TaskThickness.cpp @@ -70,7 +70,7 @@ public: { const App::DocumentObject* object; public: - FaceSelection(const App::DocumentObject* obj) + explicit FaceSelection(const App::DocumentObject* obj) : Gui::SelectionFilterGate(nullPointer()), object(obj) { } diff --git a/src/Mod/Part/Gui/TaskThickness.h b/src/Mod/Part/Gui/TaskThickness.h index f3efe92505..6cb6fa5279 100644 --- a/src/Mod/Part/Gui/TaskThickness.h +++ b/src/Mod/Part/Gui/TaskThickness.h @@ -35,7 +35,7 @@ class ThicknessWidget : public QWidget Q_OBJECT public: - ThicknessWidget(Part::Thickness*, QWidget* parent = nullptr); + explicit ThicknessWidget(Part::Thickness*, QWidget* parent = nullptr); ~ThicknessWidget() override; bool accept(); @@ -64,7 +64,7 @@ class TaskThickness : public Gui::TaskView::TaskDialog Q_OBJECT public: - TaskThickness(Part::Thickness*); + explicit TaskThickness(Part::Thickness*); ~TaskThickness() override; public: diff --git a/src/Mod/PartDesign/App/FeaturePrimitive.cpp b/src/Mod/PartDesign/App/FeaturePrimitive.cpp index b1e916e6c8..59318f1f53 100644 --- a/src/Mod/PartDesign/App/FeaturePrimitive.cpp +++ b/src/Mod/PartDesign/App/FeaturePrimitive.cpp @@ -159,7 +159,7 @@ void FeaturePrimitive::handleChangedPropertyName(Base::XMLReader &reader, const # pragma clang diagnostic ignored "-Wmissing-field-initializers" #endif -PYTHON_TYPE_DEF(PrimitivePy, PartDesign::FeaturePy) +PYTHON_TYPE_DEF(PrimitivePy, PartDesign::FeaturePy)//explicit bombs PYTHON_TYPE_IMP(PrimitivePy, PartDesign::FeaturePy) #if defined(__clang__) diff --git a/src/Mod/PartDesign/Gui/TaskBooleanParameters.h b/src/Mod/PartDesign/Gui/TaskBooleanParameters.h index dc70a39d7f..85d4b04378 100644 --- a/src/Mod/PartDesign/Gui/TaskBooleanParameters.h +++ b/src/Mod/PartDesign/Gui/TaskBooleanParameters.h @@ -48,7 +48,7 @@ class TaskBooleanParameters : public Gui::TaskView::TaskBox, public Gui::Selecti Q_OBJECT public: - TaskBooleanParameters(ViewProviderBoolean *BooleanView, QWidget *parent=nullptr); + explicit TaskBooleanParameters(ViewProviderBoolean *BooleanView, QWidget *parent=nullptr); ~TaskBooleanParameters() override; const std::vector getBodies() const; @@ -83,7 +83,7 @@ class TaskDlgBooleanParameters : public Gui::TaskView::TaskDialog Q_OBJECT public: - TaskDlgBooleanParameters(ViewProviderBoolean *BooleanView); + explicit TaskDlgBooleanParameters(ViewProviderBoolean *BooleanView); ~TaskDlgBooleanParameters() override; ViewProviderBoolean* getBooleanView() const diff --git a/src/Mod/PartDesign/Gui/TaskChamferParameters.h b/src/Mod/PartDesign/Gui/TaskChamferParameters.h index 0ce309603a..442401da80 100644 --- a/src/Mod/PartDesign/Gui/TaskChamferParameters.h +++ b/src/Mod/PartDesign/Gui/TaskChamferParameters.h @@ -39,7 +39,7 @@ class TaskChamferParameters : public TaskDressUpParameters Q_OBJECT public: - TaskChamferParameters(ViewProviderDressUp *DressUpView, QWidget *parent=nullptr); + explicit TaskChamferParameters(ViewProviderDressUp *DressUpView, QWidget *parent=nullptr); ~TaskChamferParameters() override; void apply() override; @@ -78,7 +78,7 @@ class TaskDlgChamferParameters : public TaskDlgDressUpParameters Q_OBJECT public: - TaskDlgChamferParameters(ViewProviderChamfer *DressUpView); + explicit TaskDlgChamferParameters(ViewProviderChamfer *DressUpView); ~TaskDlgChamferParameters() override; public: diff --git a/src/Mod/PartDesign/Gui/TaskDatumParameters.h b/src/Mod/PartDesign/Gui/TaskDatumParameters.h index b91842c062..ed25ca1fe7 100644 --- a/src/Mod/PartDesign/Gui/TaskDatumParameters.h +++ b/src/Mod/PartDesign/Gui/TaskDatumParameters.h @@ -50,7 +50,7 @@ class TaskDatumParameters : public PartGui::TaskAttacher Q_OBJECT public: - TaskDatumParameters(ViewProviderDatum *DatumView,QWidget *parent = nullptr); + explicit TaskDatumParameters(ViewProviderDatum *DatumView,QWidget *parent = nullptr); ~TaskDatumParameters() override; }; @@ -60,7 +60,7 @@ class TaskDlgDatumParameters : public PartGui::TaskDlgAttacher Q_OBJECT public: - TaskDlgDatumParameters(ViewProviderDatum *DatumView); + explicit TaskDlgDatumParameters(ViewProviderDatum *DatumView); ~TaskDlgDatumParameters() override; bool accept() override; diff --git a/src/Mod/PartDesign/Gui/TaskDraftParameters.h b/src/Mod/PartDesign/Gui/TaskDraftParameters.h index 52cfb610d6..b2024e9376 100644 --- a/src/Mod/PartDesign/Gui/TaskDraftParameters.h +++ b/src/Mod/PartDesign/Gui/TaskDraftParameters.h @@ -37,7 +37,7 @@ class TaskDraftParameters : public TaskDressUpParameters Q_OBJECT public: - TaskDraftParameters(ViewProviderDressUp *DressUpView, QWidget *parent=nullptr); + explicit TaskDraftParameters(ViewProviderDressUp *DressUpView, QWidget *parent=nullptr); ~TaskDraftParameters() override; double getAngle() const; @@ -69,7 +69,7 @@ class TaskDlgDraftParameters : public TaskDlgDressUpParameters Q_OBJECT public: - TaskDlgDraftParameters(ViewProviderDraft *DraftView); + explicit TaskDlgDraftParameters(ViewProviderDraft *DraftView); ~TaskDlgDraftParameters() override; public: diff --git a/src/Mod/PartDesign/Gui/TaskDressUpParameters.h b/src/Mod/PartDesign/Gui/TaskDressUpParameters.h index 431f1f48b3..f3a011cc73 100644 --- a/src/Mod/PartDesign/Gui/TaskDressUpParameters.h +++ b/src/Mod/PartDesign/Gui/TaskDressUpParameters.h @@ -105,7 +105,7 @@ class TaskDlgDressUpParameters : public TaskDlgFeatureParameters Q_OBJECT public: - TaskDlgDressUpParameters(ViewProviderDressUp *DressUpView); + explicit TaskDlgDressUpParameters(ViewProviderDressUp *DressUpView); ~TaskDlgDressUpParameters() override; ViewProviderDressUp* getDressUpView() const diff --git a/src/Mod/PartDesign/Gui/TaskFeatureParameters.h b/src/Mod/PartDesign/Gui/TaskFeatureParameters.h index b7d903e6ee..83345ac6e9 100644 --- a/src/Mod/PartDesign/Gui/TaskFeatureParameters.h +++ b/src/Mod/PartDesign/Gui/TaskFeatureParameters.h @@ -70,7 +70,7 @@ class TaskDlgFeatureParameters : public Gui::TaskView::TaskDialog Q_OBJECT public: - TaskDlgFeatureParameters(PartDesignGui::ViewProvider *vp); + explicit TaskDlgFeatureParameters(PartDesignGui::ViewProvider *vp); ~TaskDlgFeatureParameters() override; public: diff --git a/src/Mod/PartDesign/Gui/TaskFilletParameters.h b/src/Mod/PartDesign/Gui/TaskFilletParameters.h index 3121e0becc..37a1ffb977 100644 --- a/src/Mod/PartDesign/Gui/TaskFilletParameters.h +++ b/src/Mod/PartDesign/Gui/TaskFilletParameters.h @@ -36,7 +36,7 @@ class TaskFilletParameters : public TaskDressUpParameters Q_OBJECT public: - TaskFilletParameters(ViewProviderDressUp *DressUpView, QWidget *parent=nullptr); + explicit TaskFilletParameters(ViewProviderDressUp *DressUpView, QWidget *parent=nullptr); ~TaskFilletParameters() override; void apply() override; @@ -64,7 +64,7 @@ class TaskDlgFilletParameters : public TaskDlgDressUpParameters Q_OBJECT public: - TaskDlgFilletParameters(ViewProviderFillet *DressUpView); + explicit TaskDlgFilletParameters(ViewProviderFillet *DressUpView); ~TaskDlgFilletParameters() override; public: diff --git a/src/Mod/PartDesign/Gui/TaskHelixParameters.h b/src/Mod/PartDesign/Gui/TaskHelixParameters.h index 09695b9f21..76dbb194bc 100644 --- a/src/Mod/PartDesign/Gui/TaskHelixParameters.h +++ b/src/Mod/PartDesign/Gui/TaskHelixParameters.h @@ -45,7 +45,7 @@ class TaskHelixParameters : public TaskSketchBasedParameters Q_OBJECT public: - TaskHelixParameters(ViewProviderHelix* HelixView, QWidget* parent = nullptr); + explicit TaskHelixParameters(ViewProviderHelix* HelixView, QWidget* parent = nullptr); ~TaskHelixParameters() override; void apply() override; @@ -133,7 +133,7 @@ class TaskDlgHelixParameters : public TaskDlgSketchBasedParameters Q_OBJECT public: - TaskDlgHelixParameters(ViewProviderHelix* HelixView); + explicit TaskDlgHelixParameters(ViewProviderHelix* HelixView); ViewProviderHelix* getHelixView() const { return static_cast(vp); } diff --git a/src/Mod/PartDesign/Gui/TaskHoleParameters.h b/src/Mod/PartDesign/Gui/TaskHoleParameters.h index 40e4221135..b06583b878 100644 --- a/src/Mod/PartDesign/Gui/TaskHoleParameters.h +++ b/src/Mod/PartDesign/Gui/TaskHoleParameters.h @@ -50,7 +50,7 @@ class TaskHoleParameters : public TaskSketchBasedParameters Q_OBJECT public: - TaskHoleParameters(ViewProviderHole *HoleView, QWidget *parent = nullptr); + explicit TaskHoleParameters(ViewProviderHole *HoleView, QWidget *parent = nullptr); ~TaskHoleParameters() override; void apply() override; @@ -143,7 +143,7 @@ class TaskDlgHoleParameters : public TaskDlgSketchBasedParameters Q_OBJECT public: - TaskDlgHoleParameters(ViewProviderHole *HoleView); + explicit TaskDlgHoleParameters(ViewProviderHole *HoleView); ~TaskDlgHoleParameters() override; ViewProviderHole* getHoleView() const { return static_cast(vp); } diff --git a/src/Mod/PartDesign/Gui/TaskLinearPatternParameters.h b/src/Mod/PartDesign/Gui/TaskLinearPatternParameters.h index 2b134205ff..ba64fce804 100644 --- a/src/Mod/PartDesign/Gui/TaskLinearPatternParameters.h +++ b/src/Mod/PartDesign/Gui/TaskLinearPatternParameters.h @@ -48,7 +48,7 @@ class TaskLinearPatternParameters : public TaskTransformedParameters public: /// Constructor for task with ViewProvider - TaskLinearPatternParameters(ViewProviderTransformed *TransformedView, QWidget *parent = nullptr); + explicit TaskLinearPatternParameters(ViewProviderTransformed *TransformedView, QWidget *parent = nullptr); /// Constructor for task with parent task (MultiTransform mode) TaskLinearPatternParameters(TaskMultiTransformParameters *parentTask, QLayout *layout); ~TaskLinearPatternParameters() override; @@ -95,7 +95,7 @@ class TaskDlgLinearPatternParameters : public TaskDlgTransformedParameters Q_OBJECT public: - TaskDlgLinearPatternParameters(ViewProviderLinearPattern *LinearPatternView); + explicit TaskDlgLinearPatternParameters(ViewProviderLinearPattern *LinearPatternView); ~TaskDlgLinearPatternParameters() override {} }; diff --git a/src/Mod/PartDesign/Gui/TaskLoftParameters.h b/src/Mod/PartDesign/Gui/TaskLoftParameters.h index 85c302ec17..3bd852f063 100644 --- a/src/Mod/PartDesign/Gui/TaskLoftParameters.h +++ b/src/Mod/PartDesign/Gui/TaskLoftParameters.h @@ -46,7 +46,7 @@ class TaskLoftParameters : public TaskSketchBasedParameters Q_OBJECT public: - TaskLoftParameters(ViewProviderLoft *LoftView, bool newObj=false, QWidget *parent = nullptr); + explicit TaskLoftParameters(ViewProviderLoft *LoftView, bool newObj=false, QWidget *parent = nullptr); ~TaskLoftParameters() override; private Q_SLOTS: @@ -84,7 +84,7 @@ class TaskDlgLoftParameters : public TaskDlgSketchBasedParameters Q_OBJECT public: - TaskDlgLoftParameters(ViewProviderLoft *LoftView,bool newObj=false); + explicit TaskDlgLoftParameters(ViewProviderLoft *LoftView,bool newObj=false); ~TaskDlgLoftParameters() override; ViewProviderLoft* getLoftView() const diff --git a/src/Mod/PartDesign/Gui/TaskMirroredParameters.h b/src/Mod/PartDesign/Gui/TaskMirroredParameters.h index 1288b80245..b5782c7b29 100644 --- a/src/Mod/PartDesign/Gui/TaskMirroredParameters.h +++ b/src/Mod/PartDesign/Gui/TaskMirroredParameters.h @@ -47,7 +47,7 @@ class TaskMirroredParameters : public TaskTransformedParameters public: /// Constructor for task with ViewProvider - TaskMirroredParameters(ViewProviderTransformed *TransformedView, QWidget *parent = nullptr); + explicit TaskMirroredParameters(ViewProviderTransformed *TransformedView, QWidget *parent = nullptr); /// Constructor for task with parent task (MultiTransform mode) TaskMirroredParameters(TaskMultiTransformParameters *parentTask, QLayout *layout); @@ -85,7 +85,7 @@ class TaskDlgMirroredParameters : public TaskDlgTransformedParameters Q_OBJECT public: - TaskDlgMirroredParameters(ViewProviderMirrored *MirroredView); + explicit TaskDlgMirroredParameters(ViewProviderMirrored *MirroredView); ~TaskDlgMirroredParameters() override {} public: diff --git a/src/Mod/PartDesign/Gui/TaskMultiTransformParameters.h b/src/Mod/PartDesign/Gui/TaskMultiTransformParameters.h index e45bbc2cec..fdd989f5ef 100644 --- a/src/Mod/PartDesign/Gui/TaskMultiTransformParameters.h +++ b/src/Mod/PartDesign/Gui/TaskMultiTransformParameters.h @@ -51,7 +51,7 @@ class TaskMultiTransformParameters : public TaskTransformedParameters Q_OBJECT public: - TaskMultiTransformParameters(ViewProviderTransformed *TransformedView,QWidget *parent = nullptr); + explicit TaskMultiTransformParameters(ViewProviderTransformed *TransformedView,QWidget *parent = nullptr); ~TaskMultiTransformParameters() override; const std::vector getTransformFeatures() const; @@ -110,7 +110,7 @@ class TaskDlgMultiTransformParameters : public TaskDlgTransformedParameters Q_OBJECT public: - TaskDlgMultiTransformParameters(ViewProviderMultiTransform *MultiTransformView); + explicit TaskDlgMultiTransformParameters(ViewProviderMultiTransform *MultiTransformView); ~TaskDlgMultiTransformParameters() override {} public: diff --git a/src/Mod/PartDesign/Gui/TaskPadParameters.h b/src/Mod/PartDesign/Gui/TaskPadParameters.h index 7eb724ac84..0a353f410a 100644 --- a/src/Mod/PartDesign/Gui/TaskPadParameters.h +++ b/src/Mod/PartDesign/Gui/TaskPadParameters.h @@ -43,7 +43,7 @@ class TaskPadParameters : public TaskExtrudeParameters Q_OBJECT public: - TaskPadParameters(ViewProviderPad *PadView, QWidget *parent = nullptr, bool newObj=false); + explicit TaskPadParameters(ViewProviderPad *PadView, QWidget *parent = nullptr, bool newObj=false); ~TaskPadParameters() override; void apply() override; @@ -60,7 +60,7 @@ class TaskDlgPadParameters : public TaskDlgSketchBasedParameters Q_OBJECT public: - TaskDlgPadParameters(ViewProviderPad *PadView, bool newObj=false); + explicit TaskDlgPadParameters(ViewProviderPad *PadView, bool newObj=false); ViewProviderPad* getPadView() const { return static_cast(vp); } diff --git a/src/Mod/PartDesign/Gui/TaskPipeParameters.h b/src/Mod/PartDesign/Gui/TaskPipeParameters.h index b3da8a8feb..8839c86b1f 100644 --- a/src/Mod/PartDesign/Gui/TaskPipeParameters.h +++ b/src/Mod/PartDesign/Gui/TaskPipeParameters.h @@ -79,7 +79,7 @@ class TaskPipeParameters : public TaskSketchBasedParameters Q_OBJECT public: - TaskPipeParameters(ViewProviderPipe *PipeView, bool newObj=false, QWidget *parent = nullptr); + explicit TaskPipeParameters(ViewProviderPipe *PipeView, bool newObj=false, QWidget *parent = nullptr); ~TaskPipeParameters() override; bool accept(); @@ -120,7 +120,7 @@ class TaskPipeOrientation : public TaskSketchBasedParameters Q_OBJECT public: - TaskPipeOrientation(ViewProviderPipe *PipeView, bool newObj=false, QWidget *parent = nullptr); + explicit TaskPipeOrientation(ViewProviderPipe *PipeView, bool newObj=false, QWidget *parent = nullptr); ~TaskPipeOrientation() override; @@ -154,7 +154,7 @@ class TaskPipeScaling : public TaskSketchBasedParameters Q_OBJECT public: - TaskPipeScaling(ViewProviderPipe *PipeView,bool newObj=false,QWidget *parent = nullptr); + explicit TaskPipeScaling(ViewProviderPipe *PipeView,bool newObj=false,QWidget *parent = nullptr); ~TaskPipeScaling() override; private Q_SLOTS: @@ -185,7 +185,7 @@ class TaskDlgPipeParameters : public TaskDlgSketchBasedParameters Q_OBJECT public: - TaskDlgPipeParameters(ViewProviderPipe *PipeView,bool newObj=false); + explicit TaskDlgPipeParameters(ViewProviderPipe *PipeView,bool newObj=false); ~TaskDlgPipeParameters() override; public: diff --git a/src/Mod/PartDesign/Gui/TaskPocketParameters.h b/src/Mod/PartDesign/Gui/TaskPocketParameters.h index d9772456dd..e7e27e7e2f 100644 --- a/src/Mod/PartDesign/Gui/TaskPocketParameters.h +++ b/src/Mod/PartDesign/Gui/TaskPocketParameters.h @@ -43,7 +43,7 @@ class TaskPocketParameters : public TaskExtrudeParameters Q_OBJECT public: - TaskPocketParameters(ViewProviderPocket *PocketView, QWidget *parent = nullptr, bool newObj=false); + explicit TaskPocketParameters(ViewProviderPocket *PocketView, QWidget *parent = nullptr, bool newObj=false); ~TaskPocketParameters() override; void apply() override; @@ -63,7 +63,7 @@ class TaskDlgPocketParameters : public TaskDlgSketchBasedParameters Q_OBJECT public: - TaskDlgPocketParameters(ViewProviderPocket *PocketView); + explicit TaskDlgPocketParameters(ViewProviderPocket *PocketView); ViewProviderPocket* getPocketView() const { return static_cast(vp); } diff --git a/src/Mod/PartDesign/Gui/TaskPolarPatternParameters.h b/src/Mod/PartDesign/Gui/TaskPolarPatternParameters.h index d9d23c9c26..ed799b3863 100644 --- a/src/Mod/PartDesign/Gui/TaskPolarPatternParameters.h +++ b/src/Mod/PartDesign/Gui/TaskPolarPatternParameters.h @@ -48,7 +48,7 @@ class TaskPolarPatternParameters : public TaskTransformedParameters public: /// Constructor for task with ViewProvider - TaskPolarPatternParameters(ViewProviderTransformed *TransformedView, QWidget *parent = nullptr); + explicit TaskPolarPatternParameters(ViewProviderTransformed *TransformedView, QWidget *parent = nullptr); /// Constructor for task with parent task (MultiTransform mode) TaskPolarPatternParameters(TaskMultiTransformParameters *parentTask, QLayout *layout); ~TaskPolarPatternParameters() override; @@ -97,7 +97,7 @@ class TaskDlgPolarPatternParameters : public TaskDlgTransformedParameters Q_OBJECT public: - TaskDlgPolarPatternParameters(ViewProviderPolarPattern *PolarPatternView); + explicit TaskDlgPolarPatternParameters(ViewProviderPolarPattern *PolarPatternView); ~TaskDlgPolarPatternParameters() override {} }; diff --git a/src/Mod/PartDesign/Gui/TaskPrimitiveParameters.h b/src/Mod/PartDesign/Gui/TaskPrimitiveParameters.h index 41aec572e3..fe76273571 100644 --- a/src/Mod/PartDesign/Gui/TaskPrimitiveParameters.h +++ b/src/Mod/PartDesign/Gui/TaskPrimitiveParameters.h @@ -48,7 +48,7 @@ class TaskBoxPrimitives : public Gui::TaskView::TaskBox, Q_OBJECT public: - TaskBoxPrimitives(ViewProviderPrimitive* vp, QWidget* parent = nullptr); + explicit TaskBoxPrimitives(ViewProviderPrimitive* vp, QWidget* parent = nullptr); ~TaskBoxPrimitives() override; bool setPrimitive(App::DocumentObject *); @@ -112,7 +112,7 @@ class TaskPrimitiveParameters : public Gui::TaskView::TaskDialog Q_OBJECT public: - TaskPrimitiveParameters(ViewProviderPrimitive *PrimitiveView); + explicit TaskPrimitiveParameters(ViewProviderPrimitive *PrimitiveView); ~TaskPrimitiveParameters() override; protected: diff --git a/src/Mod/PartDesign/Gui/TaskRevolutionParameters.h b/src/Mod/PartDesign/Gui/TaskRevolutionParameters.h index 723fc7b064..d4a02e227f 100644 --- a/src/Mod/PartDesign/Gui/TaskRevolutionParameters.h +++ b/src/Mod/PartDesign/Gui/TaskRevolutionParameters.h @@ -46,7 +46,7 @@ class TaskRevolutionParameters : public TaskSketchBasedParameters Q_OBJECT public: - TaskRevolutionParameters(ViewProvider* RevolutionView,QWidget *parent = nullptr); + explicit TaskRevolutionParameters(ViewProvider* RevolutionView,QWidget *parent = nullptr); ~TaskRevolutionParameters() override; void apply() override; @@ -108,7 +108,7 @@ class TaskDlgRevolutionParameters : public TaskDlgSketchBasedParameters Q_OBJECT public: - TaskDlgRevolutionParameters(PartDesignGui::ViewProvider *RevolutionView); + explicit TaskDlgRevolutionParameters(PartDesignGui::ViewProvider *RevolutionView); ViewProvider* getRevolutionView() const { return vp; } diff --git a/src/Mod/PartDesign/Gui/TaskScaledParameters.h b/src/Mod/PartDesign/Gui/TaskScaledParameters.h index 9ffd5bdcfc..7a89055963 100644 --- a/src/Mod/PartDesign/Gui/TaskScaledParameters.h +++ b/src/Mod/PartDesign/Gui/TaskScaledParameters.h @@ -47,7 +47,7 @@ class TaskScaledParameters : public TaskTransformedParameters public: /// Constructor for task with ViewProvider - TaskScaledParameters(ViewProviderTransformed *TransformedView, QWidget *parent = nullptr); + explicit TaskScaledParameters(ViewProviderTransformed *TransformedView, QWidget *parent = nullptr); /// Constructor for task with parent task (MultiTransform mode) TaskScaledParameters(TaskMultiTransformParameters *parentTask, QLayout *layout); ~TaskScaledParameters() override; @@ -82,7 +82,7 @@ class TaskDlgScaledParameters : public TaskDlgTransformedParameters Q_OBJECT public: - TaskDlgScaledParameters(ViewProviderScaled *ScaledView); + explicit TaskDlgScaledParameters(ViewProviderScaled *ScaledView); ~TaskDlgScaledParameters() override {} public: diff --git a/src/Mod/PartDesign/Gui/TaskShapeBinder.h b/src/Mod/PartDesign/Gui/TaskShapeBinder.h index 6366184e77..65727a13f5 100644 --- a/src/Mod/PartDesign/Gui/TaskShapeBinder.h +++ b/src/Mod/PartDesign/Gui/TaskShapeBinder.h @@ -51,7 +51,7 @@ class TaskShapeBinder : public Gui::TaskView::TaskBox, Gui::SelectionObserver Q_OBJECT public: - TaskShapeBinder(ViewProviderShapeBinder *view,bool newObj=false,QWidget *parent = nullptr); + explicit TaskShapeBinder(ViewProviderShapeBinder *view,bool newObj=false,QWidget *parent = nullptr); ~TaskShapeBinder() override; void accept(); @@ -91,7 +91,7 @@ class TaskDlgShapeBinder : public Gui::TaskView::TaskDialog Q_OBJECT public: - TaskDlgShapeBinder(ViewProviderShapeBinder *view,bool newObj=false); + explicit TaskDlgShapeBinder(ViewProviderShapeBinder *view,bool newObj=false); ~TaskDlgShapeBinder() override; public: diff --git a/src/Mod/PartDesign/Gui/TaskSketchBasedParameters.h b/src/Mod/PartDesign/Gui/TaskSketchBasedParameters.h index 71777ce540..e5979fc21f 100644 --- a/src/Mod/PartDesign/Gui/TaskSketchBasedParameters.h +++ b/src/Mod/PartDesign/Gui/TaskSketchBasedParameters.h @@ -79,7 +79,7 @@ class TaskDlgSketchBasedParameters : public PartDesignGui::TaskDlgFeatureParamet Q_OBJECT public: - TaskDlgSketchBasedParameters(PartDesignGui::ViewProvider *vp); + explicit TaskDlgSketchBasedParameters(PartDesignGui::ViewProvider *vp); ~TaskDlgSketchBasedParameters() override; public: diff --git a/src/Mod/PartDesign/Gui/TaskThicknessParameters.h b/src/Mod/PartDesign/Gui/TaskThicknessParameters.h index 9f881aba15..5513b2f47d 100644 --- a/src/Mod/PartDesign/Gui/TaskThicknessParameters.h +++ b/src/Mod/PartDesign/Gui/TaskThicknessParameters.h @@ -36,7 +36,7 @@ class TaskThicknessParameters : public TaskDressUpParameters Q_OBJECT public: - TaskThicknessParameters(ViewProviderDressUp *DressUpView, QWidget *parent=nullptr); + explicit TaskThicknessParameters(ViewProviderDressUp *DressUpView, QWidget *parent=nullptr); ~TaskThicknessParameters() override; double getValue(void) const; @@ -69,7 +69,7 @@ class TaskDlgThicknessParameters : public TaskDlgDressUpParameters Q_OBJECT public: - TaskDlgThicknessParameters(ViewProviderThickness *ThicknessView); + explicit TaskDlgThicknessParameters(ViewProviderThickness *ThicknessView); ~TaskDlgThicknessParameters() override; public: diff --git a/src/Mod/PartDesign/Gui/TaskTransformedMessages.h b/src/Mod/PartDesign/Gui/TaskTransformedMessages.h index 048785487f..a6f0c09c6d 100644 --- a/src/Mod/PartDesign/Gui/TaskTransformedMessages.h +++ b/src/Mod/PartDesign/Gui/TaskTransformedMessages.h @@ -42,7 +42,7 @@ class TaskTransformedMessages : public Gui::TaskView::TaskBox Q_OBJECT public: - TaskTransformedMessages(ViewProviderTransformed *transformedView); + explicit TaskTransformedMessages(ViewProviderTransformed *transformedView); ~TaskTransformedMessages() override; void slotDiagnosis(QString msg); diff --git a/src/Mod/PartDesign/Gui/TaskTransformedParameters.h b/src/Mod/PartDesign/Gui/TaskTransformedParameters.h index b2ba04dff5..3efb7bb7ef 100644 --- a/src/Mod/PartDesign/Gui/TaskTransformedParameters.h +++ b/src/Mod/PartDesign/Gui/TaskTransformedParameters.h @@ -64,7 +64,7 @@ public: * remove items from the combo directly, otherwise internal tracking list * will go out of sync, and crashes may result. */ - ComboLinks(QComboBox &combo); + explicit ComboLinks(QComboBox &combo); ComboLinks() {_combo = nullptr; doc = nullptr;} void setCombo(QComboBox &combo) {assert(!_combo); this->_combo = &combo; _combo->clear();} @@ -123,9 +123,9 @@ class TaskTransformedParameters : public Gui::TaskView::TaskBox, public: /// Constructor for task with ViewProvider - TaskTransformedParameters(ViewProviderTransformed *TransformedView, QWidget *parent = nullptr); + explicit TaskTransformedParameters(ViewProviderTransformed *TransformedView, QWidget *parent = nullptr); /// Constructor for task with parent task (MultiTransform mode) - TaskTransformedParameters(TaskMultiTransformParameters *parentTask); + explicit TaskTransformedParameters(TaskMultiTransformParameters *parentTask); ~TaskTransformedParameters() override; /// Returns the originals property of associated top feeature object @@ -240,7 +240,7 @@ class TaskDlgTransformedParameters : public PartDesignGui::TaskDlgFeatureParamet Q_OBJECT public: - TaskDlgTransformedParameters(ViewProviderTransformed *TransformedView); + explicit TaskDlgTransformedParameters(ViewProviderTransformed *TransformedView); ~TaskDlgTransformedParameters() override {} ViewProviderTransformed* getTransformedView() const diff --git a/src/Mod/Path/App/Area.cpp b/src/Mod/Path/App/Area.cpp index d9387e32df..03e0b4eef9 100644 --- a/src/Mod/Path/App/Area.cpp +++ b/src/Mod/Path/App/Area.cpp @@ -913,7 +913,7 @@ struct WireJoiner { size_t iStart; size_t iEnd; size_t iCurrent; - StackInfo(size_t idx) :iStart(idx), iEnd(idx), iCurrent(idx) {} + explicit StackInfo(size_t idx) :iStart(idx), iEnd(idx), iCurrent(idx) {} }; std::vector stack; std::vector vertexStack; diff --git a/src/Mod/Path/App/Area.h b/src/Mod/Path/App/Area.h index 07248537ea..8994be0f55 100644 --- a/src/Mod/Path/App/Area.h +++ b/src/Mod/Path/App/Area.h @@ -95,7 +95,7 @@ struct PathExport CAreaConfig { * arc unfiting and fitting is lossy. And repeatedly perform these operation * may cause shape deformation. So it is best to delay arc fitting until the * final step*/ - CAreaConfig(const CAreaParams& p, bool noFitArcs = true); + explicit CAreaConfig(const CAreaParams& p, bool noFitArcs = true); /** The destructor restores the setting, and thus exception safe. */ ~CAreaConfig(); @@ -171,7 +171,7 @@ public: /** Declare all parameters defined in #AREA_PARAMS_ALL as member variable */ PARAM_ENUM_DECLARE(AREA_PARAMS_ALL) - Area(const AreaParams* params = nullptr); + explicit Area(const AreaParams* params = nullptr); Area(const Area& other, bool deep_copy = true); ~Area() override; diff --git a/src/Mod/Path/Gui/DlgProcessorChooser.h b/src/Mod/Path/Gui/DlgProcessorChooser.h index 1c190facbf..dd07b69db9 100644 --- a/src/Mod/Path/Gui/DlgProcessorChooser.h +++ b/src/Mod/Path/Gui/DlgProcessorChooser.h @@ -36,7 +36,7 @@ class DlgProcessorChooser : public QDialog Q_OBJECT public: - DlgProcessorChooser(std::vector &scriptnames, bool withArguments = false); + explicit DlgProcessorChooser(std::vector &scriptnames, bool withArguments = false); ~DlgProcessorChooser() override; std::string getProcessor(); diff --git a/src/Mod/Path/Gui/DlgSettingsPathColor.h b/src/Mod/Path/Gui/DlgSettingsPathColor.h index 262f2b51a5..797f29d102 100644 --- a/src/Mod/Path/Gui/DlgSettingsPathColor.h +++ b/src/Mod/Path/Gui/DlgSettingsPathColor.h @@ -35,7 +35,7 @@ class DlgSettingsPathColor : public Gui::Dialog::PreferencePage Q_OBJECT public: - DlgSettingsPathColor(QWidget* parent = nullptr); + explicit DlgSettingsPathColor(QWidget* parent = nullptr); ~DlgSettingsPathColor() override; void saveSettings() override; diff --git a/src/Mod/Path/Gui/TaskDlgPathCompound.h b/src/Mod/Path/Gui/TaskDlgPathCompound.h index 8cbebd20ba..bd736c3c96 100644 --- a/src/Mod/Path/Gui/TaskDlgPathCompound.h +++ b/src/Mod/Path/Gui/TaskDlgPathCompound.h @@ -41,7 +41,7 @@ class TaskWidgetPathCompound : public Gui::TaskView::TaskBox Q_OBJECT public: - TaskWidgetPathCompound(ViewProviderPathCompound *CompoundView, QWidget *parent=nullptr); + explicit TaskWidgetPathCompound(ViewProviderPathCompound *CompoundView, QWidget *parent=nullptr); ~TaskWidgetPathCompound() override; std::vector getList() const; diff --git a/src/Mod/Path/PathSimulator/App/VolSim.h b/src/Mod/Path/PathSimulator/App/VolSim.h index c14a91c35e..1d983ac534 100644 --- a/src/Mod/Path/PathSimulator/App/VolSim.h +++ b/src/Mod/Path/PathSimulator/App/VolSim.h @@ -50,8 +50,8 @@ struct Point3D { Point3D() : x(0), y(0), z(0), sina(0), cosa(0) {} Point3D(float x, float y, float z) : x(x), y(y), z(z), sina(0), cosa(0) {} - Point3D(Base::Vector3d & vec) : x(vec[0]), y(vec[1]), z(vec[2]), sina(0), cosa(0) {} - Point3D(Base::Placement & pl) : x(pl.getPosition()[0]), y(pl.getPosition()[1]), z(pl.getPosition()[2]), sina(0), cosa(0) {} + explicit Point3D(Base::Vector3d & vec) : x(vec[0]), y(vec[1]), z(vec[2]), sina(0), cosa(0) {} + explicit Point3D(Base::Placement & pl) : x(pl.getPosition()[0]), y(pl.getPosition()[1]), z(pl.getPosition()[2]), sina(0), cosa(0) {} inline void set(float px, float py, float pz) { x = px; y = py; z = pz; } inline void Add(Point3D & p) { x += p.x; y += p.y; z += p.z; } inline void Rotate() { float tx = x; x = x * cosa - y * sina; y = tx * sina + y * cosa; } diff --git a/src/Mod/Points/App/Points.h b/src/Mod/Points/App/Points.h index 6280cafc18..0776e1f4e7 100644 --- a/src/Mod/Points/App/Points.h +++ b/src/Mod/Points/App/Points.h @@ -56,7 +56,7 @@ public: PointKernel() { } - PointKernel(size_type size) + explicit PointKernel(size_type size) { resize(size); } diff --git a/src/Mod/Points/App/PointsAlgos.h b/src/Mod/Points/App/PointsAlgos.h index cde6cfa53a..6bee986ed5 100644 --- a/src/Mod/Points/App/PointsAlgos.h +++ b/src/Mod/Points/App/PointsAlgos.h @@ -129,7 +129,7 @@ protected: class Writer { public: - Writer(const PointKernel&); + explicit Writer(const PointKernel&); virtual ~Writer(); virtual void write(const std::string& filename) = 0; @@ -152,7 +152,7 @@ protected: class AscWriter : public Writer { public: - AscWriter(const PointKernel&); + explicit AscWriter(const PointKernel&); ~AscWriter() override; void write(const std::string& filename) override; }; @@ -160,7 +160,7 @@ public: class PlyWriter : public Writer { public: - PlyWriter(const PointKernel&); + explicit PlyWriter(const PointKernel&); ~PlyWriter() override; void write(const std::string& filename) override; }; @@ -168,7 +168,7 @@ public: class PcdWriter : public Writer { public: - PcdWriter(const PointKernel&); + explicit PcdWriter(const PointKernel&); ~PcdWriter() override; void write(const std::string& filename) override; }; diff --git a/src/Mod/Points/App/PointsGrid.h b/src/Mod/Points/App/PointsGrid.h index 585de8e1b0..41ac53d609 100644 --- a/src/Mod/Points/App/PointsGrid.h +++ b/src/Mod/Points/App/PointsGrid.h @@ -52,7 +52,7 @@ public: /** @name Construction */ //@{ /// Construction - PointsGrid (const PointKernel &rclM); + explicit PointsGrid (const PointKernel &rclM); /// Construction PointsGrid (); /// Construction @@ -175,7 +175,7 @@ class PointsExport PointsGridIterator { public: /// Construction - PointsGridIterator (const PointsGrid &rclG); + explicit PointsGridIterator (const PointsGrid &rclG); /** Returns the bounding box of the current grid element. */ Base::BoundBox3d GetBoundBox () const { return _rclGrid.GetBoundBox(_ulX, _ulY, _ulZ); } diff --git a/src/Mod/Points/Gui/DlgPointsReadImp.h b/src/Mod/Points/Gui/DlgPointsReadImp.h index 4a3f737d3e..d36e261104 100644 --- a/src/Mod/Points/Gui/DlgPointsReadImp.h +++ b/src/Mod/Points/Gui/DlgPointsReadImp.h @@ -38,7 +38,7 @@ class DlgPointsReadImp : public QDialog Q_OBJECT public: - DlgPointsReadImp(const char *FileName, QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags() ); + explicit DlgPointsReadImp(const char *FileName, QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags() ); ~DlgPointsReadImp() override; private: diff --git a/src/Mod/Raytracing/Gui/DlgSettingsRayImp.h b/src/Mod/Raytracing/Gui/DlgSettingsRayImp.h index f544804696..3a6efce700 100644 --- a/src/Mod/Raytracing/Gui/DlgSettingsRayImp.h +++ b/src/Mod/Raytracing/Gui/DlgSettingsRayImp.h @@ -40,7 +40,7 @@ class DlgSettingsRayImp : public Gui::Dialog::PreferencePage Q_OBJECT public: - DlgSettingsRayImp( QWidget* parent = nullptr ); + explicit DlgSettingsRayImp( QWidget* parent = nullptr ); ~DlgSettingsRayImp() override; protected: diff --git a/src/Mod/Raytracing/Gui/PovrayHighlighter.h b/src/Mod/Raytracing/Gui/PovrayHighlighter.h index 8bfcc9adaa..8e17704db7 100644 --- a/src/Mod/Raytracing/Gui/PovrayHighlighter.h +++ b/src/Mod/Raytracing/Gui/PovrayHighlighter.h @@ -36,7 +36,7 @@ class PovrayHighlighterP; class PovrayHighlighter : public Gui::SyntaxHighlighter { public: - PovrayHighlighter(QObject* parent); + explicit PovrayHighlighter(QObject* parent); virtual ~PovrayHighlighter(); protected: diff --git a/src/Mod/ReverseEngineering/App/ApproxSurface.cpp b/src/Mod/ReverseEngineering/App/ApproxSurface.cpp index 2cffc3c081..0df5c39618 100644 --- a/src/Mod/ReverseEngineering/App/ApproxSurface.cpp +++ b/src/Mod/ReverseEngineering/App/ApproxSurface.cpp @@ -1007,7 +1007,7 @@ namespace Reen { class ScalarProduct { public: - ScalarProduct(const math_Matrix& mat) : mat(mat) + explicit ScalarProduct(const math_Matrix& mat) : mat(mat) { } std::vector multiply(int col) const diff --git a/src/Mod/ReverseEngineering/App/ApproxSurface.h b/src/Mod/ReverseEngineering/App/ApproxSurface.h index 75865b5fbc..680b1dd210 100644 --- a/src/Mod/ReverseEngineering/App/ApproxSurface.h +++ b/src/Mod/ReverseEngineering/App/ApproxSurface.h @@ -55,14 +55,14 @@ public: * Constructor * @param iSize Length of Knots vector */ - SplineBasisfunction(int iSize); + explicit SplineBasisfunction(int iSize); /** * Constructor * @param vKnots Knot vector * @param iOrder Order (degree + 1) of the basic polynomial */ - SplineBasisfunction(TColStd_Array1OfReal& vKnots, int iOrder=1); + explicit SplineBasisfunction(TColStd_Array1OfReal& vKnots, int iOrder=1); /** * Constructor @@ -144,14 +144,14 @@ public: * Constructor * @param iSize Length of the knot vector */ - BSplineBasis(int iSize); + explicit BSplineBasis(int iSize); /** * Constructor * @param vKnots Knot vector * @param iOrder Order (degree + 1) of the basic polynomial */ - BSplineBasis(TColStd_Array1OfReal& vKnots, int iOrder=1); + explicit BSplineBasis(TColStd_Array1OfReal& vKnots, int iOrder=1); /** * Constructor @@ -255,7 +255,7 @@ class ReenExport ParameterCorrection public: // Constructor - ParameterCorrection(unsigned usUOrder=4, //Order in u-direction (order = degree + 1) + explicit ParameterCorrection(unsigned usUOrder=4, //Order in u-direction (order = degree + 1) unsigned usVOrder=4, //Order in v-direction unsigned usUCtrlpoints=6, //Qty. of the control points in the u-direction unsigned usVCtrlpoints=6); //Qty. of the control points in the v-direction @@ -370,7 +370,7 @@ class ReenExport BSplineParameterCorrection : public ParameterCorrection { public: // Constructor - BSplineParameterCorrection(unsigned usUOrder=4, //Order in u-direction (order = degree + 1) + explicit BSplineParameterCorrection(unsigned usUOrder=4, //Order in u-direction (order = degree + 1) unsigned usVOrder=4, //Order in the v-direction unsigned usUCtrlpoints=6, //Qty. of the control points in u-direction unsigned usVCtrlpoints=6); //Qty. of the control points in v-direction diff --git a/src/Mod/ReverseEngineering/App/Segmentation.h b/src/Mod/ReverseEngineering/App/Segmentation.h index e2df4a6d64..228b647b3f 100644 --- a/src/Mod/ReverseEngineering/App/Segmentation.h +++ b/src/Mod/ReverseEngineering/App/Segmentation.h @@ -49,7 +49,7 @@ private: class NormalEstimation { public: - NormalEstimation(const Points::PointKernel&); + explicit NormalEstimation(const Points::PointKernel&); /** \brief Set the number of k nearest neighbors to use for the feature estimation. * \param[in] k the number of k-nearest neighbors */ diff --git a/src/Mod/ReverseEngineering/Gui/FitBSplineSurface.h b/src/Mod/ReverseEngineering/Gui/FitBSplineSurface.h index a22d650a7e..02e6a22817 100644 --- a/src/Mod/ReverseEngineering/Gui/FitBSplineSurface.h +++ b/src/Mod/ReverseEngineering/Gui/FitBSplineSurface.h @@ -35,7 +35,7 @@ class FitBSplineSurfaceWidget : public QWidget Q_OBJECT public: - FitBSplineSurfaceWidget(const App::DocumentObjectT&, QWidget* parent = nullptr); + explicit FitBSplineSurfaceWidget(const App::DocumentObjectT&, QWidget* parent = nullptr); ~FitBSplineSurfaceWidget() override; bool accept(); @@ -58,7 +58,7 @@ class TaskFitBSplineSurface : public Gui::TaskView::TaskDialog Q_OBJECT public: - TaskFitBSplineSurface(const App::DocumentObjectT&); + explicit TaskFitBSplineSurface(const App::DocumentObjectT&); ~TaskFitBSplineSurface() override; public: diff --git a/src/Mod/ReverseEngineering/Gui/Poisson.h b/src/Mod/ReverseEngineering/Gui/Poisson.h index 37426efd02..3277e73dd5 100644 --- a/src/Mod/ReverseEngineering/Gui/Poisson.h +++ b/src/Mod/ReverseEngineering/Gui/Poisson.h @@ -35,7 +35,7 @@ class PoissonWidget : public QWidget Q_OBJECT public: - PoissonWidget(const App::DocumentObjectT&, QWidget* parent = nullptr); + explicit PoissonWidget(const App::DocumentObjectT&, QWidget* parent = nullptr); ~PoissonWidget() override; bool accept(); @@ -53,7 +53,7 @@ class TaskPoisson : public Gui::TaskView::TaskDialog Q_OBJECT public: - TaskPoisson(const App::DocumentObjectT&); + explicit TaskPoisson(const App::DocumentObjectT&); ~TaskPoisson() override; public: diff --git a/src/Mod/ReverseEngineering/Gui/Segmentation.h b/src/Mod/ReverseEngineering/Gui/Segmentation.h index 69a975bd40..f46b7df756 100644 --- a/src/Mod/ReverseEngineering/Gui/Segmentation.h +++ b/src/Mod/ReverseEngineering/Gui/Segmentation.h @@ -41,7 +41,7 @@ class Segmentation : public QWidget Q_OBJECT public: - Segmentation(Mesh::Feature* mesh, QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); + explicit Segmentation(Mesh::Feature* mesh, QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); ~Segmentation() override; void accept(); @@ -59,7 +59,7 @@ private: class TaskSegmentation : public Gui::TaskView::TaskDialog { public: - TaskSegmentation(Mesh::Feature* mesh); + explicit TaskSegmentation(Mesh::Feature* mesh); ~TaskSegmentation() override; public: diff --git a/src/Mod/ReverseEngineering/Gui/SegmentationManual.h b/src/Mod/ReverseEngineering/Gui/SegmentationManual.h index b74cf583b9..0133ccbb6c 100644 --- a/src/Mod/ReverseEngineering/Gui/SegmentationManual.h +++ b/src/Mod/ReverseEngineering/Gui/SegmentationManual.h @@ -43,7 +43,7 @@ class SegmentationManual : public QWidget Q_OBJECT public: - SegmentationManual(QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); + explicit SegmentationManual(QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags()); ~SegmentationManual() override; void reject(); void createSegment(); diff --git a/src/Mod/Robot/Gui/TaskDlgEdge2Trac.h b/src/Mod/Robot/Gui/TaskDlgEdge2Trac.h index b09c909345..f7f0658ae0 100644 --- a/src/Mod/Robot/Gui/TaskDlgEdge2Trac.h +++ b/src/Mod/Robot/Gui/TaskDlgEdge2Trac.h @@ -44,7 +44,7 @@ class RobotGuiExport TaskDlgEdge2Trac : public Gui::TaskView::TaskDialog Q_OBJECT public: - TaskDlgEdge2Trac(Robot::Edge2TracObject *); + explicit TaskDlgEdge2Trac(Robot::Edge2TracObject *); ~TaskDlgEdge2Trac() override; public: diff --git a/src/Mod/Robot/Gui/TaskDlgTrajectoryDressUp.h b/src/Mod/Robot/Gui/TaskDlgTrajectoryDressUp.h index eab1dc0bae..3add544ec1 100644 --- a/src/Mod/Robot/Gui/TaskDlgTrajectoryDressUp.h +++ b/src/Mod/Robot/Gui/TaskDlgTrajectoryDressUp.h @@ -44,7 +44,7 @@ class RobotGuiExport TaskDlgTrajectoryDressUp : public Gui::TaskView::TaskDialog Q_OBJECT public: - TaskDlgTrajectoryDressUp(Robot::TrajectoryDressUpObject *); + explicit TaskDlgTrajectoryDressUp(Robot::TrajectoryDressUpObject *); ~TaskDlgTrajectoryDressUp() override; public: diff --git a/src/Mod/Robot/Gui/TaskEdge2TracParameter.h b/src/Mod/Robot/Gui/TaskEdge2TracParameter.h index 527fa375d5..675fb353a3 100644 --- a/src/Mod/Robot/Gui/TaskEdge2TracParameter.h +++ b/src/Mod/Robot/Gui/TaskEdge2TracParameter.h @@ -50,7 +50,7 @@ class TaskEdge2TracParameter : public Gui::TaskView::TaskBox Q_OBJECT public: - TaskEdge2TracParameter(Robot::Edge2TracObject *pcObject,QWidget *parent = nullptr); + explicit TaskEdge2TracParameter(Robot::Edge2TracObject *pcObject,QWidget *parent = nullptr); ~TaskEdge2TracParameter() override; void setEdgeAndClusterNbr(int NbrEdges,int NbrClusters); diff --git a/src/Mod/Robot/Gui/TaskRobot6Axis.h b/src/Mod/Robot/Gui/TaskRobot6Axis.h index 4d0b1a85e9..348fdbe208 100644 --- a/src/Mod/Robot/Gui/TaskRobot6Axis.h +++ b/src/Mod/Robot/Gui/TaskRobot6Axis.h @@ -51,7 +51,7 @@ class TaskRobot6Axis : public Gui::TaskView::TaskBox Q_OBJECT public: - TaskRobot6Axis(Robot::RobotObject *pcRobotObject,QWidget *parent = nullptr); + explicit TaskRobot6Axis(Robot::RobotObject *pcRobotObject,QWidget *parent = nullptr); ~TaskRobot6Axis() override; void setRobot(Robot::RobotObject *pcRobotObject); diff --git a/src/Mod/Robot/Gui/TaskRobotControl.h b/src/Mod/Robot/Gui/TaskRobotControl.h index 9e37904090..16b6f39d67 100644 --- a/src/Mod/Robot/Gui/TaskRobotControl.h +++ b/src/Mod/Robot/Gui/TaskRobotControl.h @@ -50,7 +50,7 @@ class TaskRobotControl : public Gui::TaskView::TaskBox Q_OBJECT public: - TaskRobotControl(Robot::RobotObject *pcRobotObject,QWidget *parent = nullptr); + explicit TaskRobotControl(Robot::RobotObject *pcRobotObject,QWidget *parent = nullptr); ~TaskRobotControl() override; void setRobot(Robot::RobotObject *pcRobotObject); diff --git a/src/Mod/Robot/Gui/TaskRobotMessages.h b/src/Mod/Robot/Gui/TaskRobotMessages.h index d406f3b920..19bf9f6429 100644 --- a/src/Mod/Robot/Gui/TaskRobotMessages.h +++ b/src/Mod/Robot/Gui/TaskRobotMessages.h @@ -50,7 +50,7 @@ class TaskRobotMessages : public Gui::TaskView::TaskBox Q_OBJECT public: - TaskRobotMessages(Robot::RobotObject *pcRobotObject,QWidget *parent = nullptr); + explicit TaskRobotMessages(Robot::RobotObject *pcRobotObject,QWidget *parent = nullptr); ~TaskRobotMessages() override; private Q_SLOTS: diff --git a/src/Mod/Robot/Gui/TaskTrajectoryDressUpParameter.h b/src/Mod/Robot/Gui/TaskTrajectoryDressUpParameter.h index 0ac2bfb721..ab986d7177 100644 --- a/src/Mod/Robot/Gui/TaskTrajectoryDressUpParameter.h +++ b/src/Mod/Robot/Gui/TaskTrajectoryDressUpParameter.h @@ -44,7 +44,7 @@ class TaskTrajectoryDressUpParameter : public Gui::TaskView::TaskBox Q_OBJECT public: - TaskTrajectoryDressUpParameter(Robot::TrajectoryDressUpObject *obj,QWidget *parent = nullptr); + explicit TaskTrajectoryDressUpParameter(Robot::TrajectoryDressUpObject *obj,QWidget *parent = nullptr); ~TaskTrajectoryDressUpParameter() override; /// this methode write the values from the Gui to the object, usually in accept() diff --git a/src/Mod/Sketcher/App/Analyse.h b/src/Mod/Sketcher/App/Analyse.h index 875fbb8e96..97f7c498a6 100644 --- a/src/Mod/Sketcher/App/Analyse.h +++ b/src/Mod/Sketcher/App/Analyse.h @@ -44,7 +44,7 @@ struct Constraint_Equal typedef ConstraintIds argument_type; typedef bool result_type; struct Sketcher::ConstraintIds c; - Constraint_Equal(const ConstraintIds& c) : c(c) + explicit Constraint_Equal(const ConstraintIds& c) : c(c) { } bool operator()(const ConstraintIds& x) const diff --git a/src/Mod/Sketcher/App/ExternalGeometryFacade.h b/src/Mod/Sketcher/App/ExternalGeometryFacade.h index 2e759d8c69..2b0e218741 100644 --- a/src/Mod/Sketcher/App/ExternalGeometryFacade.h +++ b/src/Mod/Sketcher/App/ExternalGeometryFacade.h @@ -54,7 +54,7 @@ class SketcherExport ExternalGeometryFacade : public Base::BaseClass, private IS TYPESYSTEM_HEADER_WITH_OVERRIDE(); private: - ExternalGeometryFacade(const Part::Geometry * geometry); + explicit ExternalGeometryFacade(const Part::Geometry * geometry); ExternalGeometryFacade(); // As TYPESYSTEM requirement friend class ExternalGeometryFacadePy; diff --git a/src/Mod/Sketcher/App/GeometryFacade.h b/src/Mod/Sketcher/App/GeometryFacade.h index 954a97a5a6..e01c951bd0 100644 --- a/src/Mod/Sketcher/App/GeometryFacade.h +++ b/src/Mod/Sketcher/App/GeometryFacade.h @@ -108,7 +108,7 @@ class SketcherExport GeometryFacade : public Base::BaseClass, private ISketchGeo TYPESYSTEM_HEADER_WITH_OVERRIDE(); protected: - GeometryFacade(const Part::Geometry * geometry, bool owner = false); + explicit GeometryFacade(const Part::Geometry * geometry, bool owner = false); GeometryFacade(); // As TYPESYSTEM requirement friend class GeometryFacadePy; @@ -266,7 +266,7 @@ class SketcherExport GeometryTypedFacade : public GeometryFacade static_assert( std::is_base_of::type>::value && !std::is_same::type>::value, "Only for classes derived from Geometry!"); private: - GeometryTypedFacade(const Part::Geometry * geometry, bool owner = false):GeometryFacade(geometry, owner) {} + explicit GeometryTypedFacade(const Part::Geometry * geometry, bool owner = false):GeometryFacade(geometry, owner) {} GeometryTypedFacade():GeometryFacade() {} public: // Factory methods diff --git a/src/Mod/Sketcher/App/SketchAnalysis.cpp b/src/Mod/Sketcher/App/SketchAnalysis.cpp index 8c690bcb97..ccb2bddb35 100644 --- a/src/Mod/Sketcher/App/SketchAnalysis.cpp +++ b/src/Mod/Sketcher/App/SketchAnalysis.cpp @@ -71,7 +71,7 @@ struct SketchAnalysis::VertexIds { struct SketchAnalysis::Vertex_Less { - Vertex_Less(double tolerance) : tolerance(tolerance){} + explicit Vertex_Less(double tolerance) : tolerance(tolerance){} bool operator()(const VertexIds& x, const VertexIds& y) const { @@ -98,7 +98,7 @@ struct SketchAnalysis::VertexID_Less struct SketchAnalysis::Vertex_EqualTo { - Vertex_EqualTo(double tolerance) : tolerance(tolerance){} + explicit Vertex_EqualTo(double tolerance) : tolerance(tolerance){} bool operator()(const VertexIds& x, const VertexIds& y) const { @@ -122,7 +122,7 @@ struct SketchAnalysis::EdgeIds { struct SketchAnalysis::Edge_Less { - Edge_Less(double tolerance) : tolerance(tolerance){} + explicit Edge_Less(double tolerance) : tolerance(tolerance){} bool operator()(const EdgeIds& x, const EdgeIds& y) const { @@ -136,7 +136,7 @@ private: struct SketchAnalysis::Edge_EqualTo { - Edge_EqualTo(double tolerance) : tolerance(tolerance){} + explicit Edge_EqualTo(double tolerance) : tolerance(tolerance){} bool operator()(const EdgeIds& x, const EdgeIds& y) const { diff --git a/src/Mod/Sketcher/App/SketchAnalysis.h b/src/Mod/Sketcher/App/SketchAnalysis.h index b9bb589483..bb6bf97abf 100644 --- a/src/Mod/Sketcher/App/SketchAnalysis.h +++ b/src/Mod/Sketcher/App/SketchAnalysis.h @@ -63,7 +63,7 @@ public: /// They may also apply a variaty of types of Constraints. /// /// A third type of routines do not relate to autoconstraining at all, and include validation methods for sketches. - SketchAnalysis(Sketcher::SketchObject * Obj); + explicit SketchAnalysis(Sketcher::SketchObject * Obj); ~SketchAnalysis(); // Simple routines (see constructor) diff --git a/src/Mod/Sketcher/App/SketchGeometryExtension.h b/src/Mod/Sketcher/App/SketchGeometryExtension.h index 638e8d04b3..b0e9555d31 100644 --- a/src/Mod/Sketcher/App/SketchGeometryExtension.h +++ b/src/Mod/Sketcher/App/SketchGeometryExtension.h @@ -83,7 +83,7 @@ class SketcherExport SketchGeometryExtension : public Part::GeometryPersistenceE public: SketchGeometryExtension(); - SketchGeometryExtension(long cid); + explicit SketchGeometryExtension(long cid); ~SketchGeometryExtension() override = default; std::unique_ptr copy() const override; diff --git a/src/Mod/Sketcher/App/SolverGeometryExtension.h b/src/Mod/Sketcher/App/SolverGeometryExtension.h index e1f92a560e..ddd6728a94 100644 --- a/src/Mod/Sketcher/App/SolverGeometryExtension.h +++ b/src/Mod/Sketcher/App/SolverGeometryExtension.h @@ -51,7 +51,7 @@ public: class PointParameterStatus { public: - PointParameterStatus(ParameterStatus status) {setStatus(status);} + explicit PointParameterStatus(ParameterStatus status) {setStatus(status);} PointParameterStatus(ParameterStatus statusx, ParameterStatus statusy) {setStatus(statusx, statusy);} PointParameterStatus(const PointParameterStatus &) = default; diff --git a/src/Mod/Sketcher/Gui/Command.cpp b/src/Mod/Sketcher/Gui/Command.cpp index b049d39645..e4fe78854d 100644 --- a/src/Mod/Sketcher/Gui/Command.cpp +++ b/src/Mod/Sketcher/Gui/Command.cpp @@ -71,7 +71,7 @@ namespace SketcherGui { } //Pass untranslated strings, enclosed in QT_TR_NOOP() - ExceptionWrongInput(const char* ErrMsg){ + explicit ExceptionWrongInput(const char* ErrMsg){ this->ErrMsg = QObject::tr( ErrMsg ); this->setMessage(ErrMsg); } diff --git a/src/Mod/Sketcher/Gui/CommandConstraints.cpp b/src/Mod/Sketcher/Gui/CommandConstraints.cpp index 09bc3e9bd0..3abd55408c 100644 --- a/src/Mod/Sketcher/Gui/CommandConstraints.cpp +++ b/src/Mod/Sketcher/Gui/CommandConstraints.cpp @@ -600,7 +600,7 @@ namespace SketcherGui { { App::DocumentObject* object; public: - GenericConstraintSelection(App::DocumentObject* obj) + explicit GenericConstraintSelection(App::DocumentObject* obj) : Gui::SelectionFilterGate(nullPointer()) , object(obj), allowedSelTypes(0) {} @@ -641,7 +641,7 @@ class CmdSketcherConstraint : public Gui::Command { friend class DrawSketchHandlerGenConstraint; public: - CmdSketcherConstraint(const char* name) + explicit CmdSketcherConstraint(const char* name) : Command(name) {} ~CmdSketcherConstraint() override{} @@ -675,7 +675,7 @@ protected: class DrawSketchHandlerGenConstraint: public DrawSketchHandler { public: - DrawSketchHandlerGenConstraint(CmdSketcherConstraint *_cmd) + explicit DrawSketchHandlerGenConstraint(CmdSketcherConstraint *_cmd) : cmd(_cmd), seqIndex(0) {} ~DrawSketchHandlerGenConstraint() override { diff --git a/src/Mod/Sketcher/Gui/CommandSketcherTools.cpp b/src/Mod/Sketcher/Gui/CommandSketcherTools.cpp index 6c832f13a4..be5131ec2c 100644 --- a/src/Mod/Sketcher/Gui/CommandSketcherTools.cpp +++ b/src/Mod/Sketcher/Gui/CommandSketcherTools.cpp @@ -1032,7 +1032,7 @@ public: Clone, Move }; - SketcherCopy(const char* name); + explicit SketcherCopy(const char* name); void activate(SketcherCopy::Op op); virtual void activate() = 0; }; diff --git a/src/Mod/Sketcher/Gui/DrawSketchHandlerBSpline.h b/src/Mod/Sketcher/Gui/DrawSketchHandlerBSpline.h index bb32f08c31..30655db9e8 100644 --- a/src/Mod/Sketcher/Gui/DrawSketchHandlerBSpline.h +++ b/src/Mod/Sketcher/Gui/DrawSketchHandlerBSpline.h @@ -35,7 +35,7 @@ extern GeometryCreationMode geometryCreationMode; // defined in CommandCreateGeo class DrawSketchHandlerBSpline: public DrawSketchHandler { public: - DrawSketchHandlerBSpline(int constructionMethod) + explicit DrawSketchHandlerBSpline(int constructionMethod) : Mode(STATUS_SEEK_FIRST_CONTROLPOINT) , MousePressMode(MOUSE_NOT_PRESSED) , ConstrMethod(constructionMethod) diff --git a/src/Mod/Sketcher/Gui/DrawSketchHandlerCarbonCopy.h b/src/Mod/Sketcher/Gui/DrawSketchHandlerCarbonCopy.h index b29a5e52c8..7e1c44a1b3 100644 --- a/src/Mod/Sketcher/Gui/DrawSketchHandlerCarbonCopy.h +++ b/src/Mod/Sketcher/Gui/DrawSketchHandlerCarbonCopy.h @@ -36,7 +36,7 @@ class CarbonCopySelection : public Gui::SelectionFilterGate { App::DocumentObject* object; public: - CarbonCopySelection(App::DocumentObject* obj) + explicit CarbonCopySelection(App::DocumentObject* obj) : Gui::SelectionFilterGate(nullPointer()), object(obj) {} diff --git a/src/Mod/Sketcher/Gui/DrawSketchHandlerEllipse.h b/src/Mod/Sketcher/Gui/DrawSketchHandlerEllipse.h index 2c9dc13b85..5b322213fe 100644 --- a/src/Mod/Sketcher/Gui/DrawSketchHandlerEllipse.h +++ b/src/Mod/Sketcher/Gui/DrawSketchHandlerEllipse.h @@ -75,7 +75,7 @@ extern GeometryCreationMode geometryCreationMode; // defined in CommandCreateGeo class DrawSketchHandlerEllipse : public DrawSketchHandler { public: - DrawSketchHandlerEllipse(int constructionMethod) + explicit DrawSketchHandlerEllipse(int constructionMethod) : mode(STATUS_Close) , method(CENTER_PERIAPSIS_B) , constrMethod(constructionMethod) diff --git a/src/Mod/Sketcher/Gui/DrawSketchHandlerExtend.h b/src/Mod/Sketcher/Gui/DrawSketchHandlerExtend.h index 05468ff825..cd4a736d9e 100644 --- a/src/Mod/Sketcher/Gui/DrawSketchHandlerExtend.h +++ b/src/Mod/Sketcher/Gui/DrawSketchHandlerExtend.h @@ -36,7 +36,7 @@ class ExtendSelection : public Gui::SelectionFilterGate { App::DocumentObject* object; public: - ExtendSelection(App::DocumentObject* obj) + explicit ExtendSelection(App::DocumentObject* obj) : Gui::SelectionFilterGate(nullPointer()) , object(obj) , disabled(false) diff --git a/src/Mod/Sketcher/Gui/DrawSketchHandlerExternal.h b/src/Mod/Sketcher/Gui/DrawSketchHandlerExternal.h index c8135fd437..cf438a188a 100644 --- a/src/Mod/Sketcher/Gui/DrawSketchHandlerExternal.h +++ b/src/Mod/Sketcher/Gui/DrawSketchHandlerExternal.h @@ -36,7 +36,7 @@ class ExternalSelection : public Gui::SelectionFilterGate { App::DocumentObject* object; public: - ExternalSelection(App::DocumentObject* obj) + explicit ExternalSelection(App::DocumentObject* obj) : Gui::SelectionFilterGate(nullPointer()), object(obj) {} diff --git a/src/Mod/Sketcher/Gui/DrawSketchHandlerFillet.h b/src/Mod/Sketcher/Gui/DrawSketchHandlerFillet.h index 37388969f1..6920eb8858 100644 --- a/src/Mod/Sketcher/Gui/DrawSketchHandlerFillet.h +++ b/src/Mod/Sketcher/Gui/DrawSketchHandlerFillet.h @@ -35,7 +35,7 @@ class FilletSelection : public Gui::SelectionFilterGate { App::DocumentObject* object; public: - FilletSelection(App::DocumentObject* obj) + explicit FilletSelection(App::DocumentObject* obj) : Gui::SelectionFilterGate(nullPointer()), object(obj) {} @@ -80,7 +80,7 @@ public: ConstraintPreservingFillet }; - DrawSketchHandlerFillet(FilletType filletType) : filletType(filletType), Mode(STATUS_SEEK_First), firstCurve(0) {} + explicit DrawSketchHandlerFillet(FilletType filletType) : filletType(filletType), Mode(STATUS_SEEK_First), firstCurve(0) {} virtual ~DrawSketchHandlerFillet() { Gui::Selection().rmvSelectionGate(); diff --git a/src/Mod/Sketcher/Gui/DrawSketchHandlerPolygon.h b/src/Mod/Sketcher/Gui/DrawSketchHandlerPolygon.h index 61640c0a98..8e66dd0558 100644 --- a/src/Mod/Sketcher/Gui/DrawSketchHandlerPolygon.h +++ b/src/Mod/Sketcher/Gui/DrawSketchHandlerPolygon.h @@ -36,7 +36,7 @@ extern GeometryCreationMode geometryCreationMode; // defined in CommandCreateGeo class DrawSketchHandlerRegularPolygon: public DrawSketchHandler { public: - DrawSketchHandlerRegularPolygon( size_t nof_corners ): + explicit DrawSketchHandlerRegularPolygon( size_t nof_corners ): Corners( nof_corners ), AngleOfSeparation( 2.0*M_PI/static_cast(Corners) ), cos_v( cos( AngleOfSeparation ) ), diff --git a/src/Mod/Sketcher/Gui/DrawSketchHandlerRectangle.h b/src/Mod/Sketcher/Gui/DrawSketchHandlerRectangle.h index ec9f4cba52..980729db7d 100644 --- a/src/Mod/Sketcher/Gui/DrawSketchHandlerRectangle.h +++ b/src/Mod/Sketcher/Gui/DrawSketchHandlerRectangle.h @@ -40,7 +40,7 @@ public: CenterAndCorner }; - DrawSketchHandlerBox(ConstructionMethod constrMethod = Diagonal): Mode(STATUS_SEEK_First), + explicit DrawSketchHandlerBox(ConstructionMethod constrMethod = Diagonal): Mode(STATUS_SEEK_First), EditCurve(5), constructionMethod(constrMethod){} virtual ~DrawSketchHandlerBox(){} diff --git a/src/Mod/Sketcher/Gui/DrawSketchHandlerSplitting.h b/src/Mod/Sketcher/Gui/DrawSketchHandlerSplitting.h index 4eebebdda5..9a0630ea78 100644 --- a/src/Mod/Sketcher/Gui/DrawSketchHandlerSplitting.h +++ b/src/Mod/Sketcher/Gui/DrawSketchHandlerSplitting.h @@ -37,7 +37,7 @@ class SplittingSelection : public Gui::SelectionFilterGate { App::DocumentObject* object; public: - SplittingSelection(App::DocumentObject* obj) + explicit SplittingSelection(App::DocumentObject* obj) : Gui::SelectionFilterGate(nullPointer()), object(obj) {} diff --git a/src/Mod/Sketcher/Gui/DrawSketchHandlerTrimming.h b/src/Mod/Sketcher/Gui/DrawSketchHandlerTrimming.h index a658120c37..bee6475dfb 100644 --- a/src/Mod/Sketcher/Gui/DrawSketchHandlerTrimming.h +++ b/src/Mod/Sketcher/Gui/DrawSketchHandlerTrimming.h @@ -36,7 +36,7 @@ class TrimmingSelection : public Gui::SelectionFilterGate { App::DocumentObject* object; public: - TrimmingSelection(App::DocumentObject* obj) + explicit TrimmingSelection(App::DocumentObject* obj) : Gui::SelectionFilterGate(nullPointer()), object(obj) {} diff --git a/src/Mod/Sketcher/Gui/EditModeCoinManager.h b/src/Mod/Sketcher/Gui/EditModeCoinManager.h index bb575b6ea9..77e2a76bb4 100644 --- a/src/Mod/Sketcher/Gui/EditModeCoinManager.h +++ b/src/Mod/Sketcher/Gui/EditModeCoinManager.h @@ -117,7 +117,7 @@ class SketcherGuiExport EditModeCoinManager }; public: - ParameterObserver(EditModeCoinManager & client); + explicit ParameterObserver(EditModeCoinManager & client); ~ParameterObserver() override; void subscribeToParameters(); diff --git a/src/Mod/Sketcher/Gui/ShortcutListener.h b/src/Mod/Sketcher/Gui/ShortcutListener.h index e10fecb2f9..80d0ae7f65 100644 --- a/src/Mod/Sketcher/Gui/ShortcutListener.h +++ b/src/Mod/Sketcher/Gui/ShortcutListener.h @@ -44,7 +44,7 @@ class ShortcutListener: public QObject //Q_OBJECT public: - ShortcutListener(ViewProviderSketch * vp); + explicit ShortcutListener(ViewProviderSketch * vp); ~ShortcutListener() override; protected: diff --git a/src/Mod/Sketcher/Gui/SketcherSettings.h b/src/Mod/Sketcher/Gui/SketcherSettings.h index f1200de1f1..13e4b3f2b6 100644 --- a/src/Mod/Sketcher/Gui/SketcherSettings.h +++ b/src/Mod/Sketcher/Gui/SketcherSettings.h @@ -41,7 +41,7 @@ class SketcherSettings : public Gui::Dialog::PreferencePage Q_OBJECT public: - SketcherSettings(QWidget* parent = nullptr); + explicit SketcherSettings(QWidget* parent = nullptr); ~SketcherSettings() override; void saveSettings() override; @@ -64,7 +64,7 @@ class SketcherSettingsDisplay : public Gui::Dialog::PreferencePage Q_OBJECT public: - SketcherSettingsDisplay(QWidget* parent = nullptr); + explicit SketcherSettingsDisplay(QWidget* parent = nullptr); ~SketcherSettingsDisplay() override; void saveSettings() override; @@ -89,7 +89,7 @@ class SketcherSettingsColors : public Gui::Dialog::PreferencePage Q_OBJECT public: - SketcherSettingsColors(QWidget* parent = nullptr); + explicit SketcherSettingsColors(QWidget* parent = nullptr); ~SketcherSettingsColors() override; void saveSettings() override; diff --git a/src/Mod/Sketcher/Gui/TaskDlgEditSketch.h b/src/Mod/Sketcher/Gui/TaskDlgEditSketch.h index 9abfe74fba..73a057f1d7 100644 --- a/src/Mod/Sketcher/Gui/TaskDlgEditSketch.h +++ b/src/Mod/Sketcher/Gui/TaskDlgEditSketch.h @@ -45,7 +45,7 @@ class SketcherGuiExport TaskDlgEditSketch : public Gui::TaskView::TaskDialog Q_OBJECT public: - TaskDlgEditSketch(ViewProviderSketch *sketchView); + explicit TaskDlgEditSketch(ViewProviderSketch *sketchView); ~TaskDlgEditSketch() override; ViewProviderSketch* getSketchView() const { return sketchView; } diff --git a/src/Mod/Sketcher/Gui/TaskSketcherConstraints.cpp b/src/Mod/Sketcher/Gui/TaskSketcherConstraints.cpp index 04323ffb89..82e5ef65d4 100644 --- a/src/Mod/Sketcher/Gui/TaskSketcherConstraints.cpp +++ b/src/Mod/Sketcher/Gui/TaskSketcherConstraints.cpp @@ -382,7 +382,7 @@ public: class ExpressionDelegate : public QStyledItemDelegate { public: - ExpressionDelegate(QListWidget * _view) : QStyledItemDelegate(_view), view(_view) { } + explicit ExpressionDelegate(QListWidget * _view) : QStyledItemDelegate(_view), view(_view) { } protected: QPixmap getIcon(const char* name, const QSize& size) const { diff --git a/src/Mod/Sketcher/Gui/TaskSketcherConstraints.h b/src/Mod/Sketcher/Gui/TaskSketcherConstraints.h index f053d9cc06..5748ea31aa 100644 --- a/src/Mod/Sketcher/Gui/TaskSketcherConstraints.h +++ b/src/Mod/Sketcher/Gui/TaskSketcherConstraints.h @@ -83,7 +83,7 @@ class TaskSketcherConstraints : public Gui::TaskView::TaskBox, public Gui::Selec }; public: - TaskSketcherConstraints(ViewProviderSketch *sketchView); + explicit TaskSketcherConstraints(ViewProviderSketch *sketchView); ~TaskSketcherConstraints() override; /// Observer message from the Selection diff --git a/src/Mod/Sketcher/Gui/TaskSketcherCreateCommands.h b/src/Mod/Sketcher/Gui/TaskSketcherCreateCommands.h index 51f4b34079..a77bfef635 100644 --- a/src/Mod/Sketcher/Gui/TaskSketcherCreateCommands.h +++ b/src/Mod/Sketcher/Gui/TaskSketcherCreateCommands.h @@ -45,7 +45,7 @@ class TaskSketcherCreateCommands : public TaskBox, public Gui::SelectionSingleto Q_OBJECT public: - TaskSketcherCreateCommands(QWidget *parent = nullptr); + explicit TaskSketcherCreateCommands(QWidget *parent = nullptr); ~TaskSketcherCreateCommands() override; /// Observer message from the Selection void OnChange(Gui::SelectionSingleton::SubjectType &rCaller, diff --git a/src/Mod/Sketcher/Gui/TaskSketcherElements.h b/src/Mod/Sketcher/Gui/TaskSketcherElements.h index 7d390e74b4..ba5d5aef1a 100644 --- a/src/Mod/Sketcher/Gui/TaskSketcherElements.h +++ b/src/Mod/Sketcher/Gui/TaskSketcherElements.h @@ -95,7 +95,7 @@ class TaskSketcherElements : public Gui::TaskView::TaskBox, public Gui::Selectio class MultIcon { public: - MultIcon(const char*); + explicit MultIcon(const char*); QIcon Normal; QIcon Construction; @@ -105,7 +105,7 @@ class TaskSketcherElements : public Gui::TaskView::TaskBox, public Gui::Selectio }; public: - TaskSketcherElements(ViewProviderSketch *sketchView); + explicit TaskSketcherElements(ViewProviderSketch *sketchView); ~TaskSketcherElements() override; /// Observer message from the Selection diff --git a/src/Mod/Sketcher/Gui/TaskSketcherGeneral.h b/src/Mod/Sketcher/Gui/TaskSketcherGeneral.h index 41296d42c0..509a323140 100644 --- a/src/Mod/Sketcher/Gui/TaskSketcherGeneral.h +++ b/src/Mod/Sketcher/Gui/TaskSketcherGeneral.h @@ -46,7 +46,7 @@ class SketcherGeneralWidget : public QWidget Q_OBJECT public: - SketcherGeneralWidget(QWidget *parent=nullptr); + explicit SketcherGeneralWidget(QWidget *parent=nullptr); ~SketcherGeneralWidget() override; bool eventFilter(QObject *object, QEvent *event) override; @@ -84,7 +84,7 @@ class TaskSketcherGeneral : public Gui::TaskView::TaskBox, Q_OBJECT public: - TaskSketcherGeneral(ViewProviderSketch *sketchView); + explicit TaskSketcherGeneral(ViewProviderSketch *sketchView); ~TaskSketcherGeneral() override; /// Observer message from the Selection void OnChange(Gui::SelectionSingleton::SubjectType &rCaller, diff --git a/src/Mod/Sketcher/Gui/TaskSketcherMessages.h b/src/Mod/Sketcher/Gui/TaskSketcherMessages.h index 54da9834a1..b211daf83d 100644 --- a/src/Mod/Sketcher/Gui/TaskSketcherMessages.h +++ b/src/Mod/Sketcher/Gui/TaskSketcherMessages.h @@ -44,7 +44,7 @@ class TaskSketcherMessages : public Gui::TaskView::TaskBox Q_OBJECT public: - TaskSketcherMessages(ViewProviderSketch *sketchView); + explicit TaskSketcherMessages(ViewProviderSketch *sketchView); ~TaskSketcherMessages() override; void slotSetUp(const QString &state, const QString &msg, const QString& link, const QString& linkText); diff --git a/src/Mod/Sketcher/Gui/TaskSketcherSolverAdvanced.h b/src/Mod/Sketcher/Gui/TaskSketcherSolverAdvanced.h index 2a92683ede..652df7f770 100644 --- a/src/Mod/Sketcher/Gui/TaskSketcherSolverAdvanced.h +++ b/src/Mod/Sketcher/Gui/TaskSketcherSolverAdvanced.h @@ -42,7 +42,7 @@ class TaskSketcherSolverAdvanced : public Gui::TaskView::TaskBox Q_OBJECT public: - TaskSketcherSolverAdvanced(ViewProviderSketch *sketchView); + explicit TaskSketcherSolverAdvanced(ViewProviderSketch *sketchView); ~TaskSketcherSolverAdvanced() override; private Q_SLOTS: diff --git a/src/Mod/Sketcher/Gui/TaskSketcherValidation.h b/src/Mod/Sketcher/Gui/TaskSketcherValidation.h index 9cbf4b69a4..2b7cc58b27 100644 --- a/src/Mod/Sketcher/Gui/TaskSketcherValidation.h +++ b/src/Mod/Sketcher/Gui/TaskSketcherValidation.h @@ -42,7 +42,7 @@ class SketcherValidation : public QWidget Q_OBJECT public: - SketcherValidation(Sketcher::SketchObject* Obj, QWidget* parent = nullptr); + explicit SketcherValidation(Sketcher::SketchObject* Obj, QWidget* parent = nullptr); ~SketcherValidation() override; protected: @@ -78,7 +78,7 @@ class TaskSketcherValidation : public Gui::TaskView::TaskDialog Q_OBJECT public: - TaskSketcherValidation(Sketcher::SketchObject* Obj); + explicit TaskSketcherValidation(Sketcher::SketchObject* Obj); ~TaskSketcherValidation() override; QDialogButtonBox::StandardButtons getStandardButtons(void) const override { return QDialogButtonBox::Close; } diff --git a/src/Mod/Sketcher/Gui/ViewProviderSketch.h b/src/Mod/Sketcher/Gui/ViewProviderSketch.h index f76238f6b5..e8a19f6b18 100644 --- a/src/Mod/Sketcher/Gui/ViewProviderSketch.h +++ b/src/Mod/Sketcher/Gui/ViewProviderSketch.h @@ -154,7 +154,7 @@ private: class ParameterObserver : public ParameterGrp::ObserverType { public: - ParameterObserver(ViewProviderSketch & client); + explicit ParameterObserver(ViewProviderSketch & client); ~ParameterObserver(); void initParameters(); diff --git a/src/Mod/Spreadsheet/App/DisplayUnit.h b/src/Mod/Spreadsheet/App/DisplayUnit.h index d15053dc86..25089e5fa7 100644 --- a/src/Mod/Spreadsheet/App/DisplayUnit.h +++ b/src/Mod/Spreadsheet/App/DisplayUnit.h @@ -35,7 +35,7 @@ public: Base::Unit unit; double scaler; - DisplayUnit(const std::string _stringRep = "", const Base::Unit _unit = Base::Unit(), double _scaler = 0.0) + explicit DisplayUnit(const std::string _stringRep = "", const Base::Unit _unit = Base::Unit(), double _scaler = 0.0) : stringRep(_stringRep) , unit(_unit) , scaler(_scaler) diff --git a/src/Mod/Spreadsheet/App/PropertySheet.h b/src/Mod/Spreadsheet/App/PropertySheet.h index e58bd722cd..0ca0f362ae 100644 --- a/src/Mod/Spreadsheet/App/PropertySheet.h +++ b/src/Mod/Spreadsheet/App/PropertySheet.h @@ -43,7 +43,7 @@ class SpreadsheetExport PropertySheet : public App::PropertyExpressionContainer TYPESYSTEM_HEADER_WITH_OVERRIDE(); public: - PropertySheet(Sheet * _owner = nullptr); + explicit PropertySheet(Sheet * _owner = nullptr); ~PropertySheet() override; diff --git a/src/Mod/Spreadsheet/Gui/DlgSettingsImp.h b/src/Mod/Spreadsheet/Gui/DlgSettingsImp.h index dac4dc5bc3..3aa365e81e 100644 --- a/src/Mod/Spreadsheet/Gui/DlgSettingsImp.h +++ b/src/Mod/Spreadsheet/Gui/DlgSettingsImp.h @@ -40,7 +40,7 @@ class DlgSettingsImp : public Gui::Dialog::PreferencePage Q_OBJECT public: - DlgSettingsImp( QWidget* parent = nullptr ); + explicit DlgSettingsImp( QWidget* parent = nullptr ); ~DlgSettingsImp() override; protected: diff --git a/src/Mod/Spreadsheet/Gui/SheetModel.h b/src/Mod/Spreadsheet/Gui/SheetModel.h index 91851df3ea..dd71b8748c 100644 --- a/src/Mod/Spreadsheet/Gui/SheetModel.h +++ b/src/Mod/Spreadsheet/Gui/SheetModel.h @@ -40,7 +40,7 @@ public: explicit SheetModel(Spreadsheet::Sheet * _sheet, QObject *parent = nullptr); ~SheetModel() override; - SheetModel(QObject *parent); + explicit SheetModel(QObject *parent); int rowCount(const QModelIndex &parent = QModelIndex()) const override ; int columnCount(const QModelIndex &parent = QModelIndex()) const override; QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override; diff --git a/src/Mod/Spreadsheet/Gui/SpreadsheetView.h b/src/Mod/Spreadsheet/Gui/SpreadsheetView.h index f67cb65720..445a87b0fc 100644 --- a/src/Mod/Spreadsheet/Gui/SpreadsheetView.h +++ b/src/Mod/Spreadsheet/Gui/SpreadsheetView.h @@ -133,7 +133,7 @@ public: using BaseType = Py::PythonExtension; static void init_type(); - SheetViewPy(SheetView *mdi); + explicit SheetViewPy(SheetView *mdi); ~SheetViewPy() override; Py::Object repr() override; diff --git a/src/Mod/Start/Gui/DlgStartPreferencesImp.h b/src/Mod/Start/Gui/DlgStartPreferencesImp.h index 124de87ec8..f65a5283c9 100644 --- a/src/Mod/Start/Gui/DlgStartPreferencesImp.h +++ b/src/Mod/Start/Gui/DlgStartPreferencesImp.h @@ -34,7 +34,7 @@ namespace StartGui { Q_OBJECT public: - DlgStartPreferencesImp( QWidget* parent = nullptr ); + explicit DlgStartPreferencesImp( QWidget* parent = nullptr ); ~DlgStartPreferencesImp() override; protected: diff --git a/src/Mod/TechDraw/App/Cosmetic.h b/src/Mod/TechDraw/App/Cosmetic.h index d4029e438b..dc0a5d3ad1 100644 --- a/src/Mod/TechDraw/App/Cosmetic.h +++ b/src/Mod/TechDraw/App/Cosmetic.h @@ -307,7 +307,7 @@ class TechDrawExport GeomFormat: public Base::Persistence public: GeomFormat(); - GeomFormat(TechDraw::GeomFormat* gf); + explicit GeomFormat(TechDraw::GeomFormat* gf); GeomFormat(int idx, LineFormat fmt); ~GeomFormat() override; diff --git a/src/Mod/TechDraw/App/Geometry.h b/src/Mod/TechDraw/App/Geometry.h index 510d1e0c9d..079cf2f807 100644 --- a/src/Mod/TechDraw/App/Geometry.h +++ b/src/Mod/TechDraw/App/Geometry.h @@ -161,7 +161,7 @@ class TechDrawExport Circle: public BaseGeom { public: Circle(); - Circle(const TopoDS_Edge &e); + explicit Circle(const TopoDS_Edge &e); Circle(Base::Vector3d center, double radius); ~Circle() override = default; @@ -177,7 +177,7 @@ class TechDrawExport Circle: public BaseGeom class TechDrawExport Ellipse: public BaseGeom { public: - Ellipse(const TopoDS_Edge &e); + explicit Ellipse(const TopoDS_Edge &e); Ellipse(Base::Vector3d c, double mnr, double mjr); ~Ellipse() override = default; @@ -193,7 +193,7 @@ class TechDrawExport Ellipse: public BaseGeom class TechDrawExport AOE: public Ellipse { public: - AOE(const TopoDS_Edge &e); + explicit AOE(const TopoDS_Edge &e); ~AOE() override = default; public: @@ -215,7 +215,7 @@ class TechDrawExport AOE: public Ellipse class TechDrawExport AOC: public Circle { public: - AOC(const TopoDS_Edge &e); + explicit AOC(const TopoDS_Edge &e); AOC(Base::Vector3d c, double r, double s, double e); AOC(); ~AOC() override = default; @@ -247,7 +247,7 @@ class TechDrawExport AOC: public Circle class TechDrawExport BezierSegment: public BaseGeom { public: - BezierSegment(const TopoDS_Edge &e); + explicit BezierSegment(const TopoDS_Edge &e); BezierSegment() { poles = degree = 0; } ~BezierSegment() override = default; @@ -260,7 +260,7 @@ public: class TechDrawExport BSpline: public BaseGeom { public: - BSpline(const TopoDS_Edge &e); + explicit BSpline(const TopoDS_Edge &e); ~BSpline() override = default; public: @@ -284,7 +284,7 @@ class TechDrawExport BSpline: public BaseGeom class TechDrawExport Generic: public BaseGeom { public: - Generic(const TopoDS_Edge &e); + explicit Generic(const TopoDS_Edge &e); Generic(); ~Generic() override = default; @@ -303,7 +303,7 @@ class TechDrawExport Wire { public: Wire(); - Wire(const TopoDS_Wire &w); + explicit Wire(const TopoDS_Wire &w); ~Wire(); TopoDS_Wire toOccWire() const; @@ -326,9 +326,9 @@ class TechDrawExport Vertex { public: Vertex(); - Vertex(const Vertex* v); + explicit Vertex(const Vertex* v); Vertex(double x, double y); - Vertex(Base::Vector3d v); + explicit Vertex(Base::Vector3d v); virtual ~Vertex() {} virtual void Save(Base::Writer &/*writer*/) const; diff --git a/src/Mod/TechDraw/App/HatchLine.h b/src/Mod/TechDraw/App/HatchLine.h index a645385352..b8fb3714bd 100644 --- a/src/Mod/TechDraw/App/HatchLine.h +++ b/src/Mod/TechDraw/App/HatchLine.h @@ -52,7 +52,7 @@ class TechDrawExport DashSpec { public: DashSpec() {} - DashSpec(std::vector p) { m_parms = p; } + explicit DashSpec(std::vector p) { m_parms = p; } ~DashSpec() {} double get(int i) {return m_parms.at(i); } @@ -72,7 +72,7 @@ class TechDrawExport PATLineSpec { public: PATLineSpec(); - PATLineSpec(std::string& lineSpec); + explicit PATLineSpec(std::string& lineSpec); ~PATLineSpec(); void load(std::string& lineSpec); diff --git a/src/Mod/TechDraw/Gui/DlgPrefsTechDrawAdvancedImp.h b/src/Mod/TechDraw/Gui/DlgPrefsTechDrawAdvancedImp.h index b86b590042..8a62ddfa08 100644 --- a/src/Mod/TechDraw/Gui/DlgPrefsTechDrawAdvancedImp.h +++ b/src/Mod/TechDraw/Gui/DlgPrefsTechDrawAdvancedImp.h @@ -38,7 +38,7 @@ class DlgPrefsTechDrawAdvancedImp : public Gui::Dialog::PreferencePage Q_OBJECT public: - DlgPrefsTechDrawAdvancedImp( QWidget* parent = nullptr ); + explicit DlgPrefsTechDrawAdvancedImp( QWidget* parent = nullptr ); ~DlgPrefsTechDrawAdvancedImp() override; protected: diff --git a/src/Mod/TechDraw/Gui/DlgPrefsTechDrawAnnotationImp.h b/src/Mod/TechDraw/Gui/DlgPrefsTechDrawAnnotationImp.h index af3d682baf..77ebd9d422 100644 --- a/src/Mod/TechDraw/Gui/DlgPrefsTechDrawAnnotationImp.h +++ b/src/Mod/TechDraw/Gui/DlgPrefsTechDrawAnnotationImp.h @@ -38,7 +38,7 @@ class DlgPrefsTechDrawAnnotationImp : public Gui::Dialog::PreferencePage Q_OBJECT public: - DlgPrefsTechDrawAnnotationImp( QWidget* parent = nullptr ); + explicit DlgPrefsTechDrawAnnotationImp( QWidget* parent = nullptr ); ~DlgPrefsTechDrawAnnotationImp() override; public Q_SLOTS: diff --git a/src/Mod/TechDraw/Gui/DlgPrefsTechDrawColorsImp.h b/src/Mod/TechDraw/Gui/DlgPrefsTechDrawColorsImp.h index eb1625cabd..bad5a33fe2 100644 --- a/src/Mod/TechDraw/Gui/DlgPrefsTechDrawColorsImp.h +++ b/src/Mod/TechDraw/Gui/DlgPrefsTechDrawColorsImp.h @@ -38,7 +38,7 @@ class DlgPrefsTechDrawColorsImp : public Gui::Dialog::PreferencePage Q_OBJECT public: - DlgPrefsTechDrawColorsImp( QWidget* parent = nullptr ); + explicit DlgPrefsTechDrawColorsImp( QWidget* parent = nullptr ); ~DlgPrefsTechDrawColorsImp() override; protected: diff --git a/src/Mod/TechDraw/Gui/DlgPrefsTechDrawDimensionsImp.h b/src/Mod/TechDraw/Gui/DlgPrefsTechDrawDimensionsImp.h index 86c5d54a34..f7da5e0627 100644 --- a/src/Mod/TechDraw/Gui/DlgPrefsTechDrawDimensionsImp.h +++ b/src/Mod/TechDraw/Gui/DlgPrefsTechDrawDimensionsImp.h @@ -38,7 +38,7 @@ class DlgPrefsTechDrawDimensionsImp : public Gui::Dialog::PreferencePage Q_OBJECT public: - DlgPrefsTechDrawDimensionsImp( QWidget* parent = nullptr ); + explicit DlgPrefsTechDrawDimensionsImp( QWidget* parent = nullptr ); ~DlgPrefsTechDrawDimensionsImp() override; protected: diff --git a/src/Mod/TechDraw/Gui/DlgPrefsTechDrawGeneralImp.h b/src/Mod/TechDraw/Gui/DlgPrefsTechDrawGeneralImp.h index 748504d564..bcb4b95b91 100644 --- a/src/Mod/TechDraw/Gui/DlgPrefsTechDrawGeneralImp.h +++ b/src/Mod/TechDraw/Gui/DlgPrefsTechDrawGeneralImp.h @@ -38,7 +38,7 @@ class DlgPrefsTechDrawGeneralImp : public Gui::Dialog::PreferencePage Q_OBJECT public: - DlgPrefsTechDrawGeneralImp( QWidget* parent = nullptr ); + explicit DlgPrefsTechDrawGeneralImp( QWidget* parent = nullptr ); ~DlgPrefsTechDrawGeneralImp() override; protected: diff --git a/src/Mod/TechDraw/Gui/DlgPrefsTechDrawHLRImp.h b/src/Mod/TechDraw/Gui/DlgPrefsTechDrawHLRImp.h index f2a94540ef..2ae48cdb3b 100644 --- a/src/Mod/TechDraw/Gui/DlgPrefsTechDrawHLRImp.h +++ b/src/Mod/TechDraw/Gui/DlgPrefsTechDrawHLRImp.h @@ -38,7 +38,7 @@ class DlgPrefsTechDrawHLRImp : public Gui::Dialog::PreferencePage Q_OBJECT public: - DlgPrefsTechDrawHLRImp( QWidget* parent = nullptr ); + explicit DlgPrefsTechDrawHLRImp( QWidget* parent = nullptr ); ~DlgPrefsTechDrawHLRImp() override; protected: diff --git a/src/Mod/TechDraw/Gui/DlgPrefsTechDrawScaleImp.h b/src/Mod/TechDraw/Gui/DlgPrefsTechDrawScaleImp.h index 6c6ba883cc..bae0d1b3d3 100644 --- a/src/Mod/TechDraw/Gui/DlgPrefsTechDrawScaleImp.h +++ b/src/Mod/TechDraw/Gui/DlgPrefsTechDrawScaleImp.h @@ -38,7 +38,7 @@ class DlgPrefsTechDrawScaleImp : public Gui::Dialog::PreferencePage Q_OBJECT public: - DlgPrefsTechDrawScaleImp( QWidget* parent = nullptr ); + explicit DlgPrefsTechDrawScaleImp( QWidget* parent = nullptr ); ~DlgPrefsTechDrawScaleImp() override; protected Q_SLOTS: diff --git a/src/Mod/TechDraw/Gui/DlgTemplateField.h b/src/Mod/TechDraw/Gui/DlgTemplateField.h index 152da482c2..b5ba4e3191 100644 --- a/src/Mod/TechDraw/Gui/DlgTemplateField.h +++ b/src/Mod/TechDraw/Gui/DlgTemplateField.h @@ -38,7 +38,7 @@ class DlgTemplateField : public QDialog Q_OBJECT public: - DlgTemplateField( QWidget *parent = nullptr ); + explicit DlgTemplateField( QWidget *parent = nullptr ); ~DlgTemplateField() override = default; void setFieldName(std::string name); diff --git a/src/Mod/TechDraw/Gui/MDIViewPage.h b/src/Mod/TechDraw/Gui/MDIViewPage.h index e1e1f47f62..0c74b3b4e8 100644 --- a/src/Mod/TechDraw/Gui/MDIViewPage.h +++ b/src/Mod/TechDraw/Gui/MDIViewPage.h @@ -159,7 +159,7 @@ public: using BaseType = Py::PythonExtension; static void init_type(); - MDIViewPagePy(MDIViewPage *mdi); + explicit MDIViewPagePy(MDIViewPage *mdi); ~MDIViewPagePy() override; Py::Object repr() override; diff --git a/src/Mod/TechDraw/Gui/QGIDrawingTemplate.h b/src/Mod/TechDraw/Gui/QGIDrawingTemplate.h index b1a7b9009f..e1667dfaf7 100644 --- a/src/Mod/TechDraw/Gui/QGIDrawingTemplate.h +++ b/src/Mod/TechDraw/Gui/QGIDrawingTemplate.h @@ -45,7 +45,7 @@ class TechDrawGuiExport QGIDrawingTemplate : public QGITemplate Q_OBJECT public: - QGIDrawingTemplate(QGSPage *); + explicit QGIDrawingTemplate(QGSPage *); ~QGIDrawingTemplate(); enum {Type = QGraphicsItem::UserType + 151}; diff --git a/src/Mod/TechDraw/Gui/QGISVGTemplate.h b/src/Mod/TechDraw/Gui/QGISVGTemplate.h index 56e6321377..f0a3999fe3 100644 --- a/src/Mod/TechDraw/Gui/QGISVGTemplate.h +++ b/src/Mod/TechDraw/Gui/QGISVGTemplate.h @@ -48,7 +48,7 @@ class TechDrawGuiExport QGISVGTemplate : public QGITemplate Q_OBJECT public: - QGISVGTemplate(QGSPage* scene); + explicit QGISVGTemplate(QGSPage* scene); virtual ~QGISVGTemplate(); enum {Type = QGraphicsItem::UserType + 153}; diff --git a/src/Mod/TechDraw/Gui/QGSPage.h b/src/Mod/TechDraw/Gui/QGSPage.h index a67bcfac18..a2788bb881 100644 --- a/src/Mod/TechDraw/Gui/QGSPage.h +++ b/src/Mod/TechDraw/Gui/QGSPage.h @@ -70,7 +70,7 @@ class TechDrawGuiExport QGSPage : public QGraphicsScene Q_OBJECT public: - QGSPage(ViewProviderPage *vp, QWidget *parent = nullptr); + explicit QGSPage(ViewProviderPage *vp, QWidget *parent = nullptr); ~QGSPage() override; bool addView(const App::DocumentObject *obj); diff --git a/src/Mod/TechDraw/Gui/QGVNavStyle.h b/src/Mod/TechDraw/Gui/QGVNavStyle.h index de92ad3852..7622869d4d 100644 --- a/src/Mod/TechDraw/Gui/QGVNavStyle.h +++ b/src/Mod/TechDraw/Gui/QGVNavStyle.h @@ -62,7 +62,7 @@ private: class TechDrawGuiExport QGVNavStyle : public Base::BaseClass { public: - QGVNavStyle(QGVPage* qgvp); + explicit QGVNavStyle(QGVPage* qgvp); ~QGVNavStyle() override; void setViewer(QGVPage* qgvp) { m_viewer = qgvp;} ; diff --git a/src/Mod/TechDraw/Gui/QGVNavStyleBlender.h b/src/Mod/TechDraw/Gui/QGVNavStyleBlender.h index 286b3e73fb..0d16d33462 100644 --- a/src/Mod/TechDraw/Gui/QGVNavStyleBlender.h +++ b/src/Mod/TechDraw/Gui/QGVNavStyleBlender.h @@ -35,7 +35,7 @@ class QGVPage; class TechDrawGuiExport QGVNavStyleBlender : public QGVNavStyle { public: - QGVNavStyleBlender(QGVPage* qgvp); + explicit QGVNavStyleBlender(QGVPage* qgvp); ~QGVNavStyleBlender() override; void handleKeyReleaseEvent(QKeyEvent *event) override; diff --git a/src/Mod/TechDraw/Gui/QGVNavStyleCAD.h b/src/Mod/TechDraw/Gui/QGVNavStyleCAD.h index ba3c6f6b3f..6d27bcbf7a 100644 --- a/src/Mod/TechDraw/Gui/QGVNavStyleCAD.h +++ b/src/Mod/TechDraw/Gui/QGVNavStyleCAD.h @@ -35,7 +35,7 @@ class QGVPage; class TechDrawGuiExport QGVNavStyleCAD : public QGVNavStyle { public: - QGVNavStyleCAD(QGVPage* qgvp); + explicit QGVNavStyleCAD(QGVPage* qgvp); ~QGVNavStyleCAD() override; void handleKeyReleaseEvent(QKeyEvent *event) override; diff --git a/src/Mod/TechDraw/Gui/QGVNavStyleGesture.h b/src/Mod/TechDraw/Gui/QGVNavStyleGesture.h index 486fac3635..47571390ac 100644 --- a/src/Mod/TechDraw/Gui/QGVNavStyleGesture.h +++ b/src/Mod/TechDraw/Gui/QGVNavStyleGesture.h @@ -35,7 +35,7 @@ class QGVPage; class TechDrawGuiExport QGVNavStyleGesture : public QGVNavStyle { public: - QGVNavStyleGesture(QGVPage* qgvp); + explicit QGVNavStyleGesture(QGVPage* qgvp); ~QGVNavStyleGesture() override; void handleMousePressEvent(QMouseEvent *event) override; diff --git a/src/Mod/TechDraw/Gui/QGVNavStyleInventor.h b/src/Mod/TechDraw/Gui/QGVNavStyleInventor.h index 927eb73391..3d9ed0c33d 100644 --- a/src/Mod/TechDraw/Gui/QGVNavStyleInventor.h +++ b/src/Mod/TechDraw/Gui/QGVNavStyleInventor.h @@ -35,7 +35,7 @@ class QGVPage; class TechDrawGuiExport QGVNavStyleInventor : public QGVNavStyle { public: - QGVNavStyleInventor(QGVPage* qgvp); + explicit QGVNavStyleInventor(QGVPage* qgvp); ~QGVNavStyleInventor() override; void handleMousePressEvent(QMouseEvent *event) override; diff --git a/src/Mod/TechDraw/Gui/QGVNavStyleMaya.h b/src/Mod/TechDraw/Gui/QGVNavStyleMaya.h index b7f8059c0b..4d9b2afad7 100644 --- a/src/Mod/TechDraw/Gui/QGVNavStyleMaya.h +++ b/src/Mod/TechDraw/Gui/QGVNavStyleMaya.h @@ -35,7 +35,7 @@ class QGVPage; class TechDrawGuiExport QGVNavStyleMaya : public QGVNavStyle { public: - QGVNavStyleMaya(QGVPage* qgvp); + explicit QGVNavStyleMaya(QGVPage* qgvp); ~QGVNavStyleMaya() override; void handleKeyReleaseEvent(QKeyEvent *event) override; diff --git a/src/Mod/TechDraw/Gui/QGVNavStyleOCC.h b/src/Mod/TechDraw/Gui/QGVNavStyleOCC.h index 6a83fe8485..71b4825075 100644 --- a/src/Mod/TechDraw/Gui/QGVNavStyleOCC.h +++ b/src/Mod/TechDraw/Gui/QGVNavStyleOCC.h @@ -35,7 +35,7 @@ class QGVPage; class TechDrawGuiExport QGVNavStyleOCC : public QGVNavStyle { public: - QGVNavStyleOCC(QGVPage* qgvp); + explicit QGVNavStyleOCC(QGVPage* qgvp); ~QGVNavStyleOCC() override; void handleKeyReleaseEvent(QKeyEvent *event) override; diff --git a/src/Mod/TechDraw/Gui/QGVNavStyleOpenSCAD.h b/src/Mod/TechDraw/Gui/QGVNavStyleOpenSCAD.h index 729b6e1720..0417da9432 100644 --- a/src/Mod/TechDraw/Gui/QGVNavStyleOpenSCAD.h +++ b/src/Mod/TechDraw/Gui/QGVNavStyleOpenSCAD.h @@ -35,7 +35,7 @@ class QGVPage; class TechDrawGuiExport QGVNavStyleOpenSCAD : public QGVNavStyle { public: - QGVNavStyleOpenSCAD(QGVPage* qgvp); + explicit QGVNavStyleOpenSCAD(QGVPage* qgvp); ~QGVNavStyleOpenSCAD() override; void handleKeyReleaseEvent(QKeyEvent *event) override; diff --git a/src/Mod/TechDraw/Gui/QGVNavStyleRevit.h b/src/Mod/TechDraw/Gui/QGVNavStyleRevit.h index 35577eae57..07608270d3 100644 --- a/src/Mod/TechDraw/Gui/QGVNavStyleRevit.h +++ b/src/Mod/TechDraw/Gui/QGVNavStyleRevit.h @@ -35,7 +35,7 @@ class QGVPage; class TechDrawGuiExport QGVNavStyleRevit : public QGVNavStyle { public: - QGVNavStyleRevit(QGVPage* qgvp); + explicit QGVNavStyleRevit(QGVPage* qgvp); ~QGVNavStyleRevit() override; void handleMousePressEvent(QMouseEvent *event) override; diff --git a/src/Mod/TechDraw/Gui/QGVNavStyleTinkerCAD.h b/src/Mod/TechDraw/Gui/QGVNavStyleTinkerCAD.h index b7a05fdd2f..84c4ce00f7 100644 --- a/src/Mod/TechDraw/Gui/QGVNavStyleTinkerCAD.h +++ b/src/Mod/TechDraw/Gui/QGVNavStyleTinkerCAD.h @@ -37,7 +37,7 @@ class TechDrawGuiExport QGVNavStyleTinkerCAD : public QGVNavStyle // TYPESYSTEM_HEADER(); public: - QGVNavStyleTinkerCAD(QGVPage* qgvp); + explicit QGVNavStyleTinkerCAD(QGVPage* qgvp); ~QGVNavStyleTinkerCAD() override; void handleMouseMoveEvent(QMouseEvent *event) override; diff --git a/src/Mod/TechDraw/Gui/QGVNavStyleTouchpad.h b/src/Mod/TechDraw/Gui/QGVNavStyleTouchpad.h index 0b0c1c38a9..9968580966 100644 --- a/src/Mod/TechDraw/Gui/QGVNavStyleTouchpad.h +++ b/src/Mod/TechDraw/Gui/QGVNavStyleTouchpad.h @@ -35,7 +35,7 @@ class QGVPage; class TechDrawGuiExport QGVNavStyleTouchpad : public QGVNavStyle { public: - QGVNavStyleTouchpad(QGVPage* qgvp); + explicit QGVNavStyleTouchpad(QGVPage* qgvp); ~QGVNavStyleTouchpad() override; void handleKeyPressEvent(QKeyEvent *event) override; diff --git a/src/Mod/TechDraw/Gui/QGVPage.cpp b/src/Mod/TechDraw/Gui/QGVPage.cpp index a8faf7dc0d..97212bc769 100644 --- a/src/Mod/TechDraw/Gui/QGVPage.cpp +++ b/src/Mod/TechDraw/Gui/QGVPage.cpp @@ -189,7 +189,7 @@ public: /// handle to the viewer parameter group ParameterGrp::handle hGrp; QGVPage* page; - Private(QGVPage* page) : page(page) { + explicit Private(QGVPage* page) : page(page) { // attach parameter Observer hGrp = App::GetApplication().GetParameterGroupByPath("User parameter:BaseApp/Preferences/View"); hGrp->Attach(this); diff --git a/src/Mod/TechDraw/Gui/TaskActiveView.h b/src/Mod/TechDraw/Gui/TaskActiveView.h index 485f7da6c6..bd746497f9 100644 --- a/src/Mod/TechDraw/Gui/TaskActiveView.h +++ b/src/Mod/TechDraw/Gui/TaskActiveView.h @@ -91,7 +91,7 @@ class TaskDlgActiveView : public Gui::TaskView::TaskDialog Q_OBJECT public: - TaskDlgActiveView(TechDraw::DrawPage* pageFeat); + explicit TaskDlgActiveView(TechDraw::DrawPage* pageFeat); ~TaskDlgActiveView() override; public: diff --git a/src/Mod/TechDraw/Gui/TaskCustomizeFormat.h b/src/Mod/TechDraw/Gui/TaskCustomizeFormat.h index 30cbef285e..ef052ee3ec 100644 --- a/src/Mod/TechDraw/Gui/TaskCustomizeFormat.h +++ b/src/Mod/TechDraw/Gui/TaskCustomizeFormat.h @@ -62,7 +62,7 @@ class TaskCustomizeFormat : public QWidget Q_OBJECT public: - TaskCustomizeFormat(App::DocumentObject * object); + explicit TaskCustomizeFormat(App::DocumentObject * object); ~TaskCustomizeFormat() override; public Q_SLOTS: @@ -95,7 +95,7 @@ class TaskDlgCustomizeFormat : public Gui::TaskView::TaskDialog Q_OBJECT public: - TaskDlgCustomizeFormat(App::DocumentObject * object); + explicit TaskDlgCustomizeFormat(App::DocumentObject * object); ~TaskDlgCustomizeFormat() override; public: diff --git a/src/Mod/TechDraw/Gui/TaskDetail.h b/src/Mod/TechDraw/Gui/TaskDetail.h index 7630796f1a..5b54e1fb13 100644 --- a/src/Mod/TechDraw/Gui/TaskDetail.h +++ b/src/Mod/TechDraw/Gui/TaskDetail.h @@ -60,8 +60,8 @@ class TaskDetail : public QWidget Q_OBJECT public: - TaskDetail(TechDraw::DrawViewPart* baseFeat); - TaskDetail(TechDraw::DrawViewDetail* detailFeat); + explicit TaskDetail(TechDraw::DrawViewPart* baseFeat); + explicit TaskDetail(TechDraw::DrawViewDetail* detailFeat); ~TaskDetail() override; public Q_SLOTS: @@ -140,8 +140,8 @@ class TaskDlgDetail : public Gui::TaskView::TaskDialog Q_OBJECT public: - TaskDlgDetail(TechDraw::DrawViewPart* baseFeat); - TaskDlgDetail(TechDraw::DrawViewDetail* detailFeat); + explicit TaskDlgDetail(TechDraw::DrawViewPart* baseFeat); + explicit TaskDlgDetail(TechDraw::DrawViewDetail* detailFeat); ~TaskDlgDetail() override; public: diff --git a/src/Mod/TechDraw/Gui/TaskHatch.h b/src/Mod/TechDraw/Gui/TaskHatch.h index dbc2a72758..776a5b2758 100644 --- a/src/Mod/TechDraw/Gui/TaskHatch.h +++ b/src/Mod/TechDraw/Gui/TaskHatch.h @@ -51,7 +51,7 @@ class TaskHatch : public QWidget public: TaskHatch(TechDraw::DrawViewPart* inDvp, std::vector subs); - TaskHatch(TechDrawGui::ViewProviderHatch* inVp); + explicit TaskHatch(TechDrawGui::ViewProviderHatch* inVp); ~TaskHatch() override; public: @@ -100,7 +100,7 @@ class TaskDlgHatch : public Gui::TaskView::TaskDialog public: TaskDlgHatch(TechDraw::DrawViewPart* inDvp, std::vector subs); - TaskDlgHatch(TechDrawGui::ViewProviderHatch* inVp); + explicit TaskDlgHatch(TechDrawGui::ViewProviderHatch* inVp); ~TaskDlgHatch() override; public: diff --git a/src/Mod/TechDraw/Gui/TaskLeaderLine.h b/src/Mod/TechDraw/Gui/TaskLeaderLine.h index 7dddf65de5..939866356b 100644 --- a/src/Mod/TechDraw/Gui/TaskLeaderLine.h +++ b/src/Mod/TechDraw/Gui/TaskLeaderLine.h @@ -65,7 +65,7 @@ class TaskLeaderLine : public QWidget public: TaskLeaderLine(TechDraw::DrawView* baseFeat, TechDraw::DrawPage* page); - TaskLeaderLine(TechDrawGui::ViewProviderLeader* leadVP); + explicit TaskLeaderLine(TechDrawGui::ViewProviderLeader* leadVP); ~TaskLeaderLine() override; public Q_SLOTS: @@ -168,7 +168,7 @@ class TaskDlgLeaderLine : public Gui::TaskView::TaskDialog public: TaskDlgLeaderLine(TechDraw::DrawView* baseFeat, TechDraw::DrawPage* page); - TaskDlgLeaderLine(TechDrawGui::ViewProviderLeader* leadVP); + explicit TaskDlgLeaderLine(TechDrawGui::ViewProviderLeader* leadVP); ~TaskDlgLeaderLine() override; public: diff --git a/src/Mod/TechDraw/Gui/TaskRichAnno.h b/src/Mod/TechDraw/Gui/TaskRichAnno.h index ebee6b1b35..06a42a2125 100644 --- a/src/Mod/TechDraw/Gui/TaskRichAnno.h +++ b/src/Mod/TechDraw/Gui/TaskRichAnno.h @@ -58,7 +58,7 @@ class TaskRichAnno : public QWidget public: TaskRichAnno(TechDraw::DrawView* baseFeat, TechDraw::DrawPage* page); - TaskRichAnno(TechDrawGui::ViewProviderRichAnno* leadVP); + explicit TaskRichAnno(TechDrawGui::ViewProviderRichAnno* leadVP); ~TaskRichAnno() override; public Q_SLOTS: @@ -134,7 +134,7 @@ class TaskDlgRichAnno : public Gui::TaskView::TaskDialog public: TaskDlgRichAnno(TechDraw::DrawView* baseFeat, TechDraw::DrawPage* page); - TaskDlgRichAnno(TechDrawGui::ViewProviderRichAnno* leadVP); + explicit TaskDlgRichAnno(TechDrawGui::ViewProviderRichAnno* leadVP); ~TaskDlgRichAnno() override; public: diff --git a/src/Mod/TechDraw/Gui/TaskSectionView.h b/src/Mod/TechDraw/Gui/TaskSectionView.h index 30a65d12e2..623fb1bfb7 100644 --- a/src/Mod/TechDraw/Gui/TaskSectionView.h +++ b/src/Mod/TechDraw/Gui/TaskSectionView.h @@ -44,8 +44,8 @@ class TaskSectionView : public QWidget Q_OBJECT public: - TaskSectionView(TechDraw::DrawViewPart* base); - TaskSectionView(TechDraw::DrawViewSection* section); + explicit TaskSectionView(TechDraw::DrawViewPart* base); + explicit TaskSectionView(TechDraw::DrawViewSection* section); ~TaskSectionView() override; public: @@ -124,8 +124,8 @@ class TaskDlgSectionView : public Gui::TaskView::TaskDialog Q_OBJECT public: - TaskDlgSectionView(TechDraw::DrawViewPart* base); - TaskDlgSectionView(TechDraw::DrawViewSection* section); + explicit TaskDlgSectionView(TechDraw::DrawViewPart* base); + explicit TaskDlgSectionView(TechDraw::DrawViewSection* section); ~TaskDlgSectionView() override; public: diff --git a/src/Mod/TechDraw/Gui/TaskSelectLineAttributes.h b/src/Mod/TechDraw/Gui/TaskSelectLineAttributes.h index aa3d641d3d..c8c7362402 100644 --- a/src/Mod/TechDraw/Gui/TaskSelectLineAttributes.h +++ b/src/Mod/TechDraw/Gui/TaskSelectLineAttributes.h @@ -93,7 +93,7 @@ class TaskSelectLineAttributes : public QWidget Q_OBJECT public: - TaskSelectLineAttributes(lineAttributes * ptActiveAttributes); + explicit TaskSelectLineAttributes(lineAttributes * ptActiveAttributes); ~TaskSelectLineAttributes() override; public Q_SLOTS: @@ -120,7 +120,7 @@ class TaskDlgSelectLineAttributes : public Gui::TaskView::TaskDialog Q_OBJECT public: - TaskDlgSelectLineAttributes(lineAttributes * ptActiveAttributes); + explicit TaskDlgSelectLineAttributes(lineAttributes * ptActiveAttributes); ~TaskDlgSelectLineAttributes() override; public: diff --git a/src/Mod/TechDraw/Gui/TaskSurfaceFinishSymbols.h b/src/Mod/TechDraw/Gui/TaskSurfaceFinishSymbols.h index aad28b1f4c..586791360b 100644 --- a/src/Mod/TechDraw/Gui/TaskSurfaceFinishSymbols.h +++ b/src/Mod/TechDraw/Gui/TaskSurfaceFinishSymbols.h @@ -77,7 +77,7 @@ class TaskSurfaceFinishSymbols : public QWidget Q_OBJECT public: - TaskSurfaceFinishSymbols(TechDraw::DrawViewPart* view); + explicit TaskSurfaceFinishSymbols(TechDraw::DrawViewPart* view); ~TaskSurfaceFinishSymbols() override; public Q_SLOTS: @@ -120,7 +120,7 @@ class TaskDlgSurfaceFinishSymbols : public Gui::TaskView::TaskDialog Q_OBJECT public: - TaskDlgSurfaceFinishSymbols(TechDraw::DrawViewPart* view); + explicit TaskDlgSurfaceFinishSymbols(TechDraw::DrawViewPart* view); ~TaskDlgSurfaceFinishSymbols() override; public: diff --git a/src/Mod/TechDraw/Gui/TaskWeldingSymbol.h b/src/Mod/TechDraw/Gui/TaskWeldingSymbol.h index 19a72caf91..e541d05b9f 100644 --- a/src/Mod/TechDraw/Gui/TaskWeldingSymbol.h +++ b/src/Mod/TechDraw/Gui/TaskWeldingSymbol.h @@ -175,8 +175,8 @@ class TaskDlgWeldingSymbol : public Gui::TaskView::TaskDialog Q_OBJECT public: - TaskDlgWeldingSymbol(TechDraw::DrawLeaderLine* leader); - TaskDlgWeldingSymbol(TechDraw::DrawWeldSymbol* weld); + explicit TaskDlgWeldingSymbol(TechDraw::DrawLeaderLine* leader); + explicit TaskDlgWeldingSymbol(TechDraw::DrawWeldSymbol* weld); ~TaskDlgWeldingSymbol() override; public: diff --git a/src/Mod/Test/Gui/UnitTestImp.h b/src/Mod/Test/Gui/UnitTestImp.h index c0a6fce3e6..c8e460921d 100644 --- a/src/Mod/Test/Gui/UnitTestImp.h +++ b/src/Mod/Test/Gui/UnitTestImp.h @@ -60,7 +60,7 @@ public: static bool hasInstance(); protected: - UnitTestDialog(QWidget* parent = nullptr, Qt::WindowFlags f = Qt::WindowFlags()); + explicit UnitTestDialog(QWidget* parent = nullptr, Qt::WindowFlags f = Qt::WindowFlags()); ~UnitTestDialog() override; void setProgressColor(const QColor& col); diff --git a/src/Mod/Web/App/Server.h b/src/Mod/Web/App/Server.h index 693e5b603c..b1e9a2ac99 100644 --- a/src/Mod/Web/App/Server.h +++ b/src/Mod/Web/App/Server.h @@ -50,7 +50,7 @@ private: class FirewallPython : public Firewall { public: - FirewallPython(const Py::Object&); + explicit FirewallPython(const Py::Object&); ~FirewallPython() override; bool filter(const QByteArray&) const override; @@ -80,7 +80,7 @@ class AppServer : public QTcpServer Q_OBJECT public: - AppServer(bool direct = false, QObject* parent = nullptr); + explicit AppServer(bool direct = false, QObject* parent = nullptr); protected: void incomingConnection(qintptr socket) override; diff --git a/src/Mod/Web/Gui/BrowserView.cpp b/src/Mod/Web/Gui/BrowserView.cpp index 155d0e52a4..40ef609db4 100644 --- a/src/Mod/Web/Gui/BrowserView.cpp +++ b/src/Mod/Web/Gui/BrowserView.cpp @@ -85,7 +85,7 @@ enum WebAction { class WebEngineUrlRequestInterceptor : public QWebEngineUrlRequestInterceptor { public: - WebEngineUrlRequestInterceptor(BrowserView *parent) : + explicit WebEngineUrlRequestInterceptor(BrowserView *parent) : QWebEngineUrlRequestInterceptor(parent), m_parent(parent) { @@ -156,7 +156,7 @@ public: using BaseType = Py::PythonExtension; static void init_type(); // announce properties and methods - BrowserViewPy(BrowserView* view); + explicit BrowserViewPy(BrowserView* view); ~BrowserViewPy() override; Py::Object repr() override; diff --git a/src/Mod/Web/Gui/BrowserView.h b/src/Mod/Web/Gui/BrowserView.h index e1a9c139c7..8b16e03de4 100644 --- a/src/Mod/Web/Gui/BrowserView.h +++ b/src/Mod/Web/Gui/BrowserView.h @@ -56,7 +56,7 @@ class WebGuiExport WebView : public QWebView Q_OBJECT public: - WebView(QWidget *parent = nullptr); + explicit WebView(QWidget *parent = nullptr); protected: void mousePressEvent(QMouseEvent *event) override; @@ -84,7 +84,7 @@ class WebGuiExport BrowserView : public Gui::MDIView, TYPESYSTEM_HEADER_WITH_OVERRIDE(); public: - BrowserView(QWidget* parent); + explicit BrowserView(QWidget* parent); ~BrowserView() override; void load(const char* URL); diff --git a/src/Mod/Web/Gui/CookieJar.h b/src/Mod/Web/Gui/CookieJar.h index 7d3256cbae..4ac7a83838 100644 --- a/src/Mod/Web/Gui/CookieJar.h +++ b/src/Mod/Web/Gui/CookieJar.h @@ -38,7 +38,7 @@ namespace WebGui { Q_OBJECT public: - FcCookieJar(QObject* parent = nullptr); + explicit FcCookieJar(QObject* parent = nullptr); ~FcCookieJar() override; bool setCookiesFromUrl(const QList&, const QUrl&) override;