From 1b2f0063a197f9623ecebb376562183de8b74d99 Mon Sep 17 00:00:00 2001 From: Uwe Date: Sat, 25 Jun 2022 16:36:50 +0200 Subject: [PATCH] [PD] Hole initialization bugfix - by default there is no hole head cut and therefore its parameter must be initialized as read-only (will be enably when user sets a head cut) - also fix a typo - also fix a UI file issue (automatically done by Qt Designer) --- src/Mod/PartDesign/App/FeatureHole.cpp | 6 +++++- src/Mod/PartDesign/Gui/TaskHoleParameters.ui | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/Mod/PartDesign/App/FeatureHole.cpp b/src/Mod/PartDesign/App/FeatureHole.cpp index 2addb93e1c..6a2e41e385 100644 --- a/src/Mod/PartDesign/App/FeatureHole.cpp +++ b/src/Mod/PartDesign/App/FeatureHole.cpp @@ -665,13 +665,17 @@ Hole::Hole() HoleCutType.setEnums(HoleCutType_None_Enums); ADD_PROPERTY_TYPE(HoleCutCustomValues, (false), "Hole", App::Prop_None, "Custom cut values"); + HoleCutCustomValues.setReadOnly(true); ADD_PROPERTY_TYPE(HoleCutDiameter, (0.0), "Hole", App::Prop_None, "Head cut diameter"); + HoleCutDiameter.setReadOnly(true); - ADD_PROPERTY_TYPE(HoleCutDepth, (0.0), "Hole", App::Prop_None, "Head cut deth"); + ADD_PROPERTY_TYPE(HoleCutDepth, (0.0), "Hole", App::Prop_None, "Head cut depth"); + HoleCutDepth.setReadOnly(true); ADD_PROPERTY_TYPE(HoleCutCountersinkAngle, (90.0), "Hole", App::Prop_None, "Head cut countersink angle"); HoleCutCountersinkAngle.setConstraints(&floatAngle); + HoleCutCountersinkAngle.setReadOnly(true); ADD_PROPERTY_TYPE(DepthType, (0L), "Hole", App::Prop_None, "Type"); DepthType.setEnums(DepthTypeEnums); diff --git a/src/Mod/PartDesign/Gui/TaskHoleParameters.ui b/src/Mod/PartDesign/Gui/TaskHoleParameters.ui index 8bb6f26f34..1fa1295e8d 100644 --- a/src/Mod/PartDesign/Gui/TaskHoleParameters.ui +++ b/src/Mod/PartDesign/Gui/TaskHoleParameters.ui @@ -6,7 +6,7 @@ 0 0 - 355 + 438 561