kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

App: Trim “Gui::” and “NavigationStyle” more securely

Browse Source 
By using regex we can remove prefix and suffix more securely as we can’t assume all navigation styles are formatted the same (mistakes can happen)
This commit is contained in:
Benjamin Nauck
2025-06-06 23:40:07 +03:00
committed by Chris Hennes
parent a5cc926bf5
commit 1cf0f8570d
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/App/Application.cpp
View File

@@ -3774,7 +3774,12 @@ void Application::getVerboseCommonInfo(QTextStream& str, const std::map<std::str
ParameterGrp::handle hGrp = App::GetApplication().GetParameterGroupByPath("User parameter:BaseApp/Preferences/View");
const QString navStyle = QString::fromStdString(hGrp->GetASCII("NavigationStyle", "Gui::CADNavigationStyle")).remove(0, 5).chopped(15);
QString navStyle = QString::fromStdString(hGrp->GetASCII("NavigationStyle", "Gui::CADNavigationStyle"));
// All navigation styles are named on the format "Gui::<Name>NavigationStyle"
// so we remove the "Gui::" prefix and the "NavigationStyle" suffix before printing.
navStyle.replace(QRegularExpression(QLatin1String("^Gui::")), {});
navStyle.replace(QRegularExpression(QLatin1String("NavigationStyle$")), {});
const QString orbitStyle = QStringLiteral("Turntable,Trackball,Free Turntable,Trackball Classic,Rounded Arcball")
.split(QLatin1Char(','))
.at(hGrp->GetInt("OrbitStyle", 4));