kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

fix(macos): check quicklook registration state before registering

Browse Source
This commit is contained in:
graelo
2026-01-16 22:25:55 +01:00
parent 25be2c8ab6
commit 208504c9ea
1 changed files with 36 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

58
src/Gui/MainWindow.cpp
View File

@@ -1804,11 +1804,12 @@ void MainWindow::delayedStartup()
#ifdef Q_OS_MAC
void MainWindow::registerQuickLookExtensions()
{
// Check if we've already registered extensions to avoid repeated registration
static bool quickLookRegistered = false;
if (quickLookRegistered) {
// Only check once per session
static bool quickLookChecked = false;
if (quickLookChecked) {
return;
}
quickLookChecked = true;
// Get the path to FreeCAD.app/Contents/PlugIns
QString appPath = QApplication::applicationDirPath();
@@ -1818,26 +1819,39 @@ void MainWindow::registerQuickLookExtensions()
QString previewExt = plugInsPath + "/FreeCADPreviewExtension.appex";
// Check if extensions exist before attempting registration
if (QFileInfo::exists(thumbnailExt) && QFileInfo::exists(previewExt)) {
// Register extensions with pluginkit
QProcess::execute("pluginkit", QStringList() << "-a" << thumbnailExt);
QProcess::execute("pluginkit", QStringList() << "-a" << previewExt);
// Activate extensions
QProcess::execute(
"pluginkit",
QStringList() << "-e" << "use" << "-i" << "org.freecad.FreeCAD.quicklook.thumbnail"
);
QProcess::execute(
"pluginkit",
QStringList() << "-e" << "use" << "-i" << "org.freecad.FreeCAD.quicklook.preview"
);
quickLookRegistered = true;
// Optional: Log successful registration (will appear in system notification)
Base::Console().log("QuickLook extensions registered successfully\n");
if (!QFileInfo::exists(thumbnailExt) || !QFileInfo::exists(previewExt)) {
return;
}
// Check if extensions are already registered with pluginkit
QProcess checkProcess;
checkProcess.start("pluginkit", QStringList() << "-m");
checkProcess.waitForFinished();
QString registeredPlugins = QString::fromUtf8(checkProcess.readAllStandardOutput());
const QString thumbnailId = QStringLiteral("org.freecad.FreeCAD.quicklook.thumbnail");
const QString previewId = QStringLiteral("org.freecad.FreeCAD.quicklook.preview");
bool thumbnailRegistered = registeredPlugins.contains(thumbnailId);
bool previewRegistered = registeredPlugins.contains(previewId);
if (thumbnailRegistered && previewRegistered) {
Base::Console().log("QuickLook extensions already registered\n");
return;
}
// Register and activate only the extensions that are not yet registered
if (!thumbnailRegistered) {
QProcess::execute("pluginkit", QStringList() << "-a" << thumbnailExt);
QProcess::execute("pluginkit", QStringList() << "-e" << "use" << "-i" << thumbnailId);
}
if (!previewRegistered) {
QProcess::execute("pluginkit", QStringList() << "-a" << previewExt);
QProcess::execute("pluginkit", QStringList() << "-e" << "use" << "-i" << previewId);
}
Base::Console().log("QuickLook extensions registered successfully\n");
}
#endif