From 21dc72ed101b76d01ced681572f89d7689a8b263 Mon Sep 17 00:00:00 2001 From: donovaly Date: Fri, 5 Feb 2021 02:56:05 +0100 Subject: [PATCH] [TD] make more pointers to the UI std::unique_ptr addendum to PR #4293 (as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632 the pointer to the UI should be a unique pointer. This PR does this for remaining TD dialogs that don't already use a unique_ptr.) --- src/Mod/TechDraw/Gui/SymbolChooser.h | 2 +- src/Mod/TechDraw/Gui/TaskLineDecor.cpp | 1 - src/Mod/TechDraw/Gui/TaskLineDecor.h | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/Mod/TechDraw/Gui/SymbolChooser.h b/src/Mod/TechDraw/Gui/SymbolChooser.h index 3f4bdec4b6..81d26c23d1 100644 --- a/src/Mod/TechDraw/Gui/SymbolChooser.h +++ b/src/Mod/TechDraw/Gui/SymbolChooser.h @@ -54,7 +54,7 @@ protected: void loadSymbolNames(QString pathToSymbols); private: - Ui_SymbolChooser* ui; + std::unique_ptr ui; QString m_symbolDir; QString m_symbolPath; QString m_source; diff --git a/src/Mod/TechDraw/Gui/TaskLineDecor.cpp b/src/Mod/TechDraw/Gui/TaskLineDecor.cpp index 789be010c8..4758f4f62f 100644 --- a/src/Mod/TechDraw/Gui/TaskLineDecor.cpp +++ b/src/Mod/TechDraw/Gui/TaskLineDecor.cpp @@ -79,7 +79,6 @@ TaskLineDecor::TaskLineDecor(TechDraw::DrawViewPart* partFeat, TaskLineDecor::~TaskLineDecor() { - delete ui; } void TaskLineDecor::initUi() diff --git a/src/Mod/TechDraw/Gui/TaskLineDecor.h b/src/Mod/TechDraw/Gui/TaskLineDecor.h index c5205a754f..d64b8fe3ac 100644 --- a/src/Mod/TechDraw/Gui/TaskLineDecor.h +++ b/src/Mod/TechDraw/Gui/TaskLineDecor.h @@ -70,7 +70,7 @@ protected: void getDefaults(void); private: - Ui_TaskLineDecor* ui; + std::unique_ptr ui; TechDraw::DrawViewPart* m_partFeat; std::vector m_edges; int m_style;