kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

App: use empty

Browse Source
This commit is contained in:
berniev
2022-08-06 02:41:59 +10:00
committed by wwmayer
parent 125d2962c7
commit 22dcf5866f
16 changed files with 127 additions and 127 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/App/Transactions.cpp
View File

@@ -182,7 +182,7 @@ void Transaction::apply(Document &Doc, bool forward)
}catch(...) {
errMsg = "Unknown exception";
}
if(errMsg.size()) {
if(!errMsg.empty()) {
FC_ERR("Exception on " << (forward?"redo":"undo") << " '"
<< Name << "':" << errMsg);
}
@@ -310,7 +310,7 @@ void TransactionObject::applyChn(Document & /*Doc*/, TransactionalObject *pcObj,
// been destroies. We must prepare for the case where user removed
// a dynamic property but does not recordered as transaction.
auto name = pcObj->getPropertyName(prop);
if(!name || (data.name.size() && data.name != name) || data.propertyType != prop->getTypeId()) {
if(!name || (!data.name.empty() && data.name != name) || data.propertyType != prop->getTypeId()) {
// Here means the original property is not found, probably removed
if(data.name.empty()) {
// not a dynamic property, nothing to do
@@ -380,7 +380,7 @@ void TransactionObject::addOrRemoveProperty(const Property* pcProp, bool add)
return;
auto &data = _PropChangeMap[pcProp->getID()];
if(data.name.size()) {
if(!data.name.empty()) {
if(!add && !data.property) {
// this means add and remove the same property inside a single
// transaction, so they cancel each other out.