kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Part/PD: modernize C++: redundant void arg

Browse Source
This commit is contained in:
wmayer
2023-08-05 14:26:29 +02:00
committed by wwmayer
parent 702f3b4ddd
commit 22e6e2cd40
57 changed files with 163 additions and 163 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Mod/PartDesign/App/FeatureAddSub.cpp
View File

@@ -97,10 +97,10 @@ void FeatureAddSub::getAddSubShape(Part::TopoShape &addShape, Part::TopoShape &s
namespace App {
/// @cond DOXERR
PROPERTY_SOURCE_TEMPLATE(PartDesign::FeatureAddSubPython, PartDesign::FeatureAddSub)
template<> const char* PartDesign::FeatureAddSubPython::getViewProviderName(void) const {
template<> const char* PartDesign::FeatureAddSubPython::getViewProviderName() const {
return "PartDesignGui::ViewProviderPython";
}
template<> PyObject* PartDesign::FeatureAddSubPython::getPyObject(void) {
template<> PyObject* PartDesign::FeatureAddSubPython::getPyObject() {
if (PythonObject.is(Py::_None())) {
// ref counter is set to 1
PythonObject = Py::Object(new FeaturePythonPyT<PartDesign::FeaturePy>(this),true);

4
src/Mod/PartDesign/App/FeatureFillet.h
View File

@@ -44,10 +44,10 @@ public:
/** @name methods override feature */
//@{
/// recalculate the feature
App::DocumentObjectExecReturn *execute(void) override;
App::DocumentObjectExecReturn *execute() override;
short mustExecute() const override;
/// returns the type name of the view provider
const char* getViewProviderName(void) const override {
const char* getViewProviderName() const override {
return "PartDesignGui::ViewProviderFillet";
}
//@}

2
src/Mod/PartDesign/App/FeaturePyImp.cpp
View File

@@ -30,7 +30,7 @@
using namespace PartDesign;
// returns a string which represent the object e.g. when printed in python
std::string FeaturePy::representation(void) const
std::string FeaturePy::representation() const
{
App::DocumentObject* object = this->getFeaturePtr();
std::stringstream str;

6
src/Mod/PartDesign/Gui/AppPartDesignGui.cpp
View File

@@ -64,9 +64,9 @@
// use a different name to CreateCommand()
void CreatePartDesignCommands(void);
void CreatePartDesignBodyCommands(void);
void CreatePartDesignPrimitiveCommands(void);
void CreatePartDesignCommands();
void CreatePartDesignBodyCommands();
void CreatePartDesignPrimitiveCommands();
void loadPartDesignResource()
{

10
src/Mod/PartDesign/Gui/CommandPrimitive.cpp
View File

@@ -137,7 +137,7 @@ void CmdPrimtiveCompAdditive::activated(int iMsg)
PartDesignGui::setEdit(prm,pcActiveBody);
}
Gui::Action * CmdPrimtiveCompAdditive::createAction(void)
Gui::Action * CmdPrimtiveCompAdditive::createAction()
{
Gui::ActionGroup* pcAction = new Gui::ActionGroup(this, Gui::getMainWindow());
pcAction->setDropDownMenu(true);
@@ -229,7 +229,7 @@ void CmdPrimtiveCompAdditive::languageChange()
arc8->setStatusTip(arc8->toolTip());
}
bool CmdPrimtiveCompAdditive::isActive(void)
bool CmdPrimtiveCompAdditive::isActive()
{
return (hasActiveDocument() && !Gui::Control().activeDialog());
}
@@ -293,7 +293,7 @@ void CmdPrimtiveCompSubtractive::activated(int iMsg)
PartDesignGui::setEdit(Feat,pcActiveBody);
}
Gui::Action * CmdPrimtiveCompSubtractive::createAction(void)
Gui::Action * CmdPrimtiveCompSubtractive::createAction()
{
Gui::ActionGroup* pcAction = new Gui::ActionGroup(this, Gui::getMainWindow());
pcAction->setDropDownMenu(true);
@@ -385,7 +385,7 @@ void CmdPrimtiveCompSubtractive::languageChange()
arc8->setStatusTip(arc8->toolTip());
}
bool CmdPrimtiveCompSubtractive::isActive(void)
bool CmdPrimtiveCompSubtractive::isActive()
{
return (hasActiveDocument() && !Gui::Control().activeDialog());
}
@@ -394,7 +394,7 @@ bool CmdPrimtiveCompSubtractive::isActive(void)
// Initialization
//===========================================================================
void CreatePartDesignPrimitiveCommands(void)
void CreatePartDesignPrimitiveCommands()
{
Gui::CommandManager &rcCmdMgr = Gui::Application::Instance->commandManager();

6
src/Mod/PartDesign/Gui/TaskBooleanParameters.cpp
View File

@@ -235,7 +235,7 @@ void TaskBooleanParameters::onTypeChanged(int index)
pcBoolean->getDocument()->recomputeFeature(pcBoolean);
}
const std::vector<std::string> TaskBooleanParameters::getBodies(void) const
const std::vector<std::string> TaskBooleanParameters::getBodies() const
{
std::vector<std::string> result;
for (int i = 0; i < ui->listWidgetBodies->count(); i++)
@@ -243,12 +243,12 @@ const std::vector<std::string> TaskBooleanParameters::getBodies(void) const
return result;
}
int TaskBooleanParameters::getType(void) const
int TaskBooleanParameters::getType() const
{
return ui->comboType->currentIndex();
}
void TaskBooleanParameters::onBodyDeleted(void)
void TaskBooleanParameters::onBodyDeleted()
{
PartDesign::Boolean* pcBoolean = static_cast<PartDesign::Boolean*>(BooleanView->getObject());
std::vector<App::DocumentObject*> bodies = pcBoolean->Group.getValues();

14
src/Mod/PartDesign/Gui/TaskChamferParameters.h
View File

@@ -50,8 +50,8 @@ private Q_SLOTS:
void onSize2Changed(double);
void onAngleChanged(double);
void onFlipDirection(bool);
void onRefDeleted(void) override;
void onAddAllEdges(void);
void onRefDeleted() override;
void onAddAllEdges();
void onCheckBoxUseAllEdgesToggled(bool checked);
protected:
@@ -60,11 +60,11 @@ protected:
void changeEvent(QEvent *e) override;
void onSelectionChanged(const Gui::SelectionChanges& msg) override;
int getType(void) const;
double getSize(void) const;
double getSize2(void) const;
double getAngle(void) const;
bool getFlipDirection(void) const;
int getType() const;
double getSize() const;
double getSize2() const;
double getAngle() const;
bool getFlipDirection() const;
private:
void setUpUI(PartDesign::Chamfer* pcChamfer);

6
src/Mod/PartDesign/Gui/TaskDraftParameters.cpp
View File

@@ -196,7 +196,7 @@ void TaskDraftParameters::onButtonLine(bool checked)
}
}
void TaskDraftParameters::onRefDeleted(void)
void TaskDraftParameters::onRefDeleted()
{
TaskDressUpParameters::deleteRef(ui->listWidgetReferences);
}
@@ -230,7 +230,7 @@ void TaskDraftParameters::onAngleChanged(double angle)
hideOnError();
}
double TaskDraftParameters::getAngle(void) const
double TaskDraftParameters::getAngle() const
{
return ui->draftAngle->value().getValue();
}
@@ -245,7 +245,7 @@ void TaskDraftParameters::onReversedChanged(const bool on) {
hideOnError();
}
bool TaskDraftParameters::getReversed(void) const
bool TaskDraftParameters::getReversed() const
{
return ui->checkReverse->isChecked();
}

2
src/Mod/PartDesign/Gui/TaskDressUpParameters.cpp
View File

@@ -362,7 +362,7 @@ void TaskDressUpParameters::showObject()
}
}
Part::Feature* TaskDressUpParameters::getBase(void) const
Part::Feature* TaskDressUpParameters::getBase() const
{
PartDesign::DressUp* pcDressUp = static_cast<PartDesign::DressUp*>(DressUpView->getObject());
// Unlikely but this may throw an exception in case we are started to edit an object which base feature

6
src/Mod/PartDesign/Gui/TaskDressUpParameters.h
View File

@@ -49,8 +49,8 @@ public:
TaskDressUpParameters(ViewProviderDressUp *DressUpView, bool selectEdges, bool selectFaces, QWidget* parent = nullptr);
~TaskDressUpParameters() override;
const std::vector<std::string> getReferences(void) const;
Part::Feature *getBase(void) const;
const std::vector<std::string> getReferences() const;
Part::Feature *getBase() const;
void hideObject();
void showObject();
@@ -68,7 +68,7 @@ protected Q_SLOTS:
void doubleClicked(QListWidgetItem* item);
void setSelection(QListWidgetItem* current);
void itemClickedTimeout();
virtual void onRefDeleted(void) = 0;
virtual void onRefDeleted() = 0;
void createDeleteAction(QListWidget* parentList);
void createAddAllEdgesAction(QListWidget* parentList);

28
src/Mod/PartDesign/Gui/TaskExtrudeParameters.h
View File

@@ -102,24 +102,24 @@ protected:
App::PropertyLinkSub* propReferenceAxis;
void getReferenceAxis(App::DocumentObject*& obj, std::vector<std::string>& sub) const;
double getOffset(void) const;
bool getAlongSketchNormal(void) const;
bool getCustom(void) const;
std::string getReferenceAxis(void) const;
double getXDirection(void) const;
double getYDirection(void) const;
double getZDirection(void) const;
bool getReversed(void) const;
bool getMidplane(void) const;
int getMode(void) const;
QString getFaceName(void) const;
double getOffset() const;
bool getAlongSketchNormal() const;
bool getCustom() const;
std::string getReferenceAxis() const;
double getXDirection() const;
double getYDirection() const;
double getZDirection() const;
bool getReversed() const;
bool getMidplane() const;
int getMode() const;
QString getFaceName() const;
void onSelectionChanged(const Gui::SelectionChanges& msg) override;
virtual void translateModeList(int index);
virtual void updateUI(int index);
void updateDirectionEdits(void);
void updateDirectionEdits();
void setDirectionMode(int index);
void handleLineFaceNameClick(void);
void handleLineFaceNameNo(void);
void handleLineFaceNameClick();
void handleLineFaceNameNo();
private:
void tryRecomputeFeature();

4
src/Mod/PartDesign/Gui/TaskFeaturePick.h
View File

@@ -123,13 +123,13 @@ public:
/// is called by the framework if the dialog is rejected (Cancel)
bool reject() override;
/// is called by the framework if the user presses the help button
bool isAllowedAlterDocument(void) const override
bool isAllowedAlterDocument() const override
{ return false; }
void showExternal(bool val);
/// returns for Close and Help button
QDialogButtonBox::StandardButtons getStandardButtons(void) const override
QDialogButtonBox::StandardButtons getStandardButtons() const override
{ return QDialogButtonBox::Ok|QDialogButtonBox::Cancel; }

8
src/Mod/PartDesign/Gui/TaskLinearPatternParameters.cpp
View File

@@ -359,7 +359,7 @@ void TaskLinearPatternParameters::onUpdateView(bool on)
}
}
void TaskLinearPatternParameters::onFeatureDeleted(void)
void TaskLinearPatternParameters::onFeatureDeleted()
{
PartDesign::Transformed* pcTransformed = getObject();
std::vector<App::DocumentObject*> originals = pcTransformed->Originals.getValues();
@@ -382,17 +382,17 @@ void TaskLinearPatternParameters::getDirection(App::DocumentObject*& obj, std::v
sub = lnk.getSubValues();
}
bool TaskLinearPatternParameters::getReverse(void) const
bool TaskLinearPatternParameters::getReverse() const
{
return ui->checkReverse->isChecked();
}
double TaskLinearPatternParameters::getLength(void) const
double TaskLinearPatternParameters::getLength() const
{
return ui->spinLength->value().getValue();
}
unsigned TaskLinearPatternParameters::getOccurrences(void) const
unsigned TaskLinearPatternParameters::getOccurrences() const
{
return ui->spinOccurrences->value();
}

8
src/Mod/PartDesign/Gui/TaskPolarPatternParameters.cpp
View File

@@ -358,7 +358,7 @@ void TaskPolarPatternParameters::onUpdateView(bool on)
}
}
void TaskPolarPatternParameters::onFeatureDeleted(void)
void TaskPolarPatternParameters::onFeatureDeleted()
{
PartDesign::Transformed* pcTransformed = getObject();
std::vector<App::DocumentObject*> originals = pcTransformed->Originals.getValues();
@@ -381,17 +381,17 @@ void TaskPolarPatternParameters::getAxis(App::DocumentObject*& obj, std::vector<
sub = lnk.getSubValues();
}
bool TaskPolarPatternParameters::getReverse(void) const
bool TaskPolarPatternParameters::getReverse() const
{
return ui->checkReverse->isChecked();
}
double TaskPolarPatternParameters::getAngle(void) const
double TaskPolarPatternParameters::getAngle() const
{
return ui->polarAngle->value().getValue();
}
unsigned TaskPolarPatternParameters::getOccurrences(void) const
unsigned TaskPolarPatternParameters::getOccurrences() const
{
return ui->spinOccurrences->value();
}

2
src/Mod/PartDesign/Gui/TaskPrimitiveParameters.cpp
View File

@@ -961,7 +961,7 @@ bool TaskPrimitiveParameters::reject()
return true;
}
QDialogButtonBox::StandardButtons TaskPrimitiveParameters::getStandardButtons(void) const {
QDialogButtonBox::StandardButtons TaskPrimitiveParameters::getStandardButtons() const {
return Gui::TaskView::TaskDialog::getStandardButtons();
}

6
src/Mod/PartDesign/Gui/TaskScaledParameters.cpp
View File

@@ -208,7 +208,7 @@ void TaskScaledParameters::onUpdateView(bool on)
}
}
void TaskScaledParameters::onFeatureDeleted(void)
void TaskScaledParameters::onFeatureDeleted()
{
PartDesign::Transformed* pcTransformed = getObject();
std::vector<App::DocumentObject*> originals = pcTransformed->Originals.getValues();
@@ -223,12 +223,12 @@ void TaskScaledParameters::onFeatureDeleted(void)
recomputeFeature();
}
double TaskScaledParameters::getFactor(void) const
double TaskScaledParameters::getFactor() const
{
return ui->spinFactor->value().getValue();
}
unsigned TaskScaledParameters::getOccurrences(void) const
unsigned TaskScaledParameters::getOccurrences() const
{
return ui->spinOccurrences->value();
}

12
src/Mod/PartDesign/Gui/TaskThicknessParameters.cpp
View File

@@ -134,7 +134,7 @@ void TaskThicknessParameters::setButtons(const selectionModes mode)
ui->buttonRefSel->setText(mode == refSel ? btnPreviewStr() : btnSelectStr());
}
void TaskThicknessParameters::onRefDeleted(void)
void TaskThicknessParameters::onRefDeleted()
{
TaskDressUpParameters::deleteRef(ui->listWidgetReferences);
}
@@ -172,7 +172,7 @@ void TaskThicknessParameters::onModeChanged(int mode) {
hideOnError();
}
double TaskThicknessParameters::getValue(void) const
double TaskThicknessParameters::getValue() const
{
return ui->Value->value().getValue();
}
@@ -187,7 +187,7 @@ void TaskThicknessParameters::onReversedChanged(const bool on) {
hideOnError();
}
bool TaskThicknessParameters::getReversed(void) const
bool TaskThicknessParameters::getReversed() const
{
return ui->checkReverse->isChecked();
}
@@ -201,17 +201,17 @@ void TaskThicknessParameters::onIntersectionChanged(const bool on) {
hideOnError();
}
bool TaskThicknessParameters::getIntersection(void) const
bool TaskThicknessParameters::getIntersection() const
{
return ui->checkIntersection->isChecked();
}
int TaskThicknessParameters::getJoinType(void) const {
int TaskThicknessParameters::getJoinType() const {
return ui->joinComboBox->currentIndex();
}
int TaskThicknessParameters::getMode(void) const {
int TaskThicknessParameters::getMode() const {
return ui->modeComboBox->currentIndex();
}

12
src/Mod/PartDesign/Gui/TaskThicknessParameters.h
View File

@@ -41,11 +41,11 @@ public:
void apply() override;
double getValue(void) const;
bool getReversed(void) const;
bool getIntersection(void) const;
int getMode(void) const;
int getJoinType(void) const;
double getValue() const;
bool getReversed() const;
bool getIntersection() const;
int getMode() const;
int getJoinType() const;
private Q_SLOTS:
void onValueChanged(double angle);
@@ -53,7 +53,7 @@ private Q_SLOTS:
void onJoinTypeChanged(int join);
void onReversedChanged(bool reversed);
void onIntersectionChanged(bool intersection);
void onRefDeleted(void) override;
void onRefDeleted() override;
protected:
void setButtons(const selectionModes mode) override;

6
src/Mod/PartDesign/Gui/TaskTransformedParameters.h
View File

@@ -98,7 +98,7 @@ public:
*/
int setCurrentLink(const App::PropertyLinkSub &lnk);
QComboBox& combo(void) const {assert(_combo); return *_combo;}
QComboBox& combo() const {assert(_combo); return *_combo;}
~ComboLinks() {_combo = nullptr; clear();}
private:
@@ -129,7 +129,7 @@ public:
~TaskTransformedParameters() override;
/// Returns the originals property of associated top feeature object
const std::vector<App::DocumentObject*> & getOriginals(void) const;
const std::vector<App::DocumentObject*> & getOriginals() const;
/// Get the TransformedFeature object associated with this task
// Either through the ViewProvider or the currently active subFeature of the parentTask
@@ -177,7 +177,7 @@ protected Q_SLOTS:
virtual void onSubTaskButtonOK() {}
void onButtonAddFeature(const bool checked);
void onButtonRemoveFeature(const bool checked);
virtual void onFeatureDeleted(void)=0;
virtual void onFeatureDeleted() = 0;
void indexesMoved();
protected:

2
src/Mod/PartDesign/Gui/Utils.cpp
View File

@@ -180,7 +180,7 @@ PartDesign::Body * makeBodyActive(App::DocumentObject *body, App::Document *doc,
return dynamic_cast<PartDesign::Body*>(body);
}
void needActiveBodyError(void)
void needActiveBodyError()
{
QMessageBox::warning( Gui::getMainWindow(),
QObject::tr("Active Body Required"),

4
src/Mod/PartDesign/Gui/ViewProvider.h
View File

@@ -48,7 +48,7 @@ public:
/// destructor
~ViewProvider() override;
bool doubleClicked(void) override;
bool doubleClicked() override;
void updateData(const App::Property*) override;
void onChanged(const App::Property* prop) override;
@@ -68,7 +68,7 @@ public:
//Returns the ViewProvider of the body the feature belongs to, or NULL, if not in a body
ViewProviderBody* getBodyViewProvider();
PyObject* getPyObject(void) override;
PyObject* getPyObject() override;
QIcon mergeColorfulOverlayIcons (const QIcon & orig) const override;

4
src/Mod/PartDesign/Gui/ViewProviderBody.h
View File

@@ -56,10 +56,10 @@ public:
void attach(App::DocumentObject *) override;
bool doubleClicked(void) override;
bool doubleClicked() override;
void setupContextMenu(QMenu* menu, QObject* receiver, const char* member) override;
std::vector< std::string > getDisplayModes(void) const override;
std::vector< std::string > getDisplayModes() const override;
void setDisplayMode(const char* ModeName) override;
void setOverrideMode(const std::string& mode) override;

8
src/Mod/PartDesign/Gui/ViewProviderDatum.h
View File

@@ -54,14 +54,14 @@ public:
void attach(App::DocumentObject *) override;
bool onDelete(const std::vector<std::string> &) override;
bool doubleClicked(void) override;
std::vector<std::string> getDisplayModes(void) const override;
bool doubleClicked() override;
std::vector<std::string> getDisplayModes() const override;
void setDisplayMode(const char* ModeName) override;
/// indicates if the ViewProvider use the new Selection model
bool useNewSelectionModel(void) const override { return true; }
bool useNewSelectionModel() const override { return true; }
/// indicates if the ViewProvider can be selected
bool isSelectable(void) const override;
bool isSelectable() const override;
/// return a hit element to the selection path or 0
std::string getElement(const SoDetail *) const override;
SoDetail* getDetail(const char*) const override;

4
src/Mod/PartDesign/Gui/ViewProviderHelix.cpp
View File

@@ -61,7 +61,7 @@ TaskDlgFeatureParameters *ViewProviderHelix::getEditDialog()
return new TaskDlgHelixParameters( this );
}
QIcon ViewProviderHelix::getIcon(void) const {
QIcon ViewProviderHelix::getIcon() const {
QString str = QString::fromLatin1("PartDesign_");
auto* prim = static_cast<PartDesign::Helix*>(getObject());
if(prim->getAddSubType() == PartDesign::FeatureAddSub::Additive)
@@ -90,7 +90,7 @@ void ViewProviderHelix::unsetEdit(int ModNum)
PartDesignGui::ViewProvider::unsetEdit(ModNum);
}
std::vector<App::DocumentObject*> ViewProviderHelix::claimChildren(void) const {
std::vector<App::DocumentObject*> ViewProviderHelix::claimChildren() const {
std::vector<App::DocumentObject*> temp;
App::DocumentObject* sketch = static_cast<PartDesign::ProfileBased*>(getObject())->Profile.getValue();
if (sketch && sketch->isDerivedFrom(Part::Part2DObject::getClassTypeId()))

4
src/Mod/PartDesign/Gui/ViewProviderHelix.h
View File

@@ -42,12 +42,12 @@ public:
void setupContextMenu(QMenu*, QObject*, const char*) override;
/// grouping handling
std::vector<App::DocumentObject*> claimChildren(void)const override;
std::vector<App::DocumentObject*> claimChildren() const override;
bool onDelete(const std::vector<std::string> &) override;
protected:
QIcon getIcon(void) const override;
QIcon getIcon() const override;
/// Returns a newly created TaskDlgHelixParameters
TaskDlgFeatureParameters *getEditDialog() override;

4
src/Mod/PartDesign/Gui/ViewProviderLoft.h
View File

@@ -45,7 +45,7 @@ public:
~ViewProviderLoft() override;
/// grouping handling
std::vector<App::DocumentObject*> claimChildren(void)const override;
std::vector<App::DocumentObject*> claimChildren() const override;
void setupContextMenu(QMenu*, QObject*, const char*) override;
bool onDelete(const std::vector<std::string> &) override;
@@ -54,7 +54,7 @@ public:
void highlightReferences(Reference mode, bool on);
protected:
QIcon getIcon(void) const override;
QIcon getIcon() const override;
bool setEdit(int ModNum) override;
void unsetEdit(int ModNum) override;
TaskDlgFeatureParameters* getEditDialog() override;

2
src/Mod/PartDesign/Gui/ViewProviderPrimitive.h
View File

@@ -42,7 +42,7 @@ public:
void updateData(const App::Property*) override;
protected:
QIcon getIcon(void) const override;
QIcon getIcon() const override;
void setupContextMenu(QMenu* menu, QObject* receiver, const char* member) override;
bool setEdit(int ModNum) override;
void unsetEdit(int ModNum) override;

2
src/Mod/PartDesign/Gui/ViewProviderShapeBinder.cpp
View File

@@ -402,7 +402,7 @@ void ViewProviderSubShapeBinder::updatePlacement(bool transaction) {
App::GetApplication().closeActiveTransaction(true);
}
std::vector<App::DocumentObject*> ViewProviderSubShapeBinder::claimChildren(void) const {
std::vector<App::DocumentObject*> ViewProviderSubShapeBinder::claimChildren() const {
std::vector<App::DocumentObject*> ret;
auto self = Base::freecad_dynamic_cast<PartDesign::SubShapeBinder>(getObject());
if (self && self->ClaimChildren.getValue() && self->Support.getValue()) {