kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

PVS: V1024 The 'file' stream is checked for EOF before reading from it, but is not checked after reading. Potential use of invalid data

Browse Source
This commit is contained in:
wmayer
2019-03-13 13:34:45 +01:00
parent 56b9d509a1
commit 23bc00e1a1
6 changed files with 8 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/Mod/Drawing/App/FeaturePage.cpp
View File

@@ -155,9 +155,8 @@ App::DocumentObjectExecReturn *FeaturePage::execute(void)
ostringstream ofile;
string tempendl = "--endOfLine--";
while (!file.eof())
while (getline (file,line))
{
getline (file,line);
// check if the marker in the template is found
if(line.find("<!-- DrawingContent -->") == string::npos)
// if not - write through
@@ -259,8 +258,7 @@ std::vector<std::string> FeaturePage::getEditableTextsFromTemplate(void) const {
}
string tline, tfrag;
ifstream tfile (tfi.filePath().c_str());
while (!tfile.eof()) {
getline (tfile,tline);
while (getline (tfile,tline)) {
tfrag += tline;
tfrag += "--endOfLine--";
}

4
src/Mod/Drawing/Gui/TaskOrthoViews.cpp
View File

@@ -88,10 +88,8 @@ void pagesize(string & page_template, int dims[4], int block[4])
try
{
while (!file.eof())
while (getline (file,line))
{
getline (file,line);
if (line.find("<!-- Working space") != string::npos)
{
sscanf(line.c_str(), "%*s %*s %*s %d %d %d %d", &dims[0], &dims[1], &dims[2], &dims[3]); //eg " <!-- Working space 10 10 410 287 -->"