From 242c724be27520a64e221172b715b77c76dc357e Mon Sep 17 00:00:00 2001 From: Furgo <148809153+furgo16@users.noreply.github.com> Date: Tue, 22 Apr 2025 16:20:05 +0200 Subject: [PATCH] Assembly: BOM, apply suggestion: do not copy baseName Co-authored-by: Kacper Donat --- src/Mod/Assembly/App/BomObject.cpp | 2 +- src/Mod/Assembly/App/BomObject.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Mod/Assembly/App/BomObject.cpp b/src/Mod/Assembly/App/BomObject.cpp index 0353cee2e1..ca75e95e18 100644 --- a/src/Mod/Assembly/App/BomObject.cpp +++ b/src/Mod/Assembly/App/BomObject.cpp @@ -263,7 +263,7 @@ void BomObject::addObjectToBom(App::DocumentObject* obj, size_t row, std::string } } -std::string BomObject::getBomPropertyValue(App::DocumentObject* obj, std::string baseName) +std::string BomObject::getBomPropertyValue(App::DocumentObject* obj, const std::string& baseName) { App::Property* prop = obj->getPropertyByName(baseName.c_str()); diff --git a/src/Mod/Assembly/App/BomObject.h b/src/Mod/Assembly/App/BomObject.h index e93cae4188..7d0950830d 100644 --- a/src/Mod/Assembly/App/BomObject.h +++ b/src/Mod/Assembly/App/BomObject.h @@ -96,7 +96,7 @@ public: std::vector obj_list; private: - std::string getBomPropertyValue(App::DocumentObject* obj, std::string baseName); + std::string getBomPropertyValue(App::DocumentObject* obj, const std::string& baseName); };