From 2884d3ac6052520352104be341c3512c9f2fdfe9 Mon Sep 17 00:00:00 2001 From: Markus Lampert Date: Thu, 3 Aug 2017 16:42:47 -0700 Subject: [PATCH] Moved PathPocket to use PathAreaOp. --- .../Gui/Resources/panels/PageDepthsEdit.ui | 28 +- src/Mod/Path/PathScripts/PathAreaOp.py | 26 +- src/Mod/Path/PathScripts/PathAreaOpGui.py | 41 ++- src/Mod/Path/PathScripts/PathContour.py | 8 +- src/Mod/Path/PathScripts/PathPocket.py | 285 ++++-------------- 5 files changed, 132 insertions(+), 256 deletions(-) diff --git a/src/Mod/Path/Gui/Resources/panels/PageDepthsEdit.ui b/src/Mod/Path/Gui/Resources/panels/PageDepthsEdit.ui index 0baef83a6d..858a0b3fef 100644 --- a/src/Mod/Path/Gui/Resources/panels/PageDepthsEdit.ui +++ b/src/Mod/Path/Gui/Resources/panels/PageDepthsEdit.ui @@ -7,7 +7,7 @@ 0 0 394 - 403 + 219 @@ -18,7 +18,7 @@ - + Start Depth @@ -28,22 +28,32 @@ - + Final Depth - + - - + + Step Down + + + + Finish Depth + + + + + + @@ -53,6 +63,12 @@
Gui/InputField.h
 + + startDepth + finalDepth + finishDepth + stepDown + diff --git a/src/Mod/Path/PathScripts/PathAreaOp.py b/src/Mod/Path/PathScripts/PathAreaOp.py index b43215b924..100035b0e0 100644 --- a/src/Mod/Path/PathScripts/PathAreaOp.py +++ b/src/Mod/Path/PathScripts/PathAreaOp.py @@ -44,10 +44,12 @@ PathLog.trackModule() def translate(context, text, disambig=None): return QtCore.QCoreApplication.translate(context, text, disambig) -FeatureTool = 0x01 -FeatureDepths = 0x02 -FeatureHeights = 0x04 -FeatureStartPoint = 0x08 +FeatureTool = 0x01 +FeatureDepths = 0x02 +FeatureHeights = 0x04 +FeatureStartPoint = 0x08 +FeatureBaseGeometry = 0x10 +FeatureFinishDepth = 0x20 class ObjectOp(object): @@ -56,6 +58,10 @@ class ObjectOp(object): obj.addProperty("App::PropertyBool", "Active", "Path", QtCore.QT_TRANSLATE_NOOP("App::Property", "Make False, to prevent operation from generating code")) obj.addProperty("App::PropertyString", "Comment", "Path", QtCore.QT_TRANSLATE_NOOP("App::Property", "An optional comment for this Contour")) + obj.addProperty("App::PropertyString", "UserLabel", "Path", QtCore.QT_TRANSLATE_NOOP("App::Property", "User Assigned Label")) + + if FeatureBaseGeometry & self.opFeatures(obj): + obj.addProperty("App::PropertyLinkSubList", "Base", "Path", QtCore.QT_TRANSLATE_NOOP("App::Property", "The base geometry for this operation")) if FeatureTool & self.opFeatures(obj): obj.addProperty("App::PropertyLink", "ToolController", "Path", QtCore.QT_TRANSLATE_NOOP("App::Property", "The tool controller that will be used to calculate the path")) @@ -65,6 +71,9 @@ class ObjectOp(object): obj.addProperty("App::PropertyDistance", "StartDepth", "Depth", QtCore.QT_TRANSLATE_NOOP("App::Property", "Starting Depth of Tool- first cut depth in Z")) obj.addProperty("App::PropertyDistance", "FinalDepth", "Depth", QtCore.QT_TRANSLATE_NOOP("App::Property", "Final Depth of Tool- lowest value in Z")) + if FeatureFinishDepth & self.opFeatures(obj): + obj.addProperty("App::PropertyDistance", "FinishDepth", "Depth", QtCore.QT_TRANSLATE_NOOP("App::Property", "Maximum material removed on final pass.")) + if FeatureHeights & self.opFeatures(obj): obj.addProperty("App::PropertyDistance", "ClearanceHeight", "Depth", QtCore.QT_TRANSLATE_NOOP("App::Property", "The height needed to clear clamps and obstructions")) obj.addProperty("App::PropertyDistance", "SafeHeight", "Depth", QtCore.QT_TRANSLATE_NOOP("App::Property", "Rapid Safety Height between locations.")) @@ -83,6 +92,7 @@ class ObjectOp(object): self.initOperation(obj) obj.Proxy = self + self.setDefaultValues(obj) def __getstate__(self): return None @@ -91,7 +101,11 @@ class ObjectOp(object): return None def opFeatures(self, obj): - return FeatureTool | FeatureDepths | FeatureHeights | FeatureStartPoint + return FeatureTool | FeatureDepths | FeatureHeights | FeatureStartPoint | FeatureBaseGeometry | FeatureFinishDepth + def opOnChanged(self, obj, prop): + pass + def opSetDefaultValues(self, obj): + pass def onChanged(self, obj, prop): if prop in ['AreaParams', 'PathParams', 'removalshape']: @@ -148,8 +162,6 @@ class ObjectOp(object): area.setPlane(makeWorkplane(baseobject)) area.add(baseobject) - areaParams = {'Fill': 0, 'Coplanar': 2} - areaParams = self.opAreaParams(obj) heights = [i for i in self.depthparams] diff --git a/src/Mod/Path/PathScripts/PathAreaOpGui.py b/src/Mod/Path/PathScripts/PathAreaOpGui.py index fd8b2bb6f1..964181f06a 100644 --- a/src/Mod/Path/PathScripts/PathAreaOpGui.py +++ b/src/Mod/Path/PathScripts/PathAreaOpGui.py @@ -37,7 +37,7 @@ from PySide import QtCore, QtGui # 0 ... existing toolbox layout # 1 ... reverse order # 2 ... multi panel layout -TaskPanelLayout = 0 +TaskPanelLayout = 2 def translate(context, text, disambig=None): return QtCore.QCoreApplication.translate(context, text, disambig) @@ -122,9 +122,16 @@ class TaskPanelHeightsPage(TaskPanelPage): def getSignalsForUpdate(self, obj): return [self.form.safeHeight.editingFinished, self.form.clearanceHeight.editingFinished] -class TaskPanelDepthsPage(TaskPanelPage): +class TaskPanelDepthsWoFinishPage(TaskPanelPage): def getForm(self): - return FreeCADGui.PySideUic.loadUi(":/panels/PageDepthsEdit.ui") + form = FreeCADGui.PySideUic.loadUi(":/panels/PageDepthsEdit.ui") + return self.setupForm(form) + + def setupForm(self, form): + form.finishDepth.hide() + form.finishDepthLabel.hide() + return form + def getTitle(self, obj): return translate("PathAreaOp", "Depths") def getFields(self, obj): @@ -142,21 +149,41 @@ class TaskPanelDepthsPage(TaskPanelPage): signals.append(self.form.stepDown.editingFinished) return signals +class TaskPanelDepthsPage(TaskPanelDepthsWoFinishPage): + def setupForm(self, form): + form.finishDepth.setEnabled(True) + form.finishDepthLabel.setEnabled(True) + return form + def getFields(self, obj): + super(self.__class__, self).getFields(obj) + obj.FinishDepth = FreeCAD.Units.Quantity(self.form.finishDepth.text()).Value + def setFields(self, obj): + super(self.__class__, self).setFields(obj) + self.form.finishDepth.setText(FreeCAD.Units.Quantity(obj.FinishDepth.Value, FreeCAD.Units.Length).UserString) + def getSignalsForUpdate(self, obj): + signals = super(self.__class__, self).getSignalsForUpdate(obj) + signals.append(self.form.finishDepth.editingFinished) + return signals + class TaskPanel(object): - def __init__(self, obj, deleteOnReject, page, selectionFactory): + def __init__(self, obj, deleteOnReject, opPage, selectionFactory): FreeCAD.ActiveDocument.openTransaction(translate("Path_AreaOp", "AreaOp Operation")) self.deleteOnReject = deleteOnReject self.featurePages = [] if PathAreaOp.FeatureDepths & obj.Proxy.opFeatures(obj): - self.featurePages.append(TaskPanelDepthsPage(obj)) + if PathAreaOp.FeatureFinishDepth & obj.Proxy.opFeatures(obj): + depthPage = TaskPanelDepthsPage(obj) + else: + depthPage = TaskPanelDepthsWoFinishPage(obj) + self.featurePages.append(depthPage) if PathAreaOp.FeatureHeights & obj.Proxy.opFeatures(obj): self.featurePages.append(TaskPanelHeightsPage(obj)) - page.setTitle(translate('PathAreaOp', 'Operation')) - self.featurePages.append(page) + opPage.setTitle(translate('PathAreaOp', 'Operation')) + self.featurePages.append(opPage) if TaskPanelLayout < 2: self.form = QtGui.QToolBox() diff --git a/src/Mod/Path/PathScripts/PathContour.py b/src/Mod/Path/PathScripts/PathContour.py index b59bd2745d..45fbf04b33 100644 --- a/src/Mod/Path/PathScripts/PathContour.py +++ b/src/Mod/Path/PathScripts/PathContour.py @@ -55,6 +55,9 @@ __url__ = "http://www.freecadweb.org" class ObjectContour(PathAreaOp.ObjectOp): + def opFeatures(self, obj): + return PathAreaOp.FeatureTool | PathAreaOp.FeatureDepths | PathAreaOp.FeatureHeights | PathAreaOp.FeatureStartPoint + def initOperation(self, obj): PathLog.track() @@ -81,7 +84,7 @@ class ObjectContour(PathAreaOp.ObjectOp): def opShapeForDepths(self, obj): job = PathUtils.findParentJob(obj) if job and job.Base: - PathLog.info("job=%s base=%s shape=%s" % (job, job.Base, job.Base.Shape)) + PathLog.debug("job=%s base=%s shape=%s" % (job, job.Base, job.Base.Shape)) return job.Base.Shape PathLog.warning("No job object found (%s), or job has no Base." % job) return None @@ -128,7 +131,7 @@ class ObjectContour(PathAreaOp.ObjectOp): if obj.UseComp is False: params['Offset'] = 0.0 else: - params['Offset'] = self.radius+obj.OffsetExtra.Value + params['Offset'] = self.radius + obj.OffsetExtra.Value jointype = ['Round', 'Square', 'Miter'] params['JoinType'] = jointype.index(obj.JoinType) @@ -148,5 +151,4 @@ class ObjectContour(PathAreaOp.ObjectOp): def Create(name): obj = FreeCAD.ActiveDocument.addObject("Path::FeaturePython", name) proxy = ObjectContour(obj) - proxy.setDefaultValues(obj) return obj diff --git a/src/Mod/Path/PathScripts/PathPocket.py b/src/Mod/Path/PathScripts/PathPocket.py index 2b333b9ea5..0ec40b1eaf 100644 --- a/src/Mod/Path/PathScripts/PathPocket.py +++ b/src/Mod/Path/PathScripts/PathPocket.py @@ -23,16 +23,13 @@ # *************************************************************************** import FreeCAD -import Path -from PySide import QtCore, QtGui -from PathScripts import PathUtils -import PathScripts.PathLog as PathLog -from PathScripts.PathUtils import waiting_effects, depth_params import Part +import Path +import PathScripts.PathAreaOp as PathAreaOp +import PathScripts.PathLog as PathLog -FreeCADGui = None -if FreeCAD.GuiUp: - import FreeCADGui +from PathScripts import PathUtils +from PySide import QtCore, QtGui """Path Pocket object and FreeCAD command""" @@ -42,30 +39,17 @@ if False: else: PathLog.setLevel(PathLog.Level.INFO, PathLog.thisModule()) +import FreeCADGui # Qt tanslation handling def translate(context, text, disambig=None): return QtCore.QCoreApplication.translate(context, text, disambig) -class ObjectPocket: +class ObjectPocket(PathAreaOp.ObjectOp): - def __init__(self, obj): - obj.addProperty("App::PropertyLinkSubList", "Base", "Path", QtCore.QT_TRANSLATE_NOOP("App::Property", "The base geometry of this object")) - obj.addProperty("App::PropertyBool", "Active", "Path", QtCore.QT_TRANSLATE_NOOP("App::Property", "Make False, to prevent operation from generating code")) - obj.addProperty("App::PropertyString", "Comment", "Path", QtCore.QT_TRANSLATE_NOOP("App::Property", "An optional comment for this profile")) - obj.addProperty("App::PropertyString", "UserLabel", "Path", QtCore.QT_TRANSLATE_NOOP("App::Property", "User Assigned Label")) - - # Tool Properties - obj.addProperty("App::PropertyLink", "ToolController", "Path", QtCore.QT_TRANSLATE_NOOP("App::Property", "The tool controller that will be used to calculate the path")) - - # Depth Properties - obj.addProperty("App::PropertyDistance", "ClearanceHeight", "Depth", QtCore.QT_TRANSLATE_NOOP("App::Property", "The height needed to clear clamps and obstructions")) - obj.addProperty("App::PropertyDistance", "SafeHeight", "Depth", QtCore.QT_TRANSLATE_NOOP("App::Property", "Rapid Safety Height between locations.")) - obj.addProperty("App::PropertyDistance", "StepDown", "Depth", QtCore.QT_TRANSLATE_NOOP("App::Property", "Incremental Step Down of Tool")) - obj.addProperty("App::PropertyDistance", "StartDepth", "Depth", QtCore.QT_TRANSLATE_NOOP("App::Property", "Starting Depth of Tool- first cut depth in Z")) - obj.addProperty("App::PropertyDistance", "FinalDepth", "Depth", QtCore.QT_TRANSLATE_NOOP("App::Property", "Final Depth of Tool- lowest value in Z")) - obj.addProperty("App::PropertyDistance", "FinishDepth", "Depth", QtCore.QT_TRANSLATE_NOOP("App::Property", "Maximum material removed on final pass.")) + def initOperation(self, obj): + PathLog.track() # Pocket Properties obj.addProperty("App::PropertyEnumeration", "CutMode", "Pocket", QtCore.QT_TRANSLATE_NOOP("App::Property", "The direction that the toolpath should go around the part ClockWise CW or CounterClockWise CCW")) @@ -79,53 +63,17 @@ class ObjectPocket: obj.OffsetPattern = ['ZigZag', 'Offset', 'Spiral', 'ZigZagOffset', 'Line', 'Grid', 'Triangle'] obj.addProperty("App::PropertyBool", "MinTravel", "Pocket", QtCore.QT_TRANSLATE_NOOP("App::Property", "Use 3D Sorting of Path")) - # Start Point Properties - obj.addProperty("App::PropertyVector", "StartPoint", "Start Point", QtCore.QT_TRANSLATE_NOOP("App::Property", "The start point of this path")) - obj.addProperty("App::PropertyBool", "UseStartPoint", "Start Point", QtCore.QT_TRANSLATE_NOOP("App::Property", "make True, if specifying a Start Point")) - - # Debug Parameters - obj.addProperty("App::PropertyString", "AreaParams", "Path") - obj.setEditorMode('AreaParams', 2) # hide - obj.addProperty("App::PropertyString", "PathParams", "Path") - obj.setEditorMode('PathParams', 2) # hide - obj.addProperty("Part::PropertyPartShape", "removalshape", "Path") - obj.setEditorMode('removalshape', 2) # hide if FreeCAD.GuiUp: ViewProviderPocket(obj.ViewObject) - obj.Proxy = self - - def onChanged(self, obj, prop): - if prop in ['AreaParams', 'PathParams', 'removalshape']: - obj.setEditorMode(prop, 2) - - def __getstate__(self): + def opShapeForDepths(self, obj): + job = PathUtils.findParentJob(obj) + if job and job.Base: + PathLog.debug("job=%s base=%s shape=%s" % (job, job.Base, job.Base.Shape)) + return job.Base.Shape + PathLog.warning("No job object found (%s), or job has no Base." % job) return None - def __setstate__(self, state): - return None - - def setDepths(proxy, obj): - PathLog.track() - parentJob = PathUtils.findParentJob(obj) - if parentJob is None: - return - baseobject = parentJob.Base - if baseobject is None: - return - - try: - bb = baseobject.Shape.BoundBox # parent boundbox - obj.StartDepth = bb.ZMax - obj.ClearanceHeight = bb.ZMax + 5.0 - obj.SafeHeight = bb.ZMax + 3.0 - obj.FinalDepth = bb.ZMin - - except: - obj.StartDepth = 5.0 - obj.ClearanceHeight = 10.0 - obj.SafeHeight = 8.0 - def addpocketbase(self, obj, ss, sub=""): PathLog.track() baselist = obj.Base @@ -158,131 +106,45 @@ class ObjectPocket: item = (ss, sub) if item in baselist: - FreeCAD.Console.PrintWarning(translate("Path", "this object already in the list" + "\n")) + PathLog.warning(translate("Path", "this object already in the list" + "\n")) else: baselist.append(item) obj.Base = baselist self.execute(obj) - def getStock(self, obj): - """find and return a stock object from hosting project if any""" - for o in obj.InList: - if hasattr(o, "Group"): - for g in o.Group: - if hasattr(g, "Height_Allowance"): - return o - # not found? search one level up - for o in obj.InList: - return self.getStock(o) - return None - - @waiting_effects - def _buildPathArea(self, obj, envelopeshape, getsim=False): - PathLog.track() - pocket = Path.Area() - pocket.setPlane(Part.makeCircle(10)) - pocket.add(envelopeshape) - - stepover = (self.radius * 2) * (float(obj.StepOver)/100) - - pocketparams = {'Fill': 0, - 'Coplanar': 0, - 'PocketMode': 1, - 'SectionCount': -1, - 'Angle': obj.ZigZagAngle, - 'FromCenter': (obj.StartAt == "Center"), - 'PocketStepover': stepover, - 'PocketExtraOffset': obj.MaterialAllowance.Value} - - offsetval = self.radius - pocketparams['ToolRadius'] = offsetval + def opAreaParams(self, obj): + params = {} + params['Fill'] = 0 + params['Coplanar'] = 0 + params['PocketMode'] = 1 + params['SectionCount'] = -1 + params['Angle'] = obj.ZigZagAngle + params['FromCenter'] = (obj.StartAt == "Center") + params['PocketStepover'] = (self.radius * 2) * (float(obj.StepOver)/100) + params['PocketExtraOffset'] = obj.MaterialAllowance.Value + params['ToolRadius'] = self.radius Pattern = ['ZigZag', 'Offset', 'Spiral', 'ZigZagOffset', 'Line', 'Grid', 'Triangle'] - pocketparams['PocketMode'] = Pattern.index(obj.OffsetPattern) + 1 + params['PocketMode'] = Pattern.index(obj.OffsetPattern) + 1 + return params - pocket.setParams(**pocketparams) - obj.AreaParams = str(pocket.getParams()) - PathLog.debug("Pocketing with params: {}".format(pocket.getParams())) + def opPathParams(self, obj): + params = {} - heights = [i for i in self.depthparams] - PathLog.debug('pocket section heights: {}'.format(heights)) - sections = pocket.makeSections(mode=0, project=False, heights=heights) + # if MinTravel is turned on, set path sorting to 3DSort + # 3DSort shouldn't be used without a valid start point. Can cause + # tool crash without it. + if obj.MinTravel and obj.UseStartPoint and obj.StartPoint is not None: + params['sort_mode'] = 2 + return params - shapelist = [sec.getShape() for sec in sections] - - params = {'shapes': shapelist, - 'feedrate': self.horizFeed, - 'feedrate_v': self.vertFeed, - 'verbose': True, - 'resume_height': obj.StepDown.Value, - 'retraction': obj.ClearanceHeight.Value} - - if obj.UseStartPoint and obj.StartPoint is not None: - params['start'] = obj.StartPoint - - # if MinTravel is turned on, set path sorting to 3DSort - # 3DSort shouldn't be used without a valid start point. Can cause - # tool crash without it. - if obj.MinTravel: - params['sort_mode'] = 2 - - obj.PathParams = str({key: value for key, value in params.items() if key != 'shapes'}) - - pp = Path.fromShapes(**params) - PathLog.debug("Generating Path with params: {}".format(params)) - PathLog.debug(pp) - - simobj = None - if getsim: - pocketparams['Thicken'] = True - pocketparams['ToolRadius'] = self.radius - self.radius * .005 - pocketparams['Stepdown'] = -1 - pocket.setParams(**pocketparams) - simobj = pocket.getShape().extrude(FreeCAD.Vector(0, 0, obj.StepDown.Value)) - - return pp, simobj - - def execute(self, obj, getsim=False): + def opShape(self, obj, commandlist): PathLog.track() - commandlist = [] - simlist = [] - commandlist.append(Path.Command("(" + obj.Label + ")")) - if not obj.Active: - path = Path.Path("(inactive operation)") - obj.Path = path - obj.ViewObject.Visibility = False - return - parentJob = PathUtils.findParentJob(obj) - if parentJob is None: + job = PathUtils.findParentJob(obj) + if not job or not job.Base: return - baseobject = parentJob.Base - if baseobject is None: - return - - self.depthparams = depth_params( - clearance_height=obj.ClearanceHeight.Value, - safe_height=obj.SafeHeight.Value, - start_depth=obj.StartDepth.Value, - step_down=obj.StepDown.Value, - z_finish_step=0.0, - final_depth=obj.FinalDepth.Value, - user_depths=None) - - toolLoad = obj.ToolController - if toolLoad is None or toolLoad.ToolNumber == 0: - FreeCAD.Console.PrintError("No Tool Controller is selected. We need a tool to build a Path.") - else: - self.vertFeed = toolLoad.VertFeed.Value - self.horizFeed = toolLoad.HorizFeed.Value - self.vertRapid = toolLoad.VertRapid.Value - self.horizRapid = toolLoad.HorizRapid.Value - tool = toolLoad.Proxy.getTool(toolLoad) - if not tool or tool.Diameter == 0: - FreeCAD.Console.PrintError("No Tool found or diameter is zero. We need a tool to build a Path.") - return - else: - self.radius = tool.Diameter/2 + baseobject = job.Base if obj.Base: PathLog.debug("base items exist. Processing...") @@ -297,48 +159,22 @@ class ObjectPocket: env = PathUtils.getEnvelope(baseobject.Shape, subshape=shape, depthparams=self.depthparams) obj.removalshape = env.cut(baseobject.Shape) - - try: - (pp, sim) = self._buildPathArea(obj, obj.removalshape, getsim=getsim) - if sim is not None: - simlist.append(sim) - commandlist.extend(pp.Commands) - except Exception as e: - FreeCAD.Console.PrintError(e) - FreeCAD.Console.PrintError("Something unexpected happened. Unable to generate a pocket path. Check project and tool config.") else: # process the job base object as a whole PathLog.debug("processing the whole job base object") env = PathUtils.getEnvelope(baseobject.Shape, subshape=None, depthparams=self.depthparams) obj.removalshape = env.cut(baseobject.Shape) - try: - (pp, sim) = self._buildPathArea(obj, obj.removalshape, getsim=getsim) - commandlist.extend(pp.Commands) - if sim is not None: - simlist.append(sim) + return obj.removalshape - except Exception as e: - FreeCAD.Console.PrintError(e) - FreeCAD.Console.PrintError("Something unexpected happened. Unable to generate a pocket path. Check project and tool config.") + def opSetDefaultValues(self, obj): + obj.StepOver = 100 + obj.ZigZagAngle = 45 - # Let's finish by rapid to clearance...just for safety - commandlist.append(Path.Command("G0", {"Z": obj.ClearanceHeight.Value})) - - path = Path.Path(commandlist) - obj.Path = path - - PathLog.debug(simlist) - simshape = None - if len(simlist) > 1: - simshape = simlist[0].fuse(simlist[1:]) - elif len(simlist) == 1: - simshape = simlist[0] - - if simshape is not None and PathLog.getLevel(PathLog.thisModule()) == PathLog.Level.DEBUG: - sim = FreeCAD.ActiveDocument.addObject("Part::Feature", "simshape") - sim.Shape = simshape - return simshape +def Create(name): + obj = FreeCAD.ActiveDocument.addObject("Path::FeaturePython", name) + proxy = ObjectPocket(obj) + return obj class _CommandSetPocketStartPoint: def GetResources(self): @@ -407,30 +243,13 @@ class CommandPathPocket: def Activated(self): PathLog.track() - zbottom = 0.0 - ztop = 10.0 - - # if everything is ok, execute and register the transaction in the undo/redo stack FreeCAD.ActiveDocument.openTransaction(translate("PathPocket", "Create Pocket")) - FreeCADGui.addModule("PathScripts.PathPocket") - FreeCADGui.doCommand('obj = FreeCAD.ActiveDocument.addObject("Path::FeaturePython", "Pocket")') - FreeCADGui.doCommand('PathScripts.PathPocket.ObjectPocket(obj)') - FreeCADGui.doCommand('obj.Active = True') - FreeCADGui.doCommand('obj.ViewObject.Proxy.deleteOnReject = True') - FreeCADGui.doCommand('from PathScripts import PathUtils') - FreeCADGui.doCommand('obj.StepOver = 100') - FreeCADGui.doCommand('obj.ClearanceHeight = 10') # + str(bb.ZMax + 2.0)) - FreeCADGui.doCommand('obj.StepDown = 1.0') - FreeCADGui.doCommand('obj.StartDepth = ' + str(ztop)) - FreeCADGui.doCommand('obj.FinalDepth =' + str(zbottom)) - FreeCADGui.doCommand('obj.ZigZagAngle = 45') - FreeCADGui.doCommand('PathScripts.PathUtils.addToJob(obj)') - FreeCADGui.doCommand('PathScripts.PathPocket.ObjectPocket.setDepths(obj.Proxy, obj)') - FreeCADGui.doCommand('obj.ToolController = PathScripts.PathUtils.findToolController(obj)') + obj = Create("Pocket") FreeCAD.ActiveDocument.commitTransaction() # FreeCAD.ActiveDocument.recompute() - FreeCADGui.doCommand('obj.ViewObject.startEditing()') + obj.ViewObject.startEditing() + return obj class TaskPanel: