diff --git a/src/Mod/Sketcher/Gui/SketcherSettings.cpp b/src/Mod/Sketcher/Gui/SketcherSettings.cpp index ca48c9f242..0696f76b7d 100644 --- a/src/Mod/Sketcher/Gui/SketcherSettings.cpp +++ b/src/Mod/Sketcher/Gui/SketcherSettings.cpp @@ -107,7 +107,6 @@ void SketcherSettings::saveSettings() ui->checkBoxAdvancedSolverTaskBox->onSave(); ui->checkBoxRecalculateInitialSolutionWhileDragging->onSave(); ui->checkBoxEnableEscape->onSave(); - ui->checkBoxDisableShading->onSave(); ui->checkBoxNotifyConstraintSubstitutions->onSave(); ui->checkBoxAutoRemoveRedundants->onSave(); ui->checkBoxUnifiedCoincident->onSave(); @@ -180,7 +179,6 @@ void SketcherSettings::loadSettings() ui->checkBoxAdvancedSolverTaskBox->onRestore(); ui->checkBoxRecalculateInitialSolutionWhileDragging->onRestore(); ui->checkBoxEnableEscape->onRestore(); - ui->checkBoxDisableShading->onRestore(); ui->checkBoxNotifyConstraintSubstitutions->onRestore(); ui->checkBoxAutoRemoveRedundants->onRestore(); ui->checkBoxUnifiedCoincident->onRestore(); diff --git a/src/Mod/Sketcher/Gui/SketcherSettings.ui b/src/Mod/Sketcher/Gui/SketcherSettings.ui index 4203ad3764..8a7b37cfc5 100644 --- a/src/Mod/Sketcher/Gui/SketcherSettings.ui +++ b/src/Mod/Sketcher/Gui/SketcherSettings.ui @@ -140,25 +140,6 @@ Requires to re-enter edit mode to take effect. - - - - Disables the shaded view when entering the sketch edit mode. - - - Disable shading in edit mode - - - true - - - DisableShadedView - - - Mod/Sketcher/General - - - diff --git a/src/Mod/Sketcher/Gui/ViewProviderSketch.cpp b/src/Mod/Sketcher/Gui/ViewProviderSketch.cpp index 0696d0d115..d7c1421a64 100644 --- a/src/Mod/Sketcher/Gui/ViewProviderSketch.cpp +++ b/src/Mod/Sketcher/Gui/ViewProviderSketch.cpp @@ -3294,31 +3294,6 @@ void ViewProviderSketch::unsetEdit(int ModNum) if (sketchHandler) deactivateHandler(); - Gui::MDIView* mdi = getInventorView(); - - // handle the override draw style mode only if there's a 3D view, otherwise SIGSEGV may - // occur as described in https://github.com/FreeCAD/FreeCAD/issues/15918 - if (mdi) { - - // Resets the override draw style mode when leaving the sketch edit mode. - ParameterGrp::handle hGrp = App::GetApplication().GetParameterGroupByPath( - "User parameter:BaseApp/Preferences/Mod/Sketcher/General"); - auto disableShadedView = hGrp->GetBool("DisableShadedView", false); - if (disableShadedView) { - Gui::View3DInventorViewer* viewer = - static_cast(mdi)->getViewer(); - - ParameterGrp::handle hGrp = App::GetApplication().GetParameterGroupByPath( - "User parameter:BaseApp/Preferences/Mod/Sketcher/General"); - auto OverrideMode = hGrp->GetASCII("OverrideMode", "As Is"); - - if (viewer) { - viewer->updateOverrideMode(OverrideMode); - viewer->setOverrideMode(OverrideMode); - } - } - } - editCoinManager = nullptr; snapManager = nullptr; preselection.reset(); @@ -3397,24 +3372,6 @@ void ViewProviderSketch::setEditViewer(Gui::View3DInventorViewer* viewer, int Mo } } - // Sets the view mode to no shading to prevent visibility issues against parallel surfaces with shininess when entering the sketch mode. - ParameterGrp::handle hGrp = App::GetApplication().GetParameterGroupByPath( - "User parameter:BaseApp/Preferences/Mod/Sketcher/General"); - auto disableShadedView = hGrp->GetBool("DisableShadedView", false); - - hGrp = App::GetApplication().GetParameterGroupByPath( - "User parameter:BaseApp/Preferences/Mod/Sketcher/General"); - hGrp->SetASCII("OverrideMode", viewer->getOverrideMode()); - - if (disableShadedView) { - - - viewer->updateOverrideMode("No Shading"); - viewer->setOverrideMode("No Shading"); - - } - - auto editDoc = Gui::Application::Instance->editDocument(); editDocName.clear(); if (editDoc) {