PVS issues:

consistently define copy constructor and assignment operator
remove superfluous casts
initialize member variables in constructor
avoid double assignment
This commit is contained in:
wmayer
2019-03-04 11:53:49 +01:00
parent d28e6a6ae7
commit 28b195d6e2
16 changed files with 63 additions and 22 deletions

View File

@@ -286,13 +286,17 @@ void ViewProviderGeometryObject::setSelectable(bool selectable)
for (int i=0;i<pathList.getLength();i++) {
SoFCSelection *selNode = dynamic_cast<SoFCSelection*>(pathList[i]->getTail());
if (selectable) {
selNode->selectionMode = SoFCSelection::SEL_ON;
selNode->highlightMode = SoFCSelection::AUTO;
if (selNode) {
selNode->selectionMode = SoFCSelection::SEL_ON;
selNode->highlightMode = SoFCSelection::AUTO;
}
}
else {
selNode->selectionMode = SoFCSelection::SEL_OFF;
selNode->highlightMode = SoFCSelection::OFF;
selNode->selected = SoFCSelection::NOTSELECTED;
if (selNode) {
selNode->selectionMode = SoFCSelection::SEL_OFF;
selNode->highlightMode = SoFCSelection::OFF;
selNode->selected = SoFCSelection::NOTSELECTED;
}
}
}
}