kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

NotificationArea/Preferences: Allow Opt-in for Developer warnings and errors

Browse Source 
============================================================================

The old preferences had errors and warnings ON by default and allowed to opt-out.
It was not possible to separate errors/warnings intended for users from those intended for developers.

The new version has developer errors and warnings OFF by default. User intended ones are ON.
It is possible to opt-in for developer errors and warnings from the preferences dialog.

As developer errors and warnings are NOT translated, if opting-in, they won't be localised.

User errors and warnings should be translated. If they are not, it is a bug.
This commit is contained in:
Abdullah Tahiri
2023-05-22 18:37:56 +02:00
committed by abdullahtahiriyo
parent bcedfae708
commit 28b7176691
4 changed files with 66 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/Gui/DlgSettingsNotificationArea.cpp
View File

@@ -51,8 +51,8 @@ DlgSettingsNotificationArea::DlgSettingsNotificationArea(QWidget* parent)
ui->autoRemoveUserNotifications->setEnabled(true);
ui->hideNonIntrusiveNotificationsWhenWindowDeactivated->setEnabled(true);
ui->preventNonIntrusiveNotificationsWhenWindowNotActive->setEnabled(true);
ui->errorSubscriptionEnabled->setEnabled(true);
ui->warningSubscriptionEnabled->setEnabled(true);
ui->developerErrorSubscriptionEnabled->setEnabled(true);
ui->developerWarningSubscriptionEnabled->setEnabled(true);
QMessageBox::information(this,
tr("Notification Area"),
tr("Activation of the Notification Area only takes effect "
@@ -68,8 +68,8 @@ DlgSettingsNotificationArea::DlgSettingsNotificationArea(QWidget* parent)
ui->autoRemoveUserNotifications->setEnabled(false);
ui->hideNonIntrusiveNotificationsWhenWindowDeactivated->setEnabled(false);
ui->preventNonIntrusiveNotificationsWhenWindowNotActive->setEnabled(false);
ui->errorSubscriptionEnabled->setEnabled(false);
ui->warningSubscriptionEnabled->setEnabled(false);
ui->developerErrorSubscriptionEnabled->setEnabled(false);
ui->developerWarningSubscriptionEnabled->setEnabled(false);
// N.B: Deactivation is handled by the Notification Area itself, as it listens to all
// its configuration parameters.
}
@@ -91,8 +91,8 @@ void DlgSettingsNotificationArea::saveSettings()
ui->notificationWidth->onSave();
ui->hideNonIntrusiveNotificationsWhenWindowDeactivated->onSave();
ui->preventNonIntrusiveNotificationsWhenWindowNotActive->onSave();
ui->errorSubscriptionEnabled->onSave();
ui->warningSubscriptionEnabled->onSave();
ui->developerErrorSubscriptionEnabled->onSave();
ui->developerWarningSubscriptionEnabled->onSave();
}
void DlgSettingsNotificationArea::loadSettings()
@@ -107,8 +107,8 @@ void DlgSettingsNotificationArea::loadSettings()
ui->notificationWidth->onRestore();
ui->hideNonIntrusiveNotificationsWhenWindowDeactivated->onRestore();
ui->preventNonIntrusiveNotificationsWhenWindowNotActive->onRestore();
ui->errorSubscriptionEnabled->onRestore();
ui->warningSubscriptionEnabled->onRestore();
ui->developerErrorSubscriptionEnabled->onRestore();
ui->developerWarningSubscriptionEnabled->onRestore();
}
void DlgSettingsNotificationArea::changeEvent(QEvent* e)