kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Part: Fix several clazy issues:

Browse Source 
* Maybe you meant to call Primitive::onChanged() instead [-Wclazy-skipped-base-method]
* Maybe you meant to call Primitive::mustExecute() instead [-Wclazy-skipped-base-method]
* Missing reference in range-for with non trivial type [-Wclazy-range-loop-reference]
* Use multi-arg instead [-Wclazy-qstring-arg]
* Use midRef() instead [-Wclazy-qstring-ref]
This commit is contained in:
wmayer
2022-07-25 08:31:18 +02:00
parent 28ba51f23f
commit 2b039d67fe
15 changed files with 275 additions and 276 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/Mod/Part/Gui/ReferenceHighlighter.cpp
View File

@@ -114,7 +114,7 @@ void ReferenceHighlighter::getVertexColors(const std::vector<std::string>& eleme
colors.resize(vMap.Extent(), defaultColor);
if (!elements.empty()) {
for (std::string e : elements) {
for (const std::string& e : elements) {
if (boost::starts_with(e, "Vertex")) {
getVertexColor(e, colors);
}
@@ -185,7 +185,7 @@ void ReferenceHighlighter::getEdgeColors(const std::vector<std::string>& element
colors.resize(eMap.Extent(), defaultColor);
if (!elements.empty()) {
for (std::string e : elements) {
for (const std::string& e : elements) {
if (boost::starts_with(e, "Edge")) {
getEdgeColor(e, colors);
}
@@ -217,7 +217,7 @@ void ReferenceHighlighter::getFaceColors(const std::vector<std::string>& element
colors.resize(fMap.Extent(), defaultColor);
if (!elements.empty()) {
for (std::string e : elements) {
for (const std::string& e : elements) {
if (boost::starts_with(e, "Face")) {
getFaceColor(e, colors);
}