From 2b84be64cc764e2de5aac02f53e99b289c8ffc95 Mon Sep 17 00:00:00 2001 From: wandererfan Date: Sun, 28 Oct 2018 18:21:42 -0400 Subject: [PATCH] Fix spurious error message - in FeatureGroove, the check for multiple solids in result was checking the wrong variable. --- src/Mod/PartDesign/App/FeatureGroove.cpp | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/Mod/PartDesign/App/FeatureGroove.cpp b/src/Mod/PartDesign/App/FeatureGroove.cpp index ab97d79a2b..036d06e5f2 100644 --- a/src/Mod/PartDesign/App/FeatureGroove.cpp +++ b/src/Mod/PartDesign/App/FeatureGroove.cpp @@ -37,6 +37,7 @@ #endif #include +#include #include #include #include @@ -155,14 +156,15 @@ App::DocumentObjectExecReturn *Groove::execute(void) TopoDS_Shape solRes = this->getSolid(mkCut.Shape()); if (solRes.IsNull()) return new App::DocumentObjectExecReturn("Resulting shape is not a solid"); - - int solidCount = countSolids(result); - if (solidCount > 1) { - return new App::DocumentObjectExecReturn("Groove: Result has multiple solids. This is not supported at this time."); - } solRes = refineShapeIfActive(solRes); this->Shape.setValue(getSolid(solRes)); + + int solidCount = countSolids(solRes); + if (solidCount > 1) { + return new App::DocumentObjectExecReturn("Groove: Result has multiple solids. This is not supported at this time."); + } + } else return new App::DocumentObjectExecReturn("Could not revolve the sketch!");