From 2d1edacaa9249dfd8826a27a6b2ed9dd23e843aa Mon Sep 17 00:00:00 2001 From: shai Date: Thu, 4 Jul 2024 19:53:09 +0300 Subject: [PATCH] Add fixes suggested by @bgbsww --- src/Mod/Part/App/TopoShapePy.xml | 2 +- .../PartDesignTests/TestTopologicalNamingProblem.py | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/Mod/Part/App/TopoShapePy.xml b/src/Mod/Part/App/TopoShapePy.xml index 435db55ef8..96c9ef7aa0 100644 --- a/src/Mod/Part/App/TopoShapePy.xml +++ b/src/Mod/Part/App/TopoShapePy.xml @@ -817,7 +817,7 @@ infos contains additional info on the solutions. It is a list of tuples: Returns a SubElement getElement(elementName, [silent = False]) -> Face | Edge | Vertex elementName: SubElement name - i.e. 'Edge1', 'Face3' etc. - Accepts TNP names as well + Accepts TNP mitigation mapped names as well silent: True to suppress the exception throw if the shape isn't found. diff --git a/src/Mod/PartDesign/PartDesignTests/TestTopologicalNamingProblem.py b/src/Mod/PartDesign/PartDesignTests/TestTopologicalNamingProblem.py index 3f9fa99f02..599985b10a 100644 --- a/src/Mod/PartDesign/PartDesignTests/TestTopologicalNamingProblem.py +++ b/src/Mod/PartDesign/PartDesignTests/TestTopologicalNamingProblem.py @@ -1467,13 +1467,14 @@ class TestTopologicalNamingProblem(unittest.TestCase): pad.Length = 1 # Act self.Doc.recompute() - if body.Shape.ElementMapVersion == "": # Should be '4' as of Mar 2023. + if pad.Shape.ElementMapVersion == "": # Should be '4' as of Mar 2023. return map = pad.Shape.ElementMap # Assert + self.assertGreater(pad.Shape.ElementMapSize,0) for tnpName in map.keys(): - element1 = body.Shape.getElement(tnpName) - element2 = body.Shape.getElement(map[tnpName]) + element1 = pad.Shape.getElement(tnpName) + element2 = pad.Shape.getElement(map[tnpName]) self.assertTrue(element1.isSame(element2)) def testFileSaveRestore(self):