From 2e5b02e52cbdc6eafc50a7f087295cf3ee03c9ab Mon Sep 17 00:00:00 2001
From: PaddleStroke <pierrelouis.boyer@gmail.com>
Date: Mon, 22 Sep 2025 18:25:16 +0200
Subject: [PATCH] Link: Fix Selectable (#23567)

* Link: Fix Selectable

* to squash

* squash

* squash
---
 src/Gui/ViewProvider.cpp               |  3 +--
 src/Gui/ViewProviderDocumentObject.cpp |  3 +--
 src/Gui/ViewProviderLink.cpp           | 27 +++++++++++++++++++++++---
 src/Gui/ViewProviderLink.h             |  4 ++++
 4 files changed, 30 insertions(+), 7 deletions(-)

diff --git a/src/Gui/ViewProvider.cpp b/src/Gui/ViewProvider.cpp
index 065ed97e1c..f1a32892ac 100644
--- a/src/Gui/ViewProvider.cpp
+++ b/src/Gui/ViewProvider.cpp
@@ -912,8 +912,6 @@ std::vector< App::DocumentObject* > ViewProvider::claimChildren3D() const
 }
 
 bool ViewProvider::getElementPicked(const SoPickedPoint *pp, std::string &subname) const {
-    if(!isSelectable())
-        return false;
     auto vector = getExtensionsDerivedFromType<Gui::ViewProviderExtension>();
     for(Gui::ViewProviderExtension* ext : vector) {
         if(ext->extensionGetElementPicked(pp,subname))
@@ -1080,3 +1078,4 @@ void ViewProvider::setLinkVisible(bool visible) {
     if(ext)
         ext->setLinkVisible(visible);
 }
+
diff --git a/src/Gui/ViewProviderDocumentObject.cpp b/src/Gui/ViewProviderDocumentObject.cpp
index a353301708..3f6eabea10 100644
--- a/src/Gui/ViewProviderDocumentObject.cpp
+++ b/src/Gui/ViewProviderDocumentObject.cpp
@@ -591,8 +591,6 @@ bool ViewProviderDocumentObject::showInTree() const {
 
 bool ViewProviderDocumentObject::getElementPicked(const SoPickedPoint *pp, std::string &subname) const
 {
-    if(!isSelectable())
-        return false;
     auto vector = getExtensionsDerivedFromType<Gui::ViewProviderExtension>();
     for(Gui::ViewProviderExtension* ext : vector)
         if(ext->extensionGetElementPicked(pp,subname))
@@ -702,3 +700,4 @@ std::string ViewProviderDocumentObject::getFullName() const {
         return pcObject->getFullName() + ".ViewObject";
     return std::string("?");
 }
+
diff --git a/src/Gui/ViewProviderLink.cpp b/src/Gui/ViewProviderLink.cpp
index 3809773cd3..2adc25e259 100644
--- a/src/Gui/ViewProviderLink.cpp
+++ b/src/Gui/ViewProviderLink.cpp
@@ -402,6 +402,13 @@ public:
 
         for(int i=0,count=root->getNumChildren();i<count;++i) {
             SoNode *node = root->getChild(i);
+
+            // Exclude the linked object's pick style from the snapshot,
+            // so that the Link's own pick style is the only one in effect.
+            if (node->isOfType(SoPickStyle::getClassTypeId())) {
+                continue;
+            }
+
             if(node==pcLinked->getTransformNode()) {
                 if(type!=LinkView::SnapshotTransform)
                     pcSnapshot->addChild(node);
@@ -502,7 +509,7 @@ public:
     bool getElementPicked(bool addname, int type,
             const SoPickedPoint *pp, std::ostream &str) const
     {
-        if(!pp || !isLinked() || !pcLinked->isSelectable())
+        if(!pp || !isLinked())
             return false;
 
         if(addname)
@@ -1670,10 +1677,14 @@ ViewProviderLink::ViewProviderLink()
     DisplayMode.setStatus(App::Property::Status::Hidden, true);
 
     linkView = new LinkView;
+
+    pcPickStyle = new SoPickStyle;
+    pcPickStyle->ref();
 }
 
 ViewProviderLink::~ViewProviderLink()
 {
+    pcPickStyle->unref();
     linkView->setInvalid();
 }
 
@@ -1681,7 +1692,12 @@ bool ViewProviderLink::isSelectable() const {
     return Selectable.getValue();
 }
 
-void ViewProviderLink::attach(App::DocumentObject *pcObj) {
+void ViewProviderLink::attach(App::DocumentObject* pcObj)
+{
+    if (pcRoot->findChild(pcPickStyle) < 0) {
+        pcRoot->insertChild(pcPickStyle, 0);
+    }
+
     SoNode *node = linkView->getLinkRoot();
     node->setName(pcObj->getFullName().c_str());
     addDisplayMaskMode(node,"Link");
@@ -1743,7 +1759,12 @@ QPixmap ViewProviderLink::getOverlayPixmap() const {
         return BitmapFactory().pixmapFromSvg("LinkOverlay", QSizeF(px,px));
 }
 
-void ViewProviderLink::onChanged(const App::Property* prop) {
+void ViewProviderLink::onChanged(const App::Property* prop)
+{
+    if (prop == &Selectable) {
+        pcPickStyle->style = Selectable.getValue() ? SoPickStyle::SHAPE : SoPickStyle::UNPICKABLE;
+    }
+
     if(prop==&ChildViewProvider) {
         childVp = freecad_cast<ViewProviderDocumentObject*>(ChildViewProvider.getObject().get());
         if(childVp && getObject()) {
diff --git a/src/Gui/ViewProviderLink.h b/src/Gui/ViewProviderLink.h
index ab8c184990..4af944e3b5 100644
--- a/src/Gui/ViewProviderLink.h
+++ b/src/Gui/ViewProviderLink.h
@@ -39,6 +39,7 @@
 class SoBase;
 class SoDragger;
 class SoMaterialBinding;
+class SoPickStyle;
 
 namespace Gui {
 
@@ -337,6 +338,9 @@ protected:
     ViewProviderDocumentObject *childVp;
     LinkInfoPtr childVpLink;
     mutable qint64 overlayCacheKey;
+
+private:
+    SoPickStyle* pcPickStyle {nullptr};
 };
 
 using ViewProviderLinkPython = ViewProviderFeaturePythonT<ViewProviderLink>;