From 2e6dac1871c1067980e735cb100caf498abf08ff Mon Sep 17 00:00:00 2001 From: Bernd Hahnebach Date: Fri, 4 Jan 2019 11:06:00 +0100 Subject: [PATCH] FEM: code formating, flake8 --- src/Mod/Fem/femsolver/elmer/tasks.py | 1 + src/Mod/Fem/femsolver/fenics/fenics_tools.py | 11 +++++------ src/Mod/Fem/femtest/testmesh.py | 8 ++++---- src/Mod/Fem/femtest/utilstest.py | 8 ++++---- 4 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/Mod/Fem/femsolver/elmer/tasks.py b/src/Mod/Fem/femsolver/elmer/tasks.py index ef914fa80a..87745ee0ec 100644 --- a/src/Mod/Fem/femsolver/elmer/tasks.py +++ b/src/Mod/Fem/femsolver/elmer/tasks.py @@ -81,6 +81,7 @@ class Prepare(run.Prepare): except IOError as e: self.report.error("Can't access working directory.") self.fail() + del e # get flake8 quit def checkHandled(self, w): handled = w.getHandledConstraints() diff --git a/src/Mod/Fem/femsolver/fenics/fenics_tools.py b/src/Mod/Fem/femsolver/fenics/fenics_tools.py index 1e552fc90f..7e537e3578 100644 --- a/src/Mod/Fem/femsolver/fenics/fenics_tools.py +++ b/src/Mod/Fem/femsolver/fenics/fenics_tools.py @@ -138,12 +138,11 @@ else: # TODO: python classes much slower than JIT compilation - -# *********************************** -# * Sub classes due to value_shape method which is not of dynamical return type -# * Also the assignment of values is to be done by reference. Therefore it has to be -# * overloaded. -# *********************************** + # *********************************** + # * Sub classes due to value_shape method which is not of dynamical return type + # * Also the assignment of values is to be done by reference. Therefore it has to be + # * overloaded. + # *********************************** class ScalarCellExpressionFromXDMF(fenics.Expression, CellExpressionFromXDMF): diff --git a/src/Mod/Fem/femtest/testmesh.py b/src/Mod/Fem/femtest/testmesh.py index c86d5c2107..e71d7b9358 100644 --- a/src/Mod/Fem/femtest/testmesh.py +++ b/src/Mod/Fem/femtest/testmesh.py @@ -120,10 +120,10 @@ class TestMeshCommon(unittest.TestCase): read_file = open(inp_file, 'r') read_node_line = 'line was not found' - for l in read_file: - l = l.strip() - if l.startswith('2, -5'): - read_node_line = l + for ln in read_file: + ln = ln.strip() + if ln.startswith('2, -5'): + read_node_line = ln read_file.close() # 1234567 12345678901234567890 12345678901234567890 diff --git a/src/Mod/Fem/femtest/utilstest.py b/src/Mod/Fem/femtest/utilstest.py index cef4bc0ac7..5004dc85d2 100644 --- a/src/Mod/Fem/femtest/utilstest.py +++ b/src/Mod/Fem/femtest/utilstest.py @@ -154,10 +154,10 @@ def compare_stats(fea, stat_file=None, loc_stat_types=None, res_obj_name=None): def force_unix_line_ends(line_list): new_line_list = [] - for l in line_list: - if l.endswith("\r\n"): - l = l[:-2] + '\n' - new_line_list.append(l) + for ln in line_list: + if ln.endswith("\r\n"): + ln = ln[:-2] + '\n' + new_line_list.append(ln) return new_line_list