kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Compiler warning cleanup (#26229)

Browse Source 
* App: Compiler warning cleanup

* Gui: Compiler warning cleanup

* Assembly: Compiler warning cleanup

* Measure: Compiler warning cleanup

* Sketcher: Compiler warning cleanup

* TechDraw: Compiler warning cleanup

* PartDesign: Compiler warning cleanup
This commit is contained in:
Kacper Donat
2025-12-18 07:50:26 +01:00
committed by GitHub
parent 9b07585b88 e5d7920dd7
commit 2ea7c39563
17 changed files with 21 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Mod/Assembly/App/AssemblyLink.cpp
View File

@@ -323,7 +323,7 @@ void AssemblyLink::synchronizeComponents()
= srcLink->ElementList.getValues();
const std::vector<App::DocumentObject*> newElements
= link2->ElementList.getValues();
for (int i = 0; i < srcElements.size(); ++i) {
for (size_t i = 0; i < srcElements.size(); ++i) {
objLinkMap[srcElements[i]] = newElements[i];
}
break;
@@ -373,7 +373,7 @@ void AssemblyLink::synchronizeComponents()
newLink->ElementCount.setValue(srcLink->ElementCount.getValue());
const std::vector<App::DocumentObject*> srcElements = srcLink->ElementList.getValues();
const std::vector<App::DocumentObject*> newElements = newLink->ElementList.getValues();
for (int i = 0; i < srcElements.size(); ++i) {
for (size_t i = 0; i < srcElements.size(); ++i) {
auto* newObj = newElements[i];
auto* srcObj = srcElements[i];
if (newObj && srcObj) {

2
src/Mod/Assembly/Gui/TaskAssemblyMessages.cpp
View File

@@ -69,7 +69,7 @@ void TaskAssemblyMessages::updateToolTip(const QString& link)
}
}
void TaskAssemblyMessages::onLabelStatusLinkClicked(const QString& str)
void TaskAssemblyMessages::onLabelStatusLinkClicked(const QString& /*str*/)
{
// The commands are not implemented yet since App is not reporting yet the solver's status
/* if (str == QStringLiteral("#conflicting")) {

2
src/Mod/Assembly/Gui/TaskAssemblyMessages.h
View File

@@ -44,7 +44,7 @@ public:
private:
void onLabelStatusLinkClicked(const QString&) override;
void updateToolTip(const QString& link);
void updateToolTip(const QString& link) override;
protected:
ViewProviderAssembly* vp;

1
src/Mod/Assembly/Gui/ViewProviderAssembly.h
View File

@@ -284,7 +284,6 @@ private:
std::set<App::DocumentObject*>& visited
);
TaskAssemblyMessages* taskSolver;
boost::signals2::connection connectSolverUpdate;
boost::signals2::scoped_connection m_preTransactionConn;
};

1
src/Mod/Measure/App/Measurement.cpp
View File

@@ -327,6 +327,7 @@ MeasureType Measurement::getType()
TopoDS_Shape Measurement::getShape(App::DocumentObject* obj, const char* subName, TopAbs_ShapeEnum hint) const
{
(void)hint;
return Part::Feature::getShape(
obj,
Part::ShapeOption::NeedSubElement | Part::ShapeOption::ResolveLink

1
src/Mod/PartDesign/Gui/TaskRevolutionParameters.cpp
View File

@@ -775,7 +775,6 @@ void TaskRevolutionParameters::setGizmoPositions()
bool ret;
if (isGroove) {
auto groove = getObject<PartDesign::Groove>();
ret = getFeatureProps(getObject<PartDesign::Groove>());
}
else {

2
src/Mod/Sketcher/Gui/Command.cpp
View File

@@ -1614,7 +1614,7 @@ void RenderingOrderAction::updateWidget()
int midid = hGrp->GetInt("MidRenderGeometryId", 2);
int lowid = hGrp->GetInt("LowRenderGeometryId", 3);
auto idToText = [this](int id) -> QString {
auto idToText = [](int id) -> QString {
switch (id) {
case 1:
return tr("Normal geometry");

5
src/Mod/Sketcher/Gui/CommandConstraints.cpp
View File

@@ -1034,8 +1034,9 @@ public:
Gui::Selection().rmvSelectionGate();
}
void mouseMove(SnapManager::SnapHandle snapHandle) override
{}
void mouseMove(SnapManager::SnapHandle /*snapHandle*/) override
{
}
bool pressButton(Base::Vector2d /*onSketchPos*/) override
{

4
src/Mod/Sketcher/Gui/DrawSketchHandlerOffset.h
View File

@@ -298,7 +298,7 @@ private:
return line;
}
Part::Geometry* curveToCircleOrArc(BRepAdaptor_Curve curve, const TopoDS_Edge& edge)
Part::Geometry* curveToCircleOrArc(BRepAdaptor_Curve curve, const TopoDS_Edge& /*edge*/)
{
gp_Circ circle = curve.Circle();
gp_Pnt cnt = circle.Location();
@@ -330,7 +330,7 @@ private:
}
}
Part::Geometry* curveToEllipseOrArc(BRepAdaptor_Curve curve, const TopoDS_Edge& edge)
Part::Geometry* curveToEllipseOrArc(BRepAdaptor_Curve curve, const TopoDS_Edge& /*edge*/)
{
gp_Elips ellipse = curve.Ellipse();
gp_Pnt beg = curve.Value(curve.FirstParameter());

8
src/Mod/Sketcher/Gui/EditModeCoinManager.cpp
View File

@@ -121,11 +121,9 @@ void EditModeCoinManager::ParameterObserver::initParameters()
[this](const std::string& param) { updateConstraintPresentationParameters(param); }},
{"DimensionalStringFormat",
[this](const std::string& param) { updateConstraintPresentationParameters(param); }},
{"ViewScalingFactor",
[this](const std::string& param) { Client.updateElementSizeParameters(); }},
{"MarkerSize", [this](const std::string& param) { Client.updateElementSizeParameters(); }},
{"EditSketcherFontSize",
[this](const std::string& param) { Client.updateElementSizeParameters(); }},
{"ViewScalingFactor", [this](const std::string&) { Client.updateElementSizeParameters(); }},
{"MarkerSize", [this](const std::string&) { Client.updateElementSizeParameters(); }},
{"EditSketcherFontSize", [this](const std::string&) { Client.updateElementSizeParameters(); }},
{"EdgeWidth",
[this, &drawingParameters = Client.drawingParameters](const std::string& param) {
updateWidth(drawingParameters.CurveWidth, param, 2);

4
src/Mod/TechDraw/App/DrawComplexSection.cpp
View File

@@ -1558,13 +1558,13 @@ DrawComplexSection::findNormalForFace(const TopoDS_Face& face,
const std::vector<std::pair<int, Base::Vector3d>>& normalKV,
const std::vector<TopoDS_Edge>& segmentEdges)
{
int index = getSegmentIndex(face, segmentEdges);
size_t index = getSegmentIndex(face, segmentEdges);
if (index < 0 ||
index >= segmentEdges.size()) { //NOLINT
throw Base::RuntimeError("DCS::findNormalForFace - did not find normal for face!");
}
for (auto& keyValue : normalKV) {
if (keyValue.first == index) {
if (static_cast<size_t>(keyValue.first) == index) {
return keyValue;
}
}

2
src/Mod/TechDraw/Gui/QGIView.cpp
View File

@@ -74,8 +74,6 @@ using namespace TechDrawGui;
using namespace TechDraw;
using DU = DrawUtil;
const float labelCaptionFudge = 0.2f; // temp fiddle for devel
QGIView::QGIView()
:QGraphicsItemGroup(),
m_isHovered(false),