PVS: V678 An object is used as an argument to its own method. Consider checking the first actual argument of the 'setupUi' function.

Avoid to include ui generated header files within other header files but use forward declarations instead. This reduces dependencies between files and compile time considerably

src/Mod/TechDraw/Gui/DlgPrefsTechDrawAnnotationImp.h

@@ -25,12 +25,13 @@
 #ifndef DRAWINGGUI_DLGPREFSTECHDRAWIMPANNOTATION_H
 #define DRAWINGGUI_DLGPREFSTECHDRAWIMPANNOTATION_H
 
-#include <Mod/TechDraw/Gui/ui_DlgPrefsTechDrawAnnotation.h>
 #include <Gui/PropertyPage.h>
+#include <memory>
 
 namespace TechDrawGui {
+class Ui_DlgPrefsTechDrawAnnotationImp;
 
-class DlgPrefsTechDrawAnnotationImp : public Gui::Dialog::PreferencePage, public Ui_DlgPrefsTechDrawAnnotationImp
+class DlgPrefsTechDrawAnnotationImp : public Gui::Dialog::PreferencePage
 {
     Q_OBJECT
 
@@ -42,8 +43,11 @@ protected:
     void saveSettings();
     void loadSettings();
     void changeEvent(QEvent *e);
-    
+
     int prefBalloonArrow(void) const;
+
+private:
+    std::unique_ptr<Ui_DlgPrefsTechDrawAnnotationImp> ui;
 };
 
 } // namespace TechDrawGui