From 319b63cbda7c64f1a9f3b738595fa3cb4ddd4fe0 Mon Sep 17 00:00:00 2001 From: wmayer Date: Mon, 5 Dec 2022 12:46:52 +0100 Subject: [PATCH] PD: remove parameter 'supportface' from ProfileBased::getUpToFace as it's not used any more --- src/Mod/PartDesign/App/FeaturePad.cpp | 2 +- src/Mod/PartDesign/App/FeaturePocket.cpp | 2 +- src/Mod/PartDesign/App/FeatureSketchBased.cpp | 1 - src/Mod/PartDesign/App/FeatureSketchBased.h | 1 - 4 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/Mod/PartDesign/App/FeaturePad.cpp b/src/Mod/PartDesign/App/FeaturePad.cpp index bf3d9b16da..1daed9c1ed 100644 --- a/src/Mod/PartDesign/App/FeaturePad.cpp +++ b/src/Mod/PartDesign/App/FeaturePad.cpp @@ -157,7 +157,7 @@ App::DocumentObjectExecReturn *Pad::execute() getFaceFromLinkSub(upToFace, UpToFace); upToFace.Move(invObjLoc); } - getUpToFace(upToFace, base, supportface, sketchshape, method, dir); + getUpToFace(upToFace, base, sketchshape, method, dir); addOffsetToFace(upToFace, dir, Offset.getValue()); // TODO: Write our own PrismMaker which does not depend on a solid base shape diff --git a/src/Mod/PartDesign/App/FeaturePocket.cpp b/src/Mod/PartDesign/App/FeaturePocket.cpp index ef209b0e56..252092c2d9 100644 --- a/src/Mod/PartDesign/App/FeaturePocket.cpp +++ b/src/Mod/PartDesign/App/FeaturePocket.cpp @@ -167,7 +167,7 @@ App::DocumentObjectExecReturn *Pocket::execute() getFaceFromLinkSub(upToFace, UpToFace); upToFace.Move(invObjLoc); } - getUpToFace(upToFace, base, supportface, profileshape, method, dir); + getUpToFace(upToFace, base, profileshape, method, dir); addOffsetToFace(upToFace, dir, Offset.getValue()); // BRepFeat_MakePrism(..., 2, 1) in combination with PerForm(upToFace) is buggy when the diff --git a/src/Mod/PartDesign/App/FeatureSketchBased.cpp b/src/Mod/PartDesign/App/FeatureSketchBased.cpp index 199d630960..10bdee2a6c 100644 --- a/src/Mod/PartDesign/App/FeatureSketchBased.cpp +++ b/src/Mod/PartDesign/App/FeatureSketchBased.cpp @@ -449,7 +449,6 @@ void ProfileBased::getFaceFromLinkSub(TopoDS_Face& upToFace, const App::Property void ProfileBased::getUpToFace(TopoDS_Face& upToFace, const TopoDS_Shape& support, - const TopoDS_Face& supportface, const TopoDS_Shape& sketchshape, const std::string& method, const gp_Dir& dir) diff --git a/src/Mod/PartDesign/App/FeatureSketchBased.h b/src/Mod/PartDesign/App/FeatureSketchBased.h index 3a729dc49b..49bd99702b 100644 --- a/src/Mod/PartDesign/App/FeatureSketchBased.h +++ b/src/Mod/PartDesign/App/FeatureSketchBased.h @@ -134,7 +134,6 @@ protected: /// Find a valid face to extrude up to static void getUpToFace(TopoDS_Face& upToFace, const TopoDS_Shape& support, - const TopoDS_Face& supportface, const TopoDS_Shape& sketchshape, const std::string& method, const gp_Dir& dir);