From 31ed14db83fe5a3e51519745ed2e3dddb74a5edb Mon Sep 17 00:00:00 2001
From: wmayer <wmayer@users.sourceforge.net>
Date: Mon, 7 Aug 2023 11:00:14 +0200
Subject: [PATCH] modernize C++: use noexcept

---
 src/Base/Exception.cpp             | 12 ++---
 src/Base/Exception.h               | 76 +++++++++++++++---------------
 src/Base/Interpreter.cpp           |  2 +-
 src/Base/Interpreter.h             |  4 +-
 src/Mod/Part/App/AttachExtension.h |  2 +-
 src/Mod/Part/App/Attacher.h        |  2 +-
 src/Mod/Part/App/TopoShape.h       |  4 +-
 src/Mod/Sketcher/Gui/Command.cpp   |  6 ++-
 8 files changed, 55 insertions(+), 53 deletions(-)

diff --git a/src/Base/Exception.cpp b/src/Base/Exception.cpp
index bfdc7694cd..068cc3d1e4 100644
--- a/src/Base/Exception.cpp
+++ b/src/Base/Exception.cpp
@@ -81,7 +81,7 @@ Exception &Exception::operator=(const Exception &inst)
     return *this;
 }
 
-const char* Exception::what() const throw()
+const char* Exception::what() const noexcept
 {
     return _sErrMsg.c_str();
 }
@@ -174,7 +174,7 @@ AbortException::AbortException()
     _sErrMsg = "Aborted operation";
 }
 
-const char* AbortException::what() const throw()
+const char* AbortException::what() const noexcept
 {
     return Exception::what();
 }
@@ -224,7 +224,7 @@ XMLParseException::XMLParseException()
     _sErrMsg = "XML parse exception";
 }
 
-const char* XMLParseException::what() const throw()
+const char* XMLParseException::what() const noexcept
 {
     return XMLBaseException::what();
 }
@@ -251,7 +251,7 @@ XMLAttributeError::XMLAttributeError()
     _sErrMsg = "XML attribute error";
 }
 
-const char* XMLAttributeError::what() const throw()
+const char* XMLAttributeError::what() const noexcept
 {
     return XMLBaseException::what();
 }
@@ -312,7 +312,7 @@ FileException & FileException::operator=(const FileException &inst)
     return *this;
 }
 
-const char* FileException::what() const throw()
+const char* FileException::what() const noexcept
 {
     return _sErrMsgAndFileName.c_str();
 }
@@ -428,7 +428,7 @@ MemoryException & MemoryException::operator=(const MemoryException &inst)
 }
 
 #if defined (__GNUC__)
-const char* MemoryException::what() const throw()
+const char* MemoryException::what() const noexcept
 {
     // call what() of Exception, not of std::bad_alloc
     return Exception::what();
diff --git a/src/Base/Exception.h b/src/Base/Exception.h
index e1427166fd..818355ce7d 100644
--- a/src/Base/Exception.h
+++ b/src/Base/Exception.h
@@ -92,11 +92,11 @@ class BaseExport Exception : public BaseClass
   TYPESYSTEM_HEADER_WITH_OVERRIDE();
 public:
 
-  ~Exception() throw() override = default;
+  ~Exception() noexcept override = default;
 
   Exception &operator=(const Exception &inst);
 
-  virtual const char* what() const throw();
+  virtual const char* what() const noexcept;
 
   /// Reports exception. It includes a mechanism to only report an exception once.
   virtual void ReportException () const;
@@ -165,9 +165,9 @@ public:
   AbortException();
 
   /// Destruction
-  ~AbortException() throw() override = default;
+  ~AbortException() noexcept override = default;
   /// Description of the exception
-  const char* what() const throw() override;
+  const char* what() const noexcept override;
   /// returns the corresponding python exception type
   PyObject * getPyExceptionType() const override;
 };
@@ -185,7 +185,7 @@ public:
   XMLBaseException(const std::string& sMessage);
 
   /// Destruction
-  ~XMLBaseException() throw() override = default;
+  ~XMLBaseException() noexcept override = default;
   PyObject * getPyExceptionType() const override;
 };
 
@@ -204,9 +204,9 @@ public:
   XMLParseException();
 
   /// Destruction
-  ~XMLParseException() throw() override = default;
+  ~XMLParseException() noexcept override = default;
   /// Description of the exception
-  const char* what() const throw() override;
+  const char* what() const noexcept override;
   PyObject * getPyExceptionType() const override;
 };
 
@@ -225,9 +225,9 @@ public:
   XMLAttributeError();
 
   /// Destruction
-  ~XMLAttributeError() throw() override = default;
+  ~XMLAttributeError() noexcept override = default;
   /// Description of the exception
-  const char* what() const throw() override;
+  const char* what() const noexcept override;
   PyObject * getPyExceptionType() const override;
 };
 
@@ -247,11 +247,11 @@ public:
   /// Construction
   FileException(const FileException &inst);
   /// Destruction
-  ~FileException() throw() override = default;
+  ~FileException() noexcept override = default;
   /// Assignment operator
   FileException &operator=(const FileException &inst);
   /// Description of the exception
-  const char* what() const throw() override;
+  const char* what() const noexcept override;
   /// Report generation
   void ReportException () const override;
   /// Get file name for use with translatable message
@@ -283,7 +283,7 @@ public:
   FileSystemError(const char * sMessage);
   FileSystemError(const std::string& sMessage);
   /// Destruction
-  ~FileSystemError() throw() override = default;
+  ~FileSystemError() noexcept override = default;
   PyObject * getPyExceptionType() const override;
 };
 
@@ -299,7 +299,7 @@ public:
   BadFormatError(const char * sMessage);
   BadFormatError(const std::string& sMessage);
   /// Destruction
-  ~BadFormatError() throw() override = default;
+  ~BadFormatError() noexcept override = default;
   PyObject * getPyExceptionType() const override;
 };
 
@@ -320,12 +320,12 @@ public:
   /// Construction
   MemoryException(const MemoryException &inst);
   /// Destruction
-  ~MemoryException() throw() override = default;
+  ~MemoryException() noexcept override = default;
   /// Assignment operator
   MemoryException &operator=(const MemoryException &inst);
 #if defined (__GNUC__)
   /// Description of the exception
-  const char* what() const throw() override;
+  const char* what() const noexcept override;
 #endif
   PyObject * getPyExceptionType() const override;
 };
@@ -342,7 +342,7 @@ public:
   AccessViolation(const char * sMessage);
   AccessViolation(const std::string& sMessage);
   /// Destruction
-  ~AccessViolation() throw() override = default;
+  ~AccessViolation() noexcept override = default;
   PyObject * getPyExceptionType() const override;
 };
 
@@ -359,7 +359,7 @@ public:
   AbnormalProgramTermination(const char * sMessage);
   AbnormalProgramTermination(const std::string& sMessage);
   /// Destruction
-  ~AbnormalProgramTermination() throw() override = default;
+  ~AbnormalProgramTermination() noexcept override = default;
   PyObject * getPyExceptionType() const override;
 };
 
@@ -375,7 +375,7 @@ public:
   UnknownProgramOption(const char * sMessage);
   UnknownProgramOption(const std::string& sMessage);
   /// Destruction
-  ~UnknownProgramOption() throw() override = default;
+  ~UnknownProgramOption() noexcept override = default;
   PyObject * getPyExceptionType() const override;
 };
 
@@ -392,7 +392,7 @@ public:
   ProgramInformation(const std::string& sMessage);
 
   /// Destruction
-  ~ProgramInformation() throw() override = default;
+  ~ProgramInformation() noexcept override = default;
 };
 
 /**
@@ -407,7 +407,7 @@ public:
   TypeError(const char * sMessage);
   TypeError(const std::string& sMessage);
   /// Destruction
-  ~TypeError() throw() override = default;
+  ~TypeError() noexcept override = default;
   PyObject * getPyExceptionType() const override;
 };
 
@@ -423,7 +423,7 @@ public:
   ValueError(const char * sMessage);
   ValueError(const std::string& sMessage);
   /// Destruction
-  ~ValueError() throw() override = default;
+  ~ValueError() noexcept override = default;
   PyObject * getPyExceptionType() const override;
 };
 
@@ -439,7 +439,7 @@ public:
   IndexError(const char * sMessage);
   IndexError(const std::string& sMessage);
   /// Destruction
-  ~IndexError() throw() override = default;
+  ~IndexError() noexcept override = default;
   PyObject * getPyExceptionType() const override;
 };
 
@@ -451,7 +451,7 @@ public:
   NameError(const char * sMessage);
   NameError(const std::string& sMessage);
   /// Destruction
-  ~NameError() throw() override = default;
+  ~NameError() noexcept override = default;
   PyObject * getPyExceptionType() const override;
 };
 
@@ -463,7 +463,7 @@ public:
   ImportError(const char * sMessage);
   ImportError(const std::string& sMessage);
   /// Destruction
-  ~ImportError() throw() override = default;
+  ~ImportError() noexcept override = default;
   PyObject * getPyExceptionType() const override;
 };
 
@@ -479,7 +479,7 @@ public:
   AttributeError(const char * sMessage);
   AttributeError(const std::string& sMessage);
   /// Destruction
-  ~AttributeError() throw() override = default;
+  ~AttributeError() noexcept override = default;
   PyObject * getPyExceptionType() const override;
 };
 
@@ -495,7 +495,7 @@ public:
   RuntimeError(const char * sMessage);
   RuntimeError(const std::string& sMessage);
   /// Destruction
-  ~RuntimeError() throw() override = default;
+  ~RuntimeError() noexcept override = default;
   PyObject * getPyExceptionType() const override;
 };
 
@@ -511,7 +511,7 @@ public:
   BadGraphError(const char * sMessage);
   BadGraphError(const std::string& sMessage);
   /// Destruction
-  ~BadGraphError() throw() override = default;
+  ~BadGraphError() noexcept override = default;
   PyObject * getPyExceptionType() const override;
 };
 
@@ -527,7 +527,7 @@ public:
   NotImplementedError(const char * sMessage);
   NotImplementedError(const std::string& sMessage);
   /// Destruction
-  ~NotImplementedError() throw() override = default;
+  ~NotImplementedError() noexcept override = default;
   PyObject * getPyExceptionType() const override;
 };
 
@@ -543,7 +543,7 @@ public:
   ZeroDivisionError(const char * sMessage);
   ZeroDivisionError(const std::string& sMessage);
   /// Destruction
-  ~ZeroDivisionError() throw() override = default;
+  ~ZeroDivisionError() noexcept override = default;
   PyObject * getPyExceptionType() const override;
 };
 
@@ -559,7 +559,7 @@ public:
   ReferenceError(const char * sMessage);
   ReferenceError(const std::string& sMessage);
   /// Destruction
-  ~ReferenceError() throw() override = default;
+  ~ReferenceError() noexcept override = default;
   PyObject * getPyExceptionType() const override;
 };
 
@@ -576,7 +576,7 @@ public:
   ExpressionError(const char * sMessage);
   ExpressionError(const std::string& sMessage);
   /// Destruction
-  ~ExpressionError() throw() override = default;
+  ~ExpressionError() noexcept override = default;
   PyObject * getPyExceptionType() const override;
 };
 
@@ -592,7 +592,7 @@ public:
   ParserError(const char * sMessage);
   ParserError(const std::string& sMessage);
   /// Destruction
-  ~ParserError() throw() override = default;
+  ~ParserError() noexcept override = default;
   PyObject * getPyExceptionType() const override;
 };
 
@@ -608,7 +608,7 @@ public:
   UnicodeError(const char * sMessage);
   UnicodeError(const std::string& sMessage);
   /// Destruction
-  ~UnicodeError() throw() override = default;
+  ~UnicodeError() noexcept override = default;
   PyObject * getPyExceptionType() const override;
 };
 
@@ -624,7 +624,7 @@ public:
   OverflowError(const char * sMessage);
   OverflowError(const std::string& sMessage);
   /// Destruction
-  ~OverflowError() throw() override = default;
+  ~OverflowError() noexcept override = default;
   PyObject * getPyExceptionType() const override;
 };
 
@@ -640,7 +640,7 @@ public:
   UnderflowError(const char * sMessage);
   UnderflowError(const std::string& sMessage);
   /// Destruction
-  ~UnderflowError() throw() override = default;
+  ~UnderflowError() noexcept override = default;
   PyObject * getPyExceptionType() const override;
 };
 
@@ -656,7 +656,7 @@ public:
   UnitsMismatchError(const char * sMessage);
   UnitsMismatchError(const std::string& sMessage);
   /// Destruction
-  ~UnitsMismatchError() throw() override = default;
+  ~UnitsMismatchError() noexcept override = default;
   PyObject * getPyExceptionType() const override;
 };
 
@@ -673,7 +673,7 @@ public:
     CADKernelError(const char * sMessage);
     CADKernelError(const std::string& sMessage);
     /// Destruction
-    ~CADKernelError() throw() override = default;
+    ~CADKernelError() noexcept override = default;
     PyObject * getPyExceptionType() const override;
 };
 
@@ -692,7 +692,7 @@ public:
     RestoreError(const char * sMessage);
     RestoreError(const std::string& sMessage);
     /// Destruction
-    ~RestoreError() throw() override = default;
+    ~RestoreError() noexcept override = default;
     PyObject * getPyExceptionType() const override;
 };
 
diff --git a/src/Base/Interpreter.cpp b/src/Base/Interpreter.cpp
index 63c2a11818..29126d0866 100644
--- a/src/Base/Interpreter.cpp
+++ b/src/Base/Interpreter.cpp
@@ -93,7 +93,7 @@ PyException::PyException()
     PyErr_Clear(); // must be called to keep Python interpreter in a valid state (Werner)
 }
 
-PyException::~PyException() throw() = default;
+PyException::~PyException() noexcept = default;
 
 void PyException::ThrowException()
 {
diff --git a/src/Base/Interpreter.h b/src/Base/Interpreter.h
index e875bc7ff1..2655a25423 100644
--- a/src/Base/Interpreter.h
+++ b/src/Base/Interpreter.h
@@ -93,7 +93,7 @@ public:
     /// constructor does the whole job
     PyException();
     PyException(const Py::Object &obj);
-    ~PyException() throw() override;
+    ~PyException() noexcept override;
 
     void raiseException();
 
@@ -139,7 +139,7 @@ class BaseExport SystemExitException : public Exception
 {
 public:
     SystemExitException();
-    ~SystemExitException() throw() override = default;
+    ~SystemExitException() noexcept override = default;
     long getExitCode() const { return _exitCode;}
 
 protected:
diff --git a/src/Mod/Part/App/AttachExtension.h b/src/Mod/Part/App/AttachExtension.h
index 0764bd68e8..626de2b5fa 100644
--- a/src/Mod/Part/App/AttachExtension.h
+++ b/src/Mod/Part/App/AttachExtension.h
@@ -49,7 +49,7 @@ public:
    explicit AttachEngineException(const char * sMessage);
    explicit AttachEngineException(const std::string& sMessage);
    /// Destruction
-   ~AttachEngineException() throw() override {}
+   ~AttachEngineException() noexcept override {}
 };
 
 /**
diff --git a/src/Mod/Part/App/Attacher.h b/src/Mod/Part/App/Attacher.h
index bd5cd3898e..8322f1a259 100644
--- a/src/Mod/Part/App/Attacher.h
+++ b/src/Mod/Part/App/Attacher.h
@@ -465,7 +465,7 @@ class ExceptionCancel : public Base::Exception
 public:
     ExceptionCancel(){}
     explicit ExceptionCancel(char* msg){this->setMessage(msg);}
-    ~ExceptionCancel() throw() override {}
+    ~ExceptionCancel() noexcept override {}
 };
 
 } // namespace Attacher
diff --git a/src/Mod/Part/App/TopoShape.h b/src/Mod/Part/App/TopoShape.h
index 1d86fba488..1ca3bca8ee 100644
--- a/src/Mod/Part/App/TopoShape.h
+++ b/src/Mod/Part/App/TopoShape.h
@@ -57,7 +57,7 @@ public:
    explicit NullShapeException(const char * sMessage);
    explicit NullShapeException(const std::string& sMessage);
    /// Destruction
-   ~NullShapeException() throw() override {}
+   ~NullShapeException() noexcept override {}
 };
 
 /* A special sub-class to indicate boolean failures
@@ -70,7 +70,7 @@ public:
    explicit BooleanException(const char * sMessage);
    explicit BooleanException(const std::string& sMessage);
    /// Destruction
-   ~BooleanException() throw() override {}
+   ~BooleanException() noexcept override {}
 };
 
 class PartExport ShapeSegment : public Data::Segment
diff --git a/src/Mod/Sketcher/Gui/Command.cpp b/src/Mod/Sketcher/Gui/Command.cpp
index e9b0c89107..544f2228be 100644
--- a/src/Mod/Sketcher/Gui/Command.cpp
+++ b/src/Mod/Sketcher/Gui/Command.cpp
@@ -59,7 +59,8 @@
 #include "Utils.h"
 #include "ViewProviderSketch.h"
 
-
+// Hint: this is to prevent to re-format big parts of the file. Remove it later again.
+// clang-format off
 using namespace std;
 using namespace SketcherGui;
 using namespace Part;
@@ -83,7 +84,7 @@ public:
         this->setMessage(ErrMsg);
     }
 
-    ~ExceptionWrongInput() throw() override
+    ~ExceptionWrongInput() noexcept override
     {}
 
     QString ErrMsg;
@@ -1848,3 +1849,4 @@ void CreateSketcherCommands()
     rcCmdMgr.addCommand(new CmdSketcherSnap());
     rcCmdMgr.addCommand(new CmdRenderingOrder());
 }
+// clang-format on