From 32c527c5a6d030fafd15bc2c3bd16e0ca09bb52e Mon Sep 17 00:00:00 2001
From: wmayer <wmayer@users.sourceforge.net>
Date: Sun, 3 Mar 2019 18:38:03 +0100
Subject: [PATCH] PVS: V547 Expression is always true/false

---
 src/Mod/PartDesign/Gui/CommandPrimitive.cpp | 12 +++++-------
 src/Mod/Sketcher/App/Sketch.cpp             |  6 ------
 2 files changed, 5 insertions(+), 13 deletions(-)

diff --git a/src/Mod/PartDesign/Gui/CommandPrimitive.cpp b/src/Mod/PartDesign/Gui/CommandPrimitive.cpp
index 61b771600b..9c3ac5ba2a 100644
--- a/src/Mod/PartDesign/Gui/CommandPrimitive.cpp
+++ b/src/Mod/PartDesign/Gui/CommandPrimitive.cpp
@@ -285,13 +285,11 @@ void CmdPrimtiveCompSubtractive::activated(int iMsg)
         }
     }
 
-    if (pcActiveBody) {
-        copyVisual(FeatName.c_str(), "ShapeColor", pcActiveBody->getNameInDocument());
-        copyVisual(FeatName.c_str(), "LineColor", pcActiveBody->getNameInDocument());
-        copyVisual(FeatName.c_str(), "PointColor", pcActiveBody->getNameInDocument());
-        copyVisual(FeatName.c_str(), "Transparency", pcActiveBody->getNameInDocument());
-        copyVisual(FeatName.c_str(), "DisplayMode", pcActiveBody->getNameInDocument());
-    }
+    copyVisual(FeatName.c_str(), "ShapeColor", pcActiveBody->getNameInDocument());
+    copyVisual(FeatName.c_str(), "LineColor", pcActiveBody->getNameInDocument());
+    copyVisual(FeatName.c_str(), "PointColor", pcActiveBody->getNameInDocument());
+    copyVisual(FeatName.c_str(), "Transparency", pcActiveBody->getNameInDocument());
+    copyVisual(FeatName.c_str(), "DisplayMode", pcActiveBody->getNameInDocument());
 
     Gui::Command::doCommand(Gui, "Gui.activeDocument().setEdit(\'%s\')", FeatName.c_str());
 }
diff --git a/src/Mod/Sketcher/App/Sketch.cpp b/src/Mod/Sketcher/App/Sketch.cpp
index b61a2ba3b8..6c34c07e2f 100644
--- a/src/Mod/Sketcher/App/Sketch.cpp
+++ b/src/Mod/Sketcher/App/Sketch.cpp
@@ -3844,12 +3844,6 @@ TopoShape Sketch::toShape(void) const
             builder.Add(comp, *wt);
         result.setShape(comp);
     }
-    // FIXME: if free edges are left over its probably better to
-    // create a compound with the closed structures and let the
-    // features decide what to do with it...
-    if (edge_list.size() > 0)
-        Base::Console().Warning("Left over edges in Sketch. Only closed structures will be propagated at the moment!\n");
-
 #endif
 
     return result;