From 32d47402b68448c0ae1eaf4ffff22029b17e73fc Mon Sep 17 00:00:00 2001
From: Chris Hennes <chennes@gmail.com>
Date: Tue, 16 Jan 2024 19:05:40 -0600
Subject: [PATCH] Tests/Toponaming: Add tests for ElementNameComparator

This verifies the existing functionality, but does not alter it. Two tests are disabled because they represent cases that the current code does not handle correctly. They are edge cases that are not expected in real code.
---
 tests/src/App/MappedElement.cpp | 88 +++++++++++++++++++++++++++++++++
 1 file changed, 88 insertions(+)

diff --git a/tests/src/App/MappedElement.cpp b/tests/src/App/MappedElement.cpp
index 0ea03de6af..36588a8d92 100644
--- a/tests/src/App/MappedElement.cpp
+++ b/tests/src/App/MappedElement.cpp
@@ -127,3 +127,91 @@ TEST_F(MappedElementTest, lessThanOperator)
     EXPECT_FALSE(mappedElement2A < mappedElement1B);
     EXPECT_FALSE(mappedElement2B < mappedElement2BDuplicate);
 }
+
+TEST_F(MappedElementTest, comparatorBothAreZeroSize)
+{
+    // Arrange
+    Data::MappedName mappedName1 {""};
+    Data::MappedName mappedName2 {""};
+    auto comp = Data::ElementNameComparator();
+
+    // Act & Assert
+    EXPECT_FALSE(comp(mappedName1, mappedName2));
+}
+
+TEST_F(MappedElementTest, comparatorOneIsZeroSize)
+{
+    // Arrange
+    Data::MappedName mappedName1 {""};
+    Data::MappedName mappedName2 {"#12345"};
+    auto comp = Data::ElementNameComparator();
+
+    // Act & Assert
+    EXPECT_TRUE(comp(mappedName1, mappedName2));
+}
+
+TEST_F(MappedElementTest, comparatorBothStartWithHexDigitsThatDiffer)
+{
+    // Arrange
+    Data::MappedName mappedName1 {"#fed;B"};
+    Data::MappedName mappedName2 {"#abcdef;A"};
+    auto comp = Data::ElementNameComparator();
+
+    // Act & Assert
+    EXPECT_TRUE(comp(mappedName1, mappedName2));
+}
+
+TEST_F(MappedElementTest, comparatorBothStartWithTheSameHexDigits)
+{
+    // Arrange
+    Data::MappedName mappedName1 {"#12345;B"};
+    Data::MappedName mappedName2 {"#12345;A"};
+    auto comp = Data::ElementNameComparator();
+
+    // Act & Assert
+    EXPECT_FALSE(comp(mappedName1, mappedName2));
+}
+
+TEST_F(MappedElementTest, DISABLED_comparatorHexWithoutTerminatorIsBroken)
+{
+    // Arrange
+    Data::MappedName mappedName1 {"#fed"};
+    Data::MappedName mappedName2 {"#abcdef"};
+    auto comp = Data::ElementNameComparator();
+
+    // Act & Assert
+    EXPECT_FALSE(comp(mappedName1, mappedName2));
+}
+
+TEST_F(MappedElementTest, comparatorNoHexDigitsLexicalCompare)
+{
+    // Arrange
+    Data::MappedName mappedName1 {"A"};
+    Data::MappedName mappedName2 {"B"};
+    auto comp = Data::ElementNameComparator();
+
+    // Act & Assert
+    EXPECT_TRUE(comp(mappedName1, mappedName2));
+}
+
+TEST_F(MappedElementTest, comparatorNoHexDigitsSameStringNumericCompare)
+{
+    // Arrange
+    Data::MappedName mappedName1 {"Edge123456;"};
+    Data::MappedName mappedName2 {"Edge321;"};
+    auto comp = Data::ElementNameComparator();
+
+    // Act & Assert
+    EXPECT_FALSE(comp(mappedName1, mappedName2));
+}
+
+TEST_F(MappedElementTest, DISABLED_comparatorIntegerWithoutTerminatorIsBroken)
+{
+    // Arrange
+    Data::MappedName mappedName1 {"Edge123456"};
+    Data::MappedName mappedName2 {"Edge321"};
+    auto comp = Data::ElementNameComparator();
+
+    // Act & Assert
+    EXPECT_FALSE(comp(mappedName1, mappedName2));
+}