kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

[TD]Lint/Tidy/Review comments applied

Browse Source
This commit is contained in:
wandererfan
2023-03-22 14:35:54 -04:00
committed by WandererFan
parent fd26842001
commit 354480e9a4
8 changed files with 43 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/Mod/TechDraw/App/DrawViewDimension.cpp
View File

@@ -529,11 +529,13 @@ double DrawViewDimension::getDimValue()
//nothing to measure
return result;
}
if (!getViewPart())
if (!getViewPart()) {
return result;
}
if (!getViewPart()->hasGeometry())//happens when loading saved document
if (!getViewPart()->hasGeometry()) { //happens when loading saved document
return result;
}
if (MeasureType.isValue("True")) {
// True Values
@@ -1233,7 +1235,7 @@ ReferenceVector DrawViewDimension::getReferences3d() const
return refs3d;
}
void DrawViewDimension::replaceReferenceSubElement2d(int iRef, std::string newSubelement)
void DrawViewDimension::replaceReferenceSubElement2d(int iRef, std::string& newSubelement)
{
// Base::Console().Message("DVD::replaceReferenceSubElement2d(%d, %s)\n", iRef, newSubelement.c_str());
ReferenceVector refs = getReferences2d();
@@ -1241,7 +1243,7 @@ void DrawViewDimension::replaceReferenceSubElement2d(int iRef, std::string newSu
setReferences2d(refs);
}
void DrawViewDimension::replaceReferenceSubElement3d(int iRef, std::string newSubelement)
void DrawViewDimension::replaceReferenceSubElement3d(int iRef, std::string& newSubelement)
{
ReferenceVector refs = getReferences3d();
refs.at(iRef).setSubName(newSubelement);