kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

fix bugprone-*

Browse Source 
* bugprone-throw-keyword-missing
* bugprone-unhandled-self-assignment
* bugprone-suspicious-string-compare
* bugprone-reserved-identifier
* bugprone-narrowing-conversions
* bugprone-macro-parentheses
* bugprone-implicit-widening-of-multiplication-result
* bugprone-exception-escape
* bugprone-copy-constructor-init
This commit is contained in:
wmayer
2023-11-15 13:36:51 +01:00
parent 09ed6f125b
commit 365e7136cd
23 changed files with 99 additions and 73 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/Base/Rotation.cpp
View File

@@ -95,8 +95,12 @@ Rotation::Rotation(const Rotation& rot)
this->_angle = rot._angle;
}
void Rotation::operator=(const Rotation& rot)
Rotation& Rotation::operator=(const Rotation& rot)
{
if (this == &rot) {
return *this;
}
this->quat[0] = rot.quat[0];
this->quat[1] = rot.quat[1];
this->quat[2] = rot.quat[2];
@@ -106,6 +110,8 @@ void Rotation::operator=(const Rotation& rot)
this->_axis[1] = rot._axis[1];
this->_axis[2] = rot._axis[2];
this->_angle = rot._angle;
return *this;
}
const double* Rotation::getValue() const