kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Gui: clean up PropertyItem::toString

Browse Source 
I have no idea why the return type of toString was ever QVariant
This commit is contained in:
Benjamin Bræstrup Sayoc
2025-03-01 16:10:46 +01:00
parent 089605bb4d
commit 3765455ebe
4 changed files with 82 additions and 114 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/Mod/Sketcher/Gui/PropertyConstraintListItem.cpp
View File

@@ -47,7 +47,7 @@ PropertyConstraintListItem::PropertyConstraintListItem()
PropertyConstraintListItem::~PropertyConstraintListItem()
{}
QVariant PropertyConstraintListItem::toString(const QVariant& prop) const
QString PropertyConstraintListItem::toString(const QVariant& prop) const
{
const QList<Base::Quantity>& value = prop.value<QList<Base::Quantity>>();
std::stringstream out;
@@ -59,7 +59,7 @@ QVariant PropertyConstraintListItem::toString(const QVariant& prop) const
out << it->getUserString();
}
out << "]";
return QVariant(QString::fromStdString(out.str()));
return QString::fromStdString(out.str());
}
void PropertyConstraintListItem::initialize()
@@ -380,7 +380,7 @@ QWidget* PropertyConstraintListItem::createEditor(QWidget* parent,
void PropertyConstraintListItem::setEditorData(QWidget* editor, const QVariant& data) const
{
QLineEdit* le = qobject_cast<QLineEdit*>(editor);
le->setText(toString(data).toString());
le->setText(toString(data));
}
QVariant PropertyConstraintListItem::editorData(QWidget* editor) const