From 3e2780a5117fb7a5d9c1ce9ed663ce34e6decd9e Mon Sep 17 00:00:00 2001 From: David Osterberg Date: Fri, 5 Feb 2021 23:15:00 +0100 Subject: [PATCH] PartDesign: Fix sign error in Helix --- src/Mod/PartDesign/App/FeatureHelix.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/Mod/PartDesign/App/FeatureHelix.cpp b/src/Mod/PartDesign/App/FeatureHelix.cpp index b571df9a78..8b13651589 100644 --- a/src/Mod/PartDesign/App/FeatureHelix.cpp +++ b/src/Mod/PartDesign/App/FeatureHelix.cpp @@ -399,10 +399,9 @@ TopoDS_Shape Helix::generateHelixPath(void) if (radius < Precision::Confusion()) { // in this case ensure that axis is not in the sketch plane - if (v*normal < Precision::Confusion()) + if (std::fabs(v*normal) < Precision::Confusion()) throw Base::ValueError("Error: Result is self intersecting"); radius = 1.0; //fallback to radius 1 - startOffset = 0.0; } //build the helix path