From 3e4ee56ed3e32a5ccd1a01b28f0a955d4343622a Mon Sep 17 00:00:00 2001
From: wmayer <wmayer@users.sourceforge.net>
Date: Mon, 25 Jul 2022 10:40:30 +0200
Subject: [PATCH] ReverseEngineering: [skip ci] Fix several clazy issues: *
 Missing reference in range-for with non trivial type
 [-Wclazy-range-loop-reference] * Use multi-arg instead [-Wclazy-qstring-arg]

---
 src/Mod/ReverseEngineering/Gui/Command.cpp            | 6 ++----
 src/Mod/ReverseEngineering/Gui/SegmentationManual.cpp | 2 +-
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/Mod/ReverseEngineering/Gui/Command.cpp b/src/Mod/ReverseEngineering/Gui/Command.cpp
index e7c7fb9c94..b12cd51c2b 100644
--- a/src/Mod/ReverseEngineering/Gui/Command.cpp
+++ b/src/Mod/ReverseEngineering/Gui/Command.cpp
@@ -461,7 +461,7 @@ void CmdSegmentationFromComponents::activated(int)
 
         const Mesh::MeshObject& mesh = it->Mesh.getValue();
         std::vector<std::vector<MeshCore::FacetIndex> > comps = mesh.getComponents();
-        for (auto jt : comps) {
+        for (const auto& jt : comps) {
             std::unique_ptr<Mesh::MeshObject> segment(mesh.meshFromSegment(jt));
             Mesh::Feature* feaSegm = static_cast<Mesh::Feature*>(group->addObject("Mesh::Feature", "Segment"));
             Mesh::MeshObject* feaMesh = feaSegm->Mesh.startEditing();
@@ -610,9 +610,7 @@ void CmdViewTriangulation::activated(int)
                 "Width=%2.Width,"
                 "Height=%2.Height)"
             )
-            .arg(document)
-            .arg(object)
-            ;
+            .arg(document, object);
             runCommand(Doc, command.toLatin1());
         }
 
diff --git a/src/Mod/ReverseEngineering/Gui/SegmentationManual.cpp b/src/Mod/ReverseEngineering/Gui/SegmentationManual.cpp
index ff3ce8ecfe..82488df9cb 100644
--- a/src/Mod/ReverseEngineering/Gui/SegmentationManual.cpp
+++ b/src/Mod/ReverseEngineering/Gui/SegmentationManual.cpp
@@ -150,7 +150,7 @@ static void findGeometry(int minFaces, double tolerance,
                     (surfFit, kernel, minFaces, tolerance));
                 finder.FindSegments(segm);
 
-                for (auto segmIt : segm) {
+                for (const auto& segmIt : segm) {
                     const std::vector<MeshCore::MeshSegment>& data = segmIt->GetSegments();
                     for (const auto& dataIt : data) {
                         vpm->addSelection(dataIt);